)]}'
{"lib/puppet/type/aodh_api_uwsgi_config.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bb1dfc8dc6e18ce1234fd882e3c5bdb7cee534d0","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    [\u0027aodh::install::end\u0027]"},{"line_number":17,"context_line":"  end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  newproperty(:value) do"},{"line_number":20,"context_line":"    desc \u0027The value of the setting to be defined.\u0027"},{"line_number":21,"context_line":"    munge do |value|"},{"line_number":22,"context_line":"      value \u003d value.to_s.strip"},{"line_number":23,"context_line":"      value.capitalize! if value \u003d~ /^(true|false)$/i"},{"line_number":24,"context_line":"      value"},{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"6d695f07_c1c296fc","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":5},"updated":"2021-04-26 13:18:38.000000000","message":"What is the intention of this change ? If this is required then please apply the same to all modules.","commit_id":"874a158c35492792d5ff1054ebd71c71a83cf46c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"f73d9c52316dab3ba09ba974cee064789583af1a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    [\u0027aodh::install::end\u0027]"},{"line_number":17,"context_line":"  end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  newproperty(:value) do"},{"line_number":20,"context_line":"    desc \u0027The value of the setting to be defined.\u0027"},{"line_number":21,"context_line":"    munge do |value|"},{"line_number":22,"context_line":"      value \u003d value.to_s.strip"},{"line_number":23,"context_line":"      value.capitalize! if value \u003d~ /^(true|false)$/i"},{"line_number":24,"context_line":"      value"},{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bbc613c7_a73339bb","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":5},"in_reply_to":"6d695f07_c1c296fc","updated":"2021-04-26 23:30:26.000000000","message":"Hi,\n\nThe intention was precisely to add some kind of consistency in the order of writing things. Should I revert? Do you think it\u0027s best where it was?","commit_id":"874a158c35492792d5ff1054ebd71c71a83cf46c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a55928e631ac5706dd72da26695062f0bc511be4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    [\u0027aodh::install::end\u0027]"},{"line_number":17,"context_line":"  end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  newproperty(:value) do"},{"line_number":20,"context_line":"    desc \u0027The value of the setting to be defined.\u0027"},{"line_number":21,"context_line":"    munge do |value|"},{"line_number":22,"context_line":"      value \u003d value.to_s.strip"},{"line_number":23,"context_line":"      value.capitalize! if value \u003d~ /^(true|false)$/i"},{"line_number":24,"context_line":"      value"},{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"e56d0993_e51a96ce","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":5},"in_reply_to":"bbc613c7_a73339bb","updated":"2021-04-27 00:09:24.000000000","message":"With which file is this consistent ?\n\nI think the best here is to keep consistency among all *_uwsgi_config.rb in all modules. Ideally all of these files should be same except for service name.","commit_id":"874a158c35492792d5ff1054ebd71c71a83cf46c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e124b28bd5d5c89c6b1108cb7893d5b864054c94","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    [\u0027aodh::install::end\u0027]"},{"line_number":17,"context_line":"  end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  newproperty(:value) do"},{"line_number":20,"context_line":"    desc \u0027The value of the setting to be defined.\u0027"},{"line_number":21,"context_line":"    munge do |value|"},{"line_number":22,"context_line":"      value \u003d value.to_s.strip"},{"line_number":23,"context_line":"      value.capitalize! if value \u003d~ /^(true|false)$/i"},{"line_number":24,"context_line":"      value"},{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"4917edbf_23eaee9c","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":5},"in_reply_to":"e56d0993_e51a96ce","updated":"2021-06-10 15:08:36.000000000","message":"I rechecked current implementation in the other modules but I believe the previous implementation is consistent with *_uwsgi_config types in the other modules.\n\nI updated the patch to make it \"consistent\" but please let me know if you have any concern with this revert.","commit_id":"874a158c35492792d5ff1054ebd71c71a83cf46c"}]}