)]}'
{"manifests/api.pp":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4bb973b6856bea57d4dbf888e2b6c6acba728512","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":"  if $auth_type \u003d\u003d \u0027keystone\u0027 {"},{"line_number":577,"context_line":"    if $keystone_password \u003d\u003d undef {"},{"line_number":578,"context_line":"      fail(\u0027keystone_password must be defined\u0027)"},{"line_number":579,"context_line":"    }"},{"line_number":580,"context_line":"  }"},{"line_number":581,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_da5c4a1b","line":578,"updated":"2016-01-09 21:43:17.000000000","message":"Will throw error since \u0027keystone_password\u0027 is not defined in \"describe \u0027with keystone auth\u0027 do\" in \"spec/classes/barbican_api_spec.rb\"","commit_id":"b0002632c8765dcbd3859bc9fceb60dfb15cfbc5"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"3818ee70b3a1b8d13e045173d33edbd49490305c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"#   (optional) Barbican API server option to create the database"},{"line_number":204,"context_line":"#   automatically when the server starts."},{"line_number":205,"context_line":"#   Defaults to $::os_service_default"},{"line_number":206,"context_line":"#  "},{"line_number":207,"context_line":"# [*service_name*]"},{"line_number":208,"context_line":"#   (optional) Name of the service that will be providing the"},{"line_number":209,"context_line":"#   server functionality of barbican-api."}],"source_content_type":"text/x-puppet","patch_set":25,"id":"1a122d0e_cb3c19c2","line":206,"updated":"2016-05-02 18:37:08.000000000","message":"whitespace","commit_id":"6c7dbc8aab6a1769c62022f7384b9ff4eb7f0ee5"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"e9e6083dbc25c3f3562f7c5a2d01efc65b234dbd","unresolved":false,"context_lines":[{"line_number":203,"context_line":"#   (optional) Barbican API server option to create the database"},{"line_number":204,"context_line":"#   automatically when the server starts."},{"line_number":205,"context_line":"#   Defaults to $::os_service_default"},{"line_number":206,"context_line":"#  "},{"line_number":207,"context_line":"# [*service_name*]"},{"line_number":208,"context_line":"#   (optional) Name of the service that will be providing the"},{"line_number":209,"context_line":"#   server functionality of barbican-api."}],"source_content_type":"text/x-puppet","patch_set":25,"id":"1a122d0e_be573d25","line":206,"in_reply_to":"1a122d0e_cb3c19c2","updated":"2016-05-03 15:23:49.000000000","message":"Done","commit_id":"6c7dbc8aab6a1769c62022f7384b9ff4eb7f0ee5"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"3818ee70b3a1b8d13e045173d33edbd49490305c","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    # we need to make sure barbican-api is stopped before trying to start apache"},{"line_number":435,"context_line":"    Service[\u0027barbican-api\u0027] -\u003e Service[$service_name]"},{"line_number":436,"context_line":"  } else {"},{"line_number":437,"context_line":"    fail(\u0027Invalid service_name. Either barbican-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":438,"context_line":"  }"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"1a122d0e_ab6c3dd1","line":437,"updated":"2016-05-02 18:37:08.000000000","message":"Can this line be smaller?","commit_id":"6c7dbc8aab6a1769c62022f7384b9ff4eb7f0ee5"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"e9e6083dbc25c3f3562f7c5a2d01efc65b234dbd","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    # we need to make sure barbican-api is stopped before trying to start apache"},{"line_number":435,"context_line":"    Service[\u0027barbican-api\u0027] -\u003e Service[$service_name]"},{"line_number":436,"context_line":"  } else {"},{"line_number":437,"context_line":"    fail(\u0027Invalid service_name. Either barbican-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":438,"context_line":"  }"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"1a122d0e_7e5da547","line":437,"in_reply_to":"1a122d0e_ab6c3dd1","updated":"2016-05-03 15:23:49.000000000","message":"Done","commit_id":"6c7dbc8aab6a1769c62022f7384b9ff4eb7f0ee5"}],"manifests/params.pp":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4bb973b6856bea57d4dbf888e2b6c6acba728512","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \u0027Debian\u0027: {"},{"line_number":20,"context_line":"      $package_name                 \u003d \u0027openstack-barbican\u0027"},{"line_number":21,"context_line":"      $service_name                 \u003d \u0027openstack-barbican\u0027"},{"line_number":22,"context_line":"      $client_package_name          \u003d \u0027python-barbicanclient\u0027"},{"line_number":23,"context_line":"      $barbican_wsgi_script_path    \u003d \u0027/var/www/cgi-bin/barbican\u0027"},{"line_number":24,"context_line":"      $sqlite_package_name          \u003d \u0027python-pysqlite2\u0027"},{"line_number":25,"context_line":"      $barbican_wsgi_script_source  \u003d \u0027/usr/lib/python2.7/site-packages/barbican/api/app.wsgi\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_ce457343","line":22,"updated":"2016-01-09 21:43:17.000000000","message":"I had to run \"sudo apt-get dist-upgrade\"  in order to find this package. Which is fine on the gate.","commit_id":"b0002632c8765dcbd3859bc9fceb60dfb15cfbc5"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"aab64d1ea43e640d9ea576ef10af8852a43be803","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"#   [*public_port*]"},{"line_number":17,"context_line":"#     The public port."},{"line_number":18,"context_line":"#     Optional. Defaults to 5000"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"#   [*bind_host*]"},{"line_number":21,"context_line":"#     The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":24,"id":"1a122d0e_1f4854cb","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":32},"updated":"2016-04-28 19:51:10.000000000","message":"9311","commit_id":"d37f0c43b8ce03d5fc87394e273f682f077bd9a1"}],"spec/acceptance/basic_barbican_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"43db5e67ec87ed6db11f4a14462e8a4c7aa03471","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":2,"context_line":"describe \u0027barbican::api basic test class\u0027 do"},{"line_number":3,"context_line":"  context \u0027default parameters\u0027 do"},{"line_number":4,"context_line":"    pp\u003d \u003c\u003c-EOS"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a061dce_e6ff87a8","line":1,"updated":"2016-04-08 21:17:47.000000000","message":"you can drop this file and keep tests with apache only, we already do that for other modules. That will avoid tests duplication.","commit_id":"17b3f067d422228037b0b2d52c42f52fc4d8ff33"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0391dd6ff9a1eb7352fc632dffbff441753a9866","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":2,"context_line":"describe \u0027barbican::api basic test class\u0027 do"},{"line_number":3,"context_line":"  context \u0027default parameters\u0027 do"},{"line_number":4,"context_line":"    pp\u003d \u003c\u003c-EOS"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9a061dce_5920cdf7","line":1,"updated":"2016-04-09 03:30:31.000000000","message":"please rename the file to barbican_wsgi_apache_spec.rb","commit_id":"f5eceb02c03a3c45da2f89b3c4ac6fb62db19b71"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a09249735614d369409ebd2c1d77fecf1d570feb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      end"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      describe port(9311) do"},{"line_number":76,"context_line":"        it { is_expected.to be_listening.with(\u0027tcp\u0027) }"},{"line_number":77,"context_line":"      end"},{"line_number":78,"context_line":"    end"},{"line_number":79,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":25,"id":"1a122d0e_311c1c6a","side":"PARENT","line":76,"updated":"2016-05-02 19:47:07.000000000","message":"that\u0027s very bad, you\u0027re deleting an important test. Please using it, but drop the tcp because we run the process with httpd. Look other modules how it\u0027s tested (aodh for example).","commit_id":"02f89ff65bdcd803ba7674a8391849ed7f3fb322"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"e9e6083dbc25c3f3562f7c5a2d01efc65b234dbd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      end"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      describe port(9311) do"},{"line_number":76,"context_line":"        it { is_expected.to be_listening.with(\u0027tcp\u0027) }"},{"line_number":77,"context_line":"      end"},{"line_number":78,"context_line":"    end"},{"line_number":79,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":25,"id":"1a122d0e_81402637","side":"PARENT","line":76,"in_reply_to":"1a122d0e_311c1c6a","updated":"2016-05-03 15:23:49.000000000","message":"Done","commit_id":"02f89ff65bdcd803ba7674a8391849ed7f3fb322"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"db3c7e8ef7bd285050fdbfe656aad4e92f486265","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"      describe port(9311) do"},{"line_number":75,"context_line":"        it { is_expected.to be_listening.with(\u0027tcp\u0027) }"},{"line_number":76,"context_line":"      end"},{"line_number":77,"context_line":"    end"},{"line_number":78,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":30,"id":"dab17558_ddbe7363","side":"PARENT","line":75,"updated":"2016-05-13 09:39:15.000000000","message":"why do you want to remove listening with tcp exactly?","commit_id":"bf14bf1feb11f6a318780a208ec2a24822af7eb1"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"1de2012cff7540ba0f3049c22d58aa8b2523ce87","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"      describe port(9311) do"},{"line_number":75,"context_line":"        it { is_expected.to be_listening.with(\u0027tcp\u0027) }"},{"line_number":76,"context_line":"      end"},{"line_number":77,"context_line":"    end"},{"line_number":78,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":30,"id":"dab17558_80f112d0","side":"PARENT","line":75,"in_reply_to":"dab17558_ddbe7363","updated":"2016-05-13 14:01:01.000000000","message":"Found that this test fails when its an apache module.  Replaced with what we do for aodh etc,","commit_id":"bf14bf1feb11f6a318780a208ec2a24822af7eb1"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"db3c7e8ef7bd285050fdbfe656aad4e92f486265","unresolved":false,"context_lines":[{"line_number":47,"context_line":"          }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"          include ::apache"},{"line_number":50,"context_line":"          class { \u0027::barbican::wsgi::apache\u0027:"},{"line_number":51,"context_line":"            ssl \u003d\u003e false,"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"        }"}],"source_content_type":"text/x-ruby","patch_set":30,"id":"dab17558_1d159b48","line":50,"updated":"2016-05-13 09:39:15.000000000","message":"i don\u0027t see this class. Is it missed?","commit_id":"d9d35c4d4ef408023121ee52ba2742f270ea6b2c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"1de2012cff7540ba0f3049c22d58aa8b2523ce87","unresolved":false,"context_lines":[{"line_number":47,"context_line":"          }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"          include ::apache"},{"line_number":50,"context_line":"          class { \u0027::barbican::wsgi::apache\u0027:"},{"line_number":51,"context_line":"            ssl \u003d\u003e false,"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"        }"}],"source_content_type":"text/x-ruby","patch_set":30,"id":"dab17558_80be32fd","line":50,"in_reply_to":"dab17558_1d159b48","updated":"2016-05-13 14:01:01.000000000","message":"Thanks!  I couldn\u0027t for the life of me figure out why the gate was failing on this test when it passed before and passed locally.  Seems like it got lost in a rebase,\n\nNew patch coming ..","commit_id":"d9d35c4d4ef408023121ee52ba2742f270ea6b2c"}],"spec/spec_helper_acceptance.rb":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4bb973b6856bea57d4dbf888e2b6c6acba728512","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  c.after :all do"},{"line_number":60,"context_line":"    # remove config and uninstall packages"},{"line_number":61,"context_line":"    hosts.each do |host|"},{"line_number":62,"context_line":"      on host, \"yum erase -y openstack-barbican-api openstack-keystone\""},{"line_number":63,"context_line":"      on host, FileUtils.remove_entry_secure(\"/var/lib/barbican\", :force \u003d\u003e true)"},{"line_number":64,"context_line":"      on host, FileUtils.remove_entry_secure(\"/var/lib/keystone\", :force \u003d\u003e true)"},{"line_number":65,"context_line":"      on host, FileUtils.remove_entry_secure(\"/etc/barbican\", :force \u003d\u003e true)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa69d971_37fb3f7d","line":62,"updated":"2016-01-09 21:43:17.000000000","message":"This won\u0027t work for debian packages. If debian do: \"sudo apt-get remove -y barbican-api keystone\"","commit_id":"b0002632c8765dcbd3859bc9fceb60dfb15cfbc5"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4bb973b6856bea57d4dbf888e2b6c6acba728512","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      on host, FileUtils.remove_entry_secure(\"/var/lib/keystone\", :force \u003d\u003e true)"},{"line_number":65,"context_line":"      on host, FileUtils.remove_entry_secure(\"/etc/barbican\", :force \u003d\u003e true)"},{"line_number":66,"context_line":"      on host, FileUtils.remove_entry_secure(\"/etc/httpd/conf.d/10-barbican*\", :force \u003d\u003e true)"},{"line_number":67,"context_line":"      on host, \"systemctl restart httpd.service\""},{"line_number":68,"context_line":"    end"},{"line_number":69,"context_line":"  end"},{"line_number":70,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa69d971_d71ae3c5","line":67,"updated":"2016-01-09 21:43:17.000000000","message":"for debian try \"service apache2 restart\".","commit_id":"b0002632c8765dcbd3859bc9fceb60dfb15cfbc5"}]}