)]}'
{"manifests/client.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ca5a24661d431d871e8b4f26ec910624808a2cc3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class barbican::client ("},{"line_number":12,"context_line":"  $ensure \u003d \u0027present\u0027"},{"line_number":13,"context_line":") inherits barbican::params {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  package { \u0027python-barbicanclient\u0027:"},{"line_number":16,"context_line":"    ensure \u003d\u003e $ensure,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_1e1c1fc0","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":27},"updated":"2016-03-23 11:56:15.000000000","message":"no need to inherit from params class. You can simply include it.","commit_id":"928e9b3cd070aae0be10c3dccb2dc17a1bd0e719"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ca5a24661d431d871e8b4f26ec910624808a2cc3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  if $ensure \u003d\u003d \u0027present\u0027 {"},{"line_number":22,"context_line":"    include \u0027::openstacklib::openstackclient\u0027"},{"line_number":23,"context_line":"  } else {"},{"line_number":24,"context_line":"    class { \u0027::openstacklib::openstackclient\u0027:"},{"line_number":25,"context_line":"      package_ensure \u003d\u003e $ensure,"},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_3e764306","line":27,"range":{"start_line":21,"start_character":0,"end_line":27,"end_character":3},"updated":"2016-03-23 11:56:15.000000000","message":"that\u0027s bad way. Use ensure_resources function.","commit_id":"928e9b3cd070aae0be10c3dccb2dc17a1bd0e719"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eec7a03c95b1c4ad2b3d57c1424f662899c3ec6e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   (optional) Ensure state of the package."},{"line_number":9,"context_line":"#   Defaults to \u0027present\u0027."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class barbican::client ($ensure \u003d \u0027present\u0027) {"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  include ::barbican::params"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da0c15f0_0f4c55c6","line":11,"updated":"2016-03-25 12:45:48.000000000","message":"well, it\u0027s better to have a new line for every parameter :)","commit_id":"4d3d17a9e0c596c6ee65285f5be6f29d9eb41f20"}],"manifests/params.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"5c6b188a4958189b932226bd65ba7483e8baa6c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  case $::osfamily {"},{"line_number":6,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":7,"context_line":"      $package_name                 \u003d \u0027openstack-barbican\u0027"},{"line_number":8,"context_line":"      $api_package_name             \u003d \u0027openstack-barbican-api\u0027"},{"line_number":9,"context_line":"      $api_service_name             \u003d \u0027openstack-barbican-api\u0027"},{"line_number":10,"context_line":"      $worker_package_name          \u003d \u0027openstack-barbican-worker\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_74a8e5db","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":19},"updated":"2016-03-23 09:23:13.000000000","message":"I guess these changes should be mentioned in commit message","commit_id":"928e9b3cd070aae0be10c3dccb2dc17a1bd0e719"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ca5a24661d431d871e8b4f26ec910624808a2cc3","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  case $::osfamily {"},{"line_number":6,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":7,"context_line":"      $package_name                 \u003d \u0027openstack-barbican\u0027"},{"line_number":8,"context_line":"      $api_package_name             \u003d \u0027openstack-barbican-api\u0027"},{"line_number":9,"context_line":"      $api_service_name             \u003d \u0027openstack-barbican-api\u0027"},{"line_number":10,"context_line":"      $worker_package_name          \u003d \u0027openstack-barbican-worker\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_1e737f16","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":19},"in_reply_to":"fa0719c6_74a8e5db","updated":"2016-03-23 11:56:15.000000000","message":"+1","commit_id":"928e9b3cd070aae0be10c3dccb2dc17a1bd0e719"}]}
