)]}'
{"manifests/api/logging.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"929fb472d50ff89613c506de04c39724e7febc79","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  $use_stderr                    \u003d $::os_service_default,"},{"line_number":103,"context_line":"  $log_facility                  \u003d $::os_service_default,"},{"line_number":104,"context_line":"  $log_dir                       \u003d \u0027/var/log/barbican\u0027,"},{"line_number":105,"context_line":"  $log_file                      \u003d $::os_service_default,"},{"line_number":106,"context_line":"  $verbose                       \u003d $::os_service_default,"},{"line_number":107,"context_line":"  $debug                         \u003d $::os_service_default,"},{"line_number":108,"context_line":"  $logging_context_format_string \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_5e3857ef","line":105,"range":{"start_line":105,"start_character":35,"end_line":105,"end_character":56},"updated":"2016-03-23 12:00:04.000000000","message":"will be better to explicitly set to /var/log/barbican/api.log","commit_id":"0438662c4fa134de7038306e1882468d6318c02e"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"0fa4b794ba8d861181df08e1f4625751e9be739f","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":122,"context_line":"  # to use barbican::\u003cmyparam\u003e first then barbican::api::logging::\u003cmyparam\u003e."},{"line_number":123,"context_line":"  $use_syslog_real \u003d pick($::barbican::api::use_syslog,$use_syslog)"},{"line_number":124,"context_line":"  $use_stderr_real \u003d pick($::barbican::api::use_stderr,$use_stderr)"},{"line_number":125,"context_line":"  $log_facility_real \u003d pick($::barbican::api::log_facility,$log_facility)"},{"line_number":126,"context_line":"  $log_dir_real \u003d pick($::barbican::api::log_dir,$log_dir)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_444c129e","line":123,"range":{"start_line":123,"start_character":26,"end_line":123,"end_character":54},"updated":"2016-03-23 08:39:57.000000000","message":"You removed barbican::logging class, so probably it\u0027s better to take values from it","commit_id":"0438662c4fa134de7038306e1882468d6318c02e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"929fb472d50ff89613c506de04c39724e7febc79","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":122,"context_line":"  # to use barbican::\u003cmyparam\u003e first then barbican::api::logging::\u003cmyparam\u003e."},{"line_number":123,"context_line":"  $use_syslog_real \u003d pick($::barbican::api::use_syslog,$use_syslog)"},{"line_number":124,"context_line":"  $use_stderr_real \u003d pick($::barbican::api::use_stderr,$use_stderr)"},{"line_number":125,"context_line":"  $log_facility_real \u003d pick($::barbican::api::log_facility,$log_facility)"},{"line_number":126,"context_line":"  $log_dir_real \u003d pick($::barbican::api::log_dir,$log_dir)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_be39b3f4","line":123,"range":{"start_line":123,"start_character":26,"end_line":123,"end_character":54},"in_reply_to":"fa0719c6_444c129e","updated":"2016-03-23 12:00:04.000000000","message":"+1","commit_id":"0438662c4fa134de7038306e1882468d6318c02e"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"19d0b18ac294ebc4f3d62661ce2aa75173624348","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  $log_date_format               \u003d $::os_service_default,"},{"line_number":119,"context_line":") {"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":122,"context_line":"  # to use barbican::\u003cmyparam\u003e first then barbican::api::logging::\u003cmyparam\u003e."},{"line_number":123,"context_line":"  $use_syslog_real \u003d pick($::barbican::api::use_syslog,$use_syslog)"},{"line_number":124,"context_line":"  $use_stderr_real \u003d pick($::barbican::api::use_stderr,$use_stderr)"},{"line_number":125,"context_line":"  $log_facility_real \u003d pick($::barbican::api::log_facility,$log_facility)"},{"line_number":126,"context_line":"  $log_dir_real \u003d pick($::barbican::api::log_dir,$log_dir)"},{"line_number":127,"context_line":"  $verbose_real  \u003d pick($::barbican::api::verbose,$verbose)"},{"line_number":128,"context_line":"  $debug_real \u003d pick($::barbican::api::debug,$debug)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"  if is_service_default($default_log_levels) {"},{"line_number":131,"context_line":"    $default_log_levels_real \u003d $default_log_levels"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_4439b2a3","line":128,"range":{"start_line":121,"start_character":0,"end_line":128,"end_character":52},"updated":"2016-03-23 08:29:23.000000000","message":"As there was no barbican::api class earlier so i think there is no need to add this parameters to api class and picking them here, we can just use parameters directly from barbican::api::logging","commit_id":"0438662c4fa134de7038306e1882468d6318c02e"}],"manifests/logging.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"929fb472d50ff89613c506de04c39724e7febc79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Class barbican::logging"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  barbican extended logging configuration"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_7e4c3b9e","side":"PARENT","line":1,"updated":"2016-03-23 12:00:04.000000000","message":"you can\u0027t just remove class - you should respect our backward compatibility rule:\n\n1) you can move all parameters from this class to undef;\n2) raise warning that this class is deprecated;\n3) use include ::barbican::api::logging here","commit_id":"928e9b3cd070aae0be10c3dccb2dc17a1bd0e719"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"b13161251de2ac3f4be83499ea9b33649cafc1fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Class barbican::logging"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  barbican extended logging configuration"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_c1058d7a","side":"PARENT","line":1,"in_reply_to":"fa0719c6_7e4c3b9e","updated":"2016-03-23 17:50:11.000000000","message":"As discussed on irc, barbican puppet module has never been released.  So no need for deprecation here.","commit_id":"928e9b3cd070aae0be10c3dccb2dc17a1bd0e719"}]}
