)]}'
{"manifests/api.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"4e7d2766dde7431f59e9ab43c0c4584c6ca6b65c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"class barbican::api ("},{"line_number":206,"context_line":"  $ensure_package                     \u003d \u0027present\u0027,"},{"line_number":207,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":208,"context_line":"  $verbose                            \u003d undef,"},{"line_number":209,"context_line":"  $debug                              \u003d undef,"},{"line_number":210,"context_line":"  $log_dir                            \u003d undef,"},{"line_number":211,"context_line":"  $log_file                           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_7f80c3f7","line":208,"range":{"start_line":208,"start_character":40,"end_line":208,"end_character":45},"updated":"2016-03-23 08:54:34.000000000","message":"Is there a specific reason not to use $::os_service_default?","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":205,"context_line":"class barbican::api ("},{"line_number":206,"context_line":"  $ensure_package                     \u003d \u0027present\u0027,"},{"line_number":207,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":208,"context_line":"  $verbose                            \u003d undef,"},{"line_number":209,"context_line":"  $debug                              \u003d undef,"},{"line_number":210,"context_line":"  $log_dir                            \u003d undef,"},{"line_number":211,"context_line":"  $log_file                           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_db88f9c7","line":208,"range":{"start_line":208,"start_character":40,"end_line":208,"end_character":45},"in_reply_to":"fa0719c6_7f80c3f7","updated":"2016-03-23 11:46:38.000000000","message":"Agree.\n\nAs you adding a new class at all, there is shouldn\u0027t be any old params","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"4e7d2766dde7431f59e9ab43c0c4584c6ca6b65c","unresolved":false,"context_lines":[{"line_number":231,"context_line":"  $queue_namespace                    \u003d \u0027barbican\u0027,"},{"line_number":232,"context_line":"  $queue_topic                        \u003d \u0027barbican.workers\u0027,"},{"line_number":233,"context_line":"  $queue_version                      \u003d \u00271.1\u0027,"},{"line_number":234,"context_line":"  $queue_server_name                    \u003d \u0027barbican.queue\u0027,"},{"line_number":235,"context_line":"  $retry_scheduler_initial_delay_seconds \u003d 10.0,"},{"line_number":236,"context_line":"  $retry_scheduler_periodic_interval_max_seconds \u003d 10.0,"},{"line_number":237,"context_line":"  $kombu_ssl_ca_certs                 \u003d undef,"},{"line_number":238,"context_line":"  $kombu_ssl_certfile                 \u003d undef,"},{"line_number":239,"context_line":"  $kombu_ssl_keyfile                  \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_df710f46","line":236,"range":{"start_line":234,"start_character":0,"end_line":236,"end_character":55},"updated":"2016-03-23 08:54:34.000000000","message":"Please align","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  $kombu_reconnect_delay              \u003d \u00271.0\u0027,"},{"line_number":242,"context_line":"  $manage_service                     \u003d true,"},{"line_number":243,"context_line":"  $enabled                            \u003d true,"},{"line_number":244,"context_line":"  $database_connection                \u003d undef,"},{"line_number":245,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":246,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":247,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_9b7041de","line":244,"range":{"start_line":244,"start_character":2,"end_line":244,"end_character":24},"updated":"2016-03-23 11:46:38.000000000","message":"same here as above for db parameters.","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"4e7d2766dde7431f59e9ab43c0c4584c6ca6b65c","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"  include ::barbican::db"},{"line_number":256,"context_line":"  include ::barbican::api::logging"},{"line_number":257,"context_line":"  require keystone::python"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"  if $kombu_ssl_ca_certs and !$rabbit_use_ssl {"},{"line_number":260,"context_line":"    fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_7fe563da","line":257,"range":{"start_line":257,"start_character":2,"end_line":257,"end_character":26},"updated":"2016-03-23 08:54:34.000000000","message":"Please don\u0027t use, this class is deprecated\n\nhttps://github.com/openstack/puppet-keystone/blob/master/manifests/python.pp#L20","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"  include ::barbican::db"},{"line_number":256,"context_line":"  include ::barbican::api::logging"},{"line_number":257,"context_line":"  require keystone::python"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"  if $kombu_ssl_ca_certs and !$rabbit_use_ssl {"},{"line_number":260,"context_line":"    fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_5b518935","line":257,"range":{"start_line":257,"start_character":2,"end_line":257,"end_character":26},"in_reply_to":"fa0719c6_7fe563da","updated":"2016-03-23 11:46:38.000000000","message":"+1","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"d1fc55a2ba45b174b41806be24f94b4b39c9dff8","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be used together\u0027)"},{"line_number":270,"context_line":"  }"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"  group { \u0027barbican\u0027:"},{"line_number":273,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":274,"context_line":"    system  \u003d\u003e true,"},{"line_number":275,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":276,"context_line":"  }"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"  user { \u0027barbican\u0027:"},{"line_number":279,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":280,"context_line":"    gid     \u003d\u003e \u0027barbican\u0027,"},{"line_number":281,"context_line":"    system  \u003d\u003e true,"},{"line_number":282,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":283,"context_line":"  }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  file { [\u0027/etc/barbican\u0027, \u0027/var/log/barbican\u0027, \u0027/var/lib/barbican\u0027]:"},{"line_number":286,"context_line":"    ensure  \u003d\u003e directory,"},{"line_number":287,"context_line":"    mode    \u003d\u003e \u00270770\u0027,"},{"line_number":288,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":289,"context_line":"    group   \u003d\u003e \u0027barbican\u0027,"},{"line_number":290,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":291,"context_line":"    notify  \u003d\u003e Service[\u0027barbican-api\u0027],"},{"line_number":292,"context_line":"  }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  file { [\u0027/etc/barbican/barbican.conf\u0027,"},{"line_number":295,"context_line":"          \u0027/etc/barbican/barbican-api-paste.ini\u0027,"},{"line_number":296,"context_line":"          \u0027/etc/barbican/gunicorn-config.py\u0027]:"},{"line_number":297,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":298,"context_line":"    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":299,"context_line":"    owner   \u003d\u003e \u0027barbican\u0027,"},{"line_number":300,"context_line":"    group   \u003d\u003e \u0027barbican\u0027,"},{"line_number":301,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":302,"context_line":"    notify  \u003d\u003e Service[\u0027barbican-api\u0027],"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  package { \u0027barbican-api\u0027:"},{"line_number":306,"context_line":"    ensure \u003d\u003e $ensure_package,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_24a2befd","line":303,"range":{"start_line":272,"start_character":0,"end_line":303,"end_character":3},"updated":"2016-03-23 08:23:35.000000000","message":"puppet manifests should not manage POSIX users and groups,file modes this should be done by package https://bugs.launchpad.net/puppet-keystone/+bug/1458915","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be used together\u0027)"},{"line_number":270,"context_line":"  }"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"  group { \u0027barbican\u0027:"},{"line_number":273,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":274,"context_line":"    system  \u003d\u003e true,"},{"line_number":275,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":276,"context_line":"  }"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"  user { \u0027barbican\u0027:"},{"line_number":279,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":280,"context_line":"    gid     \u003d\u003e \u0027barbican\u0027,"},{"line_number":281,"context_line":"    system  \u003d\u003e true,"},{"line_number":282,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":283,"context_line":"  }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  file { [\u0027/etc/barbican\u0027, \u0027/var/log/barbican\u0027, \u0027/var/lib/barbican\u0027]:"},{"line_number":286,"context_line":"    ensure  \u003d\u003e directory,"},{"line_number":287,"context_line":"    mode    \u003d\u003e \u00270770\u0027,"},{"line_number":288,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":289,"context_line":"    group   \u003d\u003e \u0027barbican\u0027,"},{"line_number":290,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":291,"context_line":"    notify  \u003d\u003e Service[\u0027barbican-api\u0027],"},{"line_number":292,"context_line":"  }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  file { [\u0027/etc/barbican/barbican.conf\u0027,"},{"line_number":295,"context_line":"          \u0027/etc/barbican/barbican-api-paste.ini\u0027,"},{"line_number":296,"context_line":"          \u0027/etc/barbican/gunicorn-config.py\u0027]:"},{"line_number":297,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":298,"context_line":"    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":299,"context_line":"    owner   \u003d\u003e \u0027barbican\u0027,"},{"line_number":300,"context_line":"    group   \u003d\u003e \u0027barbican\u0027,"},{"line_number":301,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":302,"context_line":"    notify  \u003d\u003e Service[\u0027barbican-api\u0027],"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  package { \u0027barbican-api\u0027:"},{"line_number":306,"context_line":"    ensure \u003d\u003e $ensure_package,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_9b47a176","line":303,"range":{"start_line":272,"start_character":0,"end_line":303,"end_character":3},"in_reply_to":"fa0719c6_24a2befd","updated":"2016-03-23 11:46:38.000000000","message":"+1, if there are no issues with packages","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027barbican-api-package\u0027],"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  if $client_package_ensure \u003d\u003d \u0027present\u0027 {"},{"line_number":312,"context_line":"    include \u0027::barbican::client\u0027"},{"line_number":313,"context_line":"  } else {"},{"line_number":314,"context_line":"    class { \u0027::barbican::client\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_fe15eb3f","line":311,"range":{"start_line":311,"start_character":2,"end_line":311,"end_character":42},"updated":"2016-03-23 11:46:38.000000000","message":"we no need this if, you can simply pass it.\n\nor use ensure_resources function - that will help to avoid duplication errors along all manifests.","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  File[\u0027/etc/barbican/barbican.conf\u0027] -\u003e Barbican_config\u003c||\u003e"},{"line_number":320,"context_line":"  File[\u0027/etc/barbican/barbican-api-paste.ini\u0027] -\u003e Barbican_api_paste_ini\u003c||\u003e"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  Barbican_config\u003c||\u003e   ~\u003e Service[\u0027barbican-api\u0027]"},{"line_number":323,"context_line":"  Barbican_api_paste_ini\u003c||\u003e   ~\u003e Service[\u0027barbican-api\u0027]"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"  # basic service config"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_5ea217fe","line":322,"range":{"start_line":322,"start_character":21,"end_line":322,"end_character":23},"updated":"2016-03-23 11:46:38.000000000","message":"alignment","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  File[\u0027/etc/barbican/barbican-api-paste.ini\u0027] -\u003e Barbican_api_paste_ini\u003c||\u003e"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  Barbican_config\u003c||\u003e   ~\u003e Service[\u0027barbican-api\u0027]"},{"line_number":323,"context_line":"  Barbican_api_paste_ini\u003c||\u003e   ~\u003e Service[\u0027barbican-api\u0027]"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"  # basic service config"},{"line_number":326,"context_line":"  if $host_href \u003d\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_bea373ff","line":323,"range":{"start_line":323,"start_character":28,"end_line":323,"end_character":30},"updated":"2016-03-23 11:46:38.000000000","message":"same","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    } -\u003e Service[\u0027barbican-api\u0027]"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"  #rabbit config"},{"line_number":346,"context_line":"  if $rpc_backend \u003d\u003d \u0027rabbit\u0027 {"},{"line_number":347,"context_line":"    barbican_config {"},{"line_number":348,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_password\u0027:              value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"},{"line_number":349,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_userid\u0027:                value \u003d\u003e $rabbit_userid;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_1eba5f0a","line":346,"range":{"start_line":346,"start_character":5,"end_line":346,"end_character":29},"updated":"2016-03-23 11:46:38.000000000","message":"nit: may be we can use now puppet-oslo::messaging_rabbit? it is ready to use.","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e7a8ef133dba0d4dff5534b7b58886bb802c0931","unresolved":false,"context_lines":[{"line_number":415,"context_line":"    \u0027queue/namespace\u0027: value \u003d\u003e $queue_namespace;"},{"line_number":416,"context_line":"    \u0027queue/topic\u0027:     value \u003d\u003e $queue_topic;"},{"line_number":417,"context_line":"    \u0027queue/version\u0027:   value \u003d\u003e $queue_version;"},{"line_number":418,"context_line":"    \u0027queue/server_name\u0027: value \u003d\u003e $queue_server_name;"},{"line_number":419,"context_line":"  }"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"  # retry scheduler options"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_be3ff385","line":418,"updated":"2016-03-23 11:46:38.000000000","message":"alignment","commit_id":"be7b4a5181698d1189c4d5033bef34be805cd91c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dcd83eebe8bf8dbc6569141a0cbcc018963b858d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  $queue_topic                        \u003d \u0027barbican.workers\u0027,"},{"line_number":174,"context_line":"  $queue_version                      \u003d \u00271.1\u0027,"},{"line_number":175,"context_line":"  $queue_server_name                  \u003d \u0027barbican.queue\u0027,"},{"line_number":176,"context_line":"  $retry_scheduler_initial_delay_seconds         \u003d 10.0,"},{"line_number":177,"context_line":"  $retry_scheduler_periodic_interval_max_seconds \u003d 10.0,"},{"line_number":178,"context_line":"  $kombu_ssl_ca_certs                 \u003d $::os_service_default,"},{"line_number":179,"context_line":"  $kombu_ssl_certfile                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da0c15f0_caf52b84","line":176,"range":{"start_line":176,"start_character":49,"end_line":176,"end_character":55},"updated":"2016-03-25 13:04:27.000000000","message":"you can move it on next line","commit_id":"62e1a2a9ac3020b734ef8928f6526336acc0cff3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dcd83eebe8bf8dbc6569141a0cbcc018963b858d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  $queue_version                      \u003d \u00271.1\u0027,"},{"line_number":175,"context_line":"  $queue_server_name                  \u003d \u0027barbican.queue\u0027,"},{"line_number":176,"context_line":"  $retry_scheduler_initial_delay_seconds         \u003d 10.0,"},{"line_number":177,"context_line":"  $retry_scheduler_periodic_interval_max_seconds \u003d 10.0,"},{"line_number":178,"context_line":"  $kombu_ssl_ca_certs                 \u003d $::os_service_default,"},{"line_number":179,"context_line":"  $kombu_ssl_certfile                 \u003d $::os_service_default,"},{"line_number":180,"context_line":"  $kombu_ssl_keyfile                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da0c15f0_4a30fb56","line":177,"range":{"start_line":177,"start_character":49,"end_line":177,"end_character":55},"updated":"2016-03-25 13:04:27.000000000","message":"same","commit_id":"62e1a2a9ac3020b734ef8928f6526336acc0cff3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dcd83eebe8bf8dbc6569141a0cbcc018963b858d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"  $kombu_compression                  \u003d $::os_service_default,"},{"line_number":184,"context_line":"  $manage_service                     \u003d true,"},{"line_number":185,"context_line":"  $enabled                            \u003d true,"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":") inherits barbican::params {"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da0c15f0_ea3f4f23","line":186,"updated":"2016-03-25 13:04:27.000000000","message":"empty line","commit_id":"62e1a2a9ac3020b734ef8928f6526336acc0cff3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dcd83eebe8bf8dbc6569141a0cbcc018963b858d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  $enabled                            \u003d true,"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":") inherits barbican::params {"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  include ::barbican::db"},{"line_number":191,"context_line":"  include ::barbican::api::logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da0c15f0_ca3c0b32","line":188,"updated":"2016-03-25 13:04:27.000000000","message":"empty line","commit_id":"62e1a2a9ac3020b734ef8928f6526336acc0cff3"}],"spec/classes/barbican_api_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dcd83eebe8bf8dbc6569141a0cbcc018963b858d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"      #   .with_content(/\\s*bind \u003d \u00270.0.0.0:$param_hash[:bind_port]$/)"},{"line_number":88,"context_line":"      #end"},{"line_number":89,"context_line":"    end"},{"line_number":90,"context_line":"  end"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  describe \u0027with disabled service managing\u0027 do"},{"line_number":93,"context_line":"    let :params do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da0c15f0_6a04df7d","line":90,"updated":"2016-03-25 13:04:27.000000000","message":"please add case for passed params","commit_id":"62e1a2a9ac3020b734ef8928f6526336acc0cff3"}]}
