)]}'
{"manifests/api.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"accbb449ecb9f4cc72ebe8f14b4430f448e3787a","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  $quota_containers                   \u003d -1,"},{"line_number":289,"context_line":"  $quota_consumers                    \u003d -1,"},{"line_number":290,"context_line":"  $quota_cas                          \u003d -1,"},{"line_number":291,"context_line":"  $enable_keystone_notification       \u003d false,"},{"line_number":292,"context_line":"  $keystone_notification_control_exchange \u003d \u0027openstack\u0027,"},{"line_number":293,"context_line":"  $keystone_notification_topic        \u003d \u0027notifications\u0027,"},{"line_number":294,"context_line":"  $keystone_notification_allow_requeue \u003d false,"},{"line_number":295,"context_line":"  $keystone_notification_thread_pool_size \u003d 10,"},{"line_number":296,"context_line":"  $kombu_ssl_ca_certs                 \u003d undef,"},{"line_number":297,"context_line":"  $kombu_ssl_certfile                 \u003d undef,"},{"line_number":298,"context_line":"  $kombu_ssl_keyfile                  \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_bfb1bb49","line":295,"range":{"start_line":291,"start_character":1,"end_line":295,"end_character":47},"updated":"2016-03-23 08:44:28.000000000","message":"wrong alignment","commit_id":"da7cc5f07f94be4a8d821e79cf77b272802f39f4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"61e00ee3209ef924c83e44e8699fa588ba83f6ae","unresolved":false,"context_lines":[{"line_number":154,"context_line":"#   Defaults to $::os_service_default"},{"line_number":155,"context_line":"#"},{"line_number":156,"context_line":"# [*keystone_notification_allow_requeue*]"},{"line_number":157,"context_line":"#   (optional) Requeues otification in case of notification processing error."},{"line_number":158,"context_line":"#   Defaults to $::os_service_default"},{"line_number":159,"context_line":"#"},{"line_number":160,"context_line":"# [*keystone_notification_thread_pool_size*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da0c15f0_5f41e80a","line":157,"updated":"2016-03-25 08:41:06.000000000","message":"notification","commit_id":"51bcbcad87d5b42a0fc09cd65c81e7d62ade5807"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"61e00ee3209ef924c83e44e8699fa588ba83f6ae","unresolved":false,"context_lines":[{"line_number":230,"context_line":"  $quota_containers                   \u003d -1,"},{"line_number":231,"context_line":"  $quota_consumers                    \u003d -1,"},{"line_number":232,"context_line":"  $quota_cas                          \u003d -1,"},{"line_number":233,"context_line":"  $enable_keystone_notification           \u003d $::os_service_default,"},{"line_number":234,"context_line":"  $keystone_notification_control_exchange \u003d $::os_service_default,"},{"line_number":235,"context_line":"  $keystone_notification_topic            \u003d $::os_service_default,"},{"line_number":236,"context_line":"  $keystone_notification_allow_requeue    \u003d $::os_service_default,"},{"line_number":237,"context_line":"  $keystone_notification_thread_pool_size \u003d $::os_service_default,"},{"line_number":238,"context_line":"  $kombu_ssl_ca_certs                 \u003d $::os_service_default,"},{"line_number":239,"context_line":"  $kombu_ssl_certfile                 \u003d $::os_service_default,"},{"line_number":240,"context_line":"  $kombu_ssl_keyfile                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da0c15f0_dfbe98fe","line":237,"range":{"start_line":233,"start_character":2,"end_line":237,"end_character":66},"updated":"2016-03-25 08:41:06.000000000","message":"alignment","commit_id":"51bcbcad87d5b42a0fc09cd65c81e7d62ade5807"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"06260f4658517b518429b45ecbf856d862649217","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  $queue_version                          \u003d $::os_service_default,"},{"line_number":225,"context_line":"  $queue_server_name                      \u003d $::os_service_default,"},{"line_number":226,"context_line":"  $retry_scheduler_initial_delay_seconds  \u003d $::os_service_default,"},{"line_number":227,"context_line":"  $retry_scheduler_periodic_interval_max_seconds"},{"line_number":228,"context_line":"                                          \u003d $::os_service_default,"},{"line_number":229,"context_line":"  $quota_secrets                          \u003d $::os_service_default,"},{"line_number":230,"context_line":"  $quota_orders                           \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_7bc79e45","line":227,"updated":"2016-03-29 07:20:26.000000000","message":"actually i think all should be aligned by the most long parameter like: https://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L588 for example","commit_id":"ebe6c307a327bc64ab5cd3afdd65c8c2dee036bc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9c42055a93a76c3743fca6ce53833844cde5de96","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  $queue_version                          \u003d $::os_service_default,"},{"line_number":225,"context_line":"  $queue_server_name                      \u003d $::os_service_default,"},{"line_number":226,"context_line":"  $retry_scheduler_initial_delay_seconds  \u003d $::os_service_default,"},{"line_number":227,"context_line":"  $retry_scheduler_periodic_interval_max_seconds"},{"line_number":228,"context_line":"                                          \u003d $::os_service_default,"},{"line_number":229,"context_line":"  $quota_secrets                          \u003d $::os_service_default,"},{"line_number":230,"context_line":"  $quota_orders                           \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_bace4d58","line":227,"in_reply_to":"ba0121b8_7bc79e45","updated":"2016-03-29 08:41:45.000000000","message":"it\u0027s ok current alignment","commit_id":"ebe6c307a327bc64ab5cd3afdd65c8c2dee036bc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"da0d0b95da6fb1b0c99f70be39e1d592d35f080b","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  $queue_version                          \u003d $::os_service_default,"},{"line_number":225,"context_line":"  $queue_server_name                      \u003d $::os_service_default,"},{"line_number":226,"context_line":"  $retry_scheduler_initial_delay_seconds  \u003d $::os_service_default,"},{"line_number":227,"context_line":"  $retry_scheduler_periodic_interval_max_seconds"},{"line_number":228,"context_line":"                                          \u003d $::os_service_default,"},{"line_number":229,"context_line":"  $quota_secrets                          \u003d $::os_service_default,"},{"line_number":230,"context_line":"  $quota_orders                           \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_49b111e1","line":227,"in_reply_to":"ba0121b8_bace4d58","updated":"2016-03-29 17:47:36.000000000","message":"well, we could align all parameters correctly, it really help readability.","commit_id":"ebe6c307a327bc64ab5cd3afdd65c8c2dee036bc"}],"manifests/notification.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ecf87500f41678bb315a75e0c0251a78ffe67a07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: barbican::notification"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Sets up keystone notifications for the Barbican API server"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*enable_keystone_notification*]"},{"line_number":6,"context_line":"#   (optional) Enable keystone notification listener functionality"},{"line_number":7,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_da8576cf","line":4,"updated":"2016-03-31 11:43:15.000000000","message":"#\n# \u003d\u003d\u003d Parameters\n#","commit_id":"3ce6945b1da5f0f758adce491b43c83161711fe4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ecf87500f41678bb315a75e0c0251a78ffe67a07","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*keystone_notification_thread_pool_size*]"},{"line_number":22,"context_line":"#   (optional) max threads to be used for notification server"},{"line_number":23,"context_line":"#   Defaults to $::os_service_default"},{"line_number":24,"context_line":"class barbican::notification ("},{"line_number":25,"context_line":"  $enable_keystone_notification           \u003d $::os_service_default,"},{"line_number":26,"context_line":"  $keystone_notification_control_exchange \u003d $::os_service_default,"},{"line_number":27,"context_line":"  $keystone_notification_topic            \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_3a6f522c","line":24,"updated":"2016-03-31 11:43:15.000000000","message":"empty line with #","commit_id":"3ce6945b1da5f0f758adce491b43c83161711fe4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"05429accdfcd6a520956fd0bea46d92d395ccc34","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   (optional) max threads to be used for notification server"},{"line_number":25,"context_line":"#   Defaults to $::os_service_default"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class barbican::notification ("},{"line_number":28,"context_line":"  $enable_keystone_notification           \u003d $::os_service_default,"},{"line_number":29,"context_line":"  $keystone_notification_control_exchange \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $keystone_notification_topic            \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ba0121b8_be3153a4","line":27,"updated":"2016-04-01 13:47:41.000000000","message":"notification is a bit too general for me, while it\u0027s keystone notifications. \"notification\" is also confusing because we have oslo messaging that does notifications on amqp... so I would suggest to find another class name. Why not barbican::keystone::notifications?","commit_id":"eef18c6f0419805c65c271b6bb8f8698af3accfa"}],"spec/classes/barbican_api_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"da0d0b95da6fb1b0c99f70be39e1d592d35f080b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      :quota_cas                          \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":47,"context_line":"      :manage_service                     \u003d\u003e true,"},{"line_number":48,"context_line":"      :enabled                            \u003d\u003e true,"},{"line_number":49,"context_line":"      :enable_keystone_notification                  \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":50,"context_line":"      :keystone_notification_control_exchange        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":51,"context_line":"      :keystone_notification_topic                   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":52,"context_line":"      :keystone_notification_allow_requeue           \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba0121b8_c9c5213d","line":49,"updated":"2016-03-29 17:47:36.000000000","message":"same for alignment","commit_id":"ebe6c307a327bc64ab5cd3afdd65c8c2dee036bc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"da0d0b95da6fb1b0c99f70be39e1d592d35f080b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      :quota_cas                          \u003d\u003e 10,"},{"line_number":96,"context_line":"      :enabled                            \u003d\u003e false,"},{"line_number":97,"context_line":"      :enable_keystone_notification       \u003d\u003e true,"},{"line_number":98,"context_line":"      :keystone_notification_allow_requeue    \u003d\u003e true,"},{"line_number":99,"context_line":"      :keystone_notification_thread_pool_size \u003d\u003e 20,"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":"  ].each do |param_set|"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba0121b8_09def910","line":98,"updated":"2016-03-29 17:47:36.000000000","message":"same","commit_id":"ebe6c307a327bc64ab5cd3afdd65c8c2dee036bc"}]}