)]}'
{"lib/puppet/provider/barbican_config/openstackconfig.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fbed7baa2750ffa9daf97b766a2c01f8c54be2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:barbican_config).provide("},{"line_number":2,"context_line":"  :openstackconfig,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ruby)"},{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def file_path"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba0121b8_f5232b56","line":3,"range":{"start_line":3,"start_character":59,"end_line":3,"end_character":64},"updated":"2016-03-31 11:54:56.000000000","message":"why you not following current scheme for config providers?","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"9e0a478ebaa752544ac14837de78807a7d9a5735","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:barbican_config).provide("},{"line_number":2,"context_line":"  :openstackconfig,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ruby)"},{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def file_path"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba0121b8_58448748","line":3,"range":{"start_line":3,"start_character":59,"end_line":3,"end_character":64},"in_reply_to":"ba0121b8_f5232b56","updated":"2016-04-01 15:20:37.000000000","message":"See https://review.openstack.org/#/c/234728/10 for an example.  This is to add support for multi-opt","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fbed7baa2750ffa9daf97b766a2c01f8c54be2f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"end"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba0121b8_7ae38aa4","line":11,"updated":"2016-03-31 11:54:56.000000000","message":"empty line","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"9e0a478ebaa752544ac14837de78807a7d9a5735","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"end"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba0121b8_78450b41","line":11,"in_reply_to":"ba0121b8_7ae38aa4","updated":"2016-04-01 15:20:37.000000000","message":"Done","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"}],"lib/puppet/type/barbican_config.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fbed7baa2750ffa9daf97b766a2c01f8c54be2f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      return false unless is.is_a? Array"},{"line_number":38,"context_line":"      return false unless is.length \u003d\u003d @should.length"},{"line_number":39,"context_line":"      # we don\u0027t care about the order of items in array, hence"},{"line_number":40,"context_line":"      # it is necessary to override insync"},{"line_number":41,"context_line":"      return ("},{"line_number":42,"context_line":"        is \u0026 @should \u003d\u003d is or"},{"line_number":43,"context_line":"        is \u0026 @should.map(\u0026:to_s) \u003d\u003d is"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba0121b8_7a7f0aab","line":40,"updated":"2016-03-31 11:54:56.000000000","message":"irb(main):019:0\u003e a \u003d [1,2,3]\n\u003d\u003e [1, 2, 3]\nirb(main):020:0\u003e b \u003d [3,2,1]\n\u003d\u003e [3, 2, 1]\nirb(main):021:0\u003e a \u003d\u003d b\n\u003d\u003e false\nirb(main):022:0\u003e a.sort \u003d\u003d b.sort\n\u003d\u003e true\n\nI think you SHOULD take care about that","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"9e0a478ebaa752544ac14837de78807a7d9a5735","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      return false unless is.is_a? Array"},{"line_number":38,"context_line":"      return false unless is.length \u003d\u003d @should.length"},{"line_number":39,"context_line":"      # we don\u0027t care about the order of items in array, hence"},{"line_number":40,"context_line":"      # it is necessary to override insync"},{"line_number":41,"context_line":"      return ("},{"line_number":42,"context_line":"        is \u0026 @should \u003d\u003d is or"},{"line_number":43,"context_line":"        is \u0026 @should.map(\u0026:to_s) \u003d\u003d is"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba0121b8_589927c3","line":40,"in_reply_to":"ba0121b8_7a7f0aab","updated":"2016-04-01 15:20:37.000000000","message":"This is for multi-opt.\nx \u003d [a,b,c] will result in \n\nx \u003d a\nx \u003d b\nx \u003d c\n\nin the config file.  Therefore the order in the array does not matter.  See:\nhttps://review.openstack.org/#/c/234728/10","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fbed7baa2750ffa9daf97b766a2c01f8c54be2f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      # we don\u0027t care about the order of items in array, hence"},{"line_number":40,"context_line":"      # it is necessary to override insync"},{"line_number":41,"context_line":"      return ("},{"line_number":42,"context_line":"        is \u0026 @should \u003d\u003d is or"},{"line_number":43,"context_line":"        is \u0026 @should.map(\u0026:to_s) \u003d\u003d is"},{"line_number":44,"context_line":"      )"},{"line_number":45,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba0121b8_356ac3b3","line":42,"range":{"start_line":42,"start_character":11,"end_line":42,"end_character":12},"updated":"2016-03-31 11:54:56.000000000","message":"why you using binary operator here? Why not a way, that i described above?","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"9e0a478ebaa752544ac14837de78807a7d9a5735","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      # we don\u0027t care about the order of items in array, hence"},{"line_number":40,"context_line":"      # it is necessary to override insync"},{"line_number":41,"context_line":"      return ("},{"line_number":42,"context_line":"        is \u0026 @should \u003d\u003d is or"},{"line_number":43,"context_line":"        is \u0026 @should.map(\u0026:to_s) \u003d\u003d is"},{"line_number":44,"context_line":"      )"},{"line_number":45,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba0121b8_18f20f06","line":42,"range":{"start_line":42,"start_character":11,"end_line":42,"end_character":12},"in_reply_to":"ba0121b8_356ac3b3","updated":"2016-04-01 15:20:37.000000000","message":"same as above.","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"}],"manifests/api.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"aa94cbae6f58ef7131183980804efa81f6a096cd","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"  # TODO - add this when support for multicfg is added"},{"line_number":592,"context_line":"  # enabled_secretstore_plugins - how to do multiple choices?"},{"line_number":593,"context_line":"  #$enabled_secretstore_plugins.each do |plugin|"},{"line_number":594,"context_line":"  #  barbican_config {"},{"line_number":595,"context_line":"  #      \u0027secretstore/enabled_secretstore_plugins\u0027: value \u003d\u003e plugin"},{"line_number":596,"context_line":"  #  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_b139efd9","line":593,"updated":"2016-03-23 09:07:34.000000000","message":"3 version of puppet doesn\u0027t support \u0027each\u0027 (it\u0027s available only with \u0027future\u0027 parser, which we don\u0027t use). And you can\u0027t have multiply calls of the same resource (it leads to duplication error).\n\nIs it possible to set this value like:\nbarbican_config { secretstore/enabled_secretstore_plugins\u0027: value \u003d\u003e join($enabled_secretstore_plugin, \u0027,\u0027) } ?","commit_id":"bc4ebf94f1c46a1a2675734bbfa6849005d36126"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"05bf6169b86c828690fa7d61f4607b19312e9808","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"  # TODO - add this when support for multicfg is added"},{"line_number":592,"context_line":"  # enabled_secretstore_plugins - how to do multiple choices?"},{"line_number":593,"context_line":"  #$enabled_secretstore_plugins.each do |plugin|"},{"line_number":594,"context_line":"  #  barbican_config {"},{"line_number":595,"context_line":"  #      \u0027secretstore/enabled_secretstore_plugins\u0027: value \u003d\u003e plugin"},{"line_number":596,"context_line":"  #  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_8d159f4a","line":593,"in_reply_to":"fa0719c6_b139efd9","updated":"2016-03-23 13:09:59.000000000","message":"+1 for this\n\nAlso, you have array parameters, i think will be better add validate_array for them.","commit_id":"bc4ebf94f1c46a1a2675734bbfa6849005d36126"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3b15139ff049e57dfdb48c12d1c49eb715b8260d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"#   (optional) max threads to be used for notification server"},{"line_number":162,"context_line":"#   Defaults to $::os_service_default"},{"line_number":163,"context_line":"#"},{"line_number":164,"context_line":"# [*enabled_secretstore_plugins*]"},{"line_number":165,"context_line":"#   (optional) Enabled secretstore plugins. Multiple plugins"},{"line_number":166,"context_line":"#   are defined in a list eg. [\u0027store_crypto\u0027, dogtag_crypto\u0027]"},{"line_number":167,"context_line":"#   Defaults to [\u0027store_crypto\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da0c15f0_aa99d770","line":164,"updated":"2016-03-25 13:00:20.000000000","message":"actually, we don\u0027t have such practice as adding a new parameters which is not implemented in code yet. So, why we need to make exception here?","commit_id":"7123142bed6659566cd56bf50118642b8995ed08"}],"manifests/plugins/p11_crypto.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fbed7baa2750ffa9daf97b766a2c01f8c54be2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: barbican::plugins::p11_crypto"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Sets up Barbican API p11_crypto secret_store plugin"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*p11_crypto_plugin_library_path*]"},{"line_number":6,"context_line":"#   (optional) Path to vendor PKCS11 library"},{"line_number":7,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_95d62f4d","line":4,"updated":"2016-03-31 11:54:56.000000000","message":"\u003d\u003d\u003d Parameters","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"9e0a478ebaa752544ac14837de78807a7d9a5735","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: barbican::plugins::p11_crypto"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Sets up Barbican API p11_crypto secret_store plugin"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*p11_crypto_plugin_library_path*]"},{"line_number":6,"context_line":"#   (optional) Path to vendor PKCS11 library"},{"line_number":7,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_38db937d","line":4,"in_reply_to":"ba0121b8_95d62f4d","updated":"2016-04-01 15:20:37.000000000","message":"Done","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fbed7baa2750ffa9daf97b766a2c01f8c54be2f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   Required if p11_crypto_plugin is enabled."},{"line_number":32,"context_line":"#   Defaults to undef"},{"line_number":33,"context_line":"class barbican::plugins::p11_crypto ("},{"line_number":34,"context_line":"  $p11_crypto_plugin_library_path         \u003d $::os_service_default,"},{"line_number":35,"context_line":"  $p11_crypto_plugin_login                \u003d undef,"},{"line_number":36,"context_line":"  $p11_crypto_plugin_mkek_label           \u003d undef,"},{"line_number":37,"context_line":"  $p11_crypto_plugin_mkek_length          \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_35b12348","line":34,"updated":"2016-03-31 11:54:56.000000000","message":"alignment","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"9e0a478ebaa752544ac14837de78807a7d9a5735","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   Required if p11_crypto_plugin is enabled."},{"line_number":32,"context_line":"#   Defaults to undef"},{"line_number":33,"context_line":"class barbican::plugins::p11_crypto ("},{"line_number":34,"context_line":"  $p11_crypto_plugin_library_path         \u003d $::os_service_default,"},{"line_number":35,"context_line":"  $p11_crypto_plugin_login                \u003d undef,"},{"line_number":36,"context_line":"  $p11_crypto_plugin_mkek_label           \u003d undef,"},{"line_number":37,"context_line":"  $p11_crypto_plugin_mkek_length          \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_98e61f42","line":34,"in_reply_to":"ba0121b8_35b12348","updated":"2016-04-01 15:20:37.000000000","message":"Done","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fbed7baa2750ffa9daf97b766a2c01f8c54be2f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  barbican_config {"},{"line_number":59,"context_line":"    \u0027p11_crypto_plugin/library_path\u0027:   value \u003d\u003e $p11_crypto_plugin_library_path;"},{"line_number":60,"context_line":"    \u0027p11_crypto_plugin/login\u0027:          value \u003d\u003e $p11_crypto_plugin_login;"},{"line_number":61,"context_line":"    \u0027p11_crypto_plugin/mkek_label\u0027:     value \u003d\u003e $p11_crypto_plugin_mkek_label;"},{"line_number":62,"context_line":"    \u0027p11_crypto_plugin/mkek_length\u0027:    value \u003d\u003e $p11_crypto_plugin_mkek_length;"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_95ef4f1d","line":59,"updated":"2016-03-31 11:54:56.000000000","message":"alignment","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"9e0a478ebaa752544ac14837de78807a7d9a5735","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  barbican_config {"},{"line_number":59,"context_line":"    \u0027p11_crypto_plugin/library_path\u0027:   value \u003d\u003e $p11_crypto_plugin_library_path;"},{"line_number":60,"context_line":"    \u0027p11_crypto_plugin/login\u0027:          value \u003d\u003e $p11_crypto_plugin_login;"},{"line_number":61,"context_line":"    \u0027p11_crypto_plugin/mkek_label\u0027:     value \u003d\u003e $p11_crypto_plugin_mkek_label;"},{"line_number":62,"context_line":"    \u0027p11_crypto_plugin/mkek_length\u0027:    value \u003d\u003e $p11_crypto_plugin_mkek_length;"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_78e18b29","line":59,"in_reply_to":"ba0121b8_95ef4f1d","updated":"2016-04-01 15:20:37.000000000","message":"Done","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"}],"manifests/plugins/simple_crypto.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fbed7baa2750ffa9daf97b766a2c01f8c54be2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: barbican::plugins::simple_crypto"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Sets up Barbican simple_crypto plugin"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*simple_crypto_plugin_kek*]"},{"line_number":6,"context_line":"#   (optional) base64 encoded 32-byte value"},{"line_number":7,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_35c6439a","line":4,"updated":"2016-03-31 11:54:56.000000000","message":"same as for prev file","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"9e0a478ebaa752544ac14837de78807a7d9a5735","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: barbican::plugins::simple_crypto"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Sets up Barbican simple_crypto plugin"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*simple_crypto_plugin_kek*]"},{"line_number":6,"context_line":"#   (optional) base64 encoded 32-byte value"},{"line_number":7,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_b8d5e343","line":4,"in_reply_to":"ba0121b8_35c6439a","updated":"2016-04-01 15:20:37.000000000","message":"Done","commit_id":"e4c81a8c9a425b5b0ef4884e491e3e8e5af75ab4"}],"spec/classes/barbican_api_spec.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"835c8cb4b336387310abfefbdd973b9ce0f76e3e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      :simple_crypto_plugin_kek           \u003d\u003e \u0027YWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXoxMjM0NTY\u003d\u0027,"},{"line_number":45,"context_line":"      :p11_crypto_plugin_library_path     \u003d\u003e \u0027/usr/lib/libCryptoki2_64.so\u0027,"},{"line_number":46,"context_line":"      :enabled_certificate_plugins        \u003d\u003e [\u0027simple_certificate\u0027,\u0027snakeoil_ca\u0027],"},{"line_number":47,"context_line":"      :enabled_certificate_event_plugins  \u003d\u003e [\u0027simple_certificate\u0027],"},{"line_number":48,"context_line":"      :manage_service                     \u003d\u003e true,"},{"line_number":49,"context_line":"      :enabled                            \u003d\u003e true,"},{"line_number":50,"context_line":"    }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa0719c6_85b741f4","line":47,"range":{"start_line":47,"start_character":7,"end_line":47,"end_character":40},"updated":"2016-03-23 10:08:20.000000000","message":"Can you please also check these parameters in \u0027is_expected.to set default parameters\u0027 ?","commit_id":"bc4ebf94f1c46a1a2675734bbfa6849005d36126"}]}