)]}'
{"manifests/db/sync.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"e561e42f47952a7bba67364fe30d404960b00aec","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  Package\u003c| tag \u003d\u003d \u0027barbican-package\u0027 |\u003e ~\u003e Exec[\u0027barbican-db-manage\u0027]"},{"line_number":23,"context_line":"  Barbican_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027barbican-db-manage\u0027]"},{"line_number":24,"context_line":"  Barbican_config\u003c| title \u003d\u003d \u0027DEFAULT/sql_connection\u0027 |\u003e ~\u003e Exec[\u0027barbican-db-manage\u0027]"},{"line_number":25,"context_line":"  Barbican_config \u003c| |\u003e ~\u003e Exec[\u0027barbican-db-manage\u0027]"},{"line_number":26,"context_line":"  Exec[\u0027barbican-db-manage\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027barbican-api\u0027 |\u003e"},{"line_number":27,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_aee99482","line":24,"updated":"2016-05-19 15:29:00.000000000","message":"why do you need special notify on \u0027connection\u0027 parameter change? I think line #25 is enough","commit_id":"d7c5cc8edde7e732015bf150390bd5f75a45534d"}],"spec/classes/barbican_db_sync_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ec2ed4569522b0ca5a6877c71317279012f50358","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    it \u0027runs barbican-db-sync\u0027 do"},{"line_number":8,"context_line":"      is_expected.to contain_exec(\u0027barbican-db-manage\u0027).with("},{"line_number":9,"context_line":"        :command     \u003d\u003e \u0027barbican-db-manage upgrade\u0027,"},{"line_number":10,"context_line":"        :path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":11,"context_line":"        :user        \u003d\u003e \u0027barbican\u0027,"},{"line_number":12,"context_line":"        :refreshonly \u003d\u003e \u0027true\u0027,"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"bab6814e_1f9c4868","line":9,"updated":"2016-05-19 16:08:41.000000000","message":"\u0027barbican-db-manage upgrade \u0027 - whitespace is required, because extra_params is undef by default. But I\u0027d suggest to change the format of https://github.com/openstack/puppet-barbican/blob/master/manifests/db/sync.pp#L15 to \u0027barbican-db-manage ${extra_params} upgrade\u0027. I guess it should work. Please correct me if I\u0027m wroing","commit_id":"d7c5cc8edde7e732015bf150390bd5f75a45534d"}]}
