)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dc7cf5666663f02e18125a7993ac4a3fa1330378","unresolved":false,"context_lines":[{"line_number":11,"context_line":"keystone::resource::authtoken"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is not backward compatible, we have change"},{"line_number":14,"context_line":"auth_type in api.pp to auth_strategy."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Some deprecations:"},{"line_number":17,"context_line":"- barbican::api::auth_url is deprecated in favor of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_97de8b6b","line":14,"updated":"2016-07-28 16:17:41.000000000","message":"it would have been great to explain why :-)","commit_id":"49d397b2ad0d707750c8d8d35dfd667edeb7e601"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"beb0e03560b6d21e3e6aac6f09460bb2f80b0600","unresolved":false,"context_lines":[{"line_number":11,"context_line":"keystone::resource::authtoken"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is not backward compatible, we have change"},{"line_number":14,"context_line":"auth_type in api.pp to auth_strategy."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Some deprecations:"},{"line_number":17,"context_line":"- barbican::api::auth_url is deprecated in favor of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_5a843ad3","line":14,"in_reply_to":"bacf61ea_97de8b6b","updated":"2016-07-28 16:41:14.000000000","message":"Done","commit_id":"49d397b2ad0d707750c8d8d35dfd667edeb7e601"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dc7cf5666663f02e18125a7993ac4a3fa1330378","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- barbican::api::project_domain_id is deprecated, use"},{"line_number":28,"context_line":"  barbican::keystone::authtoken::project_domain_name"},{"line_number":29,"context_line":"- barbican::api::user_domain_id is deprecated, use"},{"line_number":30,"context_line":"  barbican::keystone::authtoken::user_domain_name"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I2dee8a3d1c399234941f96d8f21f49526777f501"},{"line_number":33,"context_line":"Related-Bug: #1604463"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_b7e3cf32","line":30,"updated":"2016-07-28 16:17:41.000000000","message":"good.","commit_id":"49d397b2ad0d707750c8d8d35dfd667edeb7e601"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"beb0e03560b6d21e3e6aac6f09460bb2f80b0600","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- barbican::api::project_domain_id is deprecated, use"},{"line_number":28,"context_line":"  barbican::keystone::authtoken::project_domain_name"},{"line_number":29,"context_line":"- barbican::api::user_domain_id is deprecated, use"},{"line_number":30,"context_line":"  barbican::keystone::authtoken::user_domain_name"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I2dee8a3d1c399234941f96d8f21f49526777f501"},{"line_number":33,"context_line":"Related-Bug: #1604463"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_3a87c6d8","line":30,"in_reply_to":"bacf61ea_b7e3cf32","updated":"2016-07-28 16:41:14.000000000","message":"removed :D","commit_id":"49d397b2ad0d707750c8d8d35dfd667edeb7e601"}],"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"85daac507bdd1a0f81aa0cac91db514d1272caa3","unresolved":false,"context_lines":[{"line_number":215,"context_line":"#   Defaults to $::os_service_default"},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# \u003d DEPRECATED"},{"line_number":218,"context_line":"#"},{"line_number":219,"context_line":"# [*auth_type*]"},{"line_number":220,"context_line":"#   (optional) DEPRECATED. Use auth_strategy instead."},{"line_number":221,"context_line":"#   Defaults to undef"},{"line_number":222,"context_line":"#"},{"line_number":223,"context_line":"# [*auth_url*]"},{"line_number":224,"context_line":"#   (optional) identity server URI, needed for keystone auth"},{"line_number":225,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bacf61ea_a2355947","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":1},"updated":"2016-07-28 14:11:37.000000000","message":"puppet-barbican has not been released yet, so we can drop backward compatibility i think and use auth_strategy right now","commit_id":"8c62fa76504916f198466d5b192a6735c8d7ef16"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"370a57758e0a8e3184b5e899ddfccd8b4aee9ea7","unresolved":false,"context_lines":[{"line_number":215,"context_line":"#   Defaults to $::os_service_default"},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# \u003d DEPRECATED"},{"line_number":218,"context_line":"#"},{"line_number":219,"context_line":"# [*auth_type*]"},{"line_number":220,"context_line":"#   (optional) DEPRECATED. Use auth_strategy instead."},{"line_number":221,"context_line":"#   Defaults to undef"},{"line_number":222,"context_line":"#"},{"line_number":223,"context_line":"# [*auth_url*]"},{"line_number":224,"context_line":"#   (optional) identity server URI, needed for keystone auth"},{"line_number":225,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bacf61ea_e22591c2","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":1},"in_reply_to":"bacf61ea_a2355947","updated":"2016-07-28 14:16:29.000000000","message":"But as i see, in keystone::authtoken we are using auth_type. So, which parameter is preferred?","commit_id":"8c62fa76504916f198466d5b192a6735c8d7ef16"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"035d5bd2b6179aa186d3f3996d857dbcd41c40df","unresolved":false,"context_lines":[{"line_number":298,"context_line":"  # Deprecated"},{"line_number":299,"context_line":"  $auth_url                                      \u003d undef,"},{"line_number":300,"context_line":"  $auth_type                                     \u003d undef,"},{"line_number":301,"context_line":"  $keystone_auth_type                            \u003d undef,"},{"line_number":302,"context_line":"  $keystone_password                             \u003d undef,"},{"line_number":303,"context_line":"  $keystone_tenant                               \u003d undef,"},{"line_number":304,"context_line":"  $keystone_user                                 \u003d undef,"},{"line_number":305,"context_line":"  $project_domain_id                             \u003d undef,"},{"line_number":306,"context_line":"  $user_domain_id                                \u003d undef,"},{"line_number":307,"context_line":") inherits barbican::params {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bacf61ea_fcd8a3f1","line":304,"range":{"start_line":301,"start_character":0,"end_line":304,"end_character":57},"updated":"2016-07-28 10:42:32.000000000","message":"i guess you need add warnings for these parameters too and for auth_url","commit_id":"8c62fa76504916f198466d5b192a6735c8d7ef16"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"90ea06800edf29dfc57cdb488553c4b0f2da1fb7","unresolved":false,"context_lines":[{"line_number":298,"context_line":"  # Deprecated"},{"line_number":299,"context_line":"  $auth_url                                      \u003d undef,"},{"line_number":300,"context_line":"  $auth_type                                     \u003d undef,"},{"line_number":301,"context_line":"  $keystone_auth_type                            \u003d undef,"},{"line_number":302,"context_line":"  $keystone_password                             \u003d undef,"},{"line_number":303,"context_line":"  $keystone_tenant                               \u003d undef,"},{"line_number":304,"context_line":"  $keystone_user                                 \u003d undef,"},{"line_number":305,"context_line":"  $project_domain_id                             \u003d undef,"},{"line_number":306,"context_line":"  $user_domain_id                                \u003d undef,"},{"line_number":307,"context_line":") inherits barbican::params {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bacf61ea_9db99eec","line":304,"range":{"start_line":301,"start_character":0,"end_line":304,"end_character":57},"in_reply_to":"bacf61ea_fcd8a3f1","updated":"2016-07-28 12:19:08.000000000","message":"Yeah a totally forgot lol, Tks Denis","commit_id":"8c62fa76504916f198466d5b192a6735c8d7ef16"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dc7cf5666663f02e18125a7993ac4a3fa1330378","unresolved":false,"context_lines":[{"line_number":214,"context_line":"#   (optional) CA certificate file to use to verify connecting clients"},{"line_number":215,"context_line":"#   Defaults to $::os_service_default"},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# \u003d DEPRECATED"},{"line_number":218,"context_line":"#"},{"line_number":219,"context_line":"# [*auth_url*]"},{"line_number":220,"context_line":"#   (optional) identity server URI, needed for keystone auth"},{"line_number":221,"context_line":"#   Defaults to undef"},{"line_number":222,"context_line":"#"},{"line_number":223,"context_line":"# [*keystone_auth_type*]"},{"line_number":224,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::auth_type instead."},{"line_number":225,"context_line":"#   Defaults to undef"},{"line_number":226,"context_line":"#"},{"line_number":227,"context_line":"# [*keystone_password*]"},{"line_number":228,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::password instead."},{"line_number":229,"context_line":"#   Defaults to undef"},{"line_number":230,"context_line":"#"},{"line_number":231,"context_line":"# [*keystone_tenant*]"},{"line_number":232,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::project_name instead."},{"line_number":233,"context_line":"#   Defaults to undef"},{"line_number":234,"context_line":"#"},{"line_number":235,"context_line":"# [*keystone_user*]"},{"line_number":236,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::username instead."},{"line_number":237,"context_line":"#   Defaults to undef"},{"line_number":238,"context_line":"#"},{"line_number":239,"context_line":"# [*project_domain_id*]"},{"line_number":240,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::project_domain_name instead."},{"line_number":241,"context_line":"#   Defaults to undef"},{"line_number":242,"context_line":"#"},{"line_number":243,"context_line":"# [*user_domain_id*]"},{"line_number":244,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::user_domain_name instead."},{"line_number":245,"context_line":"#   Defaults to undef"},{"line_number":246,"context_line":"#"},{"line_number":247,"context_line":"class barbican::api ("},{"line_number":248,"context_line":"  $ensure_package                                \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_57425311","line":245,"range":{"start_line":217,"start_character":0,"end_line":245,"end_character":21},"updated":"2016-07-28 16:17:41.000000000","message":"why do you deprecate them? I thought we agreed to make it non backward compatible because nobody is currently using the module?","commit_id":"49d397b2ad0d707750c8d8d35dfd667edeb7e601"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"beb0e03560b6d21e3e6aac6f09460bb2f80b0600","unresolved":false,"context_lines":[{"line_number":214,"context_line":"#   (optional) CA certificate file to use to verify connecting clients"},{"line_number":215,"context_line":"#   Defaults to $::os_service_default"},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# \u003d DEPRECATED"},{"line_number":218,"context_line":"#"},{"line_number":219,"context_line":"# [*auth_url*]"},{"line_number":220,"context_line":"#   (optional) identity server URI, needed for keystone auth"},{"line_number":221,"context_line":"#   Defaults to undef"},{"line_number":222,"context_line":"#"},{"line_number":223,"context_line":"# [*keystone_auth_type*]"},{"line_number":224,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::auth_type instead."},{"line_number":225,"context_line":"#   Defaults to undef"},{"line_number":226,"context_line":"#"},{"line_number":227,"context_line":"# [*keystone_password*]"},{"line_number":228,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::password instead."},{"line_number":229,"context_line":"#   Defaults to undef"},{"line_number":230,"context_line":"#"},{"line_number":231,"context_line":"# [*keystone_tenant*]"},{"line_number":232,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::project_name instead."},{"line_number":233,"context_line":"#   Defaults to undef"},{"line_number":234,"context_line":"#"},{"line_number":235,"context_line":"# [*keystone_user*]"},{"line_number":236,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::username instead."},{"line_number":237,"context_line":"#   Defaults to undef"},{"line_number":238,"context_line":"#"},{"line_number":239,"context_line":"# [*project_domain_id*]"},{"line_number":240,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::project_domain_name instead."},{"line_number":241,"context_line":"#   Defaults to undef"},{"line_number":242,"context_line":"#"},{"line_number":243,"context_line":"# [*user_domain_id*]"},{"line_number":244,"context_line":"#   (optional) DEPRECATED. Use barbican::keystone::authtoken::user_domain_name instead."},{"line_number":245,"context_line":"#   Defaults to undef"},{"line_number":246,"context_line":"#"},{"line_number":247,"context_line":"class barbican::api ("},{"line_number":248,"context_line":"  $ensure_package                                \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_7a693e25","line":245,"range":{"start_line":217,"start_character":0,"end_line":245,"end_character":21},"in_reply_to":"bacf61ea_57425311","updated":"2016-07-28 16:41:14.000000000","message":"Done","commit_id":"49d397b2ad0d707750c8d8d35dfd667edeb7e601"}],"manifests/keystone/authtoken.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2439c84cc3e7cfe7e5853bce8a8a369d252cbc1a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"  $insecure                       \u003d $::os_service_default,"},{"line_number":201,"context_line":"  $auth_section                   \u003d $::os_service_default,"},{"line_number":202,"context_line":"  $auth_type                      \u003d \u0027password\u0027,"},{"line_number":203,"context_line":"  $auth_uri                       \u003d $::os_service_default,"},{"line_number":204,"context_line":"  $auth_version                   \u003d $::os_service_default,"},{"line_number":205,"context_line":"  $cache                          \u003d $::os_service_default,"},{"line_number":206,"context_line":"  $cafile                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_e25d807a","line":203,"updated":"2016-07-28 18:54:57.000000000","message":"Shouldn\u0027t this be \u0027http://localhost:5000\u0027?   Don\u0027t you need both auth_url and auth_uri?","commit_id":"6a31d60faf3617b485803e3c966b392b718acb36"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2c3f04085e2a4a1c60ecb3b5746ac960ae77a119","unresolved":false,"context_lines":[{"line_number":192,"context_line":"#"},{"line_number":193,"context_line":"class barbican::keystone::authtoken("},{"line_number":194,"context_line":"  $username                       \u003d \u0027barbican\u0027,"},{"line_number":195,"context_line":"  $password                       \u003d $::os_service_default,"},{"line_number":196,"context_line":"  $auth_url                       \u003d \u0027http://localhost:35357\u0027,"},{"line_number":197,"context_line":"  $project_name                   \u003d \u0027services\u0027,"},{"line_number":198,"context_line":"  $user_domain_name               \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bacf61ea_2d5d8b15","line":195,"updated":"2016-08-04 17:22:26.000000000","message":"need to set to required and drop include for this class in api.\nsame as https://review.openstack.org/#/c/350369/","commit_id":"4d44dddcd563e6d1bc513701027b96a3343797e4"}],"spec/classes/barbican_api_spec.rb":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"59c109090458340bca169f2c5be0c9813076e338","unresolved":false,"context_lines":[{"line_number":190,"context_line":"  describe \u0027with SSL socket options left by default\u0027 do"},{"line_number":191,"context_line":"    let :params do"},{"line_number":192,"context_line":"      {"},{"line_number":193,"context_line":"        :use_ssl  \u003d\u003e false,"},{"line_number":194,"context_line":"        :keystone_password \u003d\u003e \u0027foobar\u0027,"},{"line_number":195,"context_line":"      }"},{"line_number":196,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bacf61ea_5e63b11a","line":193,"updated":"2016-07-28 06:37:58.000000000","message":"alignment?","commit_id":"8c62fa76504916f198466d5b192a6735c8d7ef16"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"90ea06800edf29dfc57cdb488553c4b0f2da1fb7","unresolved":false,"context_lines":[{"line_number":190,"context_line":"  describe \u0027with SSL socket options left by default\u0027 do"},{"line_number":191,"context_line":"    let :params do"},{"line_number":192,"context_line":"      {"},{"line_number":193,"context_line":"        :use_ssl  \u003d\u003e false,"},{"line_number":194,"context_line":"        :keystone_password \u003d\u003e \u0027foobar\u0027,"},{"line_number":195,"context_line":"      }"},{"line_number":196,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bacf61ea_fdceda81","line":193,"in_reply_to":"bacf61ea_5e63b11a","updated":"2016-07-28 12:19:08.000000000","message":"Sure, i\u0027ll update","commit_id":"8c62fa76504916f198466d5b192a6735c8d7ef16"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"59c109090458340bca169f2c5be0c9813076e338","unresolved":false,"context_lines":[{"line_number":192,"context_line":"      {"},{"line_number":193,"context_line":"        :use_ssl  \u003d\u003e false,"},{"line_number":194,"context_line":"        :keystone_password \u003d\u003e \u0027foobar\u0027,"},{"line_number":195,"context_line":"      }"},{"line_number":196,"context_line":"    end"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    it { is_expected.to contain_barbican_config(\u0027DEFAULT/ca_file\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bacf61ea_9e124961","line":195,"updated":"2016-07-28 06:37:58.000000000","message":"is keystone_password still required? Ditto throughout this file ..","commit_id":"8c62fa76504916f198466d5b192a6735c8d7ef16"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"90ea06800edf29dfc57cdb488553c4b0f2da1fb7","unresolved":false,"context_lines":[{"line_number":192,"context_line":"      {"},{"line_number":193,"context_line":"        :use_ssl  \u003d\u003e false,"},{"line_number":194,"context_line":"        :keystone_password \u003d\u003e \u0027foobar\u0027,"},{"line_number":195,"context_line":"      }"},{"line_number":196,"context_line":"    end"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    it { is_expected.to contain_barbican_config(\u0027DEFAULT/ca_file\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bacf61ea_7da14aa9","line":195,"in_reply_to":"bacf61ea_9e124961","updated":"2016-07-28 12:19:08.000000000","message":"This is backward compatible you can still use keystone_password \u003d)","commit_id":"8c62fa76504916f198466d5b192a6735c8d7ef16"}]}
