)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e7c9465e6bec952009146d7fc588785484a4c620","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew J. Black \u003cmjblack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-28 16:27:41 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Update barbican for Debian based systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are barbican packages available for debian based systems"},{"line_number":10,"context_line":"but the current module is designed to work with redhat based"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_d069608d","line":7,"updated":"2016-10-04 18:43:35.000000000","message":"still a WIP?","commit_id":"ee3409a34d2988e9be5dca89fd3594db1aaa88e1"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"f20766f6f34009fb88540d8c9fd959c3b6573120","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew J. Black \u003cmjblack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-28 16:27:41 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Update barbican for Debian based systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are barbican packages available for debian based systems"},{"line_number":10,"context_line":"but the current module is designed to work with redhat based"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_c2bb520d","line":7,"in_reply_to":"1a95cdbc_d069608d","updated":"2016-10-04 21:13:07.000000000","message":"yup, still working on it. I will be uploading a change soon.","commit_id":"ee3409a34d2988e9be5dca89fd3594db1aaa88e1"}],"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e7c9465e6bec952009146d7fc588785484a4c620","unresolved":false,"context_lines":[{"line_number":325,"context_line":"          \u0027/etc/barbican/barbican-api-paste.ini\u0027,"},{"line_number":326,"context_line":"          \u0027/etc/barbican/gunicorn-config.py\u0027]:"},{"line_number":327,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":328,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":329,"context_line":"  }"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  package { \u0027barbican-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a95cdbc_f0049cc7","line":328,"updated":"2016-10-04 18:43:35.000000000","message":"Yea we should just use a tag here which would simplify the notifies further down as well","commit_id":"ee3409a34d2988e9be5dca89fd3594db1aaa88e1"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ff4409c036ed3fb64cc736da4aa9b139157157f","unresolved":false,"context_lines":[{"line_number":325,"context_line":"          \u0027/etc/barbican/barbican-api-paste.ini\u0027,"},{"line_number":326,"context_line":"          \u0027/etc/barbican/gunicorn-config.py\u0027]:"},{"line_number":327,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":328,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":329,"context_line":"  }"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  package { \u0027barbican-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_1403810e","line":328,"updated":"2016-09-29 14:18:48.000000000","message":"nit refactor: i think will be better just tag those resources and then just trigger service by tag. Wwhat do you think?","commit_id":"ee3409a34d2988e9be5dca89fd3594db1aaa88e1"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"f20766f6f34009fb88540d8c9fd959c3b6573120","unresolved":false,"context_lines":[{"line_number":325,"context_line":"          \u0027/etc/barbican/barbican-api-paste.ini\u0027,"},{"line_number":326,"context_line":"          \u0027/etc/barbican/gunicorn-config.py\u0027]:"},{"line_number":327,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":328,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":329,"context_line":"  }"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  package { \u0027barbican-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a95cdbc_c25272dd","line":328,"in_reply_to":"1a95cdbc_f0049cc7","updated":"2016-10-04 21:13:07.000000000","message":"I\u0027m removing the file resource, and the notifies, since it will be handled by the barbican_config and barbican_api_paste_ini. The gunicorn file is only used if not utilizing apache so I\u0027m redoing a little bit to make sure it passes beaker tests on ubuntu.","commit_id":"ee3409a34d2988e9be5dca89fd3594db1aaa88e1"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"75deab676bf1e95824b5457d7df2e7235dc1d767","unresolved":false,"context_lines":[{"line_number":325,"context_line":"          \u0027/etc/barbican/barbican-api-paste.ini\u0027,"},{"line_number":326,"context_line":"          \u0027/etc/barbican/gunicorn-config.py\u0027]:"},{"line_number":327,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":328,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":329,"context_line":"  }"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  package { \u0027barbican-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_ba7c6fec","line":328,"in_reply_to":"3a98d1f4_1403810e","updated":"2016-09-29 16:23:18.000000000","message":"I\u0027m thinking, do we need to specify barbican.conf and barbican-api-paste.ini?","commit_id":"ee3409a34d2988e9be5dca89fd3594db1aaa88e1"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7070f0140616170fe3177355685a33d3e76287a7","unresolved":false,"context_lines":[{"line_number":325,"context_line":"          \u0027/etc/barbican/barbican-api-paste.ini\u0027,"},{"line_number":326,"context_line":"          \u0027/etc/barbican/gunicorn-config.py\u0027]:"},{"line_number":327,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":328,"context_line":"    require \u003d\u003e Package[\u0027barbican-api\u0027],"},{"line_number":329,"context_line":"  }"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  package { \u0027barbican-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_bb071180","line":328,"in_reply_to":"3a98d1f4_ba7c6fec","updated":"2016-09-29 17:14:15.000000000","message":"specify where?\n\n\n  file { [\u0027/etc/barbican/barbican.conf\u0027,\n          \u0027/etc/barbican/barbican-api-paste.ini\u0027,\n          \u0027/etc/barbican/gunicorn-config.py\u0027]:\n    ensure  \u003d\u003e present,\n    require \u003d\u003e Package[\u0027barbican-api\u0027],\n    tag     \u003d\u003e \u0027barbican-files\u0027\n  }\n\n  File\u003c|tag \u003d\u003d \u0027barbican-files\u0027|\u003e ~\u003e Service[$service_name]","commit_id":"ee3409a34d2988e9be5dca89fd3594db1aaa88e1"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"8f666063be65666f9b55201ffef26a133e3711e7","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027barbican-package\u0027],"},{"line_number":322,"context_line":"  }"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"  Package[\u0027barbican-api\u0027]                             ~\u003e Service[$service_name]"},{"line_number":325,"context_line":"  Barbican_config\u003c||\u003e                                 ~\u003e Service[$service_name]"},{"line_number":326,"context_line":"  Barbican_api_paste_ini\u003c||\u003e                          ~\u003e Service[$service_name]"},{"line_number":327,"context_line":"  Package\u003c| tag \u003d\u003d \u0027barbican-package\u0027 |\u003e              -\u003e Barbican_config\u003c||\u003e"},{"line_number":328,"context_line":"  Package\u003c| tag \u003d\u003d \u0027barbican-package\u0027 |\u003e              -\u003e Barbican_api_paste_ini\u003c||\u003e"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  # basic service config"},{"line_number":331,"context_line":"  if $host_href \u003d\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a95cdbc_bef64cd5","line":328,"range":{"start_line":324,"start_character":25,"end_line":328,"end_character":83},"updated":"2016-10-05 09:45:41.000000000","message":"alignment","commit_id":"1e434adfc228994c25860dde565487da6e9022eb"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"180da1e3c7ec9d9c42b2a7e9f58efa570805fca3","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027barbican-package\u0027],"},{"line_number":322,"context_line":"  }"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"  Package[\u0027barbican-api\u0027]                             ~\u003e Service[$service_name]"},{"line_number":325,"context_line":"  Barbican_config\u003c||\u003e                                 ~\u003e Service[$service_name]"},{"line_number":326,"context_line":"  Barbican_api_paste_ini\u003c||\u003e                          ~\u003e Service[$service_name]"},{"line_number":327,"context_line":"  Package\u003c| tag \u003d\u003d \u0027barbican-package\u0027 |\u003e              -\u003e Barbican_config\u003c||\u003e"},{"line_number":328,"context_line":"  Package\u003c| tag \u003d\u003d \u0027barbican-package\u0027 |\u003e              -\u003e Barbican_api_paste_ini\u003c||\u003e"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  # basic service config"},{"line_number":331,"context_line":"  if $host_href \u003d\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a95cdbc_575606d3","line":328,"range":{"start_line":324,"start_character":25,"end_line":328,"end_character":83},"in_reply_to":"1a95cdbc_bef64cd5","updated":"2016-10-05 12:20:49.000000000","message":"thanks, I had moved two items from that area that pushed the alignment out that far. I just uploaded another patch to address this.","commit_id":"1e434adfc228994c25860dde565487da6e9022eb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"08f46c45a1d042f30d26a559045a01029d57ea17","unresolved":false,"context_lines":[{"line_number":468,"context_line":"      match \u003d\u003e \u0027.*bind \u003d .*\u0027,"},{"line_number":469,"context_line":"    }"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    Package\u003c| tag \u003d\u003d \u0027barbican-package\u0027 |\u003e              -\u003e File_line[\u0027Modify bind_port in gunicorn-config.py\u0027]"},{"line_number":472,"context_line":"    File_line[\u0027Modify bind_port in gunicorn-config.py\u0027] ~\u003e Service[$service_name]"},{"line_number":473,"context_line":"  } elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":474,"context_line":"    include ::apache::params"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a95cdbc_3c3bd29d","line":471,"updated":"2016-10-06 18:07:32.000000000","message":"don\u0027t need to duplicate this next bit if you just continued with a ~\u003e to the Service[$service_name]","commit_id":"b09958481108225234fe119fad19e3204a957ff6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a89d6eaac3aef64f13d24f5066bd750cc3f34cb6","unresolved":false,"context_lines":[{"line_number":468,"context_line":"      match \u003d\u003e \u0027.*bind \u003d .*\u0027,"},{"line_number":469,"context_line":"    }"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    Package\u003c| tag \u003d\u003d \u0027barbican-package\u0027 |\u003e              -\u003e File_line[\u0027Modify bind_port in gunicorn-config.py\u0027]"},{"line_number":472,"context_line":"    File_line[\u0027Modify bind_port in gunicorn-config.py\u0027] ~\u003e Service[$service_name]"},{"line_number":473,"context_line":"  } elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":474,"context_line":"    include ::apache::params"},{"line_number":475,"context_line":"    # Debian/Ubuntu do not have a barbican-api and this will error out on them."}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a95cdbc_633e8d8d","line":472,"range":{"start_line":471,"start_character":0,"end_line":472,"end_character":81},"updated":"2016-10-06 23:05:48.000000000","message":"Package\u003c| tag \u003d\u003d \u0027barbican-package\u0027 |\u003e -\u003e   \n  File_line[\u0027Modify bind_port in gunicorn-config.py\u0027] ~\u003e\n    Service[$service_name]","commit_id":"1e6caf1d71ee05107d7ec4d37dd4d460f8ceccd0"}],"spec/classes/barbican_api_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f4066667000125ecf080069c204ea9f182ca2b56","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"      it \u0027is_expected.to set keystone params correctly\u0027 do"},{"line_number":246,"context_line":"        is_expected.to contain_barbican_api_paste_ini(\u0027pipeline:barbican_api/pipeline\u0027)\\"},{"line_number":247,"context_line":"          .with_value(\u0027cors authtoken context apiapp\u0027)"},{"line_number":248,"context_line":"        is_expected.to contain_class(\u0027barbican::keystone::authtoken\u0027)"},{"line_number":249,"context_line":"      end"},{"line_number":250,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"1a95cdbc_7d32d311","line":247,"range":{"start_line":247,"start_character":28,"end_line":247,"end_character":37},"updated":"2016-10-06 10:18:22.000000000","message":"keystone_authtoken","commit_id":"e660e521d2cf137c1d796e8823e2745aba84ad73"}],"spec/classes/barbican_db_mysql_spec.rb":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"e4af795c81f51a3a6e8c19710ccda6f574be08a2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  shared_examples_for \u0027barbican db mysql\u0027 do"},{"line_number":25,"context_line":"    let :pre_condition do"},{"line_number":26,"context_line":"      ["},{"line_number":27,"context_line":"\t\u0027include mysql::server\u0027,"},{"line_number":28,"context_line":"\t\u0027include barbican::db::sync\u0027"},{"line_number":29,"context_line":"      ]"},{"line_number":30,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a98d1f4_e42cd5ad","line":27,"updated":"2016-09-28 20:03:43.000000000","message":"Can you please indent with spaces rather than tabs ? (sorry)","commit_id":"d90ee8cc1f669bc1246b408c03759f222c61d3ef"}]}