)]}'
{"manifests/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"894297ddf1e7a67137adeb60ad07eca5a2e94994","unresolved":false,"context_lines":[{"line_number":322,"context_line":"  $ensure_package                                \u003d undef,"},{"line_number":323,"context_line":"  $rpc_backend                                   \u003d $::os_service_default,"},{"line_number":324,"context_line":"  $enabled_secretstore_plugins                   \u003d $::os_service_default,"},{"line_number":325,"context_line":"  $enabled_crypto_plugins                        \u003d $::os_service_default,"},{"line_number":326,"context_line":") inherits barbican::params {"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_6e01ed04","line":325,"updated":"2017-11-29 22:58:42.000000000","message":"for these 2, change default to undef","commit_id":"53591dea7f9dc01a1d622a4f4ece17938577909c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"ca7490ff2c6212f392c6a222738d228952a3810d","unresolved":false,"context_lines":[{"line_number":322,"context_line":"  $ensure_package                                \u003d undef,"},{"line_number":323,"context_line":"  $rpc_backend                                   \u003d $::os_service_default,"},{"line_number":324,"context_line":"  $enabled_secretstore_plugins                   \u003d $::os_service_default,"},{"line_number":325,"context_line":"  $enabled_crypto_plugins                        \u003d $::os_service_default,"},{"line_number":326,"context_line":") inherits barbican::params {"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_d63436fe","line":325,"in_reply_to":"ff82abbf_6e01ed04","updated":"2017-11-30 20:53:00.000000000","message":"On further reflection, these parameters have not officially been deprecated by the Barbican project.  They are simply not used if multiple_secret_stores_enabled is set to true.  So I wont deprecate them, and will rather issue a warning if these parameters are set and multiple_secret_stores_enabled is true.","commit_id":"53591dea7f9dc01a1d622a4f4ece17938577909c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"894297ddf1e7a67137adeb60ad07eca5a2e94994","unresolved":false,"context_lines":[{"line_number":431,"context_line":"    \u0027DEFAULT/max_allowed_secret_in_bytes\u0027:           value \u003d\u003e $max_allowed_secret_in_bytes;"},{"line_number":432,"context_line":"    \u0027DEFAULT/max_allowed_request_size_in_bytes\u0027:     value \u003d\u003e $max_allowed_request_size_in_bytes;"},{"line_number":433,"context_line":"  }"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"  # enabled plugins"},{"line_number":436,"context_line":"  barbican_config {"},{"line_number":437,"context_line":"    \u0027secretstore/enabled_secretstore_plugins\u0027:             value \u003d\u003e $enabled_secretstore_plugins;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_8e047116","line":434,"updated":"2017-11-29 22:58:42.000000000","message":"and here, check if the 2 params are set, send warning with deprecation message","commit_id":"53591dea7f9dc01a1d622a4f4ece17938577909c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"68cb080cc56f1949c78453a1f67e39abc40cf1d9","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    \u0027DEFAULT/max_allowed_request_size_in_bytes\u0027:     value \u003d\u003e $max_allowed_request_size_in_bytes;"},{"line_number":435,"context_line":"  }"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"  if $multiple_secret_stores_enabled and $enabled_secretstore_plugins {"},{"line_number":438,"context_line":"    warning(\"barbican::api::enabled_secretstore_plugins and barbican::api::enabled_crypto_plugins \\"},{"line_number":439,"context_line":"      will be set by puppet, but will not be used by the server whenever \\"},{"line_number":440,"context_line":"      barbican::api::multiple_secret_stores_enabled is set to true.  Use \\"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"df87a7cf_0324a5c5","line":437,"updated":"2017-12-01 21:36:41.000000000","message":"Need to use !is_service_default($enabled_secretstore_plugins) and/or you\u0027ll probably want a check to ensure that $enabled_secretstore_plugins is not set to $::os_service_default.","commit_id":"980ace8bc5bdf1d2660519a09b80ddb474da6bed"}],"manifests/plugins/dogtag.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"894297ddf1e7a67137adeb60ad07eca5a2e94994","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027secretstore:dogtag/secret_store_plugin\u0027: value \u003d\u003e \u0027dogtag_plugin\u0027;"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  if ($global_default) {"},{"line_number":78,"context_line":"    barbican_config {"},{"line_number":79,"context_line":"      \u0027secretstore:dogtag/global_default\u0027: value \u003d\u003e true;"},{"line_number":80,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_a305ce15","line":77,"updated":"2017-11-29 22:58:42.000000000","message":"you don\u0027t need a condition here right? you can just use $global_default ?","commit_id":"53591dea7f9dc01a1d622a4f4ece17938577909c"}],"manifests/plugins/kmip.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"894297ddf1e7a67137adeb60ad07eca5a2e94994","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  if ($global_default) {"},{"line_number":98,"context_line":"    barbican_config {"},{"line_number":99,"context_line":"      \u0027secretstore:kmip/global_default\u0027: value \u003d\u003e true;"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_030b5a29","line":99,"updated":"2017-11-29 22:58:42.000000000","message":"ditto","commit_id":"53591dea7f9dc01a1d622a4f4ece17938577909c"}],"manifests/plugins/p11_crypto.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"894297ddf1e7a67137adeb60ad07eca5a2e94994","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  if ($global_default) {"},{"line_number":83,"context_line":"    barbican_config {"},{"line_number":84,"context_line":"      \u0027secretstore:pkcs11/global_default\u0027: value \u003d\u003e true;"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_2e07651a","line":84,"updated":"2017-11-29 22:58:42.000000000","message":"ditto","commit_id":"53591dea7f9dc01a1d622a4f4ece17938577909c"}],"manifests/plugins/simple_crypto.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"894297ddf1e7a67137adeb60ad07eca5a2e94994","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  if ($global_default) {"},{"line_number":28,"context_line":"    barbican_config {"},{"line_number":29,"context_line":"      \u0027secretstore:simple_crypto/global_default\u0027: value \u003d\u003e true;"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_c3001205","line":29,"updated":"2017-11-29 22:58:42.000000000","message":"ditto","commit_id":"53591dea7f9dc01a1d622a4f4ece17938577909c"}]}