)]}'
{"manifests/plugins/p11_crypto.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"364bda39f7c35a01a150c2c3196c57616684af9f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#   Defaults to false"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"class barbican::plugins::p11_crypto ("},{"line_number":68,"context_line":"  $p11_crypto_plugin_library_path          \u003d undef,"},{"line_number":69,"context_line":"  $p11_crypto_plugin_login                 \u003d undef,"},{"line_number":70,"context_line":"  $p11_crypto_plugin_mkek_label            \u003d undef,"},{"line_number":71,"context_line":"  $p11_crypto_plugin_mkek_length           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f65232a_a93a2531","line":68,"range":{"start_line":68,"start_character":3,"end_line":68,"end_character":33},"updated":"2020-10-21 12:24:47.000000000","message":"(Just for my note) Maybe we can remove p11_crypto prefix from these parameters in the future...","commit_id":"811eca8afd00005c2204a57363d2dbe85688be2b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"364bda39f7c35a01a150c2c3196c57616684af9f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    \u0027p11_crypto_plugin/mkek_label\u0027:            value \u003d\u003e $p11_crypto_plugin_mkek_label;"},{"line_number":112,"context_line":"    \u0027p11_crypto_plugin/mkek_length\u0027:           value \u003d\u003e $p11_crypto_plugin_mkek_length;"},{"line_number":113,"context_line":"    \u0027p11_crypto_plugin/hmac_label\u0027:            value \u003d\u003e $p11_crypto_plugin_hmac_label;"},{"line_number":114,"context_line":"    \u0027p11_crypto_plugin/token_serial_number\u0027:   value \u003d\u003e $p11_crypto_plugin_token_serial_number;"},{"line_number":115,"context_line":"    \u0027p11_crypto_plugin/token_label\u0027:           value \u003d\u003e $p11_crypto_plugin_token_label;"},{"line_number":116,"context_line":"    \u0027p11_crypto_plugin/slot_id\u0027:               value \u003d\u003e $p11_crypto_plugin_slot_id;"},{"line_number":117,"context_line":"    \u0027p11_crypto_plugin/encryption_mechanism\u0027:  value \u003d\u003e $p11_crypto_plugin_encryption_mechanism;"},{"line_number":118,"context_line":"    \u0027p11_crypto_plugin/hmac_key_type\u0027:         value \u003d\u003e $p11_crypto_plugin_hmac_key_type;"},{"line_number":119,"context_line":"    \u0027p11_crypto_plugin/hmac_keygen_mechanism\u0027: value \u003d\u003e $p11_crypto_plugin_hmac_keygen_mechanism;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f65232a_8934894c","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":83},"updated":"2020-10-21 12:24:47.000000000","message":"IIUC correctly one of these items should be set, right ?\n\nI\u0027m afraid that setting \"undef\" would cause the parameter set with empty value instead of removing that parameter.\n\nI\u0027d suggest the following changes to achieve what we want.\n 1. Change the default value of these 3 parameters to $::os_service_default\n 2. Use is_service_default(\u003cparameter\u003e) to check whether the parameters is set","commit_id":"811eca8afd00005c2204a57363d2dbe85688be2b"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"bee59b258d22a9766ef175cce86426967158fc55","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    \u0027p11_crypto_plugin/mkek_label\u0027:            value \u003d\u003e $p11_crypto_plugin_mkek_label;"},{"line_number":112,"context_line":"    \u0027p11_crypto_plugin/mkek_length\u0027:           value \u003d\u003e $p11_crypto_plugin_mkek_length;"},{"line_number":113,"context_line":"    \u0027p11_crypto_plugin/hmac_label\u0027:            value \u003d\u003e $p11_crypto_plugin_hmac_label;"},{"line_number":114,"context_line":"    \u0027p11_crypto_plugin/token_serial_number\u0027:   value \u003d\u003e $p11_crypto_plugin_token_serial_number;"},{"line_number":115,"context_line":"    \u0027p11_crypto_plugin/token_label\u0027:           value \u003d\u003e $p11_crypto_plugin_token_label;"},{"line_number":116,"context_line":"    \u0027p11_crypto_plugin/slot_id\u0027:               value \u003d\u003e $p11_crypto_plugin_slot_id;"},{"line_number":117,"context_line":"    \u0027p11_crypto_plugin/encryption_mechanism\u0027:  value \u003d\u003e $p11_crypto_plugin_encryption_mechanism;"},{"line_number":118,"context_line":"    \u0027p11_crypto_plugin/hmac_key_type\u0027:         value \u003d\u003e $p11_crypto_plugin_hmac_key_type;"},{"line_number":119,"context_line":"    \u0027p11_crypto_plugin/hmac_keygen_mechanism\u0027: value \u003d\u003e $p11_crypto_plugin_hmac_keygen_mechanism;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f65232a_a5a20c4a","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":83},"in_reply_to":"3f65232a_8934894c","updated":"2020-10-26 20:39:10.000000000","message":"\u003e only one of these items should be set\n\nThat\u0027s not quite right.  It\u0027s OK to specify just one, or any two, or all three.","commit_id":"811eca8afd00005c2204a57363d2dbe85688be2b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c7b17886e174934b2a2e8967944891e38e471172","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    \u0027p11_crypto_plugin/mkek_label\u0027:            value \u003d\u003e $p11_crypto_plugin_mkek_label;"},{"line_number":112,"context_line":"    \u0027p11_crypto_plugin/mkek_length\u0027:           value \u003d\u003e $p11_crypto_plugin_mkek_length;"},{"line_number":113,"context_line":"    \u0027p11_crypto_plugin/hmac_label\u0027:            value \u003d\u003e $p11_crypto_plugin_hmac_label;"},{"line_number":114,"context_line":"    \u0027p11_crypto_plugin/token_serial_number\u0027:   value \u003d\u003e $p11_crypto_plugin_token_serial_number;"},{"line_number":115,"context_line":"    \u0027p11_crypto_plugin/token_label\u0027:           value \u003d\u003e $p11_crypto_plugin_token_label;"},{"line_number":116,"context_line":"    \u0027p11_crypto_plugin/slot_id\u0027:               value \u003d\u003e $p11_crypto_plugin_slot_id;"},{"line_number":117,"context_line":"    \u0027p11_crypto_plugin/encryption_mechanism\u0027:  value \u003d\u003e $p11_crypto_plugin_encryption_mechanism;"},{"line_number":118,"context_line":"    \u0027p11_crypto_plugin/hmac_key_type\u0027:         value \u003d\u003e $p11_crypto_plugin_hmac_key_type;"},{"line_number":119,"context_line":"    \u0027p11_crypto_plugin/hmac_keygen_mechanism\u0027: value \u003d\u003e $p11_crypto_plugin_hmac_keygen_mechanism;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f65232a_2b5fed0e","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":83},"in_reply_to":"3f65232a_a5a20c4a","updated":"2020-10-27 00:11:55.000000000","message":"Ah yes. Thank you for clarification.","commit_id":"811eca8afd00005c2204a57363d2dbe85688be2b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ebfee8ab80c1630aaddafdae51216657f1de23bc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*p11_crypto_plugin_library_path*]"},{"line_number":8,"context_line":"#   (optional) Path to vendor PKCS11 library"},{"line_number":9,"context_line":"#   Defaults to $::os_service_default"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*p11_crypto_plugin_login*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3f65232a_8bd2815b","line":8,"range":{"start_line":8,"start_character":5,"end_line":8,"end_character":13},"updated":"2020-10-27 00:20:41.000000000","message":"I think we need to fix these wrong descriptions. Let me submit a patch to fix them and make this depending on that patch, so that we can easily backport the comment fix...","commit_id":"4ba2e78b6e22141c179f8428546d9dacf5ad1bff"}],"releasenotes/notes/add-support-for-token-label-and-serial-5b6ec6acc7f9d791.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"23bd3fc33e842ab1079180baf4b2f8141e82f7ca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for two new options for Barbican\u0027s PKCS#11 backend.  The"},{"line_number":5,"context_line":"    new options are `[p11_crypto]token_serial_number` and"},{"line_number":6,"context_line":"    `[p11_crypto]token_label`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f65232a_8b844160","line":6,"range":{"start_line":5,"start_character":20,"end_line":6,"end_character":30},"updated":"2020-10-27 00:13:17.000000000","message":"Might be better to use bold characters instead of Italic.","commit_id":"737a76949e4358a0567e98ac1e2f7d10bf18c638"}]}