)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fc969096151416f586bf917f39e275a558ed93a0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] ~\u003e Anchor[\u0027barbican::service::end\u0027]"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":"  if $configure_endpoint {"},{"line_number":88,"context_line":"    Keystone_endpoint[\"${region}/${service_name}::${service_type}\"] ~\u003e Anchor[\u0027barbican::service::end\u0027]"},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  keystone::resource::service_identity { \u0027barbican\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"946c533c_36ea9a70","line":88,"updated":"2021-09-21 19:57:34.000000000","message":"you can just use the spaceship operator instead of doing an if clase.  Keystone_endpoint\u003c| name \u003d\u003d .. |\u003e ~\u003e Anchor[\u0027barbican::service::end\u0027]","commit_id":"a0314953e0598321d284dbdef03cb0a64a3eb201"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"62f40dc601cbec7fd7d28b05d48a8d9943d300f3","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] ~\u003e Anchor[\u0027barbican::service::end\u0027]"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":"  if $configure_endpoint {"},{"line_number":88,"context_line":"    Keystone_endpoint[\"${region}/${service_name}::${service_type}\"] ~\u003e Anchor[\u0027barbican::service::end\u0027]"},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  keystone::resource::service_identity { \u0027barbican\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"0a4f23ab_e7d3eefe","line":88,"in_reply_to":"946c533c_36ea9a70","updated":"2021-09-22 09:58:13.000000000","message":"That\u0027s true and looks a better idea but I prefer keeping the current implementation, because the same logic using if {} is already implemented in several modules.\n\nIn the future we can replace these dependency definitions by the spaceship operator but IMO that should be done in a consistent manner in all modules.","commit_id":"a0314953e0598321d284dbdef03cb0a64a3eb201"}]}