)]}'
{"manifests/wsgi/apache.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3c20f480de69387d590cbaeee831d0474081c4ab","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  include barbican::deps"},{"line_number":139,"context_line":"  include barbican::params"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Anchor[\u0027barbican::install::end\u0027] -\u003e Class[\u0027apache\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  openstacklib::wsgi::apache { \u0027barbican_wsgi_main\u0027:"},{"line_number":144,"context_line":"    bind_host                   \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"202f96f2_2dd72edf","line":141,"updated":"2022-01-11 16:36:41.000000000","message":"That\u0027s what is already defined?  Don\u0027t you need to also add a relationship to the barbican::config anchors to ensure it happens before service::begin?","commit_id":"caa893234e3d93e605057bd75f2c921435904b92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d406ecbfbbee26d11b801fcbfb4f5b82bffff3c2","unresolved":true,"context_lines":[{"line_number":138,"context_line":"  include barbican::deps"},{"line_number":139,"context_line":"  include barbican::params"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Anchor[\u0027barbican::install::end\u0027] -\u003e Class[\u0027apache\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  openstacklib::wsgi::apache { \u0027barbican_wsgi_main\u0027:"},{"line_number":144,"context_line":"    bind_host                   \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"4dacee0f_169f60b4","line":141,"in_reply_to":"202f96f2_2dd72edf","updated":"2022-01-11 23:11:11.000000000","message":"\u003e That\u0027s what is already defined?\nNo this is not yet defined. I intended to implement the same by the previous change but the problem is that the openstacklib:wsgi::apache resource \"include\" the apche class and the ordering enforcement doesn\u0027t work if the apache class is already defined in a manifest.\n(I noticed this problem after I noticed ubuntu integraton job is broken, which is caused by https://github.com/openstack/puppet-openstack-integration/blob/master/manifests/apache.pp#L8-L15 )\n\n\u003e Don\u0027t you need to also add a relationship to the barbican::config anchors to ensure it happens before service::begin?\nWe already add the appropriate tag to the apache service resource so that httpd is started within the service block, which should be enough. We might be able to do this but in my past experience the string enforcement of apache stuff is likely to result in circular dependency and I\u0027d prefer keeping the current implementation, which we already have in puppet-aodh.","commit_id":"caa893234e3d93e605057bd75f2c921435904b92"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d8f294338d988a55b1667f1859779bf0bf88fd2f","unresolved":true,"context_lines":[{"line_number":138,"context_line":"  include barbican::deps"},{"line_number":139,"context_line":"  include barbican::params"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Anchor[\u0027barbican::install::end\u0027] -\u003e Class[\u0027apache\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  openstacklib::wsgi::apache { \u0027barbican_wsgi_main\u0027:"},{"line_number":144,"context_line":"    bind_host                   \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"b3314c0a_e3406b75","line":141,"in_reply_to":"3b6521df_9b0b3084","updated":"2022-01-11 23:48:30.000000000","message":"Actually do we ned something like https://opendev.org/openstack/puppet-keystone/src/branch/master/manifests/wsgi/apache.pp#L228-L233 for all the classes?","commit_id":"caa893234e3d93e605057bd75f2c921435904b92"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d681971b8c6019acf95a97a190ba5ef50a8cf7dc","unresolved":true,"context_lines":[{"line_number":138,"context_line":"  include barbican::deps"},{"line_number":139,"context_line":"  include barbican::params"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Anchor[\u0027barbican::install::end\u0027] -\u003e Class[\u0027apache\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  openstacklib::wsgi::apache { \u0027barbican_wsgi_main\u0027:"},{"line_number":144,"context_line":"    bind_host                   \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3b6521df_9b0b3084","line":141,"in_reply_to":"4dacee0f_169f60b4","updated":"2022-01-11 23:33:08.000000000","message":"I guess i\u0027m missing which part is broken here because you\u0027re moving the relationship from the openstacklib define to ensuring apache is run after install::end. Where in the apache class is the shipped conf not being cleared? It should be when the openstacklib::wsgi::apache define is run which based on the require \u003d\u003e should be after the barbican::install::end.  Would it be better to just add Anchor[\u0027barbican::install::end\u0027] -\u003e Apache::Vhost\u003c||\u003e -\u003e Anchor[\u0027barbican::config::end\u0027]  ?","commit_id":"caa893234e3d93e605057bd75f2c921435904b92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ab1304f7aa6dc498aadec81e33133ddf9fc53a31","unresolved":true,"context_lines":[{"line_number":138,"context_line":"  include barbican::deps"},{"line_number":139,"context_line":"  include barbican::params"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Anchor[\u0027barbican::install::end\u0027] -\u003e Class[\u0027apache\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  openstacklib::wsgi::apache { \u0027barbican_wsgi_main\u0027:"},{"line_number":144,"context_line":"    bind_host                   \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"f9d6f309_3199c411","line":141,"in_reply_to":"b3314c0a_e3406b75","updated":"2022-01-12 00:05:32.000000000","message":"We need to run one of this[1] file resource which removes files under vhost config after package installation.\n[1] https://github.com/puppetlabs/puppetlabs-apache/blob/143ffaf1673cc3f450f269aa5608a10e7a616cb4/manifests/init.pp#L698-L704\n\nFor example, in scenario003 job in ubuntu, the default vhost config file(placement-api.conf) is not purged and apache can\u0027t start because of this.\n https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_702/824121/1/check/puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal/702afcc/logs/apache_config/index.html\n\nI confirmed the issue is resolved by implementing the same fix in puppet-placement.\n https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_16c/824102/3/check/puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal/16c4420/logs/apache_config/index.html\n\nIn some modules like puppet-barbican we actually had the implementation to replace the default file. However that file might be deleted by the apache class unless we do proper order enforcement, and that\u0027s why I removed that file resource by https://review.opendev.org/c/openstack/puppet-barbican/+/823382 .","commit_id":"caa893234e3d93e605057bd75f2c921435904b92"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"64af084ad03096113188b9af348c2fd32493f2ea","unresolved":true,"context_lines":[{"line_number":138,"context_line":"  include barbican::deps"},{"line_number":139,"context_line":"  include barbican::params"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Anchor[\u0027barbican::install::end\u0027] -\u003e Class[\u0027apache\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  openstacklib::wsgi::apache { \u0027barbican_wsgi_main\u0027:"},{"line_number":144,"context_line":"    bind_host                   \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"07e62d0c_ab60bef0","line":141,"in_reply_to":"f9d6f309_3199c411","updated":"2022-01-12 15:12:07.000000000","message":"Alright I guess we can go with this. It doesn\u0027t feel right but I can\u0027t think of a better way to catch that.","commit_id":"caa893234e3d93e605057bd75f2c921435904b92"}]}