)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2ab5403dbb6fb01e9385cf402c297b606c13c16b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     iberezovskiy \u003ciberezovskiy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 16:24:22 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove POSIX users, groups and file modes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These entries should be removed from the manifests as these settings"},{"line_number":10,"context_line":"should be delivered by packaging tools.  In addition, remove the need to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_8402a108","line":7,"updated":"2015-12-08 19:00:50.000000000","message":"Looks like this change only has to do with users and groups, not file modes anymore?","commit_id":"3c205f6b79eaad140773b6658ff7263de3c8364c"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"42465fa6b077fc718eb3f1a277e46f5018383e41","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     iberezovskiy \u003ciberezovskiy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 16:24:22 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove POSIX users, groups and file modes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These entries should be removed from the manifests as these settings"},{"line_number":10,"context_line":"should be delivered by packaging tools.  In addition, remove the need to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_59282986","line":7,"in_reply_to":"7a740942_8402a108","updated":"2015-12-14 11:22:49.000000000","message":"I\u0027ve just used commit message as it was before. I\u0027ll update it","commit_id":"3c205f6b79eaad140773b6658ff7263de3c8364c"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2ab5403dbb6fb01e9385cf402c297b606c13c16b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"These entries should be removed from the manifests as these settings"},{"line_number":10,"context_line":"should be delivered by packaging tools.  In addition, remove the need to"},{"line_number":11,"context_line":"track /etc/ceilometer/ceilometer.conf as nothing depends on it any"},{"line_number":12,"context_line":"longer."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Ivan Berezovskiy \u003ciberezovskiy@mirantis.com\u003e"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_e1527734","line":12,"updated":"2015-12-08 19:00:50.000000000","message":"This last part is unclear. I don\u0027t see any changes in this patch related to ceilometer.conf. Furthermore, we do still need to track ceilometer.conf because of all the ceilometer_config\u0027s.","commit_id":"3c205f6b79eaad140773b6658ff7263de3c8364c"}],"manifests/agent/compute.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0253319152d4473cf25534f3679e0dc1a2195c01","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    User[\u0027ceilometer\u0027] {"},{"line_number":42,"context_line":"      groups \u003d\u003e [\u0027nova\u0027]"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  if $manage_service {"},{"line_number":47,"context_line":"    if $enabled {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a7e1126_ab129307","side":"PARENT","line":44,"updated":"2015-12-17 18:35:15.000000000","message":"I think UCA \u0026 RDO packaging does not add \u0027nova\u0027 and \u0027libvirt\u0027 secondary groups to \u0027ceilometer\u0027 POSIX user.\nI agree we should not manage POSIX resources, but this case will break deployments running RDO \u0026 UCA for sure, except if people manage themselves user/group management.\n\nSee https://github.com/openstack-packages/ceilometer/blob/rpm-master/openstack-ceilometer.spec#L427\nand https://github.com/openstack-packages/nova/blob/rpm-master/openstack-nova.spec#L621","commit_id":"3abf7d16d2e11b463d9cc835fe125bb66b98a836"}],"manifests/db/sync.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fd264ee03ca85a555c5f6a9db665b170df4734d4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  exec { \u0027ceilometer-dbsync\u0027:"},{"line_number":24,"context_line":"    command     \u003d\u003e \"${::ceilometer::params::dbsync_command} ${extra_params}\","},{"line_number":25,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":26,"context_line":"    user        \u003d\u003e \u0027ceilometer\u0027,"},{"line_number":27,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":28,"context_line":"    logoutput   \u003d\u003e on_failure,"},{"line_number":29,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_aaced42b","line":26,"updated":"2015-12-07 16:01:21.000000000","message":"Should this be configurable?","commit_id":"3c205f6b79eaad140773b6658ff7263de3c8364c"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"06e628957503a6ac7c57d8c2db4181b9c91e5626","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  exec { \u0027ceilometer-dbsync\u0027:"},{"line_number":24,"context_line":"    command     \u003d\u003e \"${::ceilometer::params::dbsync_command} ${extra_params}\","},{"line_number":25,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":26,"context_line":"    user        \u003d\u003e \u0027ceilometer\u0027,"},{"line_number":27,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":28,"context_line":"    logoutput   \u003d\u003e on_failure,"},{"line_number":29,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_abdf8c67","line":26,"in_reply_to":"7a740942_aaced42b","updated":"2015-12-08 10:16:53.000000000","message":"I\u0027m not sure. Some of the modules (e.g. sahara, heat https://github.com/openstack/puppet-heat/blob/master/manifests/db/sync.pp#L22) don\u0027t allow to configure user. Another modules (e.g. nova, neutron https://github.com/openstack/puppet-neutron/blob/master/manifests/db/sync.pp) don\u0027t use \u0027user\u0027 variable in db_sync command. I suggest to leave it as is here","commit_id":"3c205f6b79eaad140773b6658ff7263de3c8364c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b456ee26baae013b97149043cd0bfc8aa255f417","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  exec { \u0027ceilometer-dbsync\u0027:"},{"line_number":24,"context_line":"    command     \u003d\u003e \"${::ceilometer::params::dbsync_command} ${extra_params}\","},{"line_number":25,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":26,"context_line":"    user        \u003d\u003e \u0027ceilometer\u0027,"},{"line_number":27,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":28,"context_line":"    logoutput   \u003d\u003e on_failure,"},{"line_number":29,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_d3c08352","line":26,"in_reply_to":"7a740942_abdf8c67","updated":"2015-12-08 14:32:06.000000000","message":"Just wondering since this is patch is to remove the POSIX users/files/modes. Seems odd to then hardcode something.","commit_id":"3c205f6b79eaad140773b6658ff7263de3c8364c"}],"manifests/init.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"90a0f945a2f0adfcf4f5d0c12324c4545f196d4f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be used together\u0027)"},{"line_number":150,"context_line":"  }"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  File {"},{"line_number":153,"context_line":"    require \u003d\u003e Package[\u0027ceilometer-common\u0027],"},{"line_number":154,"context_line":"  }"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_6e38d6d3","line":152,"updated":"2015-08-12 07:37:20.000000000","message":"This should also be removed. We don\u0027t manage the creation of files anymore in this module, just its management.","commit_id":"f3fcc7d7888687f923fcb3b0749404422e2238e5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d1030d5f28c7589cf1a87b53a1b122194a660aa9","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  File {"},{"line_number":171,"context_line":"    require \u003d\u003e Package[\u0027ceilometer-common\u0027],"},{"line_number":172,"context_line":"  }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  package { \u0027ceilometer-common\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba15a1d1_19986777","line":171,"updated":"2015-09-24 10:47:42.000000000","message":"Do we really need this? I think, it can be deleted too.","commit_id":"eeb47f849431db868529697321bf9bf1483b62b9"}],"manifests/params.pp":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"0bca46a4e1cae59ea9df7ef2edd1e2f1f0032c97","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        }"},{"line_number":66,"context_line":"        default: {"},{"line_number":67,"context_line":"          $libvirt_group \u003d \u0027libvirt\u0027"},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"      }"},{"line_number":70,"context_line":"      $ceilometer_wsgi_script_path    \u003d \u0027/usr/lib/cgi-bin/ceilometer\u0027"},{"line_number":71,"context_line":"      $ceilometer_wsgi_script_source  \u003d \u0027/usr/share/ceilometer/app.wsgi\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_3f175fef","side":"PARENT","line":68,"updated":"2015-07-28 12:39:17.000000000","message":"Shouldn\u0027t we remove above case too?","commit_id":"cf846dc5324f023a19eddc7ea292895b9a747a8b"}]}