)]}'
{"manifests/init.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"9ce938a6fee934845ac3409a76c2e14ddb13a819","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    \u0027DEFAULT/notification_topics\u0027    : value \u003d\u003e join($notification_topics, \u0027,\u0027);"},{"line_number":301,"context_line":"  }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  if $event_time_to_live !\u003d \u0027-1\u0027 {"},{"line_number":304,"context_line":"    ceilometer_config {"},{"line_number":305,"context_line":"      \u0027database/event_time_to_live\u0027 : value \u003d\u003e $event_time_to_live;"},{"line_number":306,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_7317e451","line":303,"updated":"2015-08-04 06:26:08.000000000","message":"Why having this if, since the default is -1 (here in the class and in the upstream component). So even if the parameter is left with its puppet default (-1) it will write event_time_to_live \u003d -1 which is fine as it is the upstream default.\n\nI would suggest to move it in the ceilometer_config{} block above\n\nhttp://docs.openstack.org/kilo/config-reference/content/section_ceilometer.conf.html","commit_id":"99cfb992bce9c9e85f77de9a44f4e6e510f9ae99"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a41710315a776e925339273b5709ce2a5d404ea8","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    \u0027DEFAULT/notification_topics\u0027    : value \u003d\u003e join($notification_topics, \u0027,\u0027);"},{"line_number":301,"context_line":"  }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  if $event_time_to_live !\u003d \u0027-1\u0027 {"},{"line_number":304,"context_line":"    ceilometer_config {"},{"line_number":305,"context_line":"      \u0027database/event_time_to_live\u0027 : value \u003d\u003e $event_time_to_live;"},{"line_number":306,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_5ebc286c","line":303,"in_reply_to":"1a4dcd0f_7317e451","updated":"2015-08-04 08:48:21.000000000","message":"Thanks for comment. will be fixed","commit_id":"99cfb992bce9c9e85f77de9a44f4e6e510f9ae99"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"9ce938a6fee934845ac3409a76c2e14ddb13a819","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    }"},{"line_number":307,"context_line":"  }"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"  if $metering_time_to_live !\u003d \u0027-1\u0027 {"},{"line_number":310,"context_line":"    ceilometer_config {"},{"line_number":311,"context_line":"      \u0027database/metering_time_to_live\u0027 : value \u003d\u003e $event_time_to_live;"},{"line_number":312,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_330abc27","line":309,"updated":"2015-08-04 06:26:08.000000000","message":"ditto","commit_id":"99cfb992bce9c9e85f77de9a44f4e6e510f9ae99"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"9fbe4a489215ae8873b62c6629fd47558ddc4801","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    \u0027DEFAULT/verbose\u0027                : value \u003d\u003e $verbose;"},{"line_number":300,"context_line":"    \u0027DEFAULT/notification_topics\u0027    : value \u003d\u003e join($notification_topics, \u0027,\u0027);"},{"line_number":301,"context_line":"    \u0027database/event_time_to_live\u0027    : value \u003d\u003e $event_time_to_live;"},{"line_number":302,"context_line":"    \u0027database/metering_time_to_live\u0027 : value \u003d\u003e $event_time_to_live;"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  # Log configuration"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a4dcd0f_30d29b01","line":302,"updated":"2015-08-04 12:48:27.000000000","message":"wrong copy/paste here, should be $metering_time_to_live. Thanks for updating the previous review.","commit_id":"a9aa169a27d33e161fd6892e85cdb2232500f67d"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1675bf2e5c08ea367735647e6b8aee645bd235ff","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    \u0027DEFAULT/verbose\u0027                : value \u003d\u003e $verbose;"},{"line_number":300,"context_line":"    \u0027DEFAULT/notification_topics\u0027    : value \u003d\u003e join($notification_topics, \u0027,\u0027);"},{"line_number":301,"context_line":"    \u0027database/event_time_to_live\u0027    : value \u003d\u003e $event_time_to_live;"},{"line_number":302,"context_line":"    \u0027database/metering_time_to_live\u0027 : value \u003d\u003e $event_time_to_live;"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  # Log configuration"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a4dcd0f_f3cd18b8","line":302,"in_reply_to":"1a4dcd0f_30d29b01","updated":"2015-08-04 13:47:34.000000000","message":"sorry for this mistake","commit_id":"a9aa169a27d33e161fd6892e85cdb2232500f67d"}]}