)]}'
{"manifests/api.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3bee0e010da69b821d7cc5a2df6b9cb03c0d3fa8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  $keystone_identity_uri      \u003d false,"},{"line_number":85,"context_line":"  $host                       \u003d \u00270.0.0.0\u0027,"},{"line_number":86,"context_line":"  $port                       \u003d \u00278777\u0027,"},{"line_number":87,"context_line":"  $service_name               \u003d $::ceilometer::params::api_service_name,"},{"line_number":88,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":89,"context_line":"  $keystone_host              \u003d \u0027127.0.0.1\u0027,"},{"line_number":90,"context_line":"  $keystone_port              \u003d \u002735357\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_4119d678","line":87,"updated":"2015-08-07 18:06:49.000000000","message":"I don\u0027t think this default will work. Need to have this class inherit ::ceilometer::params","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"51f14e5e67a0a340dabcccd977027fb4c22d8021","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  $keystone_identity_uri      \u003d false,"},{"line_number":85,"context_line":"  $host                       \u003d \u00270.0.0.0\u0027,"},{"line_number":86,"context_line":"  $port                       \u003d \u00278777\u0027,"},{"line_number":87,"context_line":"  $service_name               \u003d $::ceilometer::params::api_service_name,"},{"line_number":88,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":89,"context_line":"  $keystone_host              \u003d \u0027127.0.0.1\u0027,"},{"line_number":90,"context_line":"  $keystone_port              \u003d \u002735357\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_aacf4f28","line":87,"in_reply_to":"1a4dcd0f_4119d678","updated":"2015-08-07 19:28:55.000000000","message":"ack, will update in next patchset","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3bee0e010da69b821d7cc5a2df6b9cb03c0d3fa8","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  include ::ceilometer::params"},{"line_number":96,"context_line":"  include ::ceilometer::policy"},{"line_number":97,"context_line":"  include ::ceilometer::db"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  validate_string($keystone_password)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_c17166aa","line":97,"updated":"2015-08-07 18:06:49.000000000","message":"I don\u0027t think this should be necessary. The db class should be included before the api class in the composition layer.","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"51f14e5e67a0a340dabcccd977027fb4c22d8021","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  include ::ceilometer::params"},{"line_number":96,"context_line":"  include ::ceilometer::policy"},{"line_number":97,"context_line":"  include ::ceilometer::db"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  validate_string($keystone_password)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_eac5570a","line":97,"in_reply_to":"1a4dcd0f_c17166aa","updated":"2015-08-07 19:28:55.000000000","message":"it is, otherwise unit tests fail. maybe I missed something?","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"38f8b261c65640b29e830bc3d3fe6c739893bd76","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  include ::ceilometer::params"},{"line_number":96,"context_line":"  include ::ceilometer::policy"},{"line_number":97,"context_line":"  include ::ceilometer::db"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  validate_string($keystone_password)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_1078f28e","line":97,"in_reply_to":"1a4dcd0f_eac5570a","updated":"2015-08-07 20:01:52.000000000","message":"Add \"include ::ceilometer::db\" in the let :pre_condition section of this test","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3bee0e010da69b821d7cc5a2df6b9cb03c0d3fa8","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      tag    \u003d\u003e \u0027ceilometer-service\u0027,"},{"line_number":140,"context_line":"    }"},{"line_number":141,"context_line":"    Class[\u0027ceilometer::db\u0027] -\u003e Service[$service_name]"},{"line_number":142,"context_line":"  } elsif ($service_name !\u003d $::ceilometer::params::api_service_name) and ($service_name !\u003d \u0027httpd\u0027) {"},{"line_number":143,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-ceilometer-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":144,"context_line":"  }"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_21e60a45","line":142,"updated":"2015-08-07 18:06:49.000000000","message":"Should just be an else, we don\u0027t need the elsif because both these cases were covered above","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"51f14e5e67a0a340dabcccd977027fb4c22d8021","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      tag    \u003d\u003e \u0027ceilometer-service\u0027,"},{"line_number":140,"context_line":"    }"},{"line_number":141,"context_line":"    Class[\u0027ceilometer::db\u0027] -\u003e Service[$service_name]"},{"line_number":142,"context_line":"  } elsif ($service_name !\u003d $::ceilometer::params::api_service_name) and ($service_name !\u003d \u0027httpd\u0027) {"},{"line_number":143,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-ceilometer-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":144,"context_line":"  }"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_aae66fae","line":142,"in_reply_to":"1a4dcd0f_21e60a45","updated":"2015-08-07 19:28:55.000000000","message":"true. I guess it was late for me when I wrote this :(","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6c5d755c7dbf97920ba1dd523b997bb3a7cbade4","unresolved":false,"context_lines":[{"line_number":137,"context_line":"      tag    \u003d\u003e \u0027ceilometer-service\u0027,"},{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":"    Class[\u0027ceilometer::db\u0027] -\u003e Service[$service_name]"},{"line_number":140,"context_line":"  } elsif ($service_name !\u003d $::ceilometer::params::api_service_name) and ($service_name !\u003d \u0027httpd\u0027) {"},{"line_number":141,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-ceilometer-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a4dcd0f_efd0092e","line":140,"updated":"2015-08-13 17:23:24.000000000","message":"This unnecessary elsif is still here","commit_id":"5afab6515b88b952a05ff1a210188239631c6d2c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"838c30d30bb3ab891dfd957b02d6279bc9ef8c7e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"      tag    \u003d\u003e \u0027ceilometer-service\u0027,"},{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":"    Class[\u0027ceilometer::db\u0027] -\u003e Service[$service_name]"},{"line_number":140,"context_line":"  } elsif ($service_name !\u003d $::ceilometer::params::api_service_name) and ($service_name !\u003d \u0027httpd\u0027) {"},{"line_number":141,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-ceilometer-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a4dcd0f_8fab851e","line":140,"in_reply_to":"1a4dcd0f_efd0092e","updated":"2015-08-13 17:31:23.000000000","message":"Done","commit_id":"5afab6515b88b952a05ff1a210188239631c6d2c"}],"spec/acceptance/ceilometer_wsgi_apache_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3bee0e010da69b821d7cc5a2df6b9cb03c0d3fa8","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        enabled               \u003d\u003e true,"},{"line_number":108,"context_line":"        keystone_password     \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":109,"context_line":"        keystone_identity_uri \u003d\u003e \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":110,"context_line":"        service_name          \u003d\u003e \u0027httpd\u0027,"},{"line_number":111,"context_line":"      }"},{"line_number":112,"context_line":"      include ::apache"},{"line_number":113,"context_line":"      class { \u0027::ceilometer::wsgi::apache\u0027:"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1a4dcd0f_e10342bd","line":110,"updated":"2015-08-07 18:06:49.000000000","message":"Like with keystone, can we have two tests - one to test eventlet, and one to test the upgrade to wsgi? The test files would need to be named alphabetically to make sure they are run in the right order","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"51f14e5e67a0a340dabcccd977027fb4c22d8021","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        enabled               \u003d\u003e true,"},{"line_number":108,"context_line":"        keystone_password     \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":109,"context_line":"        keystone_identity_uri \u003d\u003e \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":110,"context_line":"        service_name          \u003d\u003e \u0027httpd\u0027,"},{"line_number":111,"context_line":"      }"},{"line_number":112,"context_line":"      include ::apache"},{"line_number":113,"context_line":"      class { \u0027::ceilometer::wsgi::apache\u0027:"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1a4dcd0f_caa2db4b","line":110,"in_reply_to":"1a4dcd0f_e10342bd","updated":"2015-08-07 19:28:55.000000000","message":"it\u0027s already done, look, I did not drop the test in this patch.","commit_id":"8d2a9baf6070bf66f7040abcee3b60ad48f6254b"}]}