)]}'
{"manifests/api.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"69c6b413101c6ceb7cb10b16156f6c432129df4d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $keystone_port              \u003d \u002735357\u0027,"},{"line_number":91,"context_line":"  $keystone_auth_admin_prefix \u003d false,"},{"line_number":92,"context_line":"  $keystone_protocol          \u003d \u0027http\u0027,"},{"line_number":93,"context_line":") inherits ceilometer::params {"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  include ::ceilometer::params"},{"line_number":96,"context_line":"  include ::ceilometer::policy"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_c9af3d93","line":93,"updated":"2015-08-17 12:22:25.000000000","message":"You already have the include below. The inherits shouldn\u0027t be necessary","commit_id":"05926aaaba5f733f7be1f3e57b59db3ee1385db3"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"69c6b413101c6ceb7cb10b16156f6c432129df4d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"      tag        \u003d\u003e \u0027ceilometer-service\u0027,"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":"  } elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":133,"context_line":"    include ::apache::params"},{"line_number":134,"context_line":"    service { \u0027ceilometer-api\u0027:"},{"line_number":135,"context_line":"      ensure \u003d\u003e \u0027stopped\u0027,"},{"line_number":136,"context_line":"      name   \u003d\u003e $::ceilometer::params::api_service_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_292039f7","line":133,"updated":"2015-08-17 12:22:25.000000000","message":"Why is this class included here ? I see no parameter from that class included here. It should be included closer to the actual vhost resource. (ceilometer::wsgi::apache, or the user own defined class)","commit_id":"05926aaaba5f733f7be1f3e57b59db3ee1385db3"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"69c6b413101c6ceb7cb10b16156f6c432129df4d","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"    Class[\u0027ceilometer::db\u0027] -\u003e Service[$service_name]"},{"line_number":141,"context_line":"  } else {"},{"line_number":142,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-ceilometer-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  ceilometer_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_29e599a7","line":142,"updated":"2015-08-17 12:22:25.000000000","message":"Question: Why is keystone mentioned here ?","commit_id":"05926aaaba5f733f7be1f3e57b59db3ee1385db3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5065a38b9f190880cb0a2aa06c391df84921a669","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"    Class[\u0027ceilometer::db\u0027] -\u003e Service[$service_name]"},{"line_number":141,"context_line":"  } else {"},{"line_number":142,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-ceilometer-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  ceilometer_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_a45b0b54","line":142,"in_reply_to":"fa1b9901_29e599a7","updated":"2015-08-17 13:49:53.000000000","message":"https://review.openstack.org/213207","commit_id":"05926aaaba5f733f7be1f3e57b59db3ee1385db3"}]}