)]}'
{"manifests/init.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"2fec7c5d446516de99ee99de42440b82a20a638a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#  [*notification_workers*]"},{"line_number":103,"context_line":"#    Number of workers for notification service. A single"},{"line_number":104,"context_line":"#    notification agent is enabled by default. (integer value)"},{"line_number":105,"context_line":"#    Defaults to notification_workers\u003d1"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*qpid_hostname*]"},{"line_number":108,"context_line":"# [*qpid_port*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_52037fb8","line":105,"updated":"2015-09-22 11:29:07.000000000","message":"And what about \u0027api_workers\u0027? I think it\u0027s related to this patch","commit_id":"ec9c03fcd1e8aadd467fa740e937faf1ae914140"},{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"d72ff000bc682af06e04681f52b4232084f064f0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#  [*notification_workers*]"},{"line_number":103,"context_line":"#    Number of workers for notification service. A single"},{"line_number":104,"context_line":"#    notification agent is enabled by default. (integer value)"},{"line_number":105,"context_line":"#    Defaults to notification_workers\u003d1"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*qpid_hostname*]"},{"line_number":108,"context_line":"# [*qpid_port*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_88256ac3","line":105,"in_reply_to":"ba15a1d1_52037fb8","updated":"2015-09-22 12:19:27.000000000","message":"So there was an \u0027api_workers\u0027 parameter which has been deprecated in favor of \u0027workers\u0027 but from what I can see on my ceilometer installation this new one does not have any effect, regardless what you set you always have one ceilometer-api process.","commit_id":"ec9c03fcd1e8aadd467fa740e937faf1ae914140"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a93a8015c34ba00d7c455d6d64bf1b2dca83a334","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $use_syslog                         \u003d false,"},{"line_number":134,"context_line":"  $use_stderr                         \u003d true,"},{"line_number":135,"context_line":"  $log_facility                       \u003d \u0027LOG_USER\u0027,"},{"line_number":136,"context_line":"  $collector_workers                  \u003d 1,"},{"line_number":137,"context_line":"  $notification_workers               \u003d 1,"},{"line_number":138,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":139,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_4ff19ccc","line":136,"updated":"2015-09-22 11:09:41.000000000","message":"According to the docs (http://docs.openstack.org/kilo/config-reference/content/ch_configuring-openstack-telemetry.html) collector_workers is parameter for Collector configuration. May be it should be moved to collector.pp class?","commit_id":"ec9c03fcd1e8aadd467fa740e937faf1ae914140"},{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"d72ff000bc682af06e04681f52b4232084f064f0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $use_syslog                         \u003d false,"},{"line_number":134,"context_line":"  $use_stderr                         \u003d true,"},{"line_number":135,"context_line":"  $log_facility                       \u003d \u0027LOG_USER\u0027,"},{"line_number":136,"context_line":"  $collector_workers                  \u003d 1,"},{"line_number":137,"context_line":"  $notification_workers               \u003d 1,"},{"line_number":138,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":139,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_e37e8769","line":136,"in_reply_to":"ba15a1d1_4ff19ccc","updated":"2015-09-22 12:19:27.000000000","message":"I was looking on this class too. Both of them are in the \"[DEFAULT]\" section of /etc/ceilometer/ceilometer.conf, not in \u0027[collector]\u0027 section. This is why I left it in main class.","commit_id":"ec9c03fcd1e8aadd467fa740e937faf1ae914140"},{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"492ef8b541bff53d26c8523ac35a6eb07f8c1bb1","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $use_syslog                         \u003d false,"},{"line_number":134,"context_line":"  $use_stderr                         \u003d true,"},{"line_number":135,"context_line":"  $log_facility                       \u003d \u0027LOG_USER\u0027,"},{"line_number":136,"context_line":"  $collector_workers                  \u003d 1,"},{"line_number":137,"context_line":"  $notification_workers               \u003d 1,"},{"line_number":138,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":139,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_9eab601e","line":136,"in_reply_to":"ba15a1d1_632a7792","updated":"2015-09-22 12:47:38.000000000","message":"I had a mixed feelings too :) \nAnd I was afraid that by putting this may cause more confusion. IMHO we should move it to \u0027[collector]\u0027 section when ceilometer will do this.","commit_id":"ec9c03fcd1e8aadd467fa740e937faf1ae914140"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ff335467a790de9ccd84f5f4b14f67e7e3d08c59","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $use_syslog                         \u003d false,"},{"line_number":134,"context_line":"  $use_stderr                         \u003d true,"},{"line_number":135,"context_line":"  $log_facility                       \u003d \u0027LOG_USER\u0027,"},{"line_number":136,"context_line":"  $collector_workers                  \u003d 1,"},{"line_number":137,"context_line":"  $notification_workers               \u003d 1,"},{"line_number":138,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":139,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_632a7792","line":136,"in_reply_to":"ba15a1d1_e37e8769","updated":"2015-09-22 12:32:56.000000000","message":"Yes, i agree. However, this parameter affects only collector service. But i\u0027m ok with current solution.","commit_id":"ec9c03fcd1e8aadd467fa740e937faf1ae914140"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3f785d24dc4c2def6d652912991e9b82371b9843","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  $use_stderr                         \u003d true,"},{"line_number":135,"context_line":"  $log_facility                       \u003d \u0027LOG_USER\u0027,"},{"line_number":136,"context_line":"  $collector_workers                  \u003d 1,"},{"line_number":137,"context_line":"  $notification_workers               \u003d 1,"},{"line_number":138,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":139,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"},{"line_number":140,"context_line":"  $rabbit_port                        \u003d 5672,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a1a9d01_cff653d7","line":137,"updated":"2015-09-24 19:49:22.000000000","message":"I\u0027m not ok. Please follow how it\u0027s done in other modules.\n\n* add api_workers in api.pp\n* add collector_workers in collector.pp\n* add notificaton_workers in agent/notification.pp","commit_id":"ec9c03fcd1e8aadd467fa740e937faf1ae914140"}],"spec/classes/ceilometer_api_spec.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"9def829ced55b6f2aee37ebb8acc4bf81d891160","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      is_expected.to contain_ceilometer_config(\u0027keystone_authtoken/auth_uri\u0027).with_value( params[:keystone_protocol] + \"://\" + params[:keystone_host] + \":5000/\" )"},{"line_number":53,"context_line":"      is_expected.to contain_ceilometer_config(\u0027api/host\u0027).with_value( params[:host] )"},{"line_number":54,"context_line":"      is_expected.to contain_ceilometer_config(\u0027api/port\u0027).with_value( params[:port] )"},{"line_number":55,"context_line":"      is_expected.to contain_ceilometer_config(\u0027DEFAULT/api_workers\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    context \u0027when specifying keystone_auth_admin_prefix\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a740942_edf2fe05","line":55,"updated":"2015-12-10 13:11:22.000000000","message":"i think here (and in other spec files) also tests with non default values should be added.","commit_id":"dc62650fdae6fbaa755ea2d4b1545fcf72ab9654"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cfdb5e6b50c580db8d01a8df2c825cf5988a0f06","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      is_expected.to contain_ceilometer_config(\u0027api/host\u0027).with_value( params[:host] )"},{"line_number":54,"context_line":"      is_expected.to contain_ceilometer_config(\u0027api/port\u0027).with_value( params[:port] )"},{"line_number":55,"context_line":"      is_expected.to contain_ceilometer_config(\u0027DEFAULT/api_workers\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    context \u0027when specifying keystone_auth_admin_prefix\u0027 do"},{"line_number":59,"context_line":"      describe \u0027with a correct value\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a740942_4989b7c9","line":56,"updated":"2015-12-10 16:56:42.000000000","message":"This is out of the context of this patch. I agree on the fact, but it can be done in another patch.","commit_id":"dc62650fdae6fbaa755ea2d4b1545fcf72ab9654"}]}