)]}'
{"manifests/api.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"4a9fc8fdcac046b65e271867ae7ed9879a03de69","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    Class[\u0027ceilometer::db\u0027] -\u003e Service[$service_name]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    # we need to make sure ceilometer-api/eventlet is stopped before trying to start apache"},{"line_number":143,"context_line":"    Service[\u0027ceilometer-api\u0027] -\u003e Service[$service_name]"},{"line_number":144,"context_line":"  } else {"},{"line_number":145,"context_line":"    fail(\u0027Invalid service_name. Either ceilometer/openstack-ceilometer-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":146,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a1a9d01_9cc72064","line":143,"updated":"2015-10-02 07:13:59.000000000","message":"Since we are on the elsif $service_name \u003d\u003d \u0027httpd\u0027,  service \u0027ceilometer-api\u0027 should always be stopped.\n\nIn which scenario the fix above has been needed ?","commit_id":"b0ee27206d0e0de22986f0cfd266a19937d88b87"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"77dd6c951ffd709555127e7569bc0715d3e85d58","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    Class[\u0027ceilometer::db\u0027] -\u003e Service[$service_name]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    # we need to make sure ceilometer-api/eventlet is stopped before trying to start apache"},{"line_number":143,"context_line":"    Service[\u0027ceilometer-api\u0027] -\u003e Service[$service_name]"},{"line_number":144,"context_line":"  } else {"},{"line_number":145,"context_line":"    fail(\u0027Invalid service_name. Either ceilometer/openstack-ceilometer-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":146,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a1a9d01_1946b5bf","line":143,"in_reply_to":"9a1a9d01_9cc72064","updated":"2015-10-02 12:42:23.000000000","message":"Ubuntu packaging start services by default when installing a package.\n\nThe current situation is:\n* puppet installs the package\n* ubuntu starts the service\n* apache try to starts but fails because *::8777 is already binded (the ceilometer-api stop is later in the catalog).\n\nThis patch aims to fix the last point, where ceilometer-api is stopped BEFORE starting apache.","commit_id":"b0ee27206d0e0de22986f0cfd266a19937d88b87"}]}