)]}'
{"manifests/db.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"5d0e71b7ea5a5e9903205309c725d947bc799c20","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  }"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  if $mongodb_replica_set {"},{"line_number":114,"context_line":"    ceilometer_config { \u0027database/mongodb_replica_set\u0027: value \u003d\u003e $mongodb_replica_set; }"},{"line_number":115,"context_line":"  } else {"},{"line_number":116,"context_line":"    ceilometer_config { \u0027database/mongodb_replica_set\u0027: ensure \u003d\u003e absent; }"},{"line_number":117,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_2512c757","line":114,"updated":"2015-10-22 14:34:34.000000000","message":"We should set this parameter only if we are using MongoDB for ceilometer","commit_id":"5cf7d21c2700451c19bff2a6d05da4431feffe8f"}],"spec/classes/ceilometer_db_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8528f9ce3c1f0c657ef07f75c312da56336ca275","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/min_pool_size\u0027).with_value(\u00271\u0027) }"},{"line_number":14,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/max_retries\u0027).with_value(\u002710\u0027) }"},{"line_number":15,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/retry_interval\u0027).with_value(\u002710\u0027) }"},{"line_number":16,"context_line":"      it { is_expected.not_to contain_ceilometer_config(\u0027database/mongodb_replica_set\u0027) }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    end"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a26ad4f_072be683","line":16,"updated":"2015-10-27 09:05:21.000000000","message":"with ensure \u003d absent","commit_id":"0fd324ca2e4a564b1276c762a2013bd935b53234"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"a7248fbd790da7c058e33798df689c8cbd2c69d8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/min_pool_size\u0027).with_value(\u00271\u0027) }"},{"line_number":14,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/max_retries\u0027).with_value(\u002710\u0027) }"},{"line_number":15,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/retry_interval\u0027).with_value(\u002710\u0027) }"},{"line_number":16,"context_line":"      it { is_expected.not_to contain_ceilometer_config(\u0027database/mongodb_replica_set\u0027) }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    end"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a26ad4f_c68167fd","line":16,"in_reply_to":"1a26ad4f_072be683","updated":"2015-10-27 15:18:45.000000000","message":"i used \"is_expected.not_to\" because with default parameters there is no resource \"ceilometer_config(\u0027database/mongodb_replica_set\u0027)\" in catalogue and \"is_expected.to ... with_ensure(\u0027absent\u0027)\" will fail","commit_id":"0fd324ca2e4a564b1276c762a2013bd935b53234"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7da8e683cf97d628f12d483eabc211189e02e65d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/min_pool_size\u0027).with_value(\u00271\u0027) }"},{"line_number":14,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/max_retries\u0027).with_value(\u002710\u0027) }"},{"line_number":15,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/retry_interval\u0027).with_value(\u002710\u0027) }"},{"line_number":16,"context_line":"      it { is_expected.not_to contain_ceilometer_config(\u0027database/mongodb_replica_set\u0027) }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    end"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa80f949_189982c4","line":16,"in_reply_to":"1a26ad4f_c68167fd","updated":"2015-11-06 08:00:35.000000000","message":"Yes, by default is mysql, my bad, sorry.","commit_id":"0fd324ca2e4a564b1276c762a2013bd935b53234"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8528f9ce3c1f0c657ef07f75c312da56336ca275","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/min_pool_size\u0027).with_value(\u00272\u0027) }"},{"line_number":35,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/max_retries\u0027).with_value(\u002711\u0027) }"},{"line_number":36,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/retry_interval\u0027).with_value(\u002711\u0027) }"},{"line_number":37,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/mongodb_replica_set\u0027).with_ensure( \u0027absent\u0027 ) }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    end"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a26ad4f_471a3e70","line":37,"updated":"2015-10-27 09:05:21.000000000","message":"i guess, we don\u0027t need additional test in the case when we don\u0027t pass this parameter (default test is enough)","commit_id":"0fd324ca2e4a564b1276c762a2013bd935b53234"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"a7248fbd790da7c058e33798df689c8cbd2c69d8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/min_pool_size\u0027).with_value(\u00272\u0027) }"},{"line_number":35,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/max_retries\u0027).with_value(\u002711\u0027) }"},{"line_number":36,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/retry_interval\u0027).with_value(\u002711\u0027) }"},{"line_number":37,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/mongodb_replica_set\u0027).with_ensure( \u0027absent\u0027 ) }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    end"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a26ad4f_a6f54b84","line":37,"in_reply_to":"1a26ad4f_471a3e70","updated":"2015-10-27 15:18:45.000000000","message":"i think default test is not enough in this case because we have such sentence in db.pp:\n case $database_connection {\n.....\n/^mongodb:\\/\\//: {\n      $backend_package \u003d $::ceilometer::params::pymongo_package_name\n      if $mongodb_replica_set {\n        ceilometer_config { \u0027database/mongodb_replica_set\u0027:  value \u003d\u003e $mongodb_replica_set; }\n      } else {\n        ceilometer_config { \u0027database/mongodb_replica_set\u0027:  ensure \u003d\u003e absent; }\n      }\n    }\n......\n\nso this test is needed because there is possible a situation when $database_connection is set to mongo and mongodb_replica_set is left empty (as it is by default)","commit_id":"0fd324ca2e4a564b1276c762a2013bd935b53234"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7da8e683cf97d628f12d483eabc211189e02e65d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/min_pool_size\u0027).with_value(\u00272\u0027) }"},{"line_number":35,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/max_retries\u0027).with_value(\u002711\u0027) }"},{"line_number":36,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/retry_interval\u0027).with_value(\u002711\u0027) }"},{"line_number":37,"context_line":"      it { is_expected.to contain_ceilometer_config(\u0027database/mongodb_replica_set\u0027).with_ensure( \u0027absent\u0027 ) }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    end"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa80f949_3896c693","line":37,"in_reply_to":"1a26ad4f_a6f54b84","updated":"2015-11-06 08:00:35.000000000","message":"The  same as above.","commit_id":"0fd324ca2e4a564b1276c762a2013bd935b53234"}]}