)]}'
{"manifests/collector.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2efae9d6d814709efdb7ec16fac552834f59c4ae","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  ceilometer_config {"},{"line_number":59,"context_line":"    \u0027collector/udp_address\u0027:    value \u003d\u003e $udp_address;"},{"line_number":60,"context_line":"    \u0027collector/udp_port\u0027:       value \u003d\u003e $udp_port;"},{"line_number":61,"context_line":"    \u0027DEFAULT/meter_dispatcher\u0027: value \u003d\u003e join($meter_dispatcher, \u0027,\u0027);"},{"line_number":62,"context_line":"    \u0027DEFAULT/event_dispatcher\u0027: value \u003d\u003e join($event_dispatcher, \u0027,\u0027);"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a8ffd7b_663ac5e9","line":61,"updated":"2015-12-01 10:50:45.000000000","message":"may be better to use any2array? It will allow to avoid additional checks.","commit_id":"3e8469d4869bce8b65fc3c2c4381aad0aac29a31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5614d87409eee5eabbc45a6a7a5e943e3e55c3c7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  ceilometer_config {"},{"line_number":59,"context_line":"    \u0027collector/udp_address\u0027:    value \u003d\u003e $udp_address;"},{"line_number":60,"context_line":"    \u0027collector/udp_port\u0027:       value \u003d\u003e $udp_port;"},{"line_number":61,"context_line":"    \u0027DEFAULT/meter_dispatcher\u0027: value \u003d\u003e join($meter_dispatcher, \u0027,\u0027);"},{"line_number":62,"context_line":"    \u0027DEFAULT/event_dispatcher\u0027: value \u003d\u003e join($event_dispatcher, \u0027,\u0027);"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a8ffd7b_a172ca7a","line":61,"in_reply_to":"9a8ffd7b_663ac5e9","updated":"2015-12-01 14:13:58.000000000","message":"good idea, it will reduce the risk of a error if we set a regular string.","commit_id":"3e8469d4869bce8b65fc3c2c4381aad0aac29a31"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"55f3a240758699e1a8aaba93642b8fb7f5cb0ff8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"#  [*event_dispatcher*]"},{"line_number":31,"context_line":"#    (optional) dispatcher driver(s) to process event data."},{"line_number":32,"context_line":"#    Should be an array."},{"line_number":33,"context_line":"#    Defaults to \u0027database\u0027"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class ceilometer::collector ("}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a8ffd7b_7fe79240","line":32,"updated":"2015-12-01 15:45:42.000000000","message":"nope, it shouldn\u0027t :) now we have any2array for this parameter. Ditto above. Also you can put just string below in parameters.","commit_id":"8686fba446f5dd868bf1e074e5273d4fba3d94c5"}],"spec/classes/ceilometer_collector_spec.rb":[{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"83b51dc9a14837239d9a98df7bc984cbe4f704be","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"      it \u0027configures ceilometer-collector server\u0027 do"},{"line_number":54,"context_line":"        is_expected.to contain_ceilometer_config(\u0027collector/udp_address\u0027).with_value( \u00270.0.0.0\u0027 )"},{"line_number":55,"context_line":"        is_expected.to contain_ceilometer_config(\u0027collector/udp_address\u0027).with_value( \u00270.0.0.0\u0027 )"},{"line_number":56,"context_line":"        is_expected.to contain_ceilometer_config(\u0027DEFAULT/meter_dispatcher\u0027).with_value( [\u0027database\u0027] )"},{"line_number":57,"context_line":"        is_expected.to contain_ceilometer_config(\u0027DEFAULT/event_dispatcher\u0027).with_value( [\u0027database\u0027] )"},{"line_number":58,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a8ffd7b_29747c9a","line":55,"updated":"2015-12-01 15:17:11.000000000","message":"twice test on udp_address, did you mean udp_port?","commit_id":"fc9f36a95f57c2d6c1df8009324d6fd93ac31b68"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"70a27971301ffd91abab91ae55f40c0a5ef5ae27","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"      it \u0027configures ceilometer-collector server\u0027 do"},{"line_number":54,"context_line":"        is_expected.to contain_ceilometer_config(\u0027collector/udp_address\u0027).with_value( \u00270.0.0.0\u0027 )"},{"line_number":55,"context_line":"        is_expected.to contain_ceilometer_config(\u0027collector/udp_address\u0027).with_value( \u00270.0.0.0\u0027 )"},{"line_number":56,"context_line":"        is_expected.to contain_ceilometer_config(\u0027DEFAULT/meter_dispatcher\u0027).with_value( [\u0027database\u0027] )"},{"line_number":57,"context_line":"        is_expected.to contain_ceilometer_config(\u0027DEFAULT/event_dispatcher\u0027).with_value( [\u0027database\u0027] )"},{"line_number":58,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a8ffd7b_c454b755","line":55,"in_reply_to":"9a8ffd7b_29747c9a","updated":"2015-12-01 15:37:38.000000000","message":"done, thanks!","commit_id":"fc9f36a95f57c2d6c1df8009324d6fd93ac31b68"}]}