)]}'
{"manifests/api.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"0a90883eaeefee5b778433d3b03dd51362b70a14","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    \u0027api/port\u0027                             : value \u003d\u003e $port;"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  if $keystone_auth_uri {"},{"line_number":139,"context_line":"    ceilometer_config {"},{"line_number":140,"context_line":"      \u0027keystone_authtoken/auth_uri\u0027: value \u003d\u003e $keystone_auth_uri;"},{"line_number":141,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a7b0d38_6d56a85d","line":138,"range":{"start_line":138,"start_character":6,"end_line":138,"end_character":23},"updated":"2015-12-29 10:29:20.000000000","message":"I think there\u0027s no need to check this variable anymore - because it has default non-empty value","commit_id":"916ace7b404c9987386561b62712e0c53c25a7a4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e92a41da3153051ad2400f4c672ae1305248ce04","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    \u0027api/port\u0027                             : value \u003d\u003e $port;"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  if $keystone_auth_uri {"},{"line_number":139,"context_line":"    ceilometer_config {"},{"line_number":140,"context_line":"      \u0027keystone_authtoken/auth_uri\u0027: value \u003d\u003e $keystone_auth_uri;"},{"line_number":141,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a7b0d38_45c94025","line":138,"range":{"start_line":138,"start_character":6,"end_line":138,"end_character":23},"in_reply_to":"1a7b0d38_6d56a85d","updated":"2015-12-29 13:25:23.000000000","message":"Agree.","commit_id":"916ace7b404c9987386561b62712e0c53c25a7a4"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"0a90883eaeefee5b778433d3b03dd51362b70a14","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    }"},{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  if $keystone_identity_uri {"},{"line_number":145,"context_line":"    ceilometer_config {"},{"line_number":146,"context_line":"      \u0027keystone_authtoken/identity_uri\u0027: value \u003d\u003e $keystone_identity_uri;"},{"line_number":147,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a7b0d38_edc85824","line":144,"range":{"start_line":144,"start_character":27,"end_line":144,"end_character":28},"updated":"2015-12-29 10:29:20.000000000","message":"The same","commit_id":"916ace7b404c9987386561b62712e0c53c25a7a4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82a5b7a4b2d19cfec8da8d2542679847b52f1c84","unresolved":false,"context_lines":[{"line_number":217,"context_line":"  if $keystone_auth_uri {"},{"line_number":218,"context_line":"    $keystone_auth_uri_real \u003d $keystone_auth_uri"},{"line_number":219,"context_line":"  } elsif $keystone_host and $keystone_protocol {"},{"line_number":220,"context_line":"    $keystone_auth_uri_real \u003d \"${keystone_protocol}://${keystone_host}:5000/\""},{"line_number":221,"context_line":"  }"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  ceilometer_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa69d971_5b49b9cf","side":"PARENT","line":220,"updated":"2015-12-30 08:40:29.000000000","message":"here, the endpoint was version-less... How do you explain this change?","commit_id":"782eeda90bbf54756130c2db9412321a0ac39d5c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82a5b7a4b2d19cfec8da8d2542679847b52f1c84","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*keystone_auth_uri*]"},{"line_number":30,"context_line":"#   (optional) Public Identity API endpoint."},{"line_number":31,"context_line":"#   Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*keystone_identity_uri*]"},{"line_number":34,"context_line":"#   (optional) Complete admin Identity API endpoint."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa69d971_bb3c7530","line":31,"updated":"2015-12-30 08:40:29.000000000","message":"do we need the endpoint version? It seems it was not set by default before (see my comment later)","commit_id":"7f4186ade9bbde87aad140660de10362a1734345"}],"spec/classes/ceilometer_api_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e92a41da3153051ad2400f4c672ae1305248ce04","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    it_configures \u0027ceilometer-api\u0027"},{"line_number":191,"context_line":"  end"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"  describe \u0027with custom auth_uri\u0027 do"},{"line_number":194,"context_line":"    let :facts do"},{"line_number":195,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027RedHat\u0027 })"},{"line_number":196,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a7b0d38_05e6d8af","side":"PARENT","line":193,"range":{"start_line":193,"start_character":24,"end_line":193,"end_character":32},"updated":"2015-12-29 13:25:23.000000000","message":"This test can be changed with testing only auth_uri and identity_uri, with non-default values.","commit_id":"782eeda90bbf54756130c2db9412321a0ac39d5c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"d69fdeac108461a76e5d720eded9527fd04052b1","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    it_configures \u0027ceilometer-api\u0027"},{"line_number":191,"context_line":"  end"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"  describe \u0027with custom auth_uri\u0027 do"},{"line_number":194,"context_line":"    let :facts do"},{"line_number":195,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027RedHat\u0027 })"},{"line_number":196,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a7b0d38_85564828","side":"PARENT","line":193,"range":{"start_line":193,"start_character":24,"end_line":193,"end_character":32},"in_reply_to":"1a7b0d38_05e6d8af","updated":"2015-12-29 13:28:29.000000000","message":"Do you mean \"with custom keystone identity_uri and auth_uri\"? It\u0027s already there","commit_id":"782eeda90bbf54756130c2db9412321a0ac39d5c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4887d80b22db6fa0f9f05469812db2985c1429eb","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    it_configures \u0027ceilometer-api\u0027"},{"line_number":191,"context_line":"  end"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"  describe \u0027with custom auth_uri\u0027 do"},{"line_number":194,"context_line":"    let :facts do"},{"line_number":195,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027RedHat\u0027 })"},{"line_number":196,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a7b0d38_faa242fb","side":"PARENT","line":193,"range":{"start_line":193,"start_character":24,"end_line":193,"end_character":32},"in_reply_to":"1a7b0d38_85564828","updated":"2015-12-29 15:21:24.000000000","message":"oh, yeah, sorry.","commit_id":"782eeda90bbf54756130c2db9412321a0ac39d5c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"0a90883eaeefee5b778433d3b03dd51362b70a14","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    it_configures \u0027ceilometer-api\u0027"},{"line_number":143,"context_line":"  end"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  context \u0027on redhat platforms\u0027 do"},{"line_number":146,"context_line":"    let :facts do"},{"line_number":147,"context_line":"      @default_facts.merge({ :osfamily               \u003d\u003e \u0027redhat\u0027,"},{"line_number":148,"context_line":"        :operatingsystem        \u003d\u003e \u0027redhat\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a7b0d38_6ddd48df","line":145,"range":{"start_line":145,"start_character":14,"end_line":145,"end_character":20},"updated":"2015-12-29 10:29:20.000000000","message":"It looks like unrelated change","commit_id":"916ace7b404c9987386561b62712e0c53c25a7a4"}]}
