)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b6f5b1694fa17c73d0248cdc031d267126561c28","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   (Optional) Public Identity API endpoint."},{"line_number":32,"context_line":"#   Defaults to \u0027http://127.0.0.1:5000/\u0027."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*keystone_identity_uri*]"},{"line_number":35,"context_line":"#   (Optional) Complete admin Identity API endpoint."},{"line_number":36,"context_line":"#   Defaults to \u0027http://127.0.0.1:35357/\u0027."},{"line_number":37,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba63e191_69025e71","side":"PARENT","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":25},"updated":"2016-01-20 09:16:28.000000000","message":"You should deprecate old parameters.","commit_id":"b787d19d9ef18e3eabdf9af5758f37b6350f273f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b6f5b1694fa17c73d0248cdc031d267126561c28","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  }"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  ceilometer_config {"},{"line_number":140,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027     : value \u003d\u003e $keystone_auth_uri;"},{"line_number":141,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027 : value \u003d\u003e $keystone_identity_uri;"},{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba63e191_e945eeb2","side":"PARENT","line":140,"range":{"start_line":140,"start_character":50,"end_line":140,"end_character":67},"updated":"2016-01-20 09:16:28.000000000","message":"also you should add check for using old parameters by using new var with _real suffix. Take a look on another modules (probably in stable/liberty release)","commit_id":"b787d19d9ef18e3eabdf9af5758f37b6350f273f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b6f5b1694fa17c73d0248cdc031d267126561c28","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  $keystone_tenant            \u003d \u0027services\u0027,"},{"line_number":69,"context_line":"  $keystone_password          \u003d false,"},{"line_number":70,"context_line":"  $auth_uri          \u003d \u0027http://127.0.0.1:5000/\u0027,"},{"line_number":71,"context_line":"  $identity_uri      \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":72,"context_line":"  $host                       \u003d \u00270.0.0.0\u0027,"},{"line_number":73,"context_line":"  $port                       \u003d \u00278777\u0027,"},{"line_number":74,"context_line":"  $service_name               \u003d $::ceilometer::params::api_service_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba63e191_c9f34a9d","line":71,"range":{"start_line":71,"start_character":15,"end_line":71,"end_character":21},"updated":"2016-01-20 09:16:28.000000000","message":"alignment","commit_id":"e07f7eb10453fd5f844d94b012b87ccc3e3bbfbe"}],"spec/classes/ceilometer_api_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c940854f5bc7fd35ea8ed66edb24f57773bcaacd","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    before do"},{"line_number":169,"context_line":"      params.merge!({"},{"line_number":170,"context_line":"        :identity_uri \u003d\u003e \u0027https://foo.bar:35357/\u0027,"},{"line_number":171,"context_line":"        :auth_uri \u003d\u003e \u0027https://foo.bar:5000/\u0027,"},{"line_number":172,"context_line":"      })"},{"line_number":173,"context_line":"    end"},{"line_number":174,"context_line":"    it \u0027configures identity_uri and auth_uri but deprecates old auth settings\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a68dd71_ebea800e","line":171,"range":{"start_line":171,"start_character":9,"end_line":171,"end_character":17},"updated":"2016-01-23 08:55:44.000000000","message":"can you please keep old tests, while we have old parameters? We usually keep tests for deprecated parameters","commit_id":"e87198b85683ef1c8f6598839f1d6c48d64168cc"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"d6a7f62c08b7d260448b46f2a1933f2a0d67b9f3","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    before do"},{"line_number":169,"context_line":"      params.merge!({"},{"line_number":170,"context_line":"        :identity_uri \u003d\u003e \u0027https://foo.bar:35357/\u0027,"},{"line_number":171,"context_line":"        :auth_uri \u003d\u003e \u0027https://foo.bar:5000/\u0027,"},{"line_number":172,"context_line":"      })"},{"line_number":173,"context_line":"    end"},{"line_number":174,"context_line":"    it \u0027configures identity_uri and auth_uri but deprecates old auth settings\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a68dd71_df2356a6","line":171,"range":{"start_line":171,"start_character":9,"end_line":171,"end_character":17},"in_reply_to":"9a68dd71_ebea800e","updated":"2016-01-26 11:20:30.000000000","message":"i am agree with Denis","commit_id":"e87198b85683ef1c8f6598839f1d6c48d64168cc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8bc09540a9fbd7783ed6673fdb4b3fdc47043dca","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    it_configures \u0027ceilometer-api\u0027"},{"line_number":162,"context_line":"  end"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  describe \"with custom keystone identity_uri and auth_uri\" do"},{"line_number":165,"context_line":"    let :facts do"},{"line_number":166,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027RedHat\u0027 })"},{"line_number":167,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a5de9d1_c302a96f","line":164,"range":{"start_line":164,"start_character":12,"end_line":164,"end_character":58},"updated":"2016-01-27 13:00:52.000000000","message":"you should rename this test then to smtg like: with deprecated keystone uri params","commit_id":"dc1a7b1b3299b37996866f3ff736658023d4449d"}]}