)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9cce9de25d1de929804f51e362579efa6f1b0eb7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"#"},{"line_number":141,"context_line":"#  [*manage_event_pipeline*]"},{"line_number":142,"context_line":"#    (Optional) Whether to manage event_pipeline.yaml"},{"line_number":143,"context_line":"#    Defaults to true"},{"line_number":144,"context_line":"#"},{"line_number":145,"context_line":"#  [*event_pipeline_publishers*]"},{"line_number":146,"context_line":"#    (Optional) A list of publishers to put in event_pipeline.yaml"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bae84128_3a8ba720","line":143,"updated":"2016-02-24 03:45:52.000000000","message":"default is false.","commit_id":"07d0bbe9a309dffc4896fe87da00398e37e60b41"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9cce9de25d1de929804f51e362579efa6f1b0eb7","unresolved":false,"context_lines":[{"line_number":146,"context_line":"#    (Optional) A list of publishers to put in event_pipeline.yaml"},{"line_number":147,"context_line":"#    Add \u0027notifier://?topic\u003dalarm.all\u0027 to the list if you are using Aodh"},{"line_number":148,"context_line":"#    for alarms."},{"line_number":149,"context_line":"#    Defaults to [\u0027notifier://\u0027],"},{"line_number":150,"context_line":"#"},{"line_number":151,"context_line":"# \u003d\u003d\u003d DEPRECATED PARAMETERS:"},{"line_number":152,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bae84128_1a8ea32d","line":149,"updated":"2016-02-24 03:45:52.000000000","message":"why not default to default array?","commit_id":"07d0bbe9a309dffc4896fe87da00398e37e60b41"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9cce9de25d1de929804f51e362579efa6f1b0eb7","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    file { \u0027event_pipeline\u0027:"},{"line_number":345,"context_line":"      path    \u003d\u003e $event_pipeline,"},{"line_number":346,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":347,"context_line":"      owner   \u003d\u003e \u0027ceilometer\u0027,"},{"line_number":348,"context_line":"      group   \u003d\u003e \u0027ceilometer\u0027,"},{"line_number":349,"context_line":"      content \u003d\u003e template(\u0027ceilometer/event_pipeline.yaml.erb\u0027),"},{"line_number":350,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bae84128_7a81affa","line":347,"updated":"2016-02-24 03:45:52.000000000","message":"We try to not hardcode POSIX users/groups.\nAlso, the file should be managed by packaging. Is it managed in RDO \u0026 UCA?\nIf not, you can manage it with Puppet but please add parameters to change users/group when needed. We need to support distros / use cases that use different user/group names.","commit_id":"07d0bbe9a309dffc4896fe87da00398e37e60b41"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c793ebbc01af8a82f8467d6cc74b00202cc3e245","unresolved":false,"context_lines":[{"line_number":196,"context_line":"  $kombu_ssl_version                  \u003d \u0027TLSv1\u0027,"},{"line_number":197,"context_line":"  $memcached_servers                  \u003d undef,"},{"line_number":198,"context_line":"  $manage_event_pipeline              \u003d false,"},{"line_number":199,"context_line":"  $event_pipeline_publishers          \u003d [\u0027notifier://\u0027],"},{"line_number":200,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":201,"context_line":"  $qpid_hostname                      \u003d undef,"},{"line_number":202,"context_line":"  $qpid_port                          \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bae84128_75b89575","line":199,"range":{"start_line":199,"start_character":40,"end_line":199,"end_character":55},"updated":"2016-02-24 09:29:49.000000000","message":"Well, for this case we can have problems if someone will pass wrong type here. I guess will be useful if you will add validate_array for this parameter, or convert this parameter to array in template.","commit_id":"87e592dab31b7b6753f576cab78ea6150de8fb7c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c793ebbc01af8a82f8467d6cc74b00202cc3e245","unresolved":false,"context_lines":[{"line_number":342,"context_line":"  if ($manage_event_pipeline)"},{"line_number":343,"context_line":"  {"},{"line_number":344,"context_line":"    file { \u0027event_pipeline\u0027:"},{"line_number":345,"context_line":"      path    \u003d\u003e $event_pipeline,"},{"line_number":346,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":347,"context_line":"      content \u003d\u003e template(\u0027ceilometer/event_pipeline.yaml.erb\u0027),"},{"line_number":348,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bae84128_3550cd31","line":345,"updated":"2016-02-24 09:29:49.000000000","message":"$::ceilometer::params::event_pipeline i guess","commit_id":"87e592dab31b7b6753f576cab78ea6150de8fb7c"}],"spec/classes/ceilometer_init_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c793ebbc01af8a82f8467d6cc74b00202cc3e245","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      before { params.merge!("},{"line_number":292,"context_line":"        :manage_event_pipeline \u003d\u003e false"},{"line_number":293,"context_line":"      ) }"},{"line_number":294,"context_line":"        it { is_expected.not_to contain_file(\u0027event_pipeline\u0027)"},{"line_number":295,"context_line":"    end"},{"line_number":296,"context_line":"  end"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"bae84128_30057b10","line":294,"updated":"2016-02-24 09:29:49.000000000","message":"missed }\n\nand use please should syntax, is_expected is deprecated now","commit_id":"87e592dab31b7b6753f576cab78ea6150de8fb7c"}]}