)]}'
{"manifests/agent/notification.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"3350d46414513473439a00070aab0d336a23fed8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#   (Optional) ensure state for package."},{"line_number":58,"context_line":"#   Defaults to \u0027present\u0027."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"#  [*manage_event_pipeline*]"},{"line_number":61,"context_line":"#    (Optional) Whether to manage event_pipeline.yaml"},{"line_number":62,"context_line":"#    Defaults to false"},{"line_number":63,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_029a8d14","line":60,"updated":"2016-08-08 15:56:34.000000000","message":"nit: remove 1 space before each line (60-68) to keep doc strings aligned","commit_id":"94d47a23d46584ec25e8d8654d57f218bfd90a12"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"ff27b266bb4a96865cd0ec8cd1270a5f6d166803","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#   (Optional) ensure state for package."},{"line_number":58,"context_line":"#   Defaults to \u0027present\u0027."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"#  [*manage_event_pipeline*]"},{"line_number":61,"context_line":"#    (Optional) Whether to manage event_pipeline.yaml"},{"line_number":62,"context_line":"#    Defaults to false"},{"line_number":63,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_9820aa4b","line":60,"in_reply_to":"9ad45d7e_029a8d14","updated":"2016-08-08 16:23:25.000000000","message":"Done","commit_id":"94d47a23d46584ec25e8d8654d57f218bfd90a12"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"85b33e6a7295210636a30ba569565103e26c8ac7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    file { \u0027event_pipeline\u0027:"},{"line_number":119,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":120,"context_line":"      path    \u003d\u003e $::ceilometer::params::event_pipeline,"},{"line_number":121,"context_line":"      content \u003d\u003e template(\u0027ceilometer/event_pipeline.yaml.erb\u0027),"},{"line_number":122,"context_line":"    }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9ad45d7e_c3c4f293","line":121,"updated":"2016-08-08 18:40:39.000000000","message":"The file is already managed by packaging and I\u0027m afraid it could contain some SElinux properties. I would suggest to add selinux_ignore_defaults \u003d\u003e true here.","commit_id":"4f8c9167966ef0e83642a4b85aa39db34634b107"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"58924bc9f8c2ed5a25005e15b709a607348c6392","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    file { \u0027event_pipeline\u0027:"},{"line_number":119,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":120,"context_line":"      path    \u003d\u003e $::ceilometer::params::event_pipeline,"},{"line_number":121,"context_line":"      content \u003d\u003e template(\u0027ceilometer/event_pipeline.yaml.erb\u0027),"},{"line_number":122,"context_line":"    }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9ad45d7e_9e2cfb4b","line":121,"in_reply_to":"9ad45d7e_c3c4f293","updated":"2016-08-09 05:58:05.000000000","message":"Done","commit_id":"4f8c9167966ef0e83642a4b85aa39db34634b107"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"85b33e6a7295210636a30ba569565103e26c8ac7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"},{"line_number":125,"context_line":"    File[\u0027event_pipeline\u0027] -\u003e Ceilometer_config\u003c||\u003e"},{"line_number":126,"context_line":"    File[\u0027event_pipeline\u0027] ~\u003e Service[\u0027ceilometer-agent-notification\u0027]"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9ad45d7e_433762b0","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":51},"updated":"2016-08-08 18:40:39.000000000","message":"Why do we need this one?","commit_id":"4f8c9167966ef0e83642a4b85aa39db34634b107"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"58924bc9f8c2ed5a25005e15b709a607348c6392","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"},{"line_number":125,"context_line":"    File[\u0027event_pipeline\u0027] -\u003e Ceilometer_config\u003c||\u003e"},{"line_number":126,"context_line":"    File[\u0027event_pipeline\u0027] ~\u003e Service[\u0027ceilometer-agent-notification\u0027]"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9ad45d7e_1e212b4e","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":51},"in_reply_to":"9ad45d7e_433762b0","updated":"2016-08-09 05:58:05.000000000","message":"We don\u0027t! Fixed.","commit_id":"4f8c9167966ef0e83642a4b85aa39db34634b107"}],"manifests/init.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"76d64bc75e45a5f93c814cd88de2aee36fed0fde","unresolved":false,"context_lines":[{"line_number":292,"context_line":"  $amqp_username                      \u003d $::os_service_default,"},{"line_number":293,"context_line":"  $amqp_password                      \u003d $::os_service_default,"},{"line_number":294,"context_line":"  $purge_config                       \u003d false,"},{"line_number":295,"context_line":"  $event_pipeline_publishers          \u003d [\u0027notifier://\u0027],"},{"line_number":296,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":297,"context_line":"  $alarm_history_time_to_live         \u003d undef,"},{"line_number":298,"context_line":"  $metering_secret                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_bb5dbfee","line":295,"updated":"2016-08-08 10:03:12.000000000","message":"manage_event_pipeline isn\u0027t added","commit_id":"eefd31d1a4f22c951308a949044b9738c007a465"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"20217c9938f4f1dbefcbfcac42e4e6a754da1c17","unresolved":false,"context_lines":[{"line_number":292,"context_line":"  $amqp_username                      \u003d $::os_service_default,"},{"line_number":293,"context_line":"  $amqp_password                      \u003d $::os_service_default,"},{"line_number":294,"context_line":"  $purge_config                       \u003d false,"},{"line_number":295,"context_line":"  $event_pipeline_publishers          \u003d [\u0027notifier://\u0027],"},{"line_number":296,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":297,"context_line":"  $alarm_history_time_to_live         \u003d undef,"},{"line_number":298,"context_line":"  $metering_secret                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_bcd2d532","line":295,"in_reply_to":"9ad45d7e_bb5dbfee","updated":"2016-08-08 11:08:05.000000000","message":"Done","commit_id":"eefd31d1a4f22c951308a949044b9738c007a465"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"30c71a4bacfcf7f9070c088a18509fec144053f1","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    topics        \u003d\u003e $notification_topics,"},{"line_number":403,"context_line":"  }"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"  if ($manage_event_pipeline)"},{"line_number":406,"context_line":"  {"},{"line_number":407,"context_line":"    validate_array($event_pipeline_publishers)"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_a18c7236","line":405,"updated":"2016-08-08 10:44:56.000000000","message":"if .. {","commit_id":"eefd31d1a4f22c951308a949044b9738c007a465"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"20217c9938f4f1dbefcbfcac42e4e6a754da1c17","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    topics        \u003d\u003e $notification_topics,"},{"line_number":403,"context_line":"  }"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"  if ($manage_event_pipeline)"},{"line_number":406,"context_line":"  {"},{"line_number":407,"context_line":"    validate_array($event_pipeline_publishers)"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_bc0495c6","line":405,"in_reply_to":"9ad45d7e_a18c7236","updated":"2016-08-08 11:08:05.000000000","message":"Done","commit_id":"eefd31d1a4f22c951308a949044b9738c007a465"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"76d64bc75e45a5f93c814cd88de2aee36fed0fde","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    file { \u0027event_pipeline\u0027:"},{"line_number":410,"context_line":"      path    \u003d\u003e $::ceilometer::params::event_pipeline,"},{"line_number":411,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":412,"context_line":"      content \u003d\u003e template(\u0027ceilometer/event_pipeline.yaml.erb\u0027),"},{"line_number":413,"context_line":"    }"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_db2a332c","line":412,"updated":"2016-08-08 10:03:12.000000000","message":"owner, mode?","commit_id":"eefd31d1a4f22c951308a949044b9738c007a465"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"20217c9938f4f1dbefcbfcac42e4e6a754da1c17","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    file { \u0027event_pipeline\u0027:"},{"line_number":410,"context_line":"      path    \u003d\u003e $::ceilometer::params::event_pipeline,"},{"line_number":411,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":412,"context_line":"      content \u003d\u003e template(\u0027ceilometer/event_pipeline.yaml.erb\u0027),"},{"line_number":413,"context_line":"    }"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_1c9321a5","line":412,"in_reply_to":"9ad45d7e_db2a332c","updated":"2016-08-08 11:08:05.000000000","message":"This file is managed by packages on both common platforms so it isn\u0027t needed as long as the package is installed before the file resource is handled.","commit_id":"eefd31d1a4f22c951308a949044b9738c007a465"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"76d64bc75e45a5f93c814cd88de2aee36fed0fde","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"},{"line_number":416,"context_line":"    File[\u0027event_pipeline\u0027] -\u003e Ceilometer_config\u003c||\u003e"},{"line_number":417,"context_line":"    File[\u0027event_pipeline\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027ceilometer-notification\u0027 |\u003e"},{"line_number":418,"context_line":"  }"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"  oslo::messaging::default { \u0027ceilometer_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_1bf68bd7","line":417,"updated":"2016-08-08 10:03:12.000000000","message":"Incorrect title - https://github.com/openstack/puppet-ceilometer/blob/master/manifests/agent/notification.pp#L94","commit_id":"eefd31d1a4f22c951308a949044b9738c007a465"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"20217c9938f4f1dbefcbfcac42e4e6a754da1c17","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"},{"line_number":416,"context_line":"    File[\u0027event_pipeline\u0027] -\u003e Ceilometer_config\u003c||\u003e"},{"line_number":417,"context_line":"    File[\u0027event_pipeline\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027ceilometer-notification\u0027 |\u003e"},{"line_number":418,"context_line":"  }"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"  oslo::messaging::default { \u0027ceilometer_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_dc13490c","line":417,"in_reply_to":"9ad45d7e_1bf68bd7","updated":"2016-08-08 11:08:05.000000000","message":"Done","commit_id":"eefd31d1a4f22c951308a949044b9738c007a465"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"01fc74570db8aba7ccb451977e2a8470773ac422","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"},{"line_number":416,"context_line":"    File[\u0027event_pipeline\u0027] -\u003e Ceilometer_config\u003c||\u003e"},{"line_number":417,"context_line":"    File[\u0027event_pipeline\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027ceilometer-agent-notification\u0027 |\u003e"},{"line_number":418,"context_line":"  }"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"  oslo::messaging::default { \u0027ceilometer_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9ad45d7e_8dd8731f","line":417,"updated":"2016-08-08 14:43:36.000000000","message":"Code looks good to me, I\u0027m just wondering: shouldn\u0027t this be configurable from agent::notification class?","commit_id":"763fdac292f3e99c5c991f0fc41a51e7361b6ecb"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"7d0f809588c2a4847929d1c0117790f0bc30d558","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"},{"line_number":416,"context_line":"    File[\u0027event_pipeline\u0027] -\u003e Ceilometer_config\u003c||\u003e"},{"line_number":417,"context_line":"    File[\u0027event_pipeline\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027ceilometer-agent-notification\u0027 |\u003e"},{"line_number":418,"context_line":"  }"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"  oslo::messaging::default { \u0027ceilometer_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9ad45d7e_a2262114","line":417,"in_reply_to":"9ad45d7e_8d03530f","updated":"2016-08-08 15:53:18.000000000","message":"Good point, done.","commit_id":"763fdac292f3e99c5c991f0fc41a51e7361b6ecb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8af54ee808e852ffd3c9b63d7ecdcc1c4a87b542","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ceilometer-package\u0027 |\u003e -\u003e File[\u0027event_pipeline\u0027]"},{"line_number":416,"context_line":"    File[\u0027event_pipeline\u0027] -\u003e Ceilometer_config\u003c||\u003e"},{"line_number":417,"context_line":"    File[\u0027event_pipeline\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027ceilometer-agent-notification\u0027 |\u003e"},{"line_number":418,"context_line":"  }"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"  oslo::messaging::default { \u0027ceilometer_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9ad45d7e_8d03530f","line":417,"in_reply_to":"9ad45d7e_8dd8731f","updated":"2016-08-08 14:47:47.000000000","message":"Yeah, looks like it can be moved to notification class.","commit_id":"763fdac292f3e99c5c991f0fc41a51e7361b6ecb"}],"spec/classes/ceilometer_agent_notification_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"85b33e6a7295210636a30ba569565103e26c8ac7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :manage_event_pipeline \u003d\u003e false"},{"line_number":128,"context_line":"      ) }"},{"line_number":129,"context_line":"        it { is_expected.not_to contain_file(\u0027event_pipeline\u0027) }"},{"line_number":130,"context_line":"    end"},{"line_number":131,"context_line":"  end"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  context \u0027on Debian platforms\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9ad45d7e_435e42ea","line":130,"updated":"2016-08-08 18:40:39.000000000","message":"Tests are not enough here, I would like to see an example with some content, and possible an array with multiple notifiers, so we can validate the expected configuration is good.","commit_id":"4f8c9167966ef0e83642a4b85aa39db34634b107"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"58924bc9f8c2ed5a25005e15b709a607348c6392","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :manage_event_pipeline \u003d\u003e false"},{"line_number":128,"context_line":"      ) }"},{"line_number":129,"context_line":"        it { is_expected.not_to contain_file(\u0027event_pipeline\u0027) }"},{"line_number":130,"context_line":"    end"},{"line_number":131,"context_line":"  end"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  context \u0027on Debian platforms\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9ad45d7e_8fe9671d","line":130,"in_reply_to":"9ad45d7e_435e42ea","updated":"2016-08-09 05:58:05.000000000","message":"Done","commit_id":"4f8c9167966ef0e83642a4b85aa39db34634b107"}]}