)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c3e8146ae68cbc363b2cbd185b34d921e9fee175","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   Defaults to true."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*configure_service*]"},{"line_number":23,"context_line":"#   Whether to create the service."},{"line_number":24,"context_line":"#   boolean; optional: default to True"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*configure_user*]"},{"line_number":27,"context_line":"#   (Optional) Should Ceilometer service user be configured?"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f65232a_cf9e7706","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":38},"updated":"2020-10-22 02:45:47.000000000","message":"I\u0027d prefer to keep the consistent formatting in a single file like;\n\n# [*configure_service*]\n#   (Optional)  Whether to create the zaqar service.\n#   Defaults to true.","commit_id":"e81e3998248636d6c66f4c79aff29e9b0cd3c952"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"323ce2450369b3e841d5cb94f3f73e05851c5e1f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   Defaults to true."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*configure_service*]"},{"line_number":23,"context_line":"#   Whether to create the service."},{"line_number":24,"context_line":"#   boolean; optional: default to True"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*configure_user*]"},{"line_number":27,"context_line":"#   (Optional) Should Ceilometer service user be configured?"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f65232a_237d7f1c","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":38},"in_reply_to":"3f65232a_cf9e7706","updated":"2020-10-22 13:17:20.000000000","message":"Done","commit_id":"e81e3998248636d6c66f4c79aff29e9b0cd3c952"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c3e8146ae68cbc363b2cbd185b34d921e9fee175","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    configure_user      \u003d\u003e $configure_user,"},{"line_number":101,"context_line":"    configure_user_role \u003d\u003e $configure_user_role,"},{"line_number":102,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"},{"line_number":103,"context_line":"    configure_service   \u003d\u003e $configure_service,"},{"line_number":104,"context_line":"    service_type        \u003d\u003e $service_type,"},{"line_number":105,"context_line":"    service_description \u003d\u003e $service_description,"},{"line_number":106,"context_line":"    service_name        \u003d\u003e $service_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f65232a_8fbd9f6a","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":46},"updated":"2020-10-22 02:45:47.000000000","message":"Is there any usecase where we want to create ceilometer endpoint and service ?\nI think we should disable both regarding the fact that we no longer have ceilometer-api and shouldn\u0027t allow to have this enabled.","commit_id":"e81e3998248636d6c66f4c79aff29e9b0cd3c952"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"323ce2450369b3e841d5cb94f3f73e05851c5e1f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    configure_user      \u003d\u003e $configure_user,"},{"line_number":101,"context_line":"    configure_user_role \u003d\u003e $configure_user_role,"},{"line_number":102,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"},{"line_number":103,"context_line":"    configure_service   \u003d\u003e $configure_service,"},{"line_number":104,"context_line":"    service_type        \u003d\u003e $service_type,"},{"line_number":105,"context_line":"    service_description \u003d\u003e $service_description,"},{"line_number":106,"context_line":"    service_name        \u003d\u003e $service_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f65232a_6377773c","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":46},"in_reply_to":"3f65232a_5a03430e","updated":"2020-10-22 13:17:20.000000000","message":"Ack. Think this is a good strategy, to merge this one and deprecate/remove it in next step.","commit_id":"e81e3998248636d6c66f4c79aff29e9b0cd3c952"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3668ab0bb1983f65ab6ddf3af3334c2695956e65","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    configure_user      \u003d\u003e $configure_user,"},{"line_number":101,"context_line":"    configure_user_role \u003d\u003e $configure_user_role,"},{"line_number":102,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"},{"line_number":103,"context_line":"    configure_service   \u003d\u003e $configure_service,"},{"line_number":104,"context_line":"    service_type        \u003d\u003e $service_type,"},{"line_number":105,"context_line":"    service_description \u003d\u003e $service_description,"},{"line_number":106,"context_line":"    service_name        \u003d\u003e $service_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f65232a_5a03430e","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":46},"in_reply_to":"3f65232a_8fbd9f6a","updated":"2020-10-22 03:07:34.000000000","message":"After giving some thought about this, now I think it\u0027d be better to add this option in master so that we can backport this to stable braches.\n\nFor master we can deprecate this parameter soon with removing all endpoint/service_type management, but should keep this parameter for this cycle so that it won\u0027t cause issue during upgrade from the old branches with the backport to master.\n\n https://review.opendev.org/#/c/759171/","commit_id":"e81e3998248636d6c66f4c79aff29e9b0cd3c952"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c29db6c611d152d4f66cab2550055b37884976bb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# [*configure_service*]"},{"line_number":23,"context_line":"#   (Optional) Whether to create the service."},{"line_number":24,"context_line":"#   Default to True"},{"line_number":25,"context_line":"#   Remark: will be deprecated soon!"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*configure_user*]"},{"line_number":28,"context_line":"#   (Optional) Should Ceilometer service user be configured?"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_81356bfa","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":36},"updated":"2020-10-22 15:16:05.000000000","message":"NOTE: should remove for backport.","commit_id":"f5a7b11d156adf30c9401491a19a3c774cf7a2ce"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"4997b535dc0508b0eefddaf3c58e5702fe69b76a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# [*configure_service*]"},{"line_number":23,"context_line":"#   (Optional) Whether to create the service."},{"line_number":24,"context_line":"#   Default to True"},{"line_number":25,"context_line":"#   Remark: will be deprecated soon!"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*configure_user*]"},{"line_number":28,"context_line":"#   (Optional) Should Ceilometer service user be configured?"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_9c3670b4","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":36},"in_reply_to":"3f65232a_81356bfa","updated":"2020-10-22 15:38:53.000000000","message":"right, I changed it to will be deprecated in wallaby cycle, so we do not need to change for backports.","commit_id":"f5a7b11d156adf30c9401491a19a3c774cf7a2ce"}]}