)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"067a040fd47e9db716dcccc40956be04bd4685eb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# [*region*]"},{"line_number":27,"context_line":"#   (Optional) Region for endpoint."},{"line_number":28,"context_line":"#   Defaults to \u0027RegionOne\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*tenant*]"},{"line_number":31,"context_line":"#   (Optional) Tenant for Ceilometer user."},{"line_number":32,"context_line":"#   Defaults to \u0027services\u0027."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_635497cb","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"updated":"2020-10-22 13:12:58.000000000","message":"region should also be deprecated","commit_id":"34ecd153d9921484c475cc969f3275e2d960a06b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5bc36af9958665119203871712073724aabdbf32","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# [*region*]"},{"line_number":27,"context_line":"#   (Optional) Region for endpoint."},{"line_number":28,"context_line":"#   Defaults to \u0027RegionOne\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*tenant*]"},{"line_number":31,"context_line":"#   (Optional) Tenant for Ceilometer user."},{"line_number":32,"context_line":"#   Defaults to \u0027services\u0027."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_a14b4785","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"3f65232a_635497cb","updated":"2020-10-22 15:14:40.000000000","message":"I think this is a bug in puppet-keystone. AFAIK we should specify region for all resources like user, project to identify the keystone endpoint to which client send requests.\n\nI\u0027ll fix the puppet-keystone side later so leave this parameter now, to avoid confusion caused by expected undeprecation.","commit_id":"34ecd153d9921484c475cc969f3275e2d960a06b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6590e00b159170b4d750d3351a0ea9c6aacacb9a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# [*region*]"},{"line_number":27,"context_line":"#   (Optional) Region for endpoint."},{"line_number":28,"context_line":"#   Defaults to \u0027RegionOne\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*tenant*]"},{"line_number":31,"context_line":"#   (Optional) Tenant for Ceilometer user."},{"line_number":32,"context_line":"#   Defaults to \u0027services\u0027."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_dc83c803","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"3f65232a_7c3274a9","updated":"2020-10-22 15:55:16.000000000","message":"(IIRC) the problem would be that the client need to identify which endpoints it should send the request to, and if we have multiple keystone endpoints with different regions then the client can\u0027t pick it up automatically.\n\nI agree that projects, users, and domains do not depend on reguins, and in most of the cases there are shared among multiple keystones in multiple regions.","commit_id":"34ecd153d9921484c475cc969f3275e2d960a06b"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"397d5f2818a20439786c7eee986b8eedc7cc4e46","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# [*region*]"},{"line_number":27,"context_line":"#   (Optional) Region for endpoint."},{"line_number":28,"context_line":"#   Defaults to \u0027RegionOne\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*tenant*]"},{"line_number":31,"context_line":"#   (Optional) Tenant for Ceilometer user."},{"line_number":32,"context_line":"#   Defaults to \u0027services\u0027."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_7c3274a9","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"3f65232a_a14b4785","updated":"2020-10-22 15:46:52.000000000","message":"hm as far as I know projects, users and domains do not depend on regions.\nBut proceeding is ok for me.","commit_id":"34ecd153d9921484c475cc969f3275e2d960a06b"}],"spec/classes/ceilometer_keystone_auth_spec.rb":[{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"397d5f2818a20439786c7eee986b8eedc7cc4e46","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      )}"},{"line_number":97,"context_line":"    end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    context \u0027when disabling service and endpoint configuration\u0027 do"},{"line_number":100,"context_line":"      before do"},{"line_number":101,"context_line":"        params.merge!("},{"line_number":102,"context_line":"          :configure_service   \u003d\u003e false,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f65232a_7cd71425","line":99,"updated":"2020-10-22 15:46:52.000000000","message":"you need to delete this part also, I added this tests with my patch ;)","commit_id":"a8b0f2d46c2b2d84e85ac11fcd4d412e75911355"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6590e00b159170b4d750d3351a0ea9c6aacacb9a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      )}"},{"line_number":97,"context_line":"    end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    context \u0027when disabling service and endpoint configuration\u0027 do"},{"line_number":100,"context_line":"      before do"},{"line_number":101,"context_line":"        params.merge!("},{"line_number":102,"context_line":"          :configure_service   \u003d\u003e false,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f65232a_fc79642f","line":99,"in_reply_to":"3f65232a_7cd71425","updated":"2020-10-22 15:55:16.000000000","message":"Done","commit_id":"a8b0f2d46c2b2d84e85ac11fcd4d412e75911355"}]}