)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"251c042252e1080aab1e70c7d73ef792f7eeb86a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7306a96c_f9a33bfc","updated":"2022-05-11 01:03:00.000000000","message":"@Takashi do you have any further comments about this change?","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"1b1a5d54e8e87bb1a03e42de6a7be69094e7c9a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6a4a84f_e9053dcb","updated":"2022-05-05 23:35:26.000000000","message":"Looks you got another change to drop the user/group creation. https://review.opendev.org/c/openstack/puppet-ceilometer/+/830022 that is totally fine with me to go with this way.","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cb5a9a6d4acc977d4b78ee92ac2eaab35afd804c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc8818ee_f3d77a84","updated":"2022-05-05 17:01:56.000000000","message":"The ceilometer user should be created by ceilometer-common package. The current resource definition is used to add the ceilometer user to nova/libvirt group but we do not intend to override the default package user. I\u0027m not sure how much beneficial to let users to override uid/gid.","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"c1a39248d11531c3db6ff21c1b3608754af23cc4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"001460e1_af30de2e","in_reply_to":"05c6d1ef_234c20c7","updated":"2022-05-15 13:21:42.000000000","message":"Thanks a lot Takashi for your detailed comments. Yeah, I agree with you that it may be better for me to create the user/groups in external manifests and adding a knob to enable/disable user/group management will be a reasonable solution. I will abandon my previous changes including this one, and will follow up your new refactor change instead. Thanks again!","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8eb2d6b4ac11616b79eee4d3733cf3ca577cc38","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05c6d1ef_234c20c7","in_reply_to":"1e2ab5cd_9d83ade7","updated":"2022-05-14 16:12:55.000000000","message":"The intention of the current user/group resources is to add the ceilometer user to the required groups. As in the current support scope of puppet, we expect the user/group are created by packages, exposing more interface to allow complicated user/group declaration is not desired, IMO.\n\nAlso, currently, these user/group resources are triggred after package installation. Thus the ceilometer user/group are created first with the specific uid/gid defined in package manifests during package installation, and then uid/gid are modified by the resource. This would leave the files provided by packages kept with old uid/gid. This sounds like problematic for your case, doesn\u0027t it ?\n\nIf you intend to use your own uid/gid then you should create system users/groups with desired ids first and then install packages so that package installation picks up the existing ids. The dependency required for that (create users BEFORE package installation) would conflict with what we need when we use the users created by packages.\n\nIMO the right approach is to add a knob to disable user/group management so that you can create users/groups as you want in external manifests or external tooling.\n\nSee https://review.opendev.org/c/openstack/puppet-ceilometer/+/841814 .","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"d47c3a4485bed5def79abf20d3e73f9a8356ada1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e2ab5cd_9d83ade7","in_reply_to":"3e4f3062_2c383b6c","updated":"2022-05-14 13:43:42.000000000","message":"Thanks Takashi for your comments. \n\nYes, we use puppet module in the host(VM) level to generate config files. And kolla container will mount the config files/folder during its runtime. In that case, if we keep the default kolla image uid/gid, we should use the same one to start the container from the host(VM). This is a natural transistion for us, because we are migarting our services from VM to container. And we deployed the service on VM using puppet module before and it worked well, so now we just want to start the service as a container without changing other things. \n\nAnd as you replied in another change I made (https://review.opendev.org/c/openstack/puppet-ceilometer/+/841528), maybe adding uid/gid as configurable parameter will be easier solution?","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ce32ca9bd2ccc00d3c94978395ef1cf362d6bf5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6181112_194f38fd","in_reply_to":"acbe1e09_6b5e4639","updated":"2022-05-14 13:19:30.000000000","message":"Sorry I was off during first week of May and missed this after coming back holidays.\n\nThough I understand part of your thought, do you mind explaining a few more details, expecialy about the way you use the puppet module with such container deployment ? AFAIK in Kolla the users are created during building the packages, so as long as you execute puppet inside containers then you don\u0027t need this change as the puppet execution looks up the user inside container images. This is how we actually use puppet modules in TripleO and we have never seen any issue with that.\n\nYou might be able to use puppet modules to generate config files, but the current modules do not support that use case perfectly (eg. There are some packages still forcefully installed. A few configuration tasks like apache files requires the packages are installed) and I believe we still need some amount of work, which I\u0027m not sure could be worth doing.","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"b0108f1584b94e83a7b1916ab1de43bb50a5e69d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"acbe1e09_6b5e4639","in_reply_to":"dc8818ee_f3d77a84","updated":"2022-05-05 23:18:28.000000000","message":"yeah the benefit is more about the ceilometer container deployment. Like for kolla container, the ceilometer uid/gid will by default use different value: 42405. Have the ability to override them will make container deployment easier. So how do you think of it?","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"197a39a1aa989a4bfa726ca5b4c7941a6d25164a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e4f3062_2c383b6c","in_reply_to":"e6181112_194f38fd","updated":"2022-05-14 13:20:22.000000000","message":"\u003e You might be able to use puppet modules to generate config files,\n\nI meant;\n\nYou might be able to use puppet modules in host level to generate config files, ...","commit_id":"5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7"}]}