)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6692b490bde9998887a8f7c2dd13f9b465f4f755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5194c88_63d9b830","updated":"2023-06-15 22:17:42.000000000","message":"I tend to avoid adding strict type deifnitions initially but probably having the suggested rule for these two specific parameters don\u0027t harm so I\u0027ve updated the change.","commit_id":"6a7d199dab5782904a2b260e8f6184f612c10422"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"9e0973a45af2eb408b0097a1cb303060f8a0e327","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6c98afce_b596ebff","updated":"2023-06-15 23:20:37.000000000","message":"Well I think the stricter the better.","commit_id":"6a7d199dab5782904a2b260e8f6184f612c10422"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"faed1b8981d268f626a1e75571f6791a5f8578c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c8a3619_5660089b","updated":"2023-06-16 01:00:13.000000000","message":"recheck\n\nUnable to download data from https://rubygems.org/ - Net::OpenTimeout: execution expired (https://rubygems.org/specs.4.8.gz)","commit_id":"6a7d199dab5782904a2b260e8f6184f612c10422"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a76534d4067ee7f7de89cd8657a2e030f9f36e00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b34d0c26_326acc1d","in_reply_to":"6c98afce_b596ebff","updated":"2023-06-16 00:59:53.000000000","message":"I agree stricter would be better, but at the same time I\u0027d keep the scope of individual step small so that each step can be doable within the reasonable time frame, consistently across all modules.\n\nWe can follow up what we want to make in the coming cycles in the thread after I share some outcomes from the discussion during PTG this week (hopefully early next week).","commit_id":"6a7d199dab5782904a2b260e8f6184f612c10422"}],"manifests/agent/notification.pp":[{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"598372d36b14fbad0494df14ea4da1bd3d810976","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  $batch_timeout                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":105,"context_line":"  $package_ensure                          \u003d \u0027present\u0027,"},{"line_number":106,"context_line":"  Boolean $manage_event_pipeline           \u003d false,"},{"line_number":107,"context_line":"  Array[String] $event_pipeline_publishers \u003d [\u0027gnocchi://\u0027],"},{"line_number":108,"context_line":"  Optional[Hash] $event_pipeline_config    \u003d undef,"},{"line_number":109,"context_line":"  Boolean $manage_pipeline                 \u003d false,"},{"line_number":110,"context_line":"  Array[String] $pipeline_publishers       \u003d [\u0027gnocchi://\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d30c315a_2fe43a55","line":107,"updated":"2023-06-15 20:42:45.000000000","message":"should use Array[String[1]]","commit_id":"e6b88100344a6ac80e87f73a46a2ff3793aa2d12"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6692b490bde9998887a8f7c2dd13f9b465f4f755","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  $batch_timeout                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":105,"context_line":"  $package_ensure                          \u003d \u0027present\u0027,"},{"line_number":106,"context_line":"  Boolean $manage_event_pipeline           \u003d false,"},{"line_number":107,"context_line":"  Array[String] $event_pipeline_publishers \u003d [\u0027gnocchi://\u0027],"},{"line_number":108,"context_line":"  Optional[Hash] $event_pipeline_config    \u003d undef,"},{"line_number":109,"context_line":"  Boolean $manage_pipeline                 \u003d false,"},{"line_number":110,"context_line":"  Array[String] $pipeline_publishers       \u003d [\u0027gnocchi://\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"792c74d9_136f4223","line":107,"in_reply_to":"d30c315a_2fe43a55","updated":"2023-06-15 22:17:42.000000000","message":"Done","commit_id":"e6b88100344a6ac80e87f73a46a2ff3793aa2d12"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"598372d36b14fbad0494df14ea4da1bd3d810976","unresolved":true,"context_lines":[{"line_number":107,"context_line":"  Array[String] $event_pipeline_publishers \u003d [\u0027gnocchi://\u0027],"},{"line_number":108,"context_line":"  Optional[Hash] $event_pipeline_config    \u003d undef,"},{"line_number":109,"context_line":"  Boolean $manage_pipeline                 \u003d false,"},{"line_number":110,"context_line":"  Array[String] $pipeline_publishers       \u003d [\u0027gnocchi://\u0027],"},{"line_number":111,"context_line":"  Optional[Hash] $pipeline_config          \u003d undef,"},{"line_number":112,"context_line":") {"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"c2c22c39_5700aafc","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":14},"updated":"2023-06-15 20:42:45.000000000","message":"also use Array[String[1]]","commit_id":"e6b88100344a6ac80e87f73a46a2ff3793aa2d12"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6692b490bde9998887a8f7c2dd13f9b465f4f755","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  Array[String] $event_pipeline_publishers \u003d [\u0027gnocchi://\u0027],"},{"line_number":108,"context_line":"  Optional[Hash] $event_pipeline_config    \u003d undef,"},{"line_number":109,"context_line":"  Boolean $manage_pipeline                 \u003d false,"},{"line_number":110,"context_line":"  Array[String] $pipeline_publishers       \u003d [\u0027gnocchi://\u0027],"},{"line_number":111,"context_line":"  Optional[Hash] $pipeline_config          \u003d undef,"},{"line_number":112,"context_line":") {"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"32d4dfbb_38394d1a","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":14},"in_reply_to":"c2c22c39_5700aafc","updated":"2023-06-15 22:17:42.000000000","message":"Done","commit_id":"e6b88100344a6ac80e87f73a46a2ff3793aa2d12"}]}