)]}'
{"manifests/rgw/keystone.pp":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"de0bbad53272a3e9ff808d1316f7225c209f1193","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*rgw_keystone_token_cache_size*] How many tokens to keep cached."},{"line_number":38,"context_line":"#   Optional. Default is 500."},{"line_number":39,"context_line":"#   Not useful when using PKI as every token is checked."},{"line_number":40,"context_line":"# "},{"line_number":41,"context_line":"# [*rgw_keystone_revocation_interval*] Interval to check for expired tokens."},{"line_number":42,"context_line":"#   Optional. Default is 600 (seconds)."},{"line_number":43,"context_line":"#   Not useful if not using PKI tokens (if not, set to high value)."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1abeadc6_b6268214","line":40,"updated":"2014-08-28 14:29:08.000000000","message":"Whitespace","commit_id":"0d67e7eea6610cc78faea015418daa8895d471ae"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"de0bbad53272a3e9ff808d1316f7225c209f1193","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*use_pki*] (bool) To determine if keystone is using token_format."},{"line_number":46,"context_line":"#   Optional. Default is undef."},{"line_number":47,"context_line":"# "},{"line_number":48,"context_line":"# [*nss_db_path*] Path to NSS \u003c - \u003e keystone tokens db files."},{"line_number":49,"context_line":"#   Optional. Default is undef."},{"line_number":50,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1abeadc6_d623fe02","line":47,"updated":"2014-08-28 14:29:08.000000000","message":"Whitespace","commit_id":"0d67e7eea6610cc78faea015418daa8895d471ae"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"f082e98cb39631ac57235da198876bc22c142252","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # fetch the keystone signing cert, add to nss db"},{"line_number":73,"context_line":"  ensure_resource(\u0027package\u0027, \u0027libnss3-tools\u0027, {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  file { $nss_db_path:"},{"line_number":76,"context_line":"    ensure \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8c0949_1f7dc21c","line":73,"updated":"2014-11-07 08:20:09.000000000","message":"What is the reason of installing the package this way?","commit_id":"980ca49a1b981fd606753ee53ff59762f1a4be26"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9f97b486a2f51f6d6d0ab0aac97de72bff612243","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $rgw_keystone_accepted_roles      \u003d \u0027_member_, Member\u0027,"},{"line_number":55,"context_line":"  $rgw_keystone_token_cache_size    \u003d 500,"},{"line_number":56,"context_line":"  $rgw_keystone_revocation_interval \u003d 600,"},{"line_number":57,"context_line":"  $use_pki                          \u003d undef,"},{"line_number":58,"context_line":"  $nss_db_path                      \u003d \u0027/var/lib/ceph/nss\u0027,"},{"line_number":59,"context_line":") {"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a50d1a3_c2668dec","line":57,"updated":"2015-07-28 20:59:08.000000000","message":"should be true or false, undef makes no sense","commit_id":"c1dd900b35d6aee72c6fd32587783b83bf4e6032"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9f97b486a2f51f6d6d0ab0aac97de72bff612243","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"client.${name}/nss_db_path\":                      value \u003d\u003e $nss_db_path;"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # fetch the keystone signing cert, add to nss db"},{"line_number":73,"context_line":"  ensure_resource(\u0027package\u0027, \u0027libnss3-tools\u0027, {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  file { $nss_db_path:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a50d1a3_6248d95c","line":72,"updated":"2015-07-28 20:59:08.000000000","message":"we should only do the nss stuf if use_pki is true","commit_id":"c1dd900b35d6aee72c6fd32587783b83bf4e6032"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9f97b486a2f51f6d6d0ab0aac97de72bff612243","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # fetch the keystone signing cert, add to nss db"},{"line_number":73,"context_line":"  ensure_resource(\u0027package\u0027, \u0027libnss3-tools\u0027, {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  file { $nss_db_path:"},{"line_number":76,"context_line":"    ensure \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a50d1a3_ce78f680","line":73,"updated":"2015-07-28 20:59:08.000000000","message":"this is the debian name, rhel6 uses \u0027nss-tools\u0027","commit_id":"c1dd900b35d6aee72c6fd32587783b83bf4e6032"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9f97b486a2f51f6d6d0ab0aac97de72bff612243","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  file { $nss_db_path:"},{"line_number":76,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":77,"context_line":"    owner  \u003d\u003e root,"},{"line_number":78,"context_line":"    group  \u003d\u003e root,"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  exec { \"${name}-nssdb-ca\":"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a50d1a3_42d6fd4f","line":78,"updated":"2015-07-28 20:59:08.000000000","message":"needs to be owned by the user running rgw (we need to fix it in ceph::rgw too so this might be nit)","commit_id":"c1dd900b35d6aee72c6fd32587783b83bf4e6032"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9f97b486a2f51f6d6d0ab0aac97de72bff612243","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    group  \u003d\u003e root,"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  exec { \"${name}-nssdb-ca\":"},{"line_number":82,"context_line":"    command \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"},{"line_number":83,"context_line":"set -ex"},{"line_number":84,"context_line":"wget --no-check-certificate ${rgw_keystone_url}/certificates/ca -O /tmp/ca"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a50d1a3_c249ad32","line":81,"updated":"2015-07-28 20:59:08.000000000","message":"needs to be owned by the user running rgw (we need to fix it in ceph::rgw too so this might be nit)","commit_id":"c1dd900b35d6aee72c6fd32587783b83bf4e6032"}],"spec/defines/ceph_rgw_keystone_spec.rb":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"de0bbad53272a3e9ff808d1316f7225c209f1193","unresolved":false,"context_lines":[{"line_number":21,"context_line":"describe \u0027ceph::rgw::keystone\u0027 do"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  shared_examples_for \u0027ceph rgw keystone\u0027 do"},{"line_number":24,"context_line":"    describe \"create with custom params\" do"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"      let :title do"},{"line_number":27,"context_line":"        \u0027radosgw.gateway\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1abeadc6_96d346d4","line":24,"updated":"2014-08-28 14:29:08.000000000","message":"Can you add a test for the default params ?","commit_id":"0d67e7eea6610cc78faea015418daa8895d471ae"},{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"de7286a490cc4f16cdf176336b2ff1dc6ada8316","unresolved":false,"context_lines":[{"line_number":21,"context_line":"describe \u0027ceph::rgw::keystone\u0027 do"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  shared_examples_for \u0027ceph rgw keystone\u0027 do"},{"line_number":24,"context_line":"    describe \"create with custom params\" do"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"      let :title do"},{"line_number":27,"context_line":"        \u0027radosgw.gateway\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1abeadc6_c2596936","line":24,"in_reply_to":"1abeadc6_96d346d4","updated":"2014-08-28 22:50:03.000000000","message":"I\u0027ll have a look... i had issues with the test failing to pick up the values from ceph::params. Any hints or pointers to something similar?","commit_id":"0d67e7eea6610cc78faea015418daa8895d471ae"}],"spec/spec_helper_system.rb":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9f97b486a2f51f6d6d0ab0aac97de72bff612243","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            :node \u003d\u003e vm)"},{"line_number":55,"context_line":"      shell(:command \u003d\u003e \u0027puppet module install --version \"\u003e\u003d1.4.1 \u003c2.0.0\" puppetlabs/apache\u0027,"},{"line_number":56,"context_line":"            :node \u003d\u003e vm)"},{"line_number":57,"context_line":"      shell(:command \u003d\u003e \u0027puppet module install --version 0.9.0 puppetlabs/mysql\u0027,"},{"line_number":58,"context_line":"            :node \u003d\u003e vm)"},{"line_number":59,"context_line":"      shell(:command \u003d\u003e \u0027puppet module install --version 4.1.0 puppetlabs/keystone\u0027,"},{"line_number":60,"context_line":"            :node \u003d\u003e vm)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"3a50d1a3_eecb72a2","line":57,"updated":"2015-07-28 20:59:08.000000000","message":"I think keystone will pull in openstacklib, which pulls mysql, we should not need it directly.","commit_id":"c1dd900b35d6aee72c6fd32587783b83bf4e6032"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9f97b486a2f51f6d6d0ab0aac97de72bff612243","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            :node \u003d\u003e vm)"},{"line_number":57,"context_line":"      shell(:command \u003d\u003e \u0027puppet module install --version 0.9.0 puppetlabs/mysql\u0027,"},{"line_number":58,"context_line":"            :node \u003d\u003e vm)"},{"line_number":59,"context_line":"      shell(:command \u003d\u003e \u0027puppet module install --version 4.1.0 puppetlabs/keystone\u0027,"},{"line_number":60,"context_line":"            :node \u003d\u003e vm)"},{"line_number":61,"context_line":"      rcp(:sp \u003d\u003e File.join(proj_root, \u0027spec/fixtures/hieradata/hiera.yaml\u0027),"},{"line_number":62,"context_line":"          :dp \u003d\u003e \u0027/etc/puppet/hiera.yaml\u0027,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"3a50d1a3_8ec50e8f","line":59,"updated":"2015-07-28 20:59:08.000000000","message":"can we use a newer version than this?","commit_id":"c1dd900b35d6aee72c6fd32587783b83bf4e6032"}],"spec/system/ceph_rgw_keystone_spec.rb":[{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"4f84799e7c32cf88363a412e33f6613eb9d7f42e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"          $pkg_swift \u003d $osfamily ? {"},{"line_number":53,"context_line":"            \u0027RedHat\u0027 \u003d\u003e \u0027openstack-swift\u0027,"},{"line_number":54,"context_line":"            default  \u003d\u003e \u0027swift\u0027,"},{"line_number":55,"context_line":"          }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da86d52c_8dd6e1ef","line":53,"updated":"2015-02-03 23:42:06.000000000","message":"afaik this is not available in centos without adding an openstack repository","commit_id":"da51c6e47afff405756864cc3850029d0982f9ae"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"4f84799e7c32cf88363a412e33f6613eb9d7f42e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"          }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"          # setup a keystone instance (need havana at least)"},{"line_number":58,"context_line":"          include apt"},{"line_number":59,"context_line":"          apt::source { \u0027cloudarchive-havana\u0027:"},{"line_number":60,"context_line":"            location          \u003d\u003e \u0027http://ubuntu-cloud.archive.canonical.com/ubuntu\u0027,"},{"line_number":61,"context_line":"            release           \u003d\u003e \u0027precise-updates/havana\u0027,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da86d52c_6dab6d75","line":58,"updated":"2015-02-03 23:42:06.000000000","message":"this doesn\u0027t work under centos/rhel","commit_id":"da51c6e47afff405756864cc3850029d0982f9ae"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"4f84799e7c32cf88363a412e33f6613eb9d7f42e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            command \u003d\u003e \u0027/usr/sbin/ceph-create-keys --id a\u0027,"},{"line_number":153,"context_line":"          }"},{"line_number":154,"context_line":"          -\u003e"},{"line_number":155,"context_line":"          ceph::osd { \u0027/srv/data\u0027: }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"          # setup ceph radosgw"},{"line_number":158,"context_line":"          host { $::fqdn: # workaround for bad \u0027hostname -f\u0027 in vagrant box"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da86d52c_0dd591b8","line":155,"updated":"2015-02-03 23:42:06.000000000","message":"when putting OSDs on /srv/data the journal size needs to be reduced or no more space error happens.\n\nceph_config {\n  \u0027global/osd_journal_size\u0027: value \u003d\u003e \u0027100\u0027;\n}","commit_id":"da51c6e47afff405756864cc3850029d0982f9ae"}]}