)]}'
{"manifests/osd.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"6c7817086b68fc65af7784882cf982911ecf8a4f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\","},{"line_number":73,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":74,"context_line":"set -ex"},{"line_number":75,"context_line":"ceph-disk list | grep -E \u0027 *${data}1? .*ceph data, (prepared|active)\u0027 ||"},{"line_number":76,"context_line":"ls -l /var/lib/ceph/osd/${cluster_name}-* | grep \u0027 ${data}\\$\u0027"},{"line_number":77,"context_line":"\","},{"line_number":78,"context_line":"        logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_abf7a757","line":75,"updated":"2015-07-22 16:53:14.000000000","message":"I need to look at this regex more clearly, by first glance, it appears to only match on first device, not all devices","commit_id":"fe132b36cf1ced1550be308e172d8b8d2fd75539"},{"author":{"_account_id":15373,"name":"Mykola Golub","email":"mgolub@mirantis.com","username":"mgolub"},"change_message_id":"dbc99b99136b5d15e79bbc34e2df7eeb07e1e155","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\","},{"line_number":73,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":74,"context_line":"set -ex"},{"line_number":75,"context_line":"ceph-disk list | grep -E \u0027 *${data}1? .*ceph data, (prepared|active)\u0027 ||"},{"line_number":76,"context_line":"ls -l /var/lib/ceph/osd/${cluster_name}-* | grep \u0027 ${data}\\$\u0027"},{"line_number":77,"context_line":"\","},{"line_number":78,"context_line":"        logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_5c3827ef","line":75,"in_reply_to":"3a50d1a3_abf7a757","updated":"2015-07-22 18:10:38.000000000","message":"Yes, the idea is to match e.g. either /dev/vda or /dev/vda1.\n\nWhen ceph-disk prepare is called for a whole disk (/dev/vda) it will create the 1st partition on the disk, so if $data\u003d/dev/vda you have actually to check if /dev/vda1 already prepared before calling prepare /dev/vda.\n\nSo, a more exact code could be: look for ${data}1 only if ${data} is a whole disk. But this makes it much more complicated, and actually we already have the case (see below) where we just check both ${data} and ${data}1.","commit_id":"fe132b36cf1ced1550be308e172d8b8d2fd75539"},{"author":{"_account_id":15373,"name":"Mykola Golub","email":"mgolub@mirantis.com","username":"mgolub"},"change_message_id":"dbc99b99136b5d15e79bbc34e2df7eeb07e1e155","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  mkdir -p ${data}"},{"line_number":87,"context_line":"fi"},{"line_number":88,"context_line":"# activate happens via udev when using the entire device"},{"line_number":89,"context_line":"if ! test -b ${data} || ! test -b ${data}1 ; then"},{"line_number":90,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":91,"context_line":"fi"},{"line_number":92,"context_line":"\","}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_7c2de3a6","line":89,"updated":"2015-07-22 18:10:38.000000000","message":"Here is this case.","commit_id":"fe132b36cf1ced1550be308e172d8b8d2fd75539"}]}