)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-01-06 10:31:04 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for civetweb support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add parameter for using and configuring civetweb frontend"},{"line_number":10,"context_line":"Passes puppet-list and locak beaker tests on centos7"},{"line_number":11,"context_line":"Correct profile/rgw.pp file used for heira"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da6ed579_b2878f60","line":8,"updated":"2016-01-12 19:14:09.000000000","message":"Can you do a good summary of the changes the commit in this review makes ? There is also no need to provide a changelog throughout patchsets within the same review.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Gurtner \u003caldavud@crimson.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-25 17:41:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for civetweb support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This configure radosgw to use the built-in civetweb server instead of"},{"line_number":10,"context_line":"an external apache server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a68dd71_879930c6","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":32},"updated":"2016-01-25 22:50:18.000000000","message":"That\u0027s one support too many ;)","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Gurtner \u003caldavud@crimson.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-25 17:41:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for civetweb support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This configure radosgw to use the built-in civetweb server instead of"},{"line_number":10,"context_line":"an external apache server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a5de9d1_59b533cb","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":32},"in_reply_to":"9a68dd71_879930c6","updated":"2016-01-27 21:05:38.000000000","message":"Done","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"}],"manifests/params.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7d9ec6faa951843c3ee1ccae32fcdb13caa043e5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#   Optional. Defaults to \u0027/tmp/radosgw.sock\u0027"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*frontend_type*] Which httpd front end to use"},{"line_number":33,"context_line":"#   Optional. Defaults or \u0027apache\u0027. \u0027civetweb\u0027 is valid. "},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class ceph::params ("},{"line_number":36,"context_line":"  $packages \u003d \u0027ceph\u0027, # just provide the minimum per default"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_9053866c","line":33,"updated":"2015-12-09 17:00:28.000000000","message":"whitespace","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d2aba7913e0d7b0d44afef0d4225797e2ebcd2f1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class ceph::params ("},{"line_number":36,"context_line":"  $packages \u003d \u0027ceph\u0027, # just provide the minimum per default"},{"line_number":37,"context_line":"  $rgw_socket_path \u003d \u0027/tmp/radosgw.sock\u0027,"},{"line_number":38,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":39,"context_line":") {"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  case $::osfamily {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_83c33b38","line":38,"updated":"2015-12-09 18:23:32.000000000","message":"I don\u0027t understand why this was added here, I think it makes more sense in the rgw profile","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#   Optional. Defaults to \u0027/tmp/radosgw.sock\u0027"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*frontend_type*] Which httpd front end to use"},{"line_number":33,"context_line":"#   Optional. Defaults or \u0027apache\u0027. \u0027civetweb\u0027 is valid."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class ceph::params ("},{"line_number":36,"context_line":"  $packages \u003d \u0027ceph\u0027, # just provide the minimum per default"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_5f573c02","line":33,"updated":"2016-01-12 19:14:09.000000000","message":"I guess this parameter was moved to the profile params, can you remove this comment ?","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#   Optional. Defaults to \u0027/tmp/radosgw.sock\u0027"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*frontend_type*] Which httpd front end to use"},{"line_number":33,"context_line":"#   Optional. Defaults or \u0027apache\u0027. \u0027civetweb\u0027 is valid."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class ceph::params ("},{"line_number":36,"context_line":"  $packages \u003d \u0027ceph\u0027, # just provide the minimum per default"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_45868266","line":33,"in_reply_to":"da6ed579_5f573c02","updated":"2016-01-16 16:09:54.000000000","message":"Done","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"}],"manifests/profile/params.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7d9ec6faa951843c3ee1ccae32fcdb13caa043e5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  $client_keys \u003d {},"},{"line_number":126,"context_line":"  $osds \u003d undef,"},{"line_number":127,"context_line":"  $manage_repo \u003d true,"},{"line_number":128,"context_line":"  $enable_rgw \u003d false ,"},{"line_number":129,"context_line":"  $rgw_user \u003d \u0027root\u0027 ,"},{"line_number":130,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":131,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_f0d44abe","line":128,"updated":"2015-12-09 17:00:28.000000000","message":"whitespace","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7d9ec6faa951843c3ee1ccae32fcdb13caa043e5","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  $osds \u003d undef,"},{"line_number":127,"context_line":"  $manage_repo \u003d true,"},{"line_number":128,"context_line":"  $enable_rgw \u003d false ,"},{"line_number":129,"context_line":"  $rgw_user \u003d \u0027root\u0027 ,"},{"line_number":130,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":131,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":132,"context_line":"  $rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_90daa6e8","line":129,"updated":"2015-12-09 17:00:28.000000000","message":"whitespace","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d2aba7913e0d7b0d44afef0d4225797e2ebcd2f1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  $rgw_user \u003d \u0027root\u0027 ,"},{"line_number":130,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":131,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":132,"context_line":"  $rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027,"},{"line_number":133,"context_line":") {"},{"line_number":134,"context_line":"  validate_hash($client_keys)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_d1b4b083","line":132,"updated":"2015-12-09 18:23:32.000000000","message":"it seems like this is not a good default, shouldn\u0027t this be cased in? (see comment on rgw)","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   the repo by yourself."},{"line_number":92,"context_line":"#   Optional. Defaults to true"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*enable_rgw*] boolean to eanble the configuration of radosgw on the controller"},{"line_number":95,"context_line":"#   Default to false"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*rgw_user*] the user ID radosgw should run as"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_5fa5fc01","line":94,"updated":"2016-01-12 19:14:09.000000000","message":"s/eanble/enable/","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   the repo by yourself."},{"line_number":92,"context_line":"#   Optional. Defaults to true"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*enable_rgw*] boolean to eanble the configuration of radosgw on the controller"},{"line_number":95,"context_line":"#   Default to false"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*rgw_user*] the user ID radosgw should run as"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_c592729f","line":94,"in_reply_to":"da6ed579_5fa5fc01","updated":"2016-01-16 16:09:54.000000000","message":"Done","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":92,"context_line":"#   Optional. Defaults to true"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*enable_rgw*] boolean to eanble the configuration of radosgw on the controller"},{"line_number":95,"context_line":"#   Default to false"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*rgw_user*] the user ID radosgw should run as"},{"line_number":98,"context_line":"#   Default to root"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_df900c98","line":95,"updated":"2016-01-12 19:14:09.000000000","message":"Can you use the same format as the other parameter documentation ?\nI.E., \"Optional. Defaults to false\" like $manage_repo. Same for other params below.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"#   Optional. Defaults to true"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*enable_rgw*] boolean to eanble the configuration of radosgw on the controller"},{"line_number":95,"context_line":"#   Default to false"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*rgw_user*] the user ID radosgw should run as"},{"line_number":98,"context_line":"#   Default to root"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_e5f3f608","line":95,"in_reply_to":"da6ed579_df900c98","updated":"2016-01-16 16:09:54.000000000","message":"I think I did it the same.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":103,"context_line":"# [*frontend_type*] what kind of HTTPD front is to use"},{"line_number":104,"context_line":"#   Default is apache Option: civetweb"},{"line_number":105,"context_line":"#"},{"line_number":106,"context_line":"# [*rgw_frontends*] additonal arguements to the HTTPD front end."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class ceph::profile::params ("}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_df1a4c17","line":106,"updated":"2016-01-12 19:14:09.000000000","message":"s/arguements/arguments/ but see my comment about argument name in manifests/rgw.pp","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"# [*frontend_type*] what kind of HTTPD front is to use"},{"line_number":104,"context_line":"#   Default is apache Option: civetweb"},{"line_number":105,"context_line":"#"},{"line_number":106,"context_line":"# [*rgw_frontends*] additonal arguements to the HTTPD front end."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class ceph::profile::params ("}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_c5d91285","line":106,"in_reply_to":"da6ed579_df1a4c17","updated":"2016-01-16 16:09:54.000000000","message":"Done","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"69214f26ad06acc155627300b99e13b667d95b3c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":130,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":131,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":132,"context_line":"  $rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027,"},{"line_number":133,"context_line":") {"},{"line_number":134,"context_line":"  validate_hash($client_keys)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_1a90e942","line":132,"range":{"start_line":132,"start_character":3,"end_line":132,"end_character":38},"updated":"2016-01-12 23:24:50.000000000","message":"+1\n\nthis also shouldn\u0027t be a problem or force you to set additional params when using civetweb, as \u0027civetweb port\u003d7480\u0027 is the implicit default to my knowledge. so just specifying frontend_type \u003d \u0027civetweb\u0027 should deploy rgw with civetweb on port 7480.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":130,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":131,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":132,"context_line":"  $rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027,"},{"line_number":133,"context_line":") {"},{"line_number":134,"context_line":"  validate_hash($client_keys)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_5fe73ce4","line":132,"updated":"2016-01-12 19:14:09.000000000","message":"I think it\u0027s a bit awkward to default frontend_type to apache but rgw_frontends to civetweb config. Should rgw_frontends default to undef ?","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":130,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":131,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":132,"context_line":"  $rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027,"},{"line_number":133,"context_line":") {"},{"line_number":134,"context_line":"  validate_hash($client_keys)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_00eb98b1","line":132,"range":{"start_line":132,"start_character":3,"end_line":132,"end_character":38},"in_reply_to":"da6ed579_1a90e942","updated":"2016-01-16 16:09:54.000000000","message":"Correct. Aslo, I switched this to default to match the original default.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"c44abeb829e5d2a4b968578a7180b11de4b9449e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":130,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":131,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":132,"context_line":"  $rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027,"},{"line_number":133,"context_line":") {"},{"line_number":134,"context_line":"  validate_hash($client_keys)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_6891db46","line":132,"range":{"start_line":132,"start_character":3,"end_line":132,"end_character":38},"in_reply_to":"da6ed579_1a90e942","updated":"2016-01-13 23:25:50.000000000","message":"I also agree here, the value is implicitly brought back if you forgot to declare it so lets default it to undef","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":130,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":131,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":132,"context_line":"  $rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027,"},{"line_number":133,"context_line":") {"},{"line_number":134,"context_line":"  validate_hash($client_keys)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_c0c6e048","line":132,"in_reply_to":"da6ed579_5fe73ce4","updated":"2016-01-16 16:09:54.000000000","message":"This is a pibkac. It is supposed to be undef.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"e49356ec7f0ea5e547cd24f4c025044a576b3451","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   the repo by yourself."},{"line_number":92,"context_line":"#   Optional. Defaults to true"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*enable_rgw*] boolean to enable the installation and configuration of "},{"line_number":95,"context_line":"#   radosgw on the controller"},{"line_number":96,"context_line":"#   Optional. Default to false"},{"line_number":97,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a5ae5dd_1ad2b25c","line":94,"range":{"start_line":94,"start_character":72,"end_line":94,"end_character":73},"updated":"2016-02-06 17:08:09.000000000","message":"whitespace","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"06ac088ec83fcec6376a8c779a49b356f1b53c87","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   the repo by yourself."},{"line_number":92,"context_line":"#   Optional. Defaults to true"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*enable_rgw*] boolean to enable the installation and configuration of "},{"line_number":95,"context_line":"#   radosgw on the controller"},{"line_number":96,"context_line":"#   Optional. Default to false"},{"line_number":97,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a5ae5dd_e09284f5","line":94,"range":{"start_line":94,"start_character":72,"end_line":94,"end_character":73},"in_reply_to":"5a5ae5dd_1ad2b25c","updated":"2016-02-06 22:05:06.000000000","message":"Done","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8a20a7f33cc60e01e409557b81a5ec4eec91d170","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#   Optional. Defaults to true"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*enable_rgw*] boolean to enable the installation and configuration of"},{"line_number":98,"context_line":"#   radosgw on the controller"},{"line_number":99,"context_line":"#   Optional. Default to false"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"# [*rgw_user*] the user ID radosgw should run as."}],"source_content_type":"text/x-puppet","patch_set":60,"id":"bae84128_1a402d07","line":98,"range":{"start_line":98,"start_character":19,"end_line":98,"end_character":29},"updated":"2016-02-24 19:10:14.000000000","message":"nit: should this be node?","commit_id":"6dbb1bc9001673c9065cd59d17df9b1fb3e3d250"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c579f7119e135e6b6169ecdd017e87c3fd02525","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#   Optional. Defaults to true"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*enable_rgw*] boolean to enable the installation and configuration of"},{"line_number":98,"context_line":"#   radosgw on the controller"},{"line_number":99,"context_line":"#   Optional. Default to false"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"# [*rgw_user*] the user ID radosgw should run as."}],"source_content_type":"text/x-puppet","patch_set":60,"id":"bae84128_9b4a7cab","line":98,"range":{"start_line":98,"start_character":19,"end_line":98,"end_character":29},"in_reply_to":"bae84128_1a402d07","updated":"2016-02-24 21:01:05.000000000","message":"It could node or server. I used controller because I planned this change for deploy rgw on a osp controller.","commit_id":"6dbb1bc9001673c9065cd59d17df9b1fb3e3d250"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a841cbd8bda796828a91942ebf721f5682051a6d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"#  Optional. Default to false"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*frontend_type*] what kind of HTTPD front is to use"},{"line_number":108,"context_line":"#   Optional. Default to apache Option: civetweb"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*rgw_frontends*] additonal arguments to the HTTPD front end."},{"line_number":111,"context_line":"#   Optional. Default to undef"}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_27a059f4","line":108,"range":{"start_line":108,"start_character":25,"end_line":108,"end_character":31},"updated":"2016-02-26 08:30:09.000000000","message":"apache-fastcgi","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a841cbd8bda796828a91942ebf721f5682051a6d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"#  Optional. Default to false"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*frontend_type*] what kind of HTTPD front is to use"},{"line_number":108,"context_line":"#   Optional. Default to apache Option: civetweb"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*rgw_frontends*] additonal arguments to the HTTPD front end."},{"line_number":111,"context_line":"#   Optional. Default to undef"}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_07ba7523","line":108,"range":{"start_line":108,"start_character":40,"end_line":108,"end_character":48},"updated":"2016-02-26 08:30:09.000000000","message":"civetweb or apache-proxy-fastcgi","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c71e2c23401a223f2d2b0acdeefb078b6493ea4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"#  Optional. Default to false"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*frontend_type*] what kind of HTTPD front is to use"},{"line_number":108,"context_line":"#   Optional. Default to apache Option: civetweb"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*rgw_frontends*] additonal arguments to the HTTPD front end."},{"line_number":111,"context_line":"#   Optional. Default to undef"}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_7c52e714","line":108,"range":{"start_line":108,"start_character":40,"end_line":108,"end_character":48},"in_reply_to":"9aed3d3a_07ba7523","updated":"2016-02-26 11:59:57.000000000","message":"Done","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c71e2c23401a223f2d2b0acdeefb078b6493ea4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"#  Optional. Default to false"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*frontend_type*] what kind of HTTPD front is to use"},{"line_number":108,"context_line":"#   Optional. Default to apache Option: civetweb"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*rgw_frontends*] additonal arguments to the HTTPD front end."},{"line_number":111,"context_line":"#   Optional. Default to undef"}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_dc57b300","line":108,"range":{"start_line":108,"start_character":25,"end_line":108,"end_character":31},"in_reply_to":"9aed3d3a_27a059f4","updated":"2016-02-26 11:59:57.000000000","message":"Done","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a841cbd8bda796828a91942ebf721f5682051a6d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"#   Optional. Default to apache Option: civetweb"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*rgw_frontends*] additonal arguments to the HTTPD front end."},{"line_number":111,"context_line":"#   Optional. Default to undef"},{"line_number":112,"context_line":"#"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class ceph::profile::params ("}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_e75f910c","line":111,"range":{"start_line":111,"start_character":25,"end_line":111,"end_character":30},"updated":"2016-02-26 08:30:09.000000000","message":"fastcgi socket_port\u003d9000 socket_host\u003d127.0.0.1","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c71e2c23401a223f2d2b0acdeefb078b6493ea4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"#   Optional. Default to apache Option: civetweb"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*rgw_frontends*] additonal arguments to the HTTPD front end."},{"line_number":111,"context_line":"#   Optional. Default to undef"},{"line_number":112,"context_line":"#"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class ceph::profile::params ("}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_bc5c6f26","line":111,"range":{"start_line":111,"start_character":25,"end_line":111,"end_character":30},"in_reply_to":"9aed3d3a_e75f910c","updated":"2016-02-26 11:59:57.000000000","message":"Done","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a841cbd8bda796828a91942ebf721f5682051a6d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $enable_rgw \u003d false,"},{"line_number":134,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":135,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":136,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":137,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":138,"context_line":") {"},{"line_number":139,"context_line":"  validate_hash($client_keys)"}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_076395dd","line":136,"range":{"start_line":136,"start_character":20,"end_line":136,"end_character":26},"updated":"2016-02-26 08:30:09.000000000","message":"apachi-fastcgi","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c71e2c23401a223f2d2b0acdeefb078b6493ea4","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $enable_rgw \u003d false,"},{"line_number":134,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":135,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":136,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":137,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":138,"context_line":") {"},{"line_number":139,"context_line":"  validate_hash($client_keys)"}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_bccf4faf","line":136,"range":{"start_line":136,"start_character":20,"end_line":136,"end_character":26},"in_reply_to":"9aed3d3a_076395dd","updated":"2016-02-26 11:59:57.000000000","message":"Done","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a841cbd8bda796828a91942ebf721f5682051a6d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":135,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":136,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":137,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":138,"context_line":") {"},{"line_number":139,"context_line":"  validate_hash($client_keys)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_a76589e2","line":137,"range":{"start_line":137,"start_character":19,"end_line":137,"end_character":24},"updated":"2016-02-26 08:30:09.000000000","message":"fastcgi socket_port\u003d9000 socket_host\u003d127.0.0.1","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c71e2c23401a223f2d2b0acdeefb078b6493ea4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  $rgw_user \u003d \u0027root\u0027,"},{"line_number":135,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":136,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":137,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":138,"context_line":") {"},{"line_number":139,"context_line":"  validate_hash($client_keys)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_fcc1d781","line":137,"range":{"start_line":137,"start_character":19,"end_line":137,"end_character":24},"in_reply_to":"9aed3d3a_a76589e2","updated":"2016-02-26 11:59:57.000000000","message":"Done","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"}],"manifests/profile/rgw.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d2aba7913e0d7b0d44afef0d4225797e2ebcd2f1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ceph::rgw { \u0027radosgw.gateway\u0027:"},{"line_number":11,"context_line":"      user          \u003d\u003e $ceph::profile::params::rgw_user,"},{"line_number":12,"context_line":"      rgw_frontends \u003d\u003e $ceph::profile::params::rgw_frontends ,"},{"line_number":13,"context_line":"      frontend_type \u003d\u003e $ceph::profile::params::frontend_type ,"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_43623318","line":13,"updated":"2015-12-09 18:23:32.000000000","message":"please pass the rest of the profile options for rgw","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Define: ceph::profile::rgw"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Profile for Ceph rgw"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a68dd71_e7a6ec0d","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":31},"updated":"2016-01-25 22:50:18.000000000","message":"Please put a complete license/copyright header.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Define: ceph::profile::rgw"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Profile for Ceph rgw"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"7a5de9d1_79c7cf12","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":31},"in_reply_to":"9a68dd71_e7a6ec0d","updated":"2016-01-27 21:05:38.000000000","message":"Done","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"e49356ec7f0ea5e547cd24f4c025044a576b3451","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#  Copyright (C) 2014 Nine Internet Solutions AG"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a5ae5dd_b56cd135","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":48},"updated":"2016-02-06 17:08:09.000000000","message":"2016 Keith Schincke","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"06ac088ec83fcec6376a8c779a49b356f1b53c87","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#  Copyright (C) 2014 Nine Internet Solutions AG"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a5ae5dd_a0bfac5f","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":48},"in_reply_to":"5a5ae5dd_b56cd135","updated":"2016-02-06 22:05:06.000000000","message":"Done","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"e49356ec7f0ea5e547cd24f4c025044a576b3451","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Author: Keith Schincke \u003ckeith.schincke@gmail.com.\u003e"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# \u003d\u003d Define: ceph::profile::rgw"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# Profile for Ceph rgw"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a5ae5dd_facc76bc","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":11},"updated":"2016-02-06 17:08:09.000000000","message":"It\u0027s a class","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"06ac088ec83fcec6376a8c779a49b356f1b53c87","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Author: Keith Schincke \u003ckeith.schincke@gmail.com.\u003e"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# \u003d\u003d Define: ceph::profile::rgw"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# Profile for Ceph rgw"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a5ae5dd_c0c2e8e8","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":11},"in_reply_to":"5a5ae5dd_facc76bc","updated":"2016-02-06 22:05:06.000000000","message":"Done","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"0be962f9993cc0e72580914ca971c68907a0463c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      log_file           \u003d\u003e \u0027/var/log/ceph/radosgw.log\u0027,"},{"line_number":33,"context_line":"      rgw_dns_name       \u003d\u003e $::fqdn,"},{"line_number":34,"context_line":"      rgw_socket_path    \u003d\u003e $::ceph::params::rgw_socket_path,"},{"line_number":35,"context_line":"      rgw_print_continue \u003d\u003e false,"},{"line_number":36,"context_line":"      rgw_port           \u003d\u003e undef,"},{"line_number":37,"context_line":"      syslog             \u003d\u003e true,"},{"line_number":38,"context_line":"      rgw_frontend_type  \u003d\u003e $ceph::profile::params::rgw_frontend_type,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_3faab01a","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":33},"updated":"2016-02-09 21:38:04.000000000","message":"it was added to params, use it\u0027s value","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f519cb7b290fb017a6f0ea0f47f4f0ce69c3af61","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      log_file           \u003d\u003e \u0027/var/log/ceph/radosgw.log\u0027,"},{"line_number":33,"context_line":"      rgw_dns_name       \u003d\u003e $::fqdn,"},{"line_number":34,"context_line":"      rgw_socket_path    \u003d\u003e $::ceph::params::rgw_socket_path,"},{"line_number":35,"context_line":"      rgw_print_continue \u003d\u003e false,"},{"line_number":36,"context_line":"      rgw_port           \u003d\u003e undef,"},{"line_number":37,"context_line":"      syslog             \u003d\u003e true,"},{"line_number":38,"context_line":"      rgw_frontend_type  \u003d\u003e $ceph::profile::params::rgw_frontend_type,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_43ec59c7","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":33},"in_reply_to":"3a57f1b5_3faab01a","updated":"2016-02-10 22:02:27.000000000","message":"Done","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"}],"manifests/rgw.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d2aba7913e0d7b0d44afef0d4225797e2ebcd2f1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#   Optional. Default is apache. Other option is civetweb"},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*rgw_frontends*] Arguments to the rgw frontend"},{"line_number":61,"context_line":"#   Optional. Default is \"civetweb port\u003d7480\""},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"define ceph::rgw ("},{"line_number":64,"context_line":"  $pkg_radosgw \u003d $::ceph::params::pkg_radosgw,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_83bd7b04","line":61,"updated":"2015-12-09 18:23:32.000000000","message":"if this value is only correct for civetweb, and the default is apache, the default should be blank, you can use a variable to auto-populate the value if its not explicitly set in the body below","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d2aba7913e0d7b0d44afef0d4225797e2ebcd2f1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $rgw_port \u003d undef,"},{"line_number":73,"context_line":"  $syslog \u003d true,"},{"line_number":74,"context_line":"  $frontend_type \u003d $::ceph::params::frontend_type,"},{"line_number":75,"context_line":"  $rgw_frontends \u003d $::ceph::params::rgw_frontends,"},{"line_number":76,"context_line":") {"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  ceph_config {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_e39f9f4e","line":75,"updated":"2015-12-09 18:23:32.000000000","message":"this wasn\u0027t added to ceph::params, it was added to ceph::profile::params","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d2aba7913e0d7b0d44afef0d4225797e2ebcd2f1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      \"client.${name}/rgw_frontends\":      value \u003d\u003e $rgw_frontends;"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  package { $pkg_radosgw:"},{"line_number":103,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":104,"context_line":"    tag    \u003d\u003e \u0027ceph\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_838fbb74","line":101,"updated":"2015-12-09 18:23:32.000000000","message":"switch to if, elseif, else. Have else fail on un-supported frontend_type","commit_id":"8c7e78bd95c54ce099e27c68ffa8d9267f6bc282"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  $syslog \u003d true,"},{"line_number":74,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":75,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":76,"context_line":") {"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  ceph_config {"},{"line_number":79,"context_line":"    \"client.${name}/host\":               value \u003d\u003e $::hostname;"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_ffc5d05a","line":76,"updated":"2016-01-12 19:14:09.000000000","message":"I think the variables frontend_type and rgw_frontends could be better named to represent what they are. What do you think about $rgw_frontend and $rgw_frontend_args ?","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"c44abeb829e5d2a4b968578a7180b11de4b9449e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  $syslog \u003d true,"},{"line_number":74,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":75,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":76,"context_line":") {"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  ceph_config {"},{"line_number":79,"context_line":"    \"client.${name}/host\":               value \u003d\u003e $::hostname;"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_28ae8381","line":76,"in_reply_to":"da6ed579_9a97f98f","updated":"2016-01-13 23:25:50.000000000","message":"This is fine (I am annoyed with ceph\u0027s name though)","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  $syslog \u003d true,"},{"line_number":74,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":75,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":76,"context_line":") {"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  ceph_config {"},{"line_number":79,"context_line":"    \"client.${name}/host\":               value \u003d\u003e $::hostname;"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_e93636e6","line":76,"in_reply_to":"da6ed579_9a97f98f","updated":"2016-01-16 16:09:54.000000000","message":"kept rgw_frontends. Prpended \"rgw_\" to the other.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"69214f26ad06acc155627300b99e13b667d95b3c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  $syslog \u003d true,"},{"line_number":74,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":75,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":76,"context_line":") {"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  ceph_config {"},{"line_number":79,"context_line":"    \"client.${name}/host\":               value \u003d\u003e $::hostname;"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_9a97f98f","line":76,"in_reply_to":"da6ed579_ffc5d05a","updated":"2016-01-12 23:24:50.000000000","message":"I like the parameters as the are as rgw_frontends is what the actual parameter is named in ceph.conf","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  $syslog \u003d true,"},{"line_number":74,"context_line":"  $frontend_type \u003d \u0027apache\u0027,"},{"line_number":75,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":76,"context_line":") {"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  ceph_config {"},{"line_number":79,"context_line":"    \"client.${name}/host\":               value \u003d\u003e $::hostname;"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_0e139067","line":76,"in_reply_to":"da6ed579_ffc5d05a","updated":"2016-01-16 16:09:54.000000000","message":"renamed frontend_type to rgw_frontend_type. \nKept rgw_frontends as it is the ceph.conf parameter.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  #for RHEL/CentOS7, systemctl needs to reload to pickup the ceph-radosgw init file"},{"line_number":161,"context_line":"  if (($::operatingsystem \u003d\u003d \u0027RedHat\u0027 or $::operatingsystem \u003d\u003d \u0027CentOS\u0027) and (versioncmp($::operatingsystemmajrelease, \u00277\u0027) \u003e\u003d 0))"},{"line_number":162,"context_line":"  {"},{"line_number":163,"context_line":"    exec { \u0027systemctl-reload-from-rgw\u0027: #needed for the new init file"},{"line_number":164,"context_line":"      command \u003d\u003e \u0027/usr/bin/systemctl daemon-reload\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_5f82dc01","line":161,"updated":"2016-01-12 19:14:09.000000000","message":"I\u0027m surprised this is necessary, should this not be handled by packaging upstream ? Is this a bug ?","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  #for RHEL/CentOS7, systemctl needs to reload to pickup the ceph-radosgw init file"},{"line_number":161,"context_line":"  if (($::operatingsystem \u003d\u003d \u0027RedHat\u0027 or $::operatingsystem \u003d\u003d \u0027CentOS\u0027) and (versioncmp($::operatingsystemmajrelease, \u00277\u0027) \u003e\u003d 0))"},{"line_number":162,"context_line":"  {"},{"line_number":163,"context_line":"    exec { \u0027systemctl-reload-from-rgw\u0027: #needed for the new init file"},{"line_number":164,"context_line":"      command \u003d\u003e \u0027/usr/bin/systemctl daemon-reload\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_f3ab89d4","line":161,"in_reply_to":"da6ed579_5f82dc01","updated":"2016-01-16 16:09:54.000000000","message":"This is the only reference I find to this issue. They fixed it in the documentation but the links in the BZ are invalid. \nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1203098","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a2e7b020b50f3f00b1c8a32f231c71cba5fd0443","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  # Log file for radosgw (ownership)"},{"line_number":123,"context_line":"  file { \u0027/var/log/ceph\u0027:"},{"line_number":124,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":125,"context_line":"    mode   \u003d\u003e \u00270755\u0027,"},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":"  file { $log_file:"},{"line_number":128,"context_line":"    ensure \u003d\u003e present,"},{"line_number":129,"context_line":"    owner  \u003d\u003e $user,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a5ae5dd_54ae7ae8","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":3},"updated":"2016-02-09 00:04:38.000000000","message":"this might not be necessary, see my commit below.","commit_id":"262020e9a41b1e9c02e0f89463efceb8c4f59a6a"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a2e7b020b50f3f00b1c8a32f231c71cba5fd0443","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  }"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"  Ceph_config\u003c||\u003e -\u003e Service[\"radosgw-${name}\"]"},{"line_number":176,"context_line":"  Package\u003c| tag \u003d\u003d \u0027ceph\u0027 |\u003e -\u003e File[\u0027/var/lib/ceph/radosgw\u0027]"},{"line_number":177,"context_line":"  File[\u0027/var/lib/ceph/radosgw\u0027]"},{"line_number":178,"context_line":"  -\u003e File[$rgw_data]"},{"line_number":179,"context_line":"  -\u003e Service[\"radosgw-${name}\"]"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a5ae5dd_9455d2fb","line":176,"range":{"start_line":176,"start_character":2,"end_line":176,"end_character":61},"updated":"2016-02-09 00:04:38.000000000","message":"I think there should be an additional line here:\nPackage\u003c| tag \u003d\u003d \u0027ceph\u0027 |\u003e -\u003e File[$log_file]\n\nSeems I broke this with a previous commit, sorry!","commit_id":"262020e9a41b1e9c02e0f89463efceb8c4f59a6a"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"0be962f9993cc0e72580914ca971c68907a0463c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  if ($rgw_frontend_type \u003d\u003d \u0027apache\u0027)"},{"line_number":86,"context_line":"  {"},{"line_number":87,"context_line":"    ceph_config {"},{"line_number":88,"context_line":"      \"client.${name}/rgw_dns_name\":       value \u003d\u003e $rgw_dns_name;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_bf40e008","line":85,"updated":"2016-02-09 21:38:04.000000000","message":"please update the define spec to cover apache and civetweb cases. This might also fix failures in http://logs.openstack.org/48/254548/23/check/gate-puppet-ceph-puppet-unit-latest-dsvm-centos7/6cb177b/","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f519cb7b290fb017a6f0ea0f47f4f0ce69c3af61","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  if ($rgw_frontend_type \u003d\u003d \u0027apache\u0027)"},{"line_number":86,"context_line":"  {"},{"line_number":87,"context_line":"    ceph_config {"},{"line_number":88,"context_line":"      \"client.${name}/rgw_dns_name\":       value \u003d\u003e $rgw_dns_name;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_1d13fc0e","line":85,"in_reply_to":"3a57f1b5_bf40e008","updated":"2016-02-10 22:02:27.000000000","message":"I am working on the define spec.","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"0be962f9993cc0e72580914ca971c68907a0463c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  # Log file for radosgw (ownership)"},{"line_number":123,"context_line":"#  file { \u0027/var/log/ceph\u0027:"},{"line_number":124,"context_line":"#    ensure \u003d\u003e directory,"},{"line_number":125,"context_line":"#    mode   \u003d\u003e \u00270755\u0027,"},{"line_number":126,"context_line":"#  }"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_df459c17","line":123,"updated":"2016-02-09 21:38:04.000000000","message":"drop commented code","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f519cb7b290fb017a6f0ea0f47f4f0ce69c3af61","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  # Log file for radosgw (ownership)"},{"line_number":123,"context_line":"#  file { \u0027/var/log/ceph\u0027:"},{"line_number":124,"context_line":"#    ensure \u003d\u003e directory,"},{"line_number":125,"context_line":"#    mode   \u003d\u003e \u00270755\u0027,"},{"line_number":126,"context_line":"#  }"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_3dbb58e7","line":123,"in_reply_to":"3a57f1b5_df459c17","updated":"2016-02-10 22:02:27.000000000","message":"Done","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8a20a7f33cc60e01e409557b81a5ec4eec91d170","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if ($rgw_frontend_type \u003d\u003d \u0027apache\u0027)"},{"line_number":95,"context_line":"  {"},{"line_number":96,"context_line":"    ceph_config {"},{"line_number":97,"context_line":"      \"client.${name}/rgw_dns_name\":       value \u003d\u003e $rgw_dns_name;"},{"line_number":98,"context_line":"      \"client.${name}/rgw_port\":           value \u003d\u003e $rgw_port;"},{"line_number":99,"context_line":"      \"client.${name}/rgw_print_continue\": value \u003d\u003e $rgw_print_continue;"},{"line_number":100,"context_line":"      \"client.${name}/rgw_socket_path\":    value \u003d\u003e $rgw_socket_path;"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":"  elsif ($rgw_frontend_type \u003d\u003d \u0027civetweb\u0027)"},{"line_number":104,"context_line":"  {"},{"line_number":105,"context_line":"    ceph::rgw::civetweb { \u0027radosgw.gateway\u0027:"},{"line_number":106,"context_line":"      rgw_frontends \u003d\u003e $rgw_frontends,"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"  }"},{"line_number":109,"context_line":"  else"},{"line_number":110,"context_line":"  {"},{"line_number":111,"context_line":"    fail(\"Unsupported rgw_frontend_type: ${rgw_frontend_type}\")"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  package { $pkg_radosgw:"},{"line_number":115,"context_line":"    ensure \u003d\u003e installed,"}],"source_content_type":"text/x-puppet","patch_set":60,"id":"bae84128_7a3059e9","line":112,"range":{"start_line":94,"start_character":0,"end_line":112,"end_character":3},"updated":"2016-02-24 19:10:14.000000000","message":"We should have rgw/apache.pp (doesn\u0027t exist) and rgw/civetweb should set these. That way we don\u0027t need to case in other types, they do it themselves.\n\nwe then either have them call rgw.pp or make rgw.pp include them based on front-end type\n\nThis can be addressed with a follow up commit","commit_id":"6dbb1bc9001673c9065cd59d17df9b1fb3e3d250"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c579f7119e135e6b6169ecdd017e87c3fd02525","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if ($rgw_frontend_type \u003d\u003d \u0027apache\u0027)"},{"line_number":95,"context_line":"  {"},{"line_number":96,"context_line":"    ceph_config {"},{"line_number":97,"context_line":"      \"client.${name}/rgw_dns_name\":       value \u003d\u003e $rgw_dns_name;"},{"line_number":98,"context_line":"      \"client.${name}/rgw_port\":           value \u003d\u003e $rgw_port;"},{"line_number":99,"context_line":"      \"client.${name}/rgw_print_continue\": value \u003d\u003e $rgw_print_continue;"},{"line_number":100,"context_line":"      \"client.${name}/rgw_socket_path\":    value \u003d\u003e $rgw_socket_path;"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":"  elsif ($rgw_frontend_type \u003d\u003d \u0027civetweb\u0027)"},{"line_number":104,"context_line":"  {"},{"line_number":105,"context_line":"    ceph::rgw::civetweb { \u0027radosgw.gateway\u0027:"},{"line_number":106,"context_line":"      rgw_frontends \u003d\u003e $rgw_frontends,"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"  }"},{"line_number":109,"context_line":"  else"},{"line_number":110,"context_line":"  {"},{"line_number":111,"context_line":"    fail(\"Unsupported rgw_frontend_type: ${rgw_frontend_type}\")"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  package { $pkg_radosgw:"},{"line_number":115,"context_line":"    ensure \u003d\u003e installed,"}],"source_content_type":"text/x-puppet","patch_set":60,"id":"bae84128_6aaec8e8","line":112,"range":{"start_line":94,"start_character":0,"end_line":112,"end_character":3},"in_reply_to":"bae84128_7a3059e9","updated":"2016-02-24 21:01:05.000000000","message":"ceph::rgw::apache exists and is used to configure Apache vhost and fcgi to interface with rgw. Would it muddle things if the ceph rgw and apache config operations occur in the same class?","commit_id":"6dbb1bc9001673c9065cd59d17df9b1fb3e3d250"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a841cbd8bda796828a91942ebf721f5682051a6d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#   Optional. Default is true."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [*frontend_type*] What type of frontend to use"},{"line_number":71,"context_line":"#   Optional. Default is apache. Other option is civetweb"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*rgw_frontends*] Arguments to the rgw frontend"},{"line_number":74,"context_line":"#   Optional. Default is undef. Example: \"civetweb port\u003d7480\""}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_d73057a1","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":31},"updated":"2016-02-26 08:30:09.000000000","message":"apache-fastcgi","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c71e2c23401a223f2d2b0acdeefb078b6493ea4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#   Optional. Default is true."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [*frontend_type*] What type of frontend to use"},{"line_number":71,"context_line":"#   Optional. Default is apache. Other option is civetweb"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*rgw_frontends*] Arguments to the rgw frontend"},{"line_number":74,"context_line":"#   Optional. Default is undef. Example: \"civetweb port\u003d7480\""}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_7c794793","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":31},"in_reply_to":"9aed3d3a_d73057a1","updated":"2016-02-26 11:59:57.000000000","message":"Done","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a841cbd8bda796828a91942ebf721f5682051a6d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#   Optional. Default is apache. Other option is civetweb"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*rgw_frontends*] Arguments to the rgw frontend"},{"line_number":74,"context_line":"#   Optional. Default is undef. Example: \"civetweb port\u003d7480\""},{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"define ceph::rgw ("},{"line_number":77,"context_line":"  $pkg_radosgw        \u003d $::ceph::params::pkg_radosgw,"}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_571d670e","line":74,"range":{"start_line":74,"start_character":25,"end_line":74,"end_character":30},"updated":"2016-02-26 08:30:09.000000000","message":"fastcgi socket_port\u003d9000 socket_host\u003d127.0.0.1","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c71e2c23401a223f2d2b0acdeefb078b6493ea4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#   Optional. Default is apache. Other option is civetweb"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*rgw_frontends*] Arguments to the rgw frontend"},{"line_number":74,"context_line":"#   Optional. Default is undef. Example: \"civetweb port\u003d7480\""},{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"define ceph::rgw ("},{"line_number":77,"context_line":"  $pkg_radosgw        \u003d $::ceph::params::pkg_radosgw,"}],"source_content_type":"text/x-puppet","patch_set":64,"id":"9aed3d3a_fc6557e1","line":74,"range":{"start_line":74,"start_character":25,"end_line":74,"end_character":30},"in_reply_to":"9aed3d3a_571d670e","updated":"2016-02-26 11:59:57.000000000","message":"Done","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"}],"manifests/rgw/civetweb.pp":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"  else"},{"line_number":18,"context_line":"  {"},{"line_number":19,"context_line":"    $apply_rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ceph_config {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_df4eccc0","line":19,"updated":"2016-01-12 19:14:09.000000000","message":"We should probably just default $rgw_frontends to \u0027civetweb port\u003d7480\u0027 and get rid of that if.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"69214f26ad06acc155627300b99e13b667d95b3c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":11,"context_line":") {"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  if( $rgw_frontends )"},{"line_number":14,"context_line":"  {"},{"line_number":15,"context_line":"    $apply_rgw_frontends \u003d $rgw_frontends"},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"  else"},{"line_number":18,"context_line":"  {"},{"line_number":19,"context_line":"    $apply_rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ceph_config {"},{"line_number":23,"context_line":"    \"client.${name}/rgw_frontends\":      value \u003d\u003e $apply_rgw_frontends;"},{"line_number":24,"context_line":"  }"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_3a9fedb5","line":24,"range":{"start_line":13,"start_character":1,"end_line":24,"end_character":3},"updated":"2016-01-12 23:24:50.000000000","message":"civetweb port\u003d7480 is the implicit default, so not setting anything has the same effect and is in my view the cleaner solution as well.\n\nSo I would recommend something like\n\nif $rgw_frontends {\n   ceph_config {\n    \"client.${name}/rgw_frontends\": value \u003d\u003e $rgw_frontends;\n  }\n}","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":11,"context_line":") {"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  if( $rgw_frontends )"},{"line_number":14,"context_line":"  {"},{"line_number":15,"context_line":"    $apply_rgw_frontends \u003d $rgw_frontends"},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"  else"},{"line_number":18,"context_line":"  {"},{"line_number":19,"context_line":"    $apply_rgw_frontends \u003d \u0027civetweb port\u003d7480\u0027"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ceph_config {"},{"line_number":23,"context_line":"    \"client.${name}/rgw_frontends\":      value \u003d\u003e $apply_rgw_frontends;"},{"line_number":24,"context_line":"  }"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_c0c0207f","line":24,"range":{"start_line":13,"start_character":1,"end_line":24,"end_character":3},"in_reply_to":"da6ed579_3a9fedb5","updated":"2016-01-16 16:09:54.000000000","message":"This is a much better solution. Old habits in new programming.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Author: Keith Schincke \u003ckeith.schincke@gmail.com.\u003e"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configures a ceph radosgw using civetweb."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a68dd71_876b70b6","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":52},"updated":"2016-01-25 22:50:18.000000000","message":"Please put a complete license header and copyright information.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Author: Keith Schincke \u003ckeith.schincke@gmail.com.\u003e"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configures a ceph radosgw using civetweb."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"7a5de9d1_b9778701","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":52},"in_reply_to":"9a68dd71_876b70b6","updated":"2016-01-27 21:05:38.000000000","message":"Done","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"e49356ec7f0ea5e547cd24f4c025044a576b3451","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#  Copyright (C) 2014 Nine Internet Solutions AG"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a5ae5dd_d5094d85","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":48},"updated":"2016-02-06 17:08:09.000000000","message":"2016 Keith Schincke","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"06ac088ec83fcec6376a8c779a49b356f1b53c87","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#  Copyright (C) 2014 Nine Internet Solutions AG"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a5ae5dd_0001e005","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":48},"in_reply_to":"5a5ae5dd_d5094d85","updated":"2016-02-06 22:05:06.000000000","message":"Done","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"0be962f9993cc0e72580914ca971c68907a0463c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*rgw_frontends*] Arguments to the rgw frontend"},{"line_number":22,"context_line":"#   Optional. Default is undef. Examp: \"civetweb port\u003d7480\""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"define ceph::rgw::civetweb ("},{"line_number":25,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":"  if( $rgw_frontends )"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_9fac04ef","line":24,"updated":"2016-02-09 21:38:04.000000000","message":"please add define spec tests","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f519cb7b290fb017a6f0ea0f47f4f0ce69c3af61","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*rgw_frontends*] Arguments to the rgw frontend"},{"line_number":22,"context_line":"#   Optional. Default is undef. Examp: \"civetweb port\u003d7480\""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"define ceph::rgw::civetweb ("},{"line_number":25,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":"  if( $rgw_frontends )"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_1daf7c95","line":24,"in_reply_to":"3a57f1b5_9fac04ef","updated":"2016-02-10 22:02:27.000000000","message":"I am working on the define spec tests.","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"0be962f9993cc0e72580914ca971c68907a0463c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"define ceph::rgw::civetweb ("},{"line_number":25,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":"  if( $rgw_frontends )"},{"line_number":28,"context_line":"  {"},{"line_number":29,"context_line":"    ceph_config {"},{"line_number":30,"context_line":"      \"client.${name}/rgw_frontends\": value \u003d\u003e $rgw_frontends;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_3f62b0d9","line":27,"updated":"2016-02-09 21:38:04.000000000","message":"no need to \u0027if\u0027 it in, undef to a inifile means don\u0027t do anything","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f519cb7b290fb017a6f0ea0f47f4f0ce69c3af61","unresolved":false,"context_lines":[{"line_number":24,"context_line":"define ceph::rgw::civetweb ("},{"line_number":25,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":"  if( $rgw_frontends )"},{"line_number":28,"context_line":"  {"},{"line_number":29,"context_line":"    ceph_config {"},{"line_number":30,"context_line":"      \"client.${name}/rgw_frontends\": value \u003d\u003e $rgw_frontends;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_bdcbc852","line":27,"in_reply_to":"3a57f1b5_3f62b0d9","updated":"2016-02-10 22:02:27.000000000","message":"will it add \"rgw_frontends \u003d undef\" to the file or no line at all?","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"19c470f0968f3942722dfae1afe382b87edbd191","unresolved":false,"context_lines":[{"line_number":24,"context_line":"define ceph::rgw::civetweb ("},{"line_number":25,"context_line":"  $rgw_frontends \u003d undef,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":"  if( $rgw_frontends )"},{"line_number":28,"context_line":"  {"},{"line_number":29,"context_line":"    ceph_config {"},{"line_number":30,"context_line":"      \"client.${name}/rgw_frontends\": value \u003d\u003e $rgw_frontends;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a57f1b5_1e1bf31c","line":27,"in_reply_to":"3a57f1b5_bdcbc852","updated":"2016-02-10 22:36:09.000000000","message":"passing puppet `undef` type will result in the value being ignored in the underlying file. Its useful as we can just pass it and it won\u0027t do anything if it\u0027s not initialized to another value","commit_id":"a6c891fe01c5b539f9caf4af4cc58a195bebc002"}],"spec/acceptance/ceph_rgw_civet_spec.rb":[{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"69214f26ad06acc155627300b99e13b667d95b3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#  Copyright (C) 2015 David Gurtner"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#  Author: David Gurtner \u003caldavud@crimson.ch\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_5a0421bf","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":45},"updated":"2016-01-12 23:24:50.000000000","message":"you wrote this, not me ;)","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#  Copyright (C) 2015 David Gurtner"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#  Author: David Gurtner \u003caldavud@crimson.ch\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_e55a1683","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":45},"in_reply_to":"da6ed579_5a0421bf","updated":"2016-01-16 16:09:54.000000000","message":"Guilty. I added my name/info and added a \"forked from\" notation.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"69214f26ad06acc155627300b99e13b667d95b3c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"describe \u0027ceph rgw/civetweb\u0027 do"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  release \u003d \u0027hammer\u0027"},{"line_number":23,"context_line":"  fsid \u003d \u0027a4807c9a-e76f-4666-a297-6d6cbc922e3a\u0027"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_7a680588","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":27},"updated":"2016-01-12 23:24:50.000000000","message":"why not move everything below into spec/acceptance/ceph_rgw_spec.rb below (or above) ceph::rgw::keystone? This way all the rgw tests are bundled together.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"c44abeb829e5d2a4b968578a7180b11de4b9449e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"describe \u0027ceph rgw/civetweb\u0027 do"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  release \u003d \u0027hammer\u0027"},{"line_number":23,"context_line":"  fsid \u003d \u0027a4807c9a-e76f-4666-a297-6d6cbc922e3a\u0027"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_53292c36","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":27},"in_reply_to":"da6ed579_7a680588","updated":"2016-01-13 23:25:50.000000000","message":"I like them being separate test sets as the fastcgi install is quite often broken, I guess some work needs to go into reducing duplication between the two, but I don\u0027t think that\u0027s necessary at this point","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"describe \u0027ceph rgw/civetweb\u0027 do"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  release \u003d \u0027hammer\u0027"},{"line_number":23,"context_line":"  fsid \u003d \u0027a4807c9a-e76f-4666-a297-6d6cbc922e3a\u0027"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_a5273e11","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":27},"in_reply_to":"da6ed579_7a680588","updated":"2016-01-16 16:09:54.000000000","message":"This is the goal. After I am finished with this patch I will work on getting rgw::keystone working on RHEL/CentOS. Then will be a good time to get a grand unified test suite.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"69214f26ad06acc155627300b99e13b667d95b3c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  test_password \u003d \u0027123456\u0027"},{"line_number":32,"context_line":"  test_email \u003d \u0027testuser@example.com\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  describe \u0027ceph::rgw::bulit-in\u0027 do"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    it \u0027should install one monitor/osd with a rgw/civetweb\u0027 do"},{"line_number":37,"context_line":"      pp \u003d \u003c\u003c-EOS"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_ba475d1c","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":31},"updated":"2016-01-12 23:24:50.000000000","message":"can you name this ceph::rgw::civetweb like te class you\u0027re testing?","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  test_password \u003d \u0027123456\u0027"},{"line_number":32,"context_line":"  test_email \u003d \u0027testuser@example.com\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  describe \u0027ceph::rgw::bulit-in\u0027 do"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    it \u0027should install one monitor/osd with a rgw/civetweb\u0027 do"},{"line_number":37,"context_line":"      pp \u003d \u003c\u003c-EOS"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_c59fd24e","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":31},"in_reply_to":"da6ed579_ba475d1c","updated":"2016-01-16 16:09:54.000000000","message":"Updated. The original name was to differentiate it from the rgw keystone test.","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    it \u0027should install one monitor/osd with a rgw/civetweb\u0027 do"},{"line_number":37,"context_line":"      pp \u003d \u003c\u003c-EOS"},{"line_number":38,"context_line":"        $user \u003d \u0027root\u0027"},{"line_number":39,"context_line":"        "},{"line_number":40,"context_line":"        case $::osfamily {"},{"line_number":41,"context_line":"          \u0027Debian\u0027: {"},{"line_number":42,"context_line":"            include ::apt"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_bfc198e6","line":39,"updated":"2016-01-12 19:14:09.000000000","message":"whitespace","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    it \u0027should install one monitor/osd with a rgw/civetweb\u0027 do"},{"line_number":37,"context_line":"      pp \u003d \u003c\u003c-EOS"},{"line_number":38,"context_line":"        $user \u003d \u0027root\u0027"},{"line_number":39,"context_line":"        "},{"line_number":40,"context_line":"        case $::osfamily {"},{"line_number":41,"context_line":"          \u0027Debian\u0027: {"},{"line_number":42,"context_line":"            include ::apt"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_c578322e","line":39,"in_reply_to":"da6ed579_bfc198e6","updated":"2016-01-16 16:09:54.000000000","message":"Done","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95b5d952ce03ddf6887fcd3e2e8b9122eb01ae00","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        }"},{"line_number":116,"context_line":"        -\u003e"},{"line_number":117,"context_line":"        ceph::osd { \u0027/srv/data\u0027: }"},{"line_number":118,"context_line":"        "},{"line_number":119,"context_line":"        # setup ceph radosgw"},{"line_number":120,"context_line":"        host { $::fqdn: # workaround for bad \u0027hostname -f\u0027 in vagrant box"},{"line_number":121,"context_line":"          ip           \u003d\u003e $ipaddress,"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_dfaa4c19","line":118,"updated":"2016-01-12 19:14:09.000000000","message":"whitespace","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4a324ef58395cb60b31126d72975b68f9c0f0a3e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        }"},{"line_number":116,"context_line":"        -\u003e"},{"line_number":117,"context_line":"        ceph::osd { \u0027/srv/data\u0027: }"},{"line_number":118,"context_line":"        "},{"line_number":119,"context_line":"        # setup ceph radosgw"},{"line_number":120,"context_line":"        host { $::fqdn: # workaround for bad \u0027hostname -f\u0027 in vagrant box"},{"line_number":121,"context_line":"          ip           \u003d\u003e $ipaddress,"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da6ed579_85723a48","line":118,"in_reply_to":"da6ed579_dfaa4c19","updated":"2016-01-16 16:09:54.000000000","message":"Done","commit_id":"39992f4b4b2899bfa65faefb61aaac68da99dedd"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d553122a342de7ee71dc830951b2baee27d5d049","unresolved":false,"context_lines":[{"line_number":207,"context_line":"          \u0027/etc/ceph/ceph.client.admin.keyring\u0027,"},{"line_number":208,"context_line":"          \u0027/etc/ceph/ceph.client.radosgw.gateway\u0027,"},{"line_number":209,"context_line":"          \u0027/var/lib/ceph\u0027,"},{"line_number":210,"context_line":"          \u0027/var/run/ceph\u0027,"},{"line_number":211,"context_line":"          \u0027/srv/data\u0027,"},{"line_number":212,"context_line":"          ]:"},{"line_number":213,"context_line":"          ensure \u003d\u003e absent,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"da6ed579_de48418d","line":210,"range":{"start_line":210,"start_character":10,"end_line":210,"end_character":25},"updated":"2016-01-15 23:00:08.000000000","message":"this seems to fail as the init script puts a socket file in here which puppet cannot clean:\n2016-01-14 00:12:02.867 |   Error: /Stage[main]/Main/File[/var/run/ceph]: Failed to generate additional resources using \u0027eval_generate\u0027: Cannot manage files of type socket","commit_id":"66c43481e9c4f1133c0b87ba74ddf8bbd144ffe8"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f63454b29f7beec294f9cec4e169c49337f2643f","unresolved":false,"context_lines":[{"line_number":207,"context_line":"          \u0027/etc/ceph/ceph.client.admin.keyring\u0027,"},{"line_number":208,"context_line":"          \u0027/etc/ceph/ceph.client.radosgw.gateway\u0027,"},{"line_number":209,"context_line":"          \u0027/var/lib/ceph\u0027,"},{"line_number":210,"context_line":"          \u0027/var/run/ceph\u0027,"},{"line_number":211,"context_line":"          \u0027/srv/data\u0027,"},{"line_number":212,"context_line":"          ]:"},{"line_number":213,"context_line":"          ensure \u003d\u003e absent,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"da6ed579_574aefad","line":210,"range":{"start_line":210,"start_character":10,"end_line":210,"end_character":25},"in_reply_to":"da6ed579_de48418d","updated":"2016-01-16 15:20:17.000000000","message":"Puppet throws the error but it deletes the directory tree. I added \"force \u003d\u003e true\". A listing of /var/run/ does not show the ceph directory before of after running the tests.","commit_id":"66c43481e9c4f1133c0b87ba74ddf8bbd144ffe8"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":49,"context_line":"              include_src       \u003d\u003e false,"},{"line_number":50,"context_line":"              required_packages \u003d\u003e \u0027ubuntu-cloud-keyring\u0027,"},{"line_number":51,"context_line":"            }"},{"line_number":52,"context_line":"            Apt::Source[\u0027cloudarchive-juno\u0027] -\u003e Package[\u0027keystone\u0027,\u0027python-swiftclient\u0027]"},{"line_number":53,"context_line":"            Exec[\u0027apt_update\u0027] -\u003e Package[\u0027keystone\u0027,\u0027python-swiftclient\u0027]"},{"line_number":54,"context_line":"          }"},{"line_number":55,"context_line":"          \u0027RedHat\u0027: {"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a68dd71_1c7a7388","line":52,"range":{"start_line":52,"start_character":48,"end_line":52,"end_character":66},"updated":"2016-01-25 22:50:18.000000000","message":"There\u0027s no matching package{\u0027keystone\u0027:} anywhere, so this leads to a puppet error.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"              include_src       \u003d\u003e false,"},{"line_number":50,"context_line":"              required_packages \u003d\u003e \u0027ubuntu-cloud-keyring\u0027,"},{"line_number":51,"context_line":"            }"},{"line_number":52,"context_line":"            Apt::Source[\u0027cloudarchive-juno\u0027] -\u003e Package[\u0027keystone\u0027,\u0027python-swiftclient\u0027]"},{"line_number":53,"context_line":"            Exec[\u0027apt_update\u0027] -\u003e Package[\u0027keystone\u0027,\u0027python-swiftclient\u0027]"},{"line_number":54,"context_line":"          }"},{"line_number":55,"context_line":"          \u0027RedHat\u0027: {"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"7a5de9d1_0a93df5c","line":52,"range":{"start_line":52,"start_character":48,"end_line":52,"end_character":66},"in_reply_to":"9a68dd71_1c7a7388","updated":"2016-01-27 21:05:38.000000000","message":"Done","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":50,"context_line":"              required_packages \u003d\u003e \u0027ubuntu-cloud-keyring\u0027,"},{"line_number":51,"context_line":"            }"},{"line_number":52,"context_line":"            Apt::Source[\u0027cloudarchive-juno\u0027] -\u003e Package[\u0027keystone\u0027,\u0027python-swiftclient\u0027]"},{"line_number":53,"context_line":"            Exec[\u0027apt_update\u0027] -\u003e Package[\u0027keystone\u0027,\u0027python-swiftclient\u0027]"},{"line_number":54,"context_line":"          }"},{"line_number":55,"context_line":"          \u0027RedHat\u0027: {"},{"line_number":56,"context_line":"            # ceph-radosgw expects open file limit of 32768"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a68dd71_3c6177d3","line":53,"range":{"start_line":53,"start_character":34,"end_line":53,"end_character":52},"updated":"2016-01-25 22:50:18.000000000","message":"Same as above.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"              required_packages \u003d\u003e \u0027ubuntu-cloud-keyring\u0027,"},{"line_number":51,"context_line":"            }"},{"line_number":52,"context_line":"            Apt::Source[\u0027cloudarchive-juno\u0027] -\u003e Package[\u0027keystone\u0027,\u0027python-swiftclient\u0027]"},{"line_number":53,"context_line":"            Exec[\u0027apt_update\u0027] -\u003e Package[\u0027keystone\u0027,\u0027python-swiftclient\u0027]"},{"line_number":54,"context_line":"          }"},{"line_number":55,"context_line":"          \u0027RedHat\u0027: {"},{"line_number":56,"context_line":"            # ceph-radosgw expects open file limit of 32768"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"7a5de9d1_aa9f2b5e","line":53,"range":{"start_line":53,"start_character":34,"end_line":53,"end_character":52},"in_reply_to":"9a68dd71_3c6177d3","updated":"2016-01-27 21:05:38.000000000","message":"Done","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":74,"context_line":"          }"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        package { \u0027wget\u0027:  # required ceph::rgw::keystone"},{"line_number":78,"context_line":"          ensure \u003d\u003e present,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":"        # ceph setup"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a68dd71_1cd6f34e","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":57},"updated":"2016-01-25 22:50:18.000000000","message":"I don\u0027t understand this comment - afaik you removed the keystone integration in this test?","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"          }"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        package { \u0027wget\u0027:  # required ceph::rgw::keystone"},{"line_number":78,"context_line":"          ensure \u003d\u003e present,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":"        # ceph setup"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"7a5de9d1_aa1acb15","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":57},"in_reply_to":"9a68dd71_1cd6f34e","updated":"2016-01-27 21:05:38.000000000","message":"Removed. It is a remainder from when I tried to get RHEL/keystone working. That will be a separate patch.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":134,"context_line":"          rgw_frontend_type \u003d\u003e \u0027civetweb\u0027,"},{"line_number":135,"context_line":"        }"},{"line_number":136,"context_line":"        -\u003e"},{"line_number":137,"context_line":"        exec { \u0027create-s3-user\u0027:"},{"line_number":138,"context_line":"          command \u003d\u003e \u0027/usr/bin/radosgw-admin user create --uid\u003d#{test_user} --email\u003d#{test_email} --secret\u003d#{test_password} --display-name\u003d\"Test User\"\u0027,"},{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":"        -\u003e"},{"line_number":141,"context_line":"        exec { \u0027create-swift-user\u0027:"},{"line_number":142,"context_line":"          command \u003d\u003e \u0027/usr/bin/radosgw-admin subuser create --uid\u003d#{test_user} --subuser\u003d#{test_user}:swift --access\u003dfull\u0027,"},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":"        -\u003e"},{"line_number":145,"context_line":"        exec { \u0027create-swift-password\u0027:"},{"line_number":146,"context_line":"          command \u003d\u003e \u0027/usr/bin/radosgw-admin key create --subuser\u003d#{test_user}:swift --key-type\u003dswift --secret\u003d#{test_password}\u0027,"},{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":"        Ceph::Osd[\u0027/srv/data\u0027] -\u003e Service[\u0027radosgw-radosgw.gateway\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        package { \u0027python-swiftclient\u0027:  # required for tests below"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a68dd71_7cb36f98","line":147,"range":{"start_line":137,"start_character":8,"end_line":147,"end_character":9},"updated":"2016-01-25 22:50:18.000000000","message":"I think it would make debugging easier if these commands were outside of the puppet code and in \u0027shell\u0027 commands.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"          rgw_frontend_type \u003d\u003e \u0027civetweb\u0027,"},{"line_number":135,"context_line":"        }"},{"line_number":136,"context_line":"        -\u003e"},{"line_number":137,"context_line":"        exec { \u0027create-s3-user\u0027:"},{"line_number":138,"context_line":"          command \u003d\u003e \u0027/usr/bin/radosgw-admin user create --uid\u003d#{test_user} --email\u003d#{test_email} --secret\u003d#{test_password} --display-name\u003d\"Test User\"\u0027,"},{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":"        -\u003e"},{"line_number":141,"context_line":"        exec { \u0027create-swift-user\u0027:"},{"line_number":142,"context_line":"          command \u003d\u003e \u0027/usr/bin/radosgw-admin subuser create --uid\u003d#{test_user} --subuser\u003d#{test_user}:swift --access\u003dfull\u0027,"},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":"        -\u003e"},{"line_number":145,"context_line":"        exec { \u0027create-swift-password\u0027:"},{"line_number":146,"context_line":"          command \u003d\u003e \u0027/usr/bin/radosgw-admin key create --subuser\u003d#{test_user}:swift --key-type\u003dswift --secret\u003d#{test_password}\u0027,"},{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":"        Ceph::Osd[\u0027/srv/data\u0027] -\u003e Service[\u0027radosgw-radosgw.gateway\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        package { \u0027python-swiftclient\u0027:  # required for tests below"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"7a5de9d1_396e37ca","line":147,"range":{"start_line":137,"start_character":8,"end_line":147,"end_character":9},"in_reply_to":"9a68dd71_7cb36f98","updated":"2016-01-27 21:05:38.000000000","message":"Moved to shell commands below.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \u0027RedHat\u0027 \u003d\u003e \u0027service ceph-radosgw status id\u003dradosgw.gateway\u0027,"},{"line_number":165,"context_line":"      }"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"      # RGW on CentOS is currently broken, so lets disable tests for now."},{"line_number":168,"context_line":"      #if osfamily !\u003d \u0027RedHat\u0027"},{"line_number":169,"context_line":"        apply_manifest(pp, :catch_failures \u003d\u003e true)"},{"line_number":170,"context_line":"        # Enable as soon as remaining changes are fixed"},{"line_number":171,"context_line":"        #apply_manifest(pp, :catch_changes \u003d\u003e true)"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a68dd71_3c765706","line":168,"range":{"start_line":167,"start_character":5,"end_line":168,"end_character":30},"updated":"2016-01-25 22:50:18.000000000","message":"Please remove this if it\u0027s not needed anymore and also fix the indentation of the following lines.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \u0027RedHat\u0027 \u003d\u003e \u0027service ceph-radosgw status id\u003dradosgw.gateway\u0027,"},{"line_number":165,"context_line":"      }"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"      # RGW on CentOS is currently broken, so lets disable tests for now."},{"line_number":168,"context_line":"      #if osfamily !\u003d \u0027RedHat\u0027"},{"line_number":169,"context_line":"        apply_manifest(pp, :catch_failures \u003d\u003e true)"},{"line_number":170,"context_line":"        # Enable as soon as remaining changes are fixed"},{"line_number":171,"context_line":"        #apply_manifest(pp, :catch_changes \u003d\u003e true)"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"7a5de9d1_4af8f7e5","line":168,"range":{"start_line":167,"start_character":5,"end_line":168,"end_character":30},"in_reply_to":"9a68dd71_3c765706","updated":"2016-01-27 21:05:38.000000000","message":"Done","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":174,"context_line":"          expect(r.exit_code).to be_zero"},{"line_number":175,"context_line":"        end"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        #shell \"swift -V 2.0 -A http://127.0.0.1:5000/v2.0 -U #{test_tenant}:#{test_user} -K #{test_password} stat\" do |r|"},{"line_number":178,"context_line":"        shell \"swift -A http://127.0.0.1:7480/auth/1.0 -U #{test_user}:swift -K #{test_password} stat\" do |r|"},{"line_number":179,"context_line":"          expect(r.exit_code).to be_zero"},{"line_number":180,"context_line":"          expect(r.stdout).to match(/Content-Type: text\\/plain; charset\u003dutf-8/)"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a68dd71_9c6bc31d","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":122},"updated":"2016-01-25 22:50:18.000000000","message":"Please remove or uncomment.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"          expect(r.exit_code).to be_zero"},{"line_number":175,"context_line":"        end"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        #shell \"swift -V 2.0 -A http://127.0.0.1:5000/v2.0 -U #{test_tenant}:#{test_user} -K #{test_password} stat\" do |r|"},{"line_number":178,"context_line":"        shell \"swift -A http://127.0.0.1:7480/auth/1.0 -U #{test_user}:swift -K #{test_password} stat\" do |r|"},{"line_number":179,"context_line":"          expect(r.exit_code).to be_zero"},{"line_number":180,"context_line":"          expect(r.stdout).to match(/Content-Type: text\\/plain; charset\u003dutf-8/)"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"7a5de9d1_2af33b0c","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":122},"in_reply_to":"9a68dd71_9c6bc31d","updated":"2016-01-27 21:05:38.000000000","message":"Done","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"12f58889dd3ca4d6c1a612252a1c8c21ebca6660","unresolved":false,"context_lines":[{"line_number":180,"context_line":"          expect(r.stdout).to match(/Content-Type: text\\/plain; charset\u003dutf-8/)"},{"line_number":181,"context_line":"          expect(r.stdout).not_to match(/401 Unauthorized/)"},{"line_number":182,"context_line":"        end"},{"line_number":183,"context_line":"      #end"},{"line_number":184,"context_line":"    end"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    it \u0027should purge everything\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a68dd71_fc62ff3c","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":10},"updated":"2016-01-25 22:50:18.000000000","message":"See above.","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a54929a8048df437ba7e00be1835d209e7d8897e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"          expect(r.stdout).to match(/Content-Type: text\\/plain; charset\u003dutf-8/)"},{"line_number":181,"context_line":"          expect(r.stdout).not_to match(/401 Unauthorized/)"},{"line_number":182,"context_line":"        end"},{"line_number":183,"context_line":"      #end"},{"line_number":184,"context_line":"    end"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    it \u0027should purge everything\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"7a5de9d1_6ae9331a","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":10},"in_reply_to":"9a68dd71_fc62ff3c","updated":"2016-01-27 21:05:38.000000000","message":"Done","commit_id":"80816ebe0c0d7bcdd498716599a9b6cda57afcdc"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"e49356ec7f0ea5e547cd24f4c025044a576b3451","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      pp \u003d \u003c\u003c-EOS"},{"line_number":40,"context_line":"        $user \u003d \u0027root\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        case $::osfamily {"},{"line_number":43,"context_line":"          \u0027Debian\u0027: {"},{"line_number":44,"context_line":"            include ::apt"},{"line_number":45,"context_line":"            apt::source { \u0027cloudarchive-juno\u0027:"},{"line_number":46,"context_line":"              location          \u003d\u003e \u0027http://ubuntu-cloud.archive.canonical.com/ubuntu\u0027,"},{"line_number":47,"context_line":"              release           \u003d\u003e \u0027trusty-updates/juno\u0027,"},{"line_number":48,"context_line":"              repos             \u003d\u003e \u0027main\u0027,"},{"line_number":49,"context_line":"              include_src       \u003d\u003e false,"},{"line_number":50,"context_line":"              required_packages \u003d\u003e \u0027ubuntu-cloud-keyring\u0027,"},{"line_number":51,"context_line":"            }"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"          \u0027RedHat\u0027: {"},{"line_number":54,"context_line":"            # ceph-radosgw expects open file limit of 32768"},{"line_number":55,"context_line":"            file { \u0027/etc/security/limits.d/80-nofile.conf\u0027:"},{"line_number":56,"context_line":"              content \u003d\u003e \u0027*          hard    nofile     32768\u0027,"},{"line_number":57,"context_line":"            }"},{"line_number":58,"context_line":"            yumrepo { \u0027openstack-juno\u0027:"},{"line_number":59,"context_line":"              descr    \u003d\u003e \u0027OpenStack Juno Repository\u0027,"},{"line_number":60,"context_line":"              #baseurl  \u003d\u003e \u0027http://repos.fedorapeople.org/repos/openstack/openstack-juno/epel-7/\u0027,"},{"line_number":61,"context_line":"              baseurl  \u003d\u003e \u0027http://repos.fedorapeople.org/repos/openstack/openstack-kilo/el7/\u0027,"},{"line_number":62,"context_line":"              enabled  \u003d\u003e \u00271\u0027,"},{"line_number":63,"context_line":"              gpgcheck \u003d\u003e \u00270\u0027,"},{"line_number":64,"context_line":"              #gpgkey   \u003d\u003e \u0027https://raw.githubusercontent.com/redhat-openstack/rdo-release/juno/RPM-GPG-KEY-RDO-Juno\u0027,"},{"line_number":65,"context_line":"              gpgkey   \u003d\u003e \u0027https://raw.githubusercontent.com/redhat-openstack/rdo-release/kilo/RPM-GPG-KEY-RDO-Kilo\u0027,"},{"line_number":66,"context_line":"              priority \u003d\u003e \u002715\u0027, # prefer over EPEL, but below ceph"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"            Yumrepo\u003c||\u003e -\u003e Package[\u0027python-swiftclient\u0027]"},{"line_number":69,"context_line":"          }"},{"line_number":70,"context_line":"          default: {"},{"line_number":71,"context_line":"            fail (\"Unsupported OS family ${::osfamily}\")"},{"line_number":72,"context_line":"          }"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # ceph setup"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_15c92526","line":72,"range":{"start_line":42,"start_character":8,"end_line":72,"end_character":11},"updated":"2016-02-06 17:08:09.000000000","message":"tbh this is a bit excessive, just so you can use the \"swift\" command later. especially because it\u0027s using Juno, introducing additional complexity when updating to Liberty (which we should do).\ncan\u0027t you just instead use curl below?","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"06ac088ec83fcec6376a8c779a49b356f1b53c87","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      pp \u003d \u003c\u003c-EOS"},{"line_number":40,"context_line":"        $user \u003d \u0027root\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        case $::osfamily {"},{"line_number":43,"context_line":"          \u0027Debian\u0027: {"},{"line_number":44,"context_line":"            include ::apt"},{"line_number":45,"context_line":"            apt::source { \u0027cloudarchive-juno\u0027:"},{"line_number":46,"context_line":"              location          \u003d\u003e \u0027http://ubuntu-cloud.archive.canonical.com/ubuntu\u0027,"},{"line_number":47,"context_line":"              release           \u003d\u003e \u0027trusty-updates/juno\u0027,"},{"line_number":48,"context_line":"              repos             \u003d\u003e \u0027main\u0027,"},{"line_number":49,"context_line":"              include_src       \u003d\u003e false,"},{"line_number":50,"context_line":"              required_packages \u003d\u003e \u0027ubuntu-cloud-keyring\u0027,"},{"line_number":51,"context_line":"            }"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"          \u0027RedHat\u0027: {"},{"line_number":54,"context_line":"            # ceph-radosgw expects open file limit of 32768"},{"line_number":55,"context_line":"            file { \u0027/etc/security/limits.d/80-nofile.conf\u0027:"},{"line_number":56,"context_line":"              content \u003d\u003e \u0027*          hard    nofile     32768\u0027,"},{"line_number":57,"context_line":"            }"},{"line_number":58,"context_line":"            yumrepo { \u0027openstack-juno\u0027:"},{"line_number":59,"context_line":"              descr    \u003d\u003e \u0027OpenStack Juno Repository\u0027,"},{"line_number":60,"context_line":"              #baseurl  \u003d\u003e \u0027http://repos.fedorapeople.org/repos/openstack/openstack-juno/epel-7/\u0027,"},{"line_number":61,"context_line":"              baseurl  \u003d\u003e \u0027http://repos.fedorapeople.org/repos/openstack/openstack-kilo/el7/\u0027,"},{"line_number":62,"context_line":"              enabled  \u003d\u003e \u00271\u0027,"},{"line_number":63,"context_line":"              gpgcheck \u003d\u003e \u00270\u0027,"},{"line_number":64,"context_line":"              #gpgkey   \u003d\u003e \u0027https://raw.githubusercontent.com/redhat-openstack/rdo-release/juno/RPM-GPG-KEY-RDO-Juno\u0027,"},{"line_number":65,"context_line":"              gpgkey   \u003d\u003e \u0027https://raw.githubusercontent.com/redhat-openstack/rdo-release/kilo/RPM-GPG-KEY-RDO-Kilo\u0027,"},{"line_number":66,"context_line":"              priority \u003d\u003e \u002715\u0027, # prefer over EPEL, but below ceph"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"            Yumrepo\u003c||\u003e -\u003e Package[\u0027python-swiftclient\u0027]"},{"line_number":69,"context_line":"          }"},{"line_number":70,"context_line":"          default: {"},{"line_number":71,"context_line":"            fail (\"Unsupported OS family ${::osfamily}\")"},{"line_number":72,"context_line":"          }"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # ceph setup"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_c06988fa","line":72,"range":{"start_line":42,"start_character":8,"end_line":72,"end_character":11},"in_reply_to":"5a5ae5dd_15c92526","updated":"2016-02-06 22:05:06.000000000","message":"We can reduce this to a curl test if it will successfully test as equally as swift. I would rather have this change in a separate patch so this patch can be contained and not do too much.","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"51df26378be2799596f2a3e8e2937f5433ba3d53","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      pp \u003d \u003c\u003c-EOS"},{"line_number":40,"context_line":"        $user \u003d \u0027root\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        case $::osfamily {"},{"line_number":43,"context_line":"          \u0027Debian\u0027: {"},{"line_number":44,"context_line":"            include ::apt"},{"line_number":45,"context_line":"            apt::source { \u0027cloudarchive-juno\u0027:"},{"line_number":46,"context_line":"              location          \u003d\u003e \u0027http://ubuntu-cloud.archive.canonical.com/ubuntu\u0027,"},{"line_number":47,"context_line":"              release           \u003d\u003e \u0027trusty-updates/juno\u0027,"},{"line_number":48,"context_line":"              repos             \u003d\u003e \u0027main\u0027,"},{"line_number":49,"context_line":"              include_src       \u003d\u003e false,"},{"line_number":50,"context_line":"              required_packages \u003d\u003e \u0027ubuntu-cloud-keyring\u0027,"},{"line_number":51,"context_line":"            }"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"          \u0027RedHat\u0027: {"},{"line_number":54,"context_line":"            # ceph-radosgw expects open file limit of 32768"},{"line_number":55,"context_line":"            file { \u0027/etc/security/limits.d/80-nofile.conf\u0027:"},{"line_number":56,"context_line":"              content \u003d\u003e \u0027*          hard    nofile     32768\u0027,"},{"line_number":57,"context_line":"            }"},{"line_number":58,"context_line":"            yumrepo { \u0027openstack-juno\u0027:"},{"line_number":59,"context_line":"              descr    \u003d\u003e \u0027OpenStack Juno Repository\u0027,"},{"line_number":60,"context_line":"              #baseurl  \u003d\u003e \u0027http://repos.fedorapeople.org/repos/openstack/openstack-juno/epel-7/\u0027,"},{"line_number":61,"context_line":"              baseurl  \u003d\u003e \u0027http://repos.fedorapeople.org/repos/openstack/openstack-kilo/el7/\u0027,"},{"line_number":62,"context_line":"              enabled  \u003d\u003e \u00271\u0027,"},{"line_number":63,"context_line":"              gpgcheck \u003d\u003e \u00270\u0027,"},{"line_number":64,"context_line":"              #gpgkey   \u003d\u003e \u0027https://raw.githubusercontent.com/redhat-openstack/rdo-release/juno/RPM-GPG-KEY-RDO-Juno\u0027,"},{"line_number":65,"context_line":"              gpgkey   \u003d\u003e \u0027https://raw.githubusercontent.com/redhat-openstack/rdo-release/kilo/RPM-GPG-KEY-RDO-Kilo\u0027,"},{"line_number":66,"context_line":"              priority \u003d\u003e \u002715\u0027, # prefer over EPEL, but below ceph"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"            Yumrepo\u003c||\u003e -\u003e Package[\u0027python-swiftclient\u0027]"},{"line_number":69,"context_line":"          }"},{"line_number":70,"context_line":"          default: {"},{"line_number":71,"context_line":"            fail (\"Unsupported OS family ${::osfamily}\")"},{"line_number":72,"context_line":"          }"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # ceph setup"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"3a57f1b5_1fe254d6","line":72,"range":{"start_line":42,"start_character":8,"end_line":72,"end_character":11},"in_reply_to":"5a5ae5dd_c06988fa","updated":"2016-02-09 21:30:22.000000000","message":"I\u0027m fine with it staying the same as apache/fastcgi for now","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"e49356ec7f0ea5e547cd24f4c025044a576b3451","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        expect(r.exit_code).to be_zero"},{"line_number":168,"context_line":"      end"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"      shell \"swift -A http://127.0.0.1:7480/auth/1.0 -U #{test_user}:swift -K #{test_password} stat\" do |r|"},{"line_number":171,"context_line":"        expect(r.exit_code).to be_zero"},{"line_number":172,"context_line":"        expect(r.stdout).to match(/Content-Type: text\\/plain; charset\u003dutf-8/)"},{"line_number":173,"context_line":"        expect(r.stdout).not_to match(/401 Unauthorized/)"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_55e31da4","line":170,"range":{"start_line":170,"start_character":13,"end_line":170,"end_character":99},"updated":"2016-02-06 17:08:09.000000000","message":"curl -i -H \u0027X-Auth-User: #{test_user}:swift\u0027 -H \u0027X-Auth-Key: #{test_password}\u0027 http://127.0.0.1:7480/auth/v1.0/","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"06ac088ec83fcec6376a8c779a49b356f1b53c87","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        expect(r.exit_code).to be_zero"},{"line_number":168,"context_line":"      end"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"      shell \"swift -A http://127.0.0.1:7480/auth/1.0 -U #{test_user}:swift -K #{test_password} stat\" do |r|"},{"line_number":171,"context_line":"        expect(r.exit_code).to be_zero"},{"line_number":172,"context_line":"        expect(r.stdout).to match(/Content-Type: text\\/plain; charset\u003dutf-8/)"},{"line_number":173,"context_line":"        expect(r.stdout).not_to match(/401 Unauthorized/)"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_606c5408","line":170,"range":{"start_line":170,"start_character":13,"end_line":170,"end_character":99},"in_reply_to":"5a5ae5dd_55e31da4","updated":"2016-02-06 22:05:06.000000000","message":"See above.","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"a841cbd8bda796828a91942ebf721f5682051a6d","unresolved":false,"context_lines":[{"line_number":233,"context_line":"# Local Variables:"},{"line_number":234,"context_line":"# compile-command: \"cd ../.."},{"line_number":235,"context_line":"#   BUNDLE_PATH\u003d/tmp/vendor bundle install"},{"line_number":236,"context_line":"#   BEAKER_set\u003dubuntu-server-1204-x64 \\"},{"line_number":237,"context_line":"#   BUNDLE_PATH\u003d/tmp/vendor \\"},{"line_number":238,"context_line":"#   bundle exec rspec spec/acceptance/ceph_usecases_spec.rb"},{"line_number":239,"context_line":"# \""}],"source_content_type":"text/x-ruby","patch_set":64,"id":"9aed3d3a_f7b91bee","line":236,"range":{"start_line":236,"start_character":29,"end_line":236,"end_character":33},"updated":"2016-02-26 08:30:09.000000000","message":"nit: 1404","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0c71e2c23401a223f2d2b0acdeefb078b6493ea4","unresolved":false,"context_lines":[{"line_number":233,"context_line":"# Local Variables:"},{"line_number":234,"context_line":"# compile-command: \"cd ../.."},{"line_number":235,"context_line":"#   BUNDLE_PATH\u003d/tmp/vendor bundle install"},{"line_number":236,"context_line":"#   BEAKER_set\u003dubuntu-server-1204-x64 \\"},{"line_number":237,"context_line":"#   BUNDLE_PATH\u003d/tmp/vendor \\"},{"line_number":238,"context_line":"#   bundle exec rspec spec/acceptance/ceph_usecases_spec.rb"},{"line_number":239,"context_line":"# \""}],"source_content_type":"text/x-ruby","patch_set":64,"id":"9aed3d3a_1c7d9b1c","line":236,"range":{"start_line":236,"start_character":29,"end_line":236,"end_character":33},"in_reply_to":"9aed3d3a_f7b91bee","updated":"2016-02-26 11:59:57.000000000","message":"Done","commit_id":"f16bdd3759b8e640129e0fc2d54e73ebcfb2594e"}],"spec/acceptance/ceph_rgw_spec.rb":[{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d553122a342de7ee71dc830951b2baee27d5d049","unresolved":false,"context_lines":[{"line_number":256,"context_line":"           \u0027/etc/ceph/ceph.client.admin.keyring\u0027,"},{"line_number":257,"context_line":"           \u0027/etc/ceph/ceph.client.radosgw.gateway\u0027,"},{"line_number":258,"context_line":"           \u0027/var/lib/ceph\u0027,"},{"line_number":259,"context_line":"           \u0027/var/run/ceph\u0027,"},{"line_number":260,"context_line":"           \u0027/srv/data\u0027,"},{"line_number":261,"context_line":"          ]:"},{"line_number":262,"context_line":"          ensure \u003d\u003e absent,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"da6ed579_5e2451c5","line":259,"range":{"start_line":259,"start_character":11,"end_line":259,"end_character":27},"updated":"2016-01-15 23:00:08.000000000","message":"i think this is also going to fail, once the CentoOS tests get enabled again","commit_id":"66c43481e9c4f1133c0b87ba74ddf8bbd144ffe8"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f63454b29f7beec294f9cec4e169c49337f2643f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"           \u0027/etc/ceph/ceph.client.admin.keyring\u0027,"},{"line_number":257,"context_line":"           \u0027/etc/ceph/ceph.client.radosgw.gateway\u0027,"},{"line_number":258,"context_line":"           \u0027/var/lib/ceph\u0027,"},{"line_number":259,"context_line":"           \u0027/var/run/ceph\u0027,"},{"line_number":260,"context_line":"           \u0027/srv/data\u0027,"},{"line_number":261,"context_line":"          ]:"},{"line_number":262,"context_line":"          ensure \u003d\u003e absent,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"da6ed579_17f23770","line":259,"range":{"start_line":259,"start_character":11,"end_line":259,"end_character":27},"in_reply_to":"da6ed579_5e2451c5","updated":"2016-01-16 15:20:17.000000000","message":"Please see the other comment.","commit_id":"66c43481e9c4f1133c0b87ba74ddf8bbd144ffe8"}],"spec/defines/ceph_rgw_civetweb_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b1a60003a288876bc77af617dd570e04b14d9bf1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      end"},{"line_number":32,"context_line":"      let :params do"},{"line_number":33,"context_line":"      {"},{"line_number":34,"context_line":"        :rgw_frontend_type \u003d\u003e\u0027civetweb\u0027,"},{"line_number":35,"context_line":"      }"},{"line_number":36,"context_line":"      end"},{"line_number":37,"context_line":"      it { is_expected.to contain_ceph_config(\u0027client.radosgw.civetweb/user\u0027).with_value(\"#{default_params[:user]}\") }"}],"source_content_type":"text/x-ruby","patch_set":58,"id":"bae84128_42f20e9b","line":34,"updated":"2016-02-23 22:42:50.000000000","message":"the parameter does not exist in the ceph::rgw::civetweb define but in ceph::rgw.","commit_id":"d8dbe11be29268e88642c446ea4cdc87c45afaca"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"ff683dba72a302ff3836f5a128dab2f303942653","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      end"},{"line_number":32,"context_line":"      let :params do"},{"line_number":33,"context_line":"      {"},{"line_number":34,"context_line":"        :rgw_frontend_type \u003d\u003e\u0027civetweb\u0027,"},{"line_number":35,"context_line":"      }"},{"line_number":36,"context_line":"      end"},{"line_number":37,"context_line":"      it { is_expected.to contain_ceph_config(\u0027client.radosgw.civetweb/user\u0027).with_value(\"#{default_params[:user]}\") }"}],"source_content_type":"text/x-ruby","patch_set":58,"id":"bae84128_251551e4","line":34,"in_reply_to":"bae84128_42f20e9b","updated":"2016-02-24 00:29:00.000000000","message":"Well frap that was easy. I thought describe on line 20 was just descriptive. I changed it to \"ceph::rgw\" and have watched unit tests 3.3 -\u003e 3.8 pass while I am typing. Thanks!","commit_id":"d8dbe11be29268e88642c446ea4cdc87c45afaca"}],"spec/defines/ceph_rgw_spec.rb":[{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"e49356ec7f0ea5e547cd24f4c025044a576b3451","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        :hostname                    \u003d\u003e \u0027myhost\u0027,"},{"line_number":134,"context_line":"        :osfamily                    \u003d\u003e \u0027RedHat\u0027,"},{"line_number":135,"context_line":"        :operatingsystem             \u003d\u003e \u0027RedHat\u0027,"},{"line_number":136,"context_line":"        :operatingsystemrelease      \u003d\u003e \u00277\u0027,"},{"line_number":137,"context_line":"        :operatingsystemmajorrelease \u003d\u003e \u00277\u0027,"},{"line_number":138,"context_line":"      }"},{"line_number":139,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_3567814e","line":136,"range":{"start_line":136,"start_character":9,"end_line":136,"end_character":44},"updated":"2016-02-06 17:08:09.000000000","message":"this should be 7.0 or 7.2 or similar","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"06ac088ec83fcec6376a8c779a49b356f1b53c87","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        :hostname                    \u003d\u003e \u0027myhost\u0027,"},{"line_number":134,"context_line":"        :osfamily                    \u003d\u003e \u0027RedHat\u0027,"},{"line_number":135,"context_line":"        :operatingsystem             \u003d\u003e \u0027RedHat\u0027,"},{"line_number":136,"context_line":"        :operatingsystemrelease      \u003d\u003e \u00277\u0027,"},{"line_number":137,"context_line":"        :operatingsystemmajorrelease \u003d\u003e \u00277\u0027,"},{"line_number":138,"context_line":"      }"},{"line_number":139,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_e005a413","line":136,"range":{"start_line":136,"start_character":9,"end_line":136,"end_character":44},"in_reply_to":"5a5ae5dd_3567814e","updated":"2016-02-06 22:05:06.000000000","message":"The rest of the RHEL operatingsystem{maj}release are whole numbers.","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"e49356ec7f0ea5e547cd24f4c025044a576b3451","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        :osfamily                    \u003d\u003e \u0027RedHat\u0027,"},{"line_number":135,"context_line":"        :operatingsystem             \u003d\u003e \u0027RedHat\u0027,"},{"line_number":136,"context_line":"        :operatingsystemrelease      \u003d\u003e \u00277\u0027,"},{"line_number":137,"context_line":"        :operatingsystemmajorrelease \u003d\u003e \u00277\u0027,"},{"line_number":138,"context_line":"      }"},{"line_number":139,"context_line":"    end"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_d5570d58","line":137,"range":{"start_line":137,"start_character":9,"end_line":137,"end_character":36},"updated":"2016-02-06 17:08:09.000000000","message":"operatingsystemMAJrelease not operatinsystemMAJORrelease","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"06ac088ec83fcec6376a8c779a49b356f1b53c87","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        :osfamily                    \u003d\u003e \u0027RedHat\u0027,"},{"line_number":135,"context_line":"        :operatingsystem             \u003d\u003e \u0027RedHat\u0027,"},{"line_number":136,"context_line":"        :operatingsystemrelease      \u003d\u003e \u00277\u0027,"},{"line_number":137,"context_line":"        :operatingsystemmajorrelease \u003d\u003e \u00277\u0027,"},{"line_number":138,"context_line":"      }"},{"line_number":139,"context_line":"    end"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_4024b8c3","line":137,"range":{"start_line":137,"start_character":9,"end_line":137,"end_character":36},"in_reply_to":"5a5ae5dd_d5570d58","updated":"2016-02-06 22:05:06.000000000","message":"Done","commit_id":"462b4a05801026d19feb8de9996f26bb9e906064"}]}