)]}'
{"manifests/rgw/apache.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"bb7d086f245035a246c1ae27fe27196524f9ee18","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $rgw_socket_path     \u003d $::ceph::params::rgw_socket_path,"},{"line_number":66,"context_line":"  $syslog              \u003d true,"},{"line_number":67,"context_line":"  $ceph_apache_repo    \u003d true,"},{"line_number":68,"context_line":"  $custom_apache       \u003d false,"},{"line_number":69,"context_line":"  $custom_apache_ports \u003d \u002780\u0027,"},{"line_number":70,"context_line":") {"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a68dd71_14c91059","line":68,"range":{"start_line":68,"start_character":3,"end_line":68,"end_character":16},"updated":"2016-01-25 10:18:56.000000000","message":"may be we should add ability override purge_{*} parameters, instead of calling a whole class?","commit_id":"57c30639b7d2cb27bd8161255dd53abf777a2436"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"04f8cca7154806f26231f5a92603319b98cb999b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $rgw_socket_path     \u003d $::ceph::params::rgw_socket_path,"},{"line_number":66,"context_line":"  $syslog              \u003d true,"},{"line_number":67,"context_line":"  $ceph_apache_repo    \u003d true,"},{"line_number":68,"context_line":"  $custom_apache       \u003d false,"},{"line_number":69,"context_line":"  $custom_apache_ports \u003d \u002780\u0027,"},{"line_number":70,"context_line":") {"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a5de9d1_bb5ebb74","line":68,"range":{"start_line":68,"start_character":3,"end_line":68,"end_character":16},"in_reply_to":"9a68dd71_14c91059","updated":"2016-01-27 11:59:27.000000000","message":"Somthing like this:\n\nclass { \u0027::apache\u0027:\n  default_mods    \u003d\u003e $default_mods,\n  default_vhost   \u003d\u003e $default_vhost,\n  purge_configs   \u003d\u003e $purge_configs,\n  purge_vhost_dir \u003d\u003e $purge_vhost_dir,\n}\nif $custom_apache_ports {\n  apache::listen {$custom_apache_ports: }\n}","commit_id":"57c30639b7d2cb27bd8161255dd53abf777a2436"}],"manifests/rgw/apache_fastcgi.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"b00946be102051e42d308644be78be61614a8059","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  $syslog              \u003d true,"},{"line_number":67,"context_line":"  $ceph_apache_repo    \u003d true,"},{"line_number":68,"context_line":"  $custom_apache       \u003d false,"},{"line_number":69,"context_line":"  $custom_apache_ports \u003d \u002780\u0027,"},{"line_number":70,"context_line":") {"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $custom_apache {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5aef4532_6799751f","line":69,"range":{"start_line":69,"start_character":26,"end_line":69,"end_character":28},"updated":"2016-03-09 00:37:17.000000000","message":"Isn\u0027t rgw_port and custom_apache_port the same here?","commit_id":"1dda2fce91eb9addf846f0bfcf3ebbe017d11c60"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1869cc6e5d890c9ff44a66a00a46601f2daf6fa5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  $custom_apache_ports \u003d undef,"},{"line_number":70,"context_line":") {"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $custom_apache {"},{"line_number":73,"context_line":"    class { \u0027::apache\u0027:"},{"line_number":74,"context_line":"      default_mods    \u003d\u003e false,"},{"line_number":75,"context_line":"      purge_configs   \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5aef4532_d64d853f","line":72,"updated":"2016-03-09 11:25:03.000000000","message":"see my comment in 2 patch set: https://review.openstack.org/#/c/260639/4/manifests/rgw/apache.pp","commit_id":"a837c4322ec0f0e3c4b70ce6063482c66222915d"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"bf1055e1ca948000d2375bec376cb327879c5c67","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  $custom_apache_ports \u003d undef,"},{"line_number":70,"context_line":") {"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $custom_apache {"},{"line_number":73,"context_line":"    class { \u0027::apache\u0027:"},{"line_number":74,"context_line":"      default_mods    \u003d\u003e false,"},{"line_number":75,"context_line":"      purge_configs   \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1af94dfe_870ff235","line":72,"in_reply_to":"5aef4532_d64d853f","updated":"2016-03-18 21:50:20.000000000","message":"+1 to degorenko","commit_id":"a837c4322ec0f0e3c4b70ce6063482c66222915d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4da6487a68735fc007dea992e5d8aa12b61e4224","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    purge_vhost_dir \u003d\u003e $apache_purge_vhost,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  if $custom_apache_ports {"},{"line_number":93,"context_line":"    apache::listen { $custom_apache_ports: }"},{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa0719c6_ca8881ea","line":92,"updated":"2016-03-21 18:33:43.000000000","message":"Should this be here or should this be something that the end user would configure prior to including the ceph::rgw::apache_fastcgi?","commit_id":"b7b9ca415bc2c87056d54d4d352805227e9e4bd6"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"4632b820dc852ec1c9e1fc873a0c25ecdc42fba4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    purge_vhost_dir \u003d\u003e $apache_purge_vhost,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  if $custom_apache_ports {"},{"line_number":93,"context_line":"    apache::listen { $custom_apache_ports: }"},{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa0719c6_586d6b97","line":92,"in_reply_to":"fa0719c6_ca8881ea","updated":"2016-03-21 19:13:14.000000000","message":"this should be here, because w/o this apache will drop all existing ports it listens to.","commit_id":"b7b9ca415bc2c87056d54d4d352805227e9e4bd6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4da6487a68735fc007dea992e5d8aa12b61e4224","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  if !$apache_mods {"},{"line_number":97,"context_line":"    include ::apache::mod::auth_basic"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  include ::apache::mod::alias"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa0719c6_6a4fb5bd","line":97,"updated":"2016-03-21 18:33:43.000000000","message":"Same question for this line as well, seems like something that can be done in the end user\u0027s composition layer","commit_id":"b7b9ca415bc2c87056d54d4d352805227e9e4bd6"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"4632b820dc852ec1c9e1fc873a0c25ecdc42fba4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  if !$apache_mods {"},{"line_number":97,"context_line":"    include ::apache::mod::auth_basic"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  include ::apache::mod::alias"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa0719c6_98ba63e0","line":97,"in_reply_to":"fa0719c6_6a4fb5bd","updated":"2016-03-21 19:13:14.000000000","message":"This mod is provided by default_mods \u003d\u003e true and give duplicate error","commit_id":"b7b9ca415bc2c87056d54d4d352805227e9e4bd6"}],"manifests/rgw/apache_proxy_fcgi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5c29585046c5cd67da4914bbc5cfe36c7b11b21e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"# [*apache_mods*] Whether to configure and enable a set of default Apache modules."},{"line_number":52,"context_line":"#   Optional. Defaults to false."},{"line_number":53,"context_line":"#   "},{"line_number":54,"context_line":"# [*apache_vhost*] Configures a default virtual host."},{"line_number":55,"context_line":"#   Optional. Defaults to false."},{"line_number":56,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa0719c6_ca5b6f53","line":53,"updated":"2016-03-21 14:44:33.000000000","message":"remove please empty spaces","commit_id":"a0d91dd40568d435376ce28a28cb2a1b53095bf0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5c29585046c5cd67da4914bbc5cfe36c7b11b21e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*apache_purge_configs*] Removes all other Apache configs and virtual hosts."},{"line_number":58,"context_line":"#   Optional. Defaults to true."},{"line_number":59,"context_line":"#   "},{"line_number":60,"context_line":"# [*apache_purge_vhost*] Whether to remove any configurations inside vhost_dir not managed"},{"line_number":61,"context_line":"#   by Puppet."},{"line_number":62,"context_line":"#   Optional. Defaults to true."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa0719c6_6a31830b","line":59,"updated":"2016-03-21 14:44:33.000000000","message":"ditto","commit_id":"a0d91dd40568d435376ce28a28cb2a1b53095bf0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5c29585046c5cd67da4914bbc5cfe36c7b11b21e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"# [*apache_purge_vhost*] Whether to remove any configurations inside vhost_dir not managed"},{"line_number":61,"context_line":"#   by Puppet."},{"line_number":62,"context_line":"#   Optional. Defaults to true."},{"line_number":63,"context_line":"# "},{"line_number":64,"context_line":"# [*custom_apache_ports*] Array of ports to listen by Apache."},{"line_number":65,"context_line":"#   Optional. Works only if custom_apache set to true. Default is undef."},{"line_number":66,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa0719c6_ca224fb9","line":63,"updated":"2016-03-21 14:44:33.000000000","message":"same","commit_id":"a0d91dd40568d435376ce28a28cb2a1b53095bf0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4da6487a68735fc007dea992e5d8aa12b61e4224","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    purge_vhost_dir \u003d\u003e $apache_purge_vhost,"},{"line_number":88,"context_line":"  }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  if $custom_apache_ports {"},{"line_number":91,"context_line":"    apache::listen { $custom_apache_ports: }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa0719c6_ea9f4501","line":90,"updated":"2016-03-21 18:33:43.000000000","message":"would be a similar question as the other resource","commit_id":"b7b9ca415bc2c87056d54d4d352805227e9e4bd6"}]}