)]}'
{"manifests/rgw.pp":[{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"3564e544fe1aeaad361afbe0f5996bcd335951ce","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Optional. Default is \u0027www-data\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*keyring_path*] Location of keyring."},{"line_number":37,"context_line":"#   Optional. Default is \u0027/etc/ceph/radosgw.${name}.keyring\u0027."},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*log_file*] Log file to write to."},{"line_number":40,"context_line":"#   Optional. Default is \u0027/var/log/ceph/radosgw.log\u0027."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a68dd71_e456f7cc","line":37,"range":{"start_line":37,"start_character":36,"end_line":37,"end_character":43},"updated":"2016-01-25 17:16:07.000000000","message":"/etc/ceph/ceph.client.radosgw.${name}.keyring (or maybe /etc/ceph/${cluster}.client.radosgw.${name}.keyring)","commit_id":"38df580403a1e2a1aa3753adf561c4e2e15e5044"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"856be536fe2e306d89fd9a9151a7665d36a8c06a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $syslog \u003d true,"},{"line_number":68,"context_line":") {"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":71,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":72,"context_line":"  } else {"},{"line_number":73,"context_line":"    $name_real \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a5de9d1_056d50cb","line":70,"updated":"2016-02-01 17:48:49.000000000","message":"This is good for backwards compatibility. Should we put a warning in this case as well letting the end user know that they no longer need to specify \u0027radosgw.\u0027 in the name?  That way we could get rid of this at some point as well","commit_id":"eaedf535318b1da7c28f50020489388e9c5b36f4"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"f40d20c68859689da795e1eb200b302909beaeaf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $syslog \u003d true,"},{"line_number":68,"context_line":") {"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":71,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":72,"context_line":"  } else {"},{"line_number":73,"context_line":"    $name_real \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a5de9d1_747daab0","line":70,"in_reply_to":"7a5de9d1_056d50cb","updated":"2016-02-02 13:55:16.000000000","message":"done","commit_id":"eaedf535318b1da7c28f50020489388e9c5b36f4"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"a10710de54029b2e8d4e2b623f204a380e026e86","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $syslog \u003d true,"},{"line_number":68,"context_line":") {"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":71,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":72,"context_line":"  } else {"},{"line_number":73,"context_line":"    $name_real \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a5de9d1_1625885a","line":70,"in_reply_to":"7a5de9d1_056d50cb","updated":"2016-02-01 18:57:05.000000000","message":"please add a test to cover this and the warning Alex mentioned, otherwise LGTM","commit_id":"eaedf535318b1da7c28f50020489388e9c5b36f4"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"f40d20c68859689da795e1eb200b302909beaeaf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $syslog \u003d true,"},{"line_number":68,"context_line":") {"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":71,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":72,"context_line":"  } else {"},{"line_number":73,"context_line":"    $name_real \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a5de9d1_54574e26","line":70,"in_reply_to":"7a5de9d1_1625885a","updated":"2016-02-02 13:55:16.000000000","message":"Andrew, I have added to each test name","commit_id":"eaedf535318b1da7c28f50020489388e9c5b36f4"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"f40d20c68859689da795e1eb200b302909beaeaf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $syslog \u003d true,"},{"line_number":68,"context_line":") {"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":71,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":72,"context_line":"  } else {"},{"line_number":73,"context_line":"    $name_real \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a5de9d1_3751740f","line":70,"in_reply_to":"7a5de9d1_1625885a","updated":"2016-02-02 13:55:16.000000000","message":"Andrew, in each test we have 2 titles: \u0027radosgw.gateway\u0027 and \u0027myid\u0027. They should cover all the cases. Does it make sense?","commit_id":"eaedf535318b1da7c28f50020489388e9c5b36f4"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"e58653d3354cd23d8f2dd562cd9fb822cceb2915","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $syslog \u003d true,"},{"line_number":68,"context_line":") {"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":71,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":72,"context_line":"  } else {"},{"line_number":73,"context_line":"    $name_real \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a5de9d1_3778948f","line":70,"in_reply_to":"7a5de9d1_54574e26","updated":"2016-02-02 13:55:54.000000000","message":"Done","commit_id":"eaedf535318b1da7c28f50020489388e9c5b36f4"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d474eca6074c9397e043c9b596b6f13c91daf6e2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    $name_real         \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":72,"context_line":"    $rgw_data_real     \u003d \"/var/lib/ceph/radosgw/ceph-radosgw.${name_real}\""},{"line_number":73,"context_line":"    $keyring_path_real \u003d \"/etc/ceph/ceph.client.radosgw.${name_real}.keyring\""},{"line_number":74,"context_line":"    warning (\"No more need to pass name that starts with \u0027radosgw\u0027, this prefix will be cutted.\")"},{"line_number":75,"context_line":"  } else {"},{"line_number":76,"context_line":"    $name_real         \u003d $name"},{"line_number":77,"context_line":"    $rgw_data_real     \u003d $rgw_data"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a5ae5dd_ffad489b","line":74,"range":{"start_line":74,"start_character":88,"end_line":74,"end_character":94},"updated":"2016-02-06 13:41:07.000000000","message":"nit: \"cut\"","commit_id":"3bf6eab1eb9fde68de899e82294758efcbaaf46e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d474eca6074c9397e043c9b596b6f13c91daf6e2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    $name_real         \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":72,"context_line":"    $rgw_data_real     \u003d \"/var/lib/ceph/radosgw/ceph-radosgw.${name_real}\""},{"line_number":73,"context_line":"    $keyring_path_real \u003d \"/etc/ceph/ceph.client.radosgw.${name_real}.keyring\""},{"line_number":74,"context_line":"    warning (\"No more need to pass name that starts with \u0027radosgw\u0027, this prefix will be cutted.\")"},{"line_number":75,"context_line":"  } else {"},{"line_number":76,"context_line":"    $name_real         \u003d $name"},{"line_number":77,"context_line":"    $rgw_data_real     \u003d $rgw_data"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a5ae5dd_7fc39857","line":74,"range":{"start_line":74,"start_character":30,"end_line":74,"end_character":39},"updated":"2016-02-06 13:41:07.000000000","message":"nit: \"pass a name\"","commit_id":"3bf6eab1eb9fde68de899e82294758efcbaaf46e"}],"manifests/rgw/apache.pp":[{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d474eca6074c9397e043c9b596b6f13c91daf6e2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":65,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":66,"context_line":"    warning (\"No more need to pass name that starts with \u0027radosgw\u0027, this prefix will be cutted.\")"},{"line_number":67,"context_line":"  } else {"},{"line_number":68,"context_line":"    $name_real \u003d $name"},{"line_number":69,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a5ae5dd_dfb16c02","line":66,"range":{"start_line":66,"start_character":88,"end_line":66,"end_character":94},"updated":"2016-02-06 13:41:07.000000000","message":"nit: \"cut\"","commit_id":"3bf6eab1eb9fde68de899e82294758efcbaaf46e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d474eca6074c9397e043c9b596b6f13c91daf6e2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":65,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":66,"context_line":"    warning (\"No more need to pass name that starts with \u0027radosgw\u0027, this prefix will be cutted.\")"},{"line_number":67,"context_line":"  } else {"},{"line_number":68,"context_line":"    $name_real \u003d $name"},{"line_number":69,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a5ae5dd_ffb6a8f7","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":39},"updated":"2016-02-06 13:41:07.000000000","message":"nit: \"pass a name\"","commit_id":"3bf6eab1eb9fde68de899e82294758efcbaaf46e"}],"manifests/rgw/keystone.pp":[{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d474eca6074c9397e043c9b596b6f13c91daf6e2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":65,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":66,"context_line":"    warning (\"No more need to pass name that starts with \u0027radosgw\u0027, this prefix will be cutted.\")"},{"line_number":67,"context_line":"  } else {"},{"line_number":68,"context_line":"    $name_real \u003d $name"},{"line_number":69,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a5ae5dd_5fc6dc68","line":66,"range":{"start_line":66,"start_character":88,"end_line":66,"end_character":94},"updated":"2016-02-06 13:41:07.000000000","message":"nit: \"cut\"","commit_id":"3bf6eab1eb9fde68de899e82294758efcbaaf46e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d474eca6074c9397e043c9b596b6f13c91daf6e2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if $name \u003d~ /^radosgw\\..+/ {"},{"line_number":65,"context_line":"    $name_real \u003d regsubst($name, \u0027^radosgw\\.(.+)$\u0027, \u0027\\1\u0027)"},{"line_number":66,"context_line":"    warning (\"No more need to pass name that starts with \u0027radosgw\u0027, this prefix will be cutted.\")"},{"line_number":67,"context_line":"  } else {"},{"line_number":68,"context_line":"    $name_real \u003d $name"},{"line_number":69,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a5ae5dd_bfcd9086","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":39},"updated":"2016-02-06 13:41:07.000000000","message":"nit: \"pass a name\"","commit_id":"3bf6eab1eb9fde68de899e82294758efcbaaf46e"}],"spec/defines/ceph_rgw_apache_spec.rb":[{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d474eca6074c9397e043c9b596b6f13c91daf6e2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    describe \u0027activated with default params\u0027 do"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"      let :title do"},{"line_number":49,"context_line":"        \u0027radosgw.gateway\u0027"},{"line_number":50,"context_line":"      end"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      it { is_expected.to contain_apache__vhost(\u0027myhost.domain-radosgw\u0027).with( {"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"5a5ae5dd_bfe6f012","line":49,"range":{"start_line":49,"start_character":9,"end_line":49,"end_character":24},"updated":"2016-02-06 13:41:07.000000000","message":"is it on purpose that your testing the old value for Debian based systems and the new way for Red Hat below (see comment below).","commit_id":"3bf6eab1eb9fde68de899e82294758efcbaaf46e"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"d474eca6074c9397e043c9b596b6f13c91daf6e2","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    describe \u0027activated with default params\u0027 do"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      let :title do"},{"line_number":143,"context_line":"        \u0027gateway\u0027"},{"line_number":144,"context_line":"      end"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"      it { is_expected.to contain_apache__vhost(\u0027myhost.domain-radosgw\u0027).with( {"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"5a5ae5dd_5fefbce8","line":143,"range":{"start_line":143,"start_character":9,"end_line":143,"end_character":16},"updated":"2016-02-06 13:41:07.000000000","message":"is it on purpose that your testing the old value for Debian based systems and the new way for Red Hat below (see comment above).","commit_id":"3bf6eab1eb9fde68de899e82294758efcbaaf46e"}]}