)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"256d4835580f623b45b6ccf14c5b1637471c71b3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For Hammer and previous versions we disable the rules [2]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. http://www.spinics.net/lists/ceph-devel/msg28449.html"},{"line_number":15,"context_line":"2. https://bugzilla.redhat.com/show_bug.cgi?id\u003d1297251#c25"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6991cf92ce393b39a480289723b8354dc1903d81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a57f1b5_6ac71346","line":15,"updated":"2016-02-09 18:04:33.000000000","message":"bug is restricted","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7ae6e52663e2161ea1b144b1f7bc14558736dccc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For Hammer and previous versions we disable the rules [2]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. http://www.spinics.net/lists/ceph-devel/msg28449.html"},{"line_number":15,"context_line":"2. https://bugzilla.redhat.com/show_bug.cgi?id\u003d1297251#c25"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6991cf92ce393b39a480289723b8354dc1903d81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a57f1b5_04a0cbf3","line":15,"in_reply_to":"3a57f1b5_6ac71346","updated":"2016-02-09 20:56:31.000000000","message":"dah, sorry :(\n\nit also doesn\u0027t seem to add much to the commit message anyway as a longer explanation is in the email thread at point 1) so I will remove the reference entirely","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"}],"manifests/osd.pp":[{"author":{"_account_id":2064,"name":"Loic Dachary","email":"loic@dachary.org","username":"dachary"},"change_message_id":"96282f61fd0efa9e68e3a721fc7c7aa040d40e2c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"fi"},{"line_number":75,"context_line":"# In Hammer the udev rules might race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable the udev rules and re-enable them after prepare."},{"line_number":77,"context_line":"# More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":78,"context_line":"if [ ${release} \u003d\u003d \u0027hammer\u0027 ]; then"},{"line_number":79,"context_line":"  $UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"},{"line_number":80,"context_line":"  if [ -f $UDEV_RULES_FILE ]; then"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a5ae5dd_4b031077","line":77,"updated":"2016-02-09 14:45:10.000000000","message":"if the udev rules are not deactivated entirely, races will happen.","commit_id":"b418afa0831f8b804fb98c9543fd699d179644ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5e4564479e62b5628bf4863ecda78de1d87d298f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"fi"},{"line_number":75,"context_line":"# In Hammer the udev rules might race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable the udev rules and re-enable them after prepare."},{"line_number":77,"context_line":"# More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":78,"context_line":"if [ ${release} \u003d\u003d \u0027hammer\u0027 ]; then"},{"line_number":79,"context_line":"  $UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"},{"line_number":80,"context_line":"  if [ -f $UDEV_RULES_FILE ]; then"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a5ae5dd_2bba546f","line":77,"in_reply_to":"5a5ae5dd_4b031077","updated":"2016-02-09 14:49:14.000000000","message":"thanks will update","commit_id":"b418afa0831f8b804fb98c9543fd699d179644ba"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"2d918ce780413a0ca5be1c7f19867a74988e3140","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# In Hammer the udev rules might race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable the udev rules and re-enable them after prepare."},{"line_number":77,"context_line":"# More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":78,"context_line":"if [ ${release} \u003d\u003d \u0027hammer\u0027 ]; then"},{"line_number":79,"context_line":"  $UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"},{"line_number":80,"context_line":"  if [ -f $UDEV_RULES_FILE ]; then"},{"line_number":81,"context_line":"    mv -f $UDEV_RULES_FILE $UDEV_RULES_FILE.orig"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a5ae5dd_2b87b4d8","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":35},"updated":"2016-02-09 14:47:13.000000000","message":"release is not defined. even if you use $::ceph::repo::release it won\u0027t necessarily be the right value, as you might not use the ceph::repo class at all (for example the RHEL use-case).\nthis should be based on the package version, i.e. \u003c\u003d1.0.0 (given the shift in versioning scheme from 0.94.* to 9.2.*)","commit_id":"b418afa0831f8b804fb98c9543fd699d179644ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5e4564479e62b5628bf4863ecda78de1d87d298f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# In Hammer the udev rules might race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable the udev rules and re-enable them after prepare."},{"line_number":77,"context_line":"# More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":78,"context_line":"if [ ${release} \u003d\u003d \u0027hammer\u0027 ]; then"},{"line_number":79,"context_line":"  $UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"},{"line_number":80,"context_line":"  if [ -f $UDEV_RULES_FILE ]; then"},{"line_number":81,"context_line":"    mv -f $UDEV_RULES_FILE $UDEV_RULES_FILE.orig"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a5ae5dd_0bb5187d","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":35},"in_reply_to":"5a5ae5dd_2b87b4d8","updated":"2016-02-09 14:49:14.000000000","message":"ah, thanks","commit_id":"b418afa0831f8b804fb98c9543fd699d179644ba"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"2d918ce780413a0ca5be1c7f19867a74988e3140","unresolved":false,"context_lines":[{"line_number":103,"context_line":"if ! test -b ${data} ; then"},{"line_number":104,"context_line":"  mkdir -p ${data}"},{"line_number":105,"context_line":"fi"},{"line_number":106,"context_line":"# activate happens via udev when using the entire device"},{"line_number":107,"context_line":"if ! test -b ${data} || ! test -b ${data}1 ; then"},{"line_number":108,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":109,"context_line":"fi"},{"line_number":110,"context_line":"\","},{"line_number":111,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":112,"context_line":"set -ex"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a5ae5dd_8b190825","line":109,"range":{"start_line":106,"start_character":0,"end_line":109,"end_character":2},"updated":"2016-02-09 14:47:13.000000000","message":"if you remove the udev rules, you need to make sure to manually call activate.","commit_id":"b418afa0831f8b804fb98c9543fd699d179644ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5e4564479e62b5628bf4863ecda78de1d87d298f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"if ! test -b ${data} ; then"},{"line_number":104,"context_line":"  mkdir -p ${data}"},{"line_number":105,"context_line":"fi"},{"line_number":106,"context_line":"# activate happens via udev when using the entire device"},{"line_number":107,"context_line":"if ! test -b ${data} || ! test -b ${data}1 ; then"},{"line_number":108,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":109,"context_line":"fi"},{"line_number":110,"context_line":"\","},{"line_number":111,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":112,"context_line":"set -ex"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a5ae5dd_8ba90827","line":109,"range":{"start_line":106,"start_character":0,"end_line":109,"end_character":2},"in_reply_to":"5a5ae5dd_8b190825","updated":"2016-02-09 14:49:14.000000000","message":"ah I missed this, thanks","commit_id":"b418afa0831f8b804fb98c9543fd699d179644ba"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"74c9dfcb069fc1920069973eaf9f3c71ad3730e0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"if ! test -b ${data} ; then"},{"line_number":73,"context_line":"  mkdir -p ${data}"},{"line_number":74,"context_line":"fi"},{"line_number":75,"context_line":"# In Hammer the udev rules race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable the udev rules and re-enable them after."},{"line_number":77,"context_line":"# More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":78,"context_line":"if which rpmquery 2\u003e\u00261 \u003e /dev/null; then"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a5ae5dd_a6175253","line":75,"range":{"start_line":75,"start_character":2,"end_line":75,"end_character":12},"updated":"2016-02-09 17:12:59.000000000","message":"Only on Red Hat based distros?","commit_id":"556fc4ec91d6a62827d605dfe6c78146e554b0d2"},{"author":{"_account_id":2064,"name":"Loic Dachary","email":"loic@dachary.org","username":"dachary"},"change_message_id":"3f026975e6c017b2535f25ffcadc761ef358be7b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# In Hammer the udev rules race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable the udev rules and re-enable them after."},{"line_number":77,"context_line":"# More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":78,"context_line":"if which rpmquery 2\u003e\u00261 \u003e /dev/null; then"},{"line_number":79,"context_line":"  CEPH_OSD_MAJOR\u003d$(rpmquery --queryformat \u0027%{VERSION}\u0027 ceph-osd|cut -d. -f1,2)"},{"line_number":80,"context_line":"  if [ $(echo \"$CEPH_OSD_MAJOR \u003c\u003d 0.94\" | bc) -ne 0 ] ; then"},{"line_number":81,"context_line":"    UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a5ae5dd_a68e7225","line":78,"updated":"2016-02-09 17:06:07.000000000","message":"use ceph --version to do that in an Operating System agnostic way.","commit_id":"556fc4ec91d6a62827d605dfe6c78146e554b0d2"},{"author":{"_account_id":2064,"name":"Loic Dachary","email":"loic@dachary.org","username":"dachary"},"change_message_id":"3f026975e6c017b2535f25ffcadc761ef358be7b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"},{"line_number":114,"context_line":"if test -f ${UDEV_RULES_FILE}.disabled ; then"},{"line_number":115,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":116,"context_line":"  mv -f ${UDEV_RULES_FILE}.disabled $UDEV_RULES_FILE || true"},{"line_number":117,"context_line":"fi"},{"line_number":118,"context_line":"\","},{"line_number":119,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a5ae5dd_46c77e45","line":116,"updated":"2016-02-09 17:06:07.000000000","message":"Do not re-enable the udev rules.","commit_id":"556fc4ec91d6a62827d605dfe6c78146e554b0d2"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"256d4835580f623b45b6ccf14c5b1637471c71b3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"if [ $(echo \\\"${CEPH_OSD_MAJOR} \u003c\u003d 0.94\\\" | bc) -ne 0 ] ; then"},{"line_number":80,"context_line":"  UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"},{"line_number":81,"context_line":"  if test -f ${UDEV_RULES_FILE} ; then"},{"line_number":82,"context_line":"    mv -f ${UDEV_RULES_FILE} ${UDEV_RULES_FILE}.disabled || true"},{"line_number":83,"context_line":"  fi"},{"line_number":84,"context_line":"fi"},{"line_number":85,"context_line":"ceph-disk prepare ${cluster_option} ${data} ${journal}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a57f1b5_aa9d0b5b","line":82,"updated":"2016-02-09 18:04:33.000000000","message":"we disable udev rules and don\u0027t re-enable them. We rely on the call to ceph-disk activate to mount the device and start the OSD. Either we re-enable the udev rules or clean up what we loose","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7ae6e52663e2161ea1b144b1f7bc14558736dccc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"if [ $(echo \\\"${CEPH_OSD_MAJOR} \u003c\u003d 0.94\\\" | bc) -ne 0 ] ; then"},{"line_number":80,"context_line":"  UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"},{"line_number":81,"context_line":"  if test -f ${UDEV_RULES_FILE} ; then"},{"line_number":82,"context_line":"    mv -f ${UDEV_RULES_FILE} ${UDEV_RULES_FILE}.disabled || true"},{"line_number":83,"context_line":"  fi"},{"line_number":84,"context_line":"fi"},{"line_number":85,"context_line":"ceph-disk prepare ${cluster_option} ${data} ${journal}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a57f1b5_e4256fae","line":82,"in_reply_to":"3a57f1b5_aa9d0b5b","updated":"2016-02-09 20:56:31.000000000","message":"I think it\u0027s somewhat still safer to disable the rules without removing the file?","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"256d4835580f623b45b6ccf14c5b1637471c71b3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"if ! test -b ${data} ; then"},{"line_number":102,"context_line":"  mkdir -p ${data}"},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":"# activate happens via udev when using the entire device"},{"line_number":105,"context_line":"if ! test -b ${data} || ! test -b ${data}1 ; then"},{"line_number":106,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":107,"context_line":"fi"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a57f1b5_0aad3f88","line":104,"updated":"2016-02-09 18:04:33.000000000","message":"I\u0027m not sure why we don\u0027t just always send activate","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7ae6e52663e2161ea1b144b1f7bc14558736dccc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"if ! test -b ${data} ; then"},{"line_number":102,"context_line":"  mkdir -p ${data}"},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":"# activate happens via udev when using the entire device"},{"line_number":105,"context_line":"if ! test -b ${data} || ! test -b ${data}1 ; then"},{"line_number":106,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":107,"context_line":"fi"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a57f1b5_843efbb6","line":104,"in_reply_to":"3a57f1b5_0aad3f88","updated":"2016-02-09 20:56:31.000000000","message":"you mean activate is idempotent and can be given multiple times?","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"},{"author":{"_account_id":2064,"name":"Loic Dachary","email":"loic@dachary.org","username":"dachary"},"change_message_id":"40e67223f2d37027e4ec3bc830e4f4bd0a79a173","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  mkdir -p ${data}"},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":"# activate happens via udev when using the entire device"},{"line_number":105,"context_line":"if ! test -b ${data} || ! test -b ${data}1 ; then"},{"line_number":106,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":107,"context_line":"fi"},{"line_number":108,"context_line":"# Before Hammer we delete the udev rules so activation must be executed"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a57f1b5_f6b3d308","line":105,"updated":"2016-02-10 05:14:38.000000000","message":"This is for when data is a directory.","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"256d4835580f623b45b6ccf14c5b1637471c71b3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"if ! test -b ${data} || ! test -b ${data}1 ; then"},{"line_number":106,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":107,"context_line":"fi"},{"line_number":108,"context_line":"# Before Hammer we delete the udev rules so activation must be executed"},{"line_number":109,"context_line":"# when using entire devices too."},{"line_number":110,"context_line":"# More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":111,"context_line":"UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a57f1b5_cab5e7d0","line":108,"updated":"2016-02-09 18:04:33.000000000","message":"We can end up sending activate twice here, so lets try to merge the two","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7ae6e52663e2161ea1b144b1f7bc14558736dccc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"if ! test -b ${data} || ! test -b ${data}1 ; then"},{"line_number":106,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":107,"context_line":"fi"},{"line_number":108,"context_line":"# Before Hammer we delete the udev rules so activation must be executed"},{"line_number":109,"context_line":"# when using entire devices too."},{"line_number":110,"context_line":"# More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":111,"context_line":"UDEV_RULES_FILE\u003d/usr/lib/udev/rules.d/95-ceph-osd.rules"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a57f1b5_244b875b","line":108,"in_reply_to":"3a57f1b5_cab5e7d0","updated":"2016-02-09 20:56:31.000000000","message":"right, thanks!","commit_id":"c8ca6b6ac478df276967eb19c78758b094225c22"},{"author":{"_account_id":2064,"name":"Loic Dachary","email":"loic@dachary.org","username":"dachary"},"change_message_id":"00022bb2495bce6cbfe3bc7c97c54649391201d0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":"\","},{"line_number":123,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":124,"context_line":"set -ex"},{"line_number":125,"context_line":"ceph-disk list | grep -E \u0027 *${data}1? .*ceph data, active\u0027 ||"},{"line_number":126,"context_line":"ls -ld /var/lib/ceph/osd/${cluster_name}-* | grep \u0027 ${data}\\$\u0027"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"3a57f1b5_2245496f","line":123,"updated":"2016-02-11 15:30:40.000000000","message":"You can remove this \"unless\".","commit_id":"5c9834a20d89292233501b97c8c3ecb8fee093ce"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c31ffe4a9b4d2e2728304912032e7203d83191cd","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  ceph-disk activate ${data} || true"},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":"\","},{"line_number":123,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":124,"context_line":"set -ex"},{"line_number":125,"context_line":"ceph-disk list | grep -E \u0027 *${data}1? .*ceph data, active\u0027 ||"},{"line_number":126,"context_line":"ls -ld /var/lib/ceph/osd/${cluster_name}-* | grep \u0027 ${data}\\$\u0027"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"3a57f1b5_f4404836","line":123,"in_reply_to":"3a57f1b5_2245496f","updated":"2016-02-11 16:31:43.000000000","message":"David can you comment on this? I think the exec is idempotent and maybe the \u0027ls -ld\u0027 will catch majority of the unwanted scenarios because we don\u0027t allow for configuration of the mount path. Sounds valid?","commit_id":"5c9834a20d89292233501b97c8c3ecb8fee093ce"},{"author":{"_account_id":2064,"name":"Loic Dachary","email":"loic@dachary.org","username":"dachary"},"change_message_id":"00022bb2495bce6cbfe3bc7c97c54649391201d0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"      exec { $ceph_activate_all:"},{"line_number":133,"context_line":"        command     \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":134,"context_line":"set -ex"},{"line_number":135,"context_line":"sleep 3s \u0026\u0026 ceph-disk activate-all"},{"line_number":136,"context_line":"\","},{"line_number":137,"context_line":"        logoutput   \u003d\u003e true,"},{"line_number":138,"context_line":"        refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"3a57f1b5_02228db9","line":135,"updated":"2016-02-11 15:30:40.000000000","message":"ceph-disk activate {data}1 seems better since you don\u0027t want to activate anything else.","commit_id":"5c9834a20d89292233501b97c8c3ecb8fee093ce"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c31ffe4a9b4d2e2728304912032e7203d83191cd","unresolved":false,"context_lines":[{"line_number":132,"context_line":"      exec { $ceph_activate_all:"},{"line_number":133,"context_line":"        command     \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":134,"context_line":"set -ex"},{"line_number":135,"context_line":"sleep 3s \u0026\u0026 ceph-disk activate-all"},{"line_number":136,"context_line":"\","},{"line_number":137,"context_line":"        logoutput   \u003d\u003e true,"},{"line_number":138,"context_line":"        refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"3a57f1b5_34f6e0f9","line":135,"in_reply_to":"3a57f1b5_02228db9","updated":"2016-02-11 16:31:43.000000000","message":"David, looks like I might remove this and add activation of ${data}1 to the previous exec based on existence of the .disabled rules file?","commit_id":"5c9834a20d89292233501b97c8c3ecb8fee093ce"},{"author":{"_account_id":2064,"name":"Loic Dachary","email":"loic@dachary.org","username":"dachary"},"change_message_id":"73ccc4cf86a49df61cb2555e1b05da0b520f2423","unresolved":false,"context_lines":[{"line_number":125,"context_line":"\","},{"line_number":126,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":127,"context_line":"set -ex"},{"line_number":128,"context_line":"ceph-disk list | grep -E \u0027 *${data}1? .*ceph data, active\u0027 ||"},{"line_number":129,"context_line":"ls -ld /var/lib/ceph/osd/${cluster_name}-* | grep \u0027 ${data}\\$\u0027"},{"line_number":130,"context_line":"\","},{"line_number":131,"context_line":"        logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a57f1b5_a818331f","line":128,"updated":"2016-02-11 17:30:14.000000000","message":"remove the ceph-disk list, the ls -d should be enough","commit_id":"cd0123a210b1cada46c526b8ffc827c2eb0e8e7c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ebd1589c37e27f51e19b52c1b0c505b8c0f26b61","unresolved":false,"context_lines":[{"line_number":80,"context_line":"set -ex"},{"line_number":81,"context_line":"CEPH_OSD_MAJOR\u003d\\$(ceph --version|cut -d\u0027 \u0027 -f3|cut -d. -f1,2)"},{"line_number":82,"context_line":"DISABLE_UDEV\u003d\\$(echo \\\"\\$CEPH_OSD_MAJOR \u003c\u003d 0.94\\\" | bc)"},{"line_number":83,"context_line":"test \\$DISABLE_UDEV -ne 0 \u0026\u0026 test -f ${udev_rules_file}"},{"line_number":84,"context_line":"\","},{"line_number":85,"context_line":"        logoutput \u003d\u003e true,"},{"line_number":86,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":30,"id":"3a57f1b5_4d6acd82","line":83,"updated":"2016-02-12 10:43:39.000000000","message":"this \u0027onlyif\u0027 works fine when launched locally, puppet will exit with 2 on the first run and with 0 on the second run\n\nthe idempotency issue seems to me to be related to the why how the test environment is built/rebuilt","commit_id":"54746dc9ce372481caeeda1e838edfa92cc7b5e4"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"79e8f99dfcf2afd5f6e55f93416b0664b4e35c7d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"      $udev_rules_file \u003d \u0027/usr/lib/udev/rules.d/95-ceph-osd.rules\u0027"},{"line_number":72,"context_line":"      exec { $ceph_check_udev:"},{"line_number":73,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":74,"context_line":"set -ex"},{"line_number":75,"context_line":"# Before Infernalis the udev rules race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable them. More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":77,"context_line":"mv -f ${udev_rules_file} ${udev_rules_file}.disabled || true"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"bae84128_20a5ff03","line":74,"updated":"2016-02-19 11:59:52.000000000","message":"We do not need set -ex here as on 77 we have || true\nso it will have effect for udevadm control --reload. However, udevadm control --reload is the last command in chain so its exit code will be used by default.","commit_id":"062aacc310faed9466e23088d54a0ad39d8608ed"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e23d89f201a700a2c743637ae07bdb3e26cc4d81","unresolved":false,"context_lines":[{"line_number":71,"context_line":"      $udev_rules_file \u003d \u0027/usr/lib/udev/rules.d/95-ceph-osd.rules\u0027"},{"line_number":72,"context_line":"      exec { $ceph_check_udev:"},{"line_number":73,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":74,"context_line":"set -ex"},{"line_number":75,"context_line":"# Before Infernalis the udev rules race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable them. More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":77,"context_line":"mv -f ${udev_rules_file} ${udev_rules_file}.disabled || true"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"bae84128_8625fcc3","line":74,"in_reply_to":"bae84128_20a5ff03","updated":"2016-02-22 16:33:58.000000000","message":"yeah this stayed here from the previous patchsets\n\nit looks like we can also do:\n\n  mv ... \u0026\u0026 udevadm control --reload || true\n\nto avoid unnecessary runs of reload, looks valid?","commit_id":"062aacc310faed9466e23088d54a0ad39d8608ed"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"26be848b25f94541f078f247212d8121aa651614","unresolved":false,"context_lines":[{"line_number":71,"context_line":"      $udev_rules_file \u003d \u0027/usr/lib/udev/rules.d/95-ceph-osd.rules\u0027"},{"line_number":72,"context_line":"      exec { $ceph_check_udev:"},{"line_number":73,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":74,"context_line":"set -ex"},{"line_number":75,"context_line":"# Before Infernalis the udev rules race causing the activation to fail so we"},{"line_number":76,"context_line":"# disable them. More at: http://www.spinics.net/lists/ceph-devel/msg28436.html"},{"line_number":77,"context_line":"mv -f ${udev_rules_file} ${udev_rules_file}.disabled || true"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"bae84128_e3ff33a8","line":74,"in_reply_to":"bae84128_8625fcc3","updated":"2016-02-22 17:26:47.000000000","message":"+1 to avoiding the unnecessary reloads.","commit_id":"062aacc310faed9466e23088d54a0ad39d8608ed"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"79e8f99dfcf2afd5f6e55f93416b0664b4e35c7d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"udevadm control --reload"},{"line_number":79,"context_line":"\","},{"line_number":80,"context_line":"        onlyif    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":81,"context_line":"set -ex"},{"line_number":82,"context_line":"CEPH_OSD_MAJOR\u003d\\$(ceph --version|cut -d\u0027 \u0027 -f3|cut -d. -f1,2)"},{"line_number":83,"context_line":"DISABLE_UDEV\u003d\\$(echo \\\"\\$CEPH_OSD_MAJOR \u003c\u003d 0.94\\\" | bc || echo 0)"},{"line_number":84,"context_line":"test \\$DISABLE_UDEV -ne 0 \u0026\u0026 test -f ${udev_rules_file}"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"bae84128_dd307c0a","line":81,"updated":"2016-02-19 11:59:52.000000000","message":"line 81-84 can be replaced with simple\n\nceph --version | awk \u0027match($3, /[0-9]\\.[0-9]+/) {if (substr($3, RSTART, RLENGTH) \u003c\u003d 0.94) {exit 1}}\u0027\n\n\nhere is the output\nroot@node-1:~# ceph --version | awk \u0027match($3, /[0-9]\\.[0-9]+/) {if (substr($3, RSTART, RLENGTH) \u003c\u003d 0.94) {exit 1}}\u0027\nroot@node-1:~# echo $?\n1\nroot@node-1:~# ceph --version | awk \u0027match($3, /[0-9]\\.[0-9]+/) {if (substr($3, RSTART, RLENGTH) \u003c\u003d 0.93) {exit 1}}\u0027\nroot@node-1:~# echo $?\n0\nroot@node-1:~# ceph --version\nceph version 0.94.5 (9764da52395923e0b32908d83a9f7304401fee43)","commit_id":"062aacc310faed9466e23088d54a0ad39d8608ed"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e23d89f201a700a2c743637ae07bdb3e26cc4d81","unresolved":false,"context_lines":[{"line_number":78,"context_line":"udevadm control --reload"},{"line_number":79,"context_line":"\","},{"line_number":80,"context_line":"        onlyif    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":81,"context_line":"set -ex"},{"line_number":82,"context_line":"CEPH_OSD_MAJOR\u003d\\$(ceph --version|cut -d\u0027 \u0027 -f3|cut -d. -f1,2)"},{"line_number":83,"context_line":"DISABLE_UDEV\u003d\\$(echo \\\"\\$CEPH_OSD_MAJOR \u003c\u003d 0.94\\\" | bc || echo 0)"},{"line_number":84,"context_line":"test \\$DISABLE_UDEV -ne 0 \u0026\u0026 test -f ${udev_rules_file}"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"bae84128_fbe19d9b","line":81,"in_reply_to":"bae84128_dd307c0a","updated":"2016-02-22 16:33:58.000000000","message":"sure, it\u0027s some serious awk-fu but diminishes the need for pipes and variable so thanks!","commit_id":"062aacc310faed9466e23088d54a0ad39d8608ed"}]}