)]}'
{"manifests/mon.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b1f4d43c3ab46fdae150eb7d9497ac95d20a9d39","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"      if $public_addr {"},{"line_number":132,"context_line":"        $public_addr_option \u003d \"--public_addr ${public_addr}\""},{"line_number":133,"context_line":"        ceph_config {"},{"line_number":134,"context_line":"          \"mon.${id}/public_addr\": value \u003d\u003e $public_addr;"},{"line_number":135,"context_line":"        }"},{"line_number":136,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dae33548_a03722af","line":133,"updated":"2016-02-15 19:16:32.000000000","message":"not sure if you guys think we should have some ensure absent if public_addr is undef?","commit_id":"1a0f897da7234c70e4c94ef83de6d184c4efd911"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0d46bb9a0c7c774dfab4f67a611af69e835d35ba","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        timeout   \u003d\u003e $exec_timeout,"},{"line_number":224,"context_line":"      } -\u003e"},{"line_number":225,"context_line":"      ceph_config {"},{"line_number":226,"context_line":"        \"mon.${id}/public_addr\": ensure \u003d\u003e absent;"},{"line_number":227,"context_line":"      } -\u003e Package\u003c| tag \u003d\u003d \u0027ceph\u0027 |\u003e"},{"line_number":228,"context_line":"    }"},{"line_number":229,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9aed3d3a_a31859d4","line":226,"updated":"2016-02-29 17:58:08.000000000","message":"the centos beaker test will fail because the output from [1] is not the same when the stanza named [mon.$id] is still in the config file, even though empty\n\nhow can we remove the stanza entirely?\n\n1. https://github.com/openstack/puppet-ceph/blob/master/spec/acceptance/ceph_usecases_spec.rb#L101","commit_id":"4c936de45d87f1b2d9c5daba72f5ebb219157158"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"388d186a0ce1f785bb2887b1439407e292fe9b99","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        timeout   \u003d\u003e $exec_timeout,"},{"line_number":224,"context_line":"      } -\u003e"},{"line_number":225,"context_line":"      ceph_config {"},{"line_number":226,"context_line":"        \"mon.${id}/public_addr\": ensure \u003d\u003e absent;"},{"line_number":227,"context_line":"      } -\u003e Package\u003c| tag \u003d\u003d \u0027ceph\u0027 |\u003e"},{"line_number":228,"context_line":"    }"},{"line_number":229,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5aef4532_e9662528","line":226,"in_reply_to":"9aed3d3a_a31859d4","updated":"2016-03-08 08:48:32.000000000","message":"there was a change for puppetlabs-inifile which should fix this by removing an empty stanza when the last key is deleted from it [1]\n\n1. https://github.com/puppetlabs/puppetlabs-inifile/commit/2027a0b2ab5d2a2c71220617fc7331c3d13e3c29","commit_id":"4c936de45d87f1b2d9c5daba72f5ebb219157158"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"55f0e1070211be9a515e9bd55f8686d2e6f49d73","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        timeout   \u003d\u003e $exec_timeout,"},{"line_number":224,"context_line":"      } -\u003e"},{"line_number":225,"context_line":"      ceph_config {"},{"line_number":226,"context_line":"        \"mon.${id}/public_addr\": ensure \u003d\u003e absent;"},{"line_number":227,"context_line":"      } -\u003e Package\u003c| tag \u003d\u003d \u0027ceph\u0027 |\u003e"},{"line_number":228,"context_line":"    }"},{"line_number":229,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5aef4532_ef63c53f","line":226,"updated":"2016-03-08 09:33:30.000000000","message":"the centos beaker test will fail because the output from [1] is not the same after the config setting has been removed, because the ini stanza named [mon.$id] is still in the config file, even though empty\n\na recent change for puppetlabs-inifile should fix this by removing an empty stanza when the last key is deleted from it [2]\n\n1. https://github.com/openstack/puppet-ceph/blob/master/spec/acceptance/ceph_usecases_spec.rb#L101\n2. https://github.com/puppetlabs/puppetlabs-inifile/commit/2027a0b2ab5d2a2c71220617fc7331c3d13e3c29","commit_id":"76f84d49cd451519f1240855be44696b924315de"}],"manifests/profile/mon.pp":[{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"2631133d42b7822860ee81167444241e42e752e7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class ceph::profile::mon {"},{"line_number":24,"context_line":"  require ::ceph::profile::base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  Ceph_Config\u003c| |\u003e -\u003e"},{"line_number":27,"context_line":"  ceph::mon { $::hostname:"},{"line_number":28,"context_line":"    authentication_type \u003d\u003e $ceph::profile::params::authentication_type,"},{"line_number":29,"context_line":"    key                 \u003d\u003e $ceph::profile::params::mon_key,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dae33548_2e2e05a5","side":"PARENT","line":26,"updated":"2016-02-17 11:17:02.000000000","message":"Why you have removed this?","commit_id":"998e023d8f20584220d8c4ab2eed27541cd7ef98"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"334630ed07cc09dccef6871f7e26041093315d78","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class ceph::profile::mon {"},{"line_number":24,"context_line":"  require ::ceph::profile::base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  Ceph_Config\u003c| |\u003e -\u003e"},{"line_number":27,"context_line":"  ceph::mon { $::hostname:"},{"line_number":28,"context_line":"    authentication_type \u003d\u003e $ceph::profile::params::authentication_type,"},{"line_number":29,"context_line":"    key                 \u003d\u003e $ceph::profile::params::mon_key,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dae33548_940c843c","side":"PARENT","line":26,"in_reply_to":"dae33548_2e2e05a5","updated":"2016-02-17 11:35:14.000000000","message":"if we keep it here the ceph_config editing in ::mon will cause a circular dependency\n\nthe requirement on Ceph_Config is ensured already by the ::mon resource itself [1], I think it belongs there as it happens for the ::osd and ::rgw resources too\n\n1. https://github.com/openstack/puppet-ceph/blob/master/manifests/mon.pp#L135","commit_id":"998e023d8f20584220d8c4ab2eed27541cd7ef98"}],"manifests/profile/params.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"3bb5f28e3c32747f9e5f8b5c7ccd05b34b68b828","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*public_addr*] The bind IP address."},{"line_number":80,"context_line":"#   Optional. The IPv(4|6) address on which MON binds itself."},{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"# [*mon_key*] The mon secret key."},{"line_number":83,"context_line":"#   Optional. Either mon_key or mon_keyring need to be set when using cephx."},{"line_number":84,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5aef4532_3ef33c75","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":1},"updated":"2016-03-07 20:53:32.000000000","message":"Please add a note to clarify when one would want to use this a)when not specifying public_network, b) when their is more than one interface on the same network (where you would have used public_network instead. and in all cases is only needed for the monitor its self, not the clients","commit_id":"4c936de45d87f1b2d9c5daba72f5ebb219157158"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"388d186a0ce1f785bb2887b1439407e292fe9b99","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*public_addr*] The bind IP address."},{"line_number":80,"context_line":"#   Optional. The IPv(4|6) address on which MON binds itself."},{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"# [*mon_key*] The mon secret key."},{"line_number":83,"context_line":"#   Optional. Either mon_key or mon_keyring need to be set when using cephx."},{"line_number":84,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5aef4532_c99409e4","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":1},"in_reply_to":"5aef4532_3ef33c75","updated":"2016-03-08 08:48:32.000000000","message":"agreed, good idea, thanks!","commit_id":"4c936de45d87f1b2d9c5daba72f5ebb219157158"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"a45f346f081d34f0a254707c229d297616179c08","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# [*public_network*] The address of the public network."},{"line_number":77,"context_line":"#   Optional. {public-network-ip/netmask}"},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*public_addr*] The bind IP address."},{"line_number":80,"context_line":"#   Optional. The IPv(4|6) address on which MON binds itself."},{"line_number":81,"context_line":"#   This is useful when not specifying public_network or when there is more than one IP address on"},{"line_number":82,"context_line":"#   the same network and you want to be specific about the IP to bind the MON on."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5aef4532_c7104904","line":79,"range":{"start_line":79,"start_character":18,"end_line":79,"end_character":26},"updated":"2016-03-09 00:21:06.000000000","message":"nit: \"The MON bind...\"","commit_id":"76f84d49cd451519f1240855be44696b924315de"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f4f6f57165ffba2961b8df49e9af0b74b06d5e66","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# [*public_network*] The address of the public network."},{"line_number":77,"context_line":"#   Optional. {public-network-ip/netmask}"},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*public_addr*] The bind IP address."},{"line_number":80,"context_line":"#   Optional. The IPv(4|6) address on which MON binds itself."},{"line_number":81,"context_line":"#   This is useful when not specifying public_network or when there is more than one IP address on"},{"line_number":82,"context_line":"#   the same network and you want to be specific about the IP to bind the MON on."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5aef4532_442d4945","line":79,"range":{"start_line":79,"start_character":18,"end_line":79,"end_character":26},"in_reply_to":"5aef4532_c7104904","updated":"2016-03-09 08:14:06.000000000","message":"ack, thanks","commit_id":"76f84d49cd451519f1240855be44696b924315de"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"a7b575f0e79ddd501ad29e57b79fe6775ff1dc63","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# [*public_network*] The address of the public network."},{"line_number":77,"context_line":"#   Optional. {public-network-ip/netmask}"},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*public_addr*] The MON bind IP address."},{"line_number":80,"context_line":"#   Optional. The IPv(4|6) address on which MON binds itself."},{"line_number":81,"context_line":"#   This is useful when not specifying public_network or when there is more than one IP address on"},{"line_number":82,"context_line":"#   the same network and you want to be specific about the IP to bind the MON on."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5aef4532_cd881a74","line":79,"updated":"2016-03-10 02:48:46.000000000","message":"I\u0027m thinking this is a bit awkward. For me, .*::params is a way to have constant variables or defaults shared across different manifests. Most/all of the other variables are a good fit here as they could be re-used in different places and are not exclusive to any single host. Now, we have public_addr which is the bind IP for *one* monitor. If there is more than one monitor (fairly standard to have at least 3) this means this parameter *needs* to be at the host hierarchy (hiera). Is this the intended use case ?","commit_id":"134e431719c986474c6e967569ab7544ac84909a"}]}