)]}'
{"manifests/osd.pp":[{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"05ef9a7907fee9523b47e706fc56efa213f335b9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"if [ \\\"\\$id\\\" ] ; then"},{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove \\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_1948b6cb","line":143,"updated":"2016-03-17 15:19:36.000000000","message":"seems that correct is osd.id","commit_id":"9cecc5ccfb271fa0815277c6a7cf95c8c425feef"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"388a4a73fb5cc14468e33e9b9ddd5d89be77b533","unresolved":false,"context_lines":[{"line_number":140,"context_line":"if [ \\\"\\$id\\\" ] ; then"},{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove \\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_77145e9f","line":143,"in_reply_to":"1af94dfe_0c5191d8","updated":"2016-03-17 16:57:26.000000000","message":"Of course, I meant to say \"I\u0027m sorry Oleksiy.\" and not the opposite. My english is very bad, I know !","commit_id":"9cecc5ccfb271fa0815277c6a7cf95c8c425feef"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"45bc85b28ace1dc334f5d120a43c5a4af8c19b40","unresolved":false,"context_lines":[{"line_number":140,"context_line":"if [ \\\"\\$id\\\" ] ; then"},{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove \\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_c06c92d2","line":143,"in_reply_to":"1af94dfe_1948b6cb","updated":"2016-03-17 15:40:52.000000000","message":"I don\u0027t think so, if we trust the official documentation:\nhttps://access.redhat.com/documentation/en/red-hat-ceph-storage/version-1.3/red-hat-ceph-storage-13-red-hat-ceph-administration-guide/#removing-osds-manual","commit_id":"9cecc5ccfb271fa0815277c6a7cf95c8c425feef"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"f30edf69517979e8cc921ef28fc3027337e50709","unresolved":false,"context_lines":[{"line_number":140,"context_line":"if [ \\\"\\$id\\\" ] ; then"},{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove \\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_c62305a6","line":143,"in_reply_to":"1af94dfe_77145e9f","updated":"2016-03-17 17:20:32.000000000","message":"No worries, Emilien. I know that because I used this doc yesterday \u003d)))","commit_id":"9cecc5ccfb271fa0815277c6a7cf95c8c425feef"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"9f5d04b0f2b8db5678d6d546277c1f24bd87bee2","unresolved":false,"context_lines":[{"line_number":140,"context_line":"if [ \\\"\\$id\\\" ] ; then"},{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove \\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_c642ea67","line":143,"in_reply_to":"1af94dfe_a3d4f0bc","updated":"2016-03-17 16:16:04.000000000","message":"Are you sure it does ? \n\n2016-03-17 15:24:10.081 |   Notice: /Stage[main]/Main/Ceph::Osd[/srv/data]/Exec[remove-osd-/srv/data]/returns: + ceph osd crush remove 0\n2016-03-17 15:24:10.081 |   Notice: /Stage[main]/Main/Ceph::Osd[/srv/data]/Exec[remove-osd-/srv/data]/returns: device \u00270\u0027 does not appear in the crush map","commit_id":"9cecc5ccfb271fa0815277c6a7cf95c8c425feef"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fac1f51e4afd85422abe9bf8929d5662200d6726","unresolved":false,"context_lines":[{"line_number":140,"context_line":"if [ \\\"\\$id\\\" ] ; then"},{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove \\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_a3d4f0bc","line":143,"in_reply_to":"1af94dfe_c06c92d2","updated":"2016-03-17 15:58:40.000000000","message":"If you look at CI job:\nhttp://logs.openstack.org/91/294091/1/check/gate-puppet-ceph-puppet-beaker-rspec-dsvm-centos7/88e9ca3/console.html#_2016-03-17_15_24_10_081\n\nMy patch actually works.","commit_id":"9cecc5ccfb271fa0815277c6a7cf95c8c425feef"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6f5fd1290d5761b8c4fc0acf8a922bb470775f3b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"if [ \\\"\\$id\\\" ] ; then"},{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove \\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_0c5191d8","line":143,"in_reply_to":"1af94dfe_c642ea67","updated":"2016-03-17 16:35:40.000000000","message":"Ok I was wrong :-)\nApologize Oleksiy!","commit_id":"9cecc5ccfb271fa0815277c6a7cf95c8c425feef"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c596732b794aef6878f6a01c2a93e3c1fb26fd82","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove osd.\\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"},{"line_number":147,"context_line":"  umount /var/lib/ceph/osd/${cluster_name}-\\$id || true"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_f246b279","line":144,"updated":"2016-03-17 20:36:12.000000000","message":"ceph ${cluster_option} ...","commit_id":"c94c0786a6130f2f21d712fbfdc59b43b7a4d446"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"32c404611926b02ecbcdb3162cdc465a8a85ebf6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  stop ceph-osd cluster\u003d${cluster_name} id\u003d\\$id || true"},{"line_number":142,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":143,"context_line":"  ceph ${cluster_option} osd crush remove osd.\\$id"},{"line_number":144,"context_line":"  ceph auth del osd.\\$id"},{"line_number":145,"context_line":"  ceph ${cluster_option} osd rm \\$id"},{"line_number":146,"context_line":"  rm -fr /var/lib/ceph/osd/${cluster_name}-\\$id/*"},{"line_number":147,"context_line":"  umount /var/lib/ceph/osd/${cluster_name}-\\$id || true"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_9560f8d0","line":144,"in_reply_to":"1af94dfe_f246b279","updated":"2016-03-17 20:43:39.000000000","message":"Done","commit_id":"c94c0786a6130f2f21d712fbfdc59b43b7a4d446"}],"spec/defines/ceph_osd_spec.rb":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c596732b794aef6878f6a01c2a93e3c1fb26fd82","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  stop ceph-osd cluster\u003dceph id\u003d\\$id || true"},{"line_number":170,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":171,"context_line":"  ceph  osd crush remove osd.\\$id"},{"line_number":172,"context_line":"  ceph auth del osd.\\$id"},{"line_number":173,"context_line":"  ceph  osd rm \\$id"},{"line_number":174,"context_line":"  rm -fr /var/lib/ceph/osd/ceph-\\$id/*"},{"line_number":175,"context_line":"  umount /var/lib/ceph/osd/ceph-\\$id || true"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1af94dfe_12399ef2","line":172,"updated":"2016-03-17 20:36:12.000000000","message":"this should have two spaces as well then, \u0027ceph  auth del\u0027","commit_id":"c94c0786a6130f2f21d712fbfdc59b43b7a4d446"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"32c404611926b02ecbcdb3162cdc465a8a85ebf6","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  stop ceph-osd cluster\u003dceph id\u003d\\$id || true"},{"line_number":170,"context_line":"  service ceph stop osd.\\$id || true"},{"line_number":171,"context_line":"  ceph  osd crush remove osd.\\$id"},{"line_number":172,"context_line":"  ceph auth del osd.\\$id"},{"line_number":173,"context_line":"  ceph  osd rm \\$id"},{"line_number":174,"context_line":"  rm -fr /var/lib/ceph/osd/ceph-\\$id/*"},{"line_number":175,"context_line":"  umount /var/lib/ceph/osd/ceph-\\$id || true"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1af94dfe_950118b2","line":172,"in_reply_to":"1af94dfe_12399ef2","updated":"2016-03-17 20:43:39.000000000","message":"Done","commit_id":"c94c0786a6130f2f21d712fbfdc59b43b7a4d446"}]}