)]}'
{"id":"openstack%2Fpuppet-ceph~295989","triplet_id":"openstack%2Fpuppet-ceph~master~Id52648888f3db1537b95190b7eb41777bac36eed","project":"openstack/puppet-ceph","branch":"master","topic":"add-rgw-key-param","hashtags":[],"change_id":"Id52648888f3db1537b95190b7eb41777bac36eed","subject":"Add rgw_key to profile/params.pp","status":"ABANDONED","created":"2016-03-22 18:28:08.000000000","updated":"2017-02-23 16:57:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"88bb40b5f4140a513ac1710dae8436c580a487d7","_number":295989,"virtual_id_number":295989,"owner":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-03-23 01:28:33.000000000","_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},{"value":-1,"date":"2016-03-24 00:11:54.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},{"value":-1,"date":"2016-03-22 20:37:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-03-22 18:29:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},{"date":"2016-04-07 14:41:18.000000000","_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-22 18:29:49.000000000","updated_by":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"reviewer":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"state":"REVIEWER"},{"updated":"2016-03-22 20:37:17.000000000","updated_by":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"reviewer":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"state":"REVIEWER"},{"updated":"2016-03-24 00:11:54.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-04-07 14:41:18.000000000","updated_by":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"reviewer":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"state":"REVIEWER"}],"messages":[{"id":"32cd05089e687366ed56fadd228a53e7450d4a5b","author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"date":"2016-03-22 18:28:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b58a5178661e83f2c42d1d3d9ae7109437aa9091","author":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"date":"2016-03-22 18:29:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5d1078e3ea87e38f8e3f9eff9e1a0bfd4db881a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 18:58:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-ceph-puppet-lint http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-lint/125cc69/ : SUCCESS in 8m 31s\n- gate-puppet-ceph-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-syntax-3-dsvm-centos7/24e6cef/ : SUCCESS in 3m 39s\n- gate-puppet-ceph-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-syntax-4-dsvm-centos7/1f8cf53/ : SUCCESS in 4m 59s\n- gate-puppet-ceph-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-unit-3.3-dsvm-centos7/f1ac30c/ : SUCCESS in 5m 10s\n- gate-puppet-ceph-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-unit-3.4-dsvm-centos7/8a7f5ac/ : SUCCESS in 6m 55s\n- gate-puppet-ceph-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-unit-3.6-dsvm-centos7/4535b50/ : SUCCESS in 5m 25s\n- gate-puppet-ceph-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-unit-3.7-dsvm-centos7/4c50443/ : SUCCESS in 7m 11s\n- gate-puppet-ceph-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-unit-3.8-dsvm-centos7/300386f/ : SUCCESS in 9m 35s\n- gate-puppet-ceph-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-unit-4.0-dsvm-centos7/cee9d06/ : SUCCESS in 6m 13s\n- gate-puppet-ceph-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-unit-latest-dsvm-centos7/d55894d/ : SUCCESS in 3m 52s (non-voting)\n- gate-puppet-ceph-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-beaker-rspec-dsvm-trusty/67d59aa/ : SUCCESS in 11m 37s\n- gate-puppet-ceph-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-ceph-puppet-beaker-rspec-dsvm-centos7/e3db08d/ : SUCCESS in 10m 00s\n- gate-puppet-openstack-integration-3-scenario001-tempest-dsvm-trusty http://logs.openstack.org/89/295989/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-dsvm-trusty/5fec265/ : SUCCESS in 26m 21s\n- gate-puppet-openstack-integration-3-scenario001-tempest-dsvm-centos7 http://logs.openstack.org/89/295989/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-dsvm-centos7/8c635c4/ : SUCCESS in 25m 11s","accounts_in_message":[],"_revision_number":1},{"id":"b793f1902533b33333821ff28d5ae89f1bfec4dd","author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"date":"2016-03-22 20:37:17.000000000","message":"Patch Set 1: Code-Review-1\n\nthis has no functionality.","accounts_in_message":[],"_revision_number":1},{"id":"82652f0c2b8b8620c081078f81d12625a374f818","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 20:41:26.000000000","message":"Patch Set 1:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/89/295989/1/check-tripleo/gate-tripleo-ci-f22-nonha/b5192b5/ : FAILURE in 1h 22m 37s","accounts_in_message":[],"_revision_number":1},{"id":"0af82633227180c1ec2ffaf87e553db19a8d6c83","author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"date":"2016-03-23 01:28:33.000000000","message":"Patch Set 1:\n\nNot in itself. It is variable to be used by https://review.openstack.org/#/c/289027/ to allow heat to set the secret value and create the keyring for rgw.","accounts_in_message":[],"_revision_number":1},{"id":"260b1f287374767a87e7165f92369ec6e909ebde","author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"date":"2016-03-23 18:27:22.000000000","message":"Patch Set 1:\n\nthat\u0027s a weird way of mixing concerns. if you need to have a variable to pass to the overcloud via hiera, create one there - it doesn\u0027t make sense here.","accounts_in_message":[],"_revision_number":1},{"id":"c3529fdc312e91d67f86e7b73c6c237009bc782d","author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"date":"2016-03-23 18:40:18.000000000","message":"Patch Set 1:\n\nDavid, I am on a learning curve and currently have half a hammer in my tool box. Can I simply add a key/value to a namespace in hiera without a matching puppet entry.","accounts_in_message":[],"_revision_number":1},{"id":"d4c40592b29865eac8781da131d0b8938df8cc78","author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"date":"2016-03-23 19:36:53.000000000","message":"Patch Set 1:\n\nHei Keith,\n\nyes you can. but then you need to pull it in via the hiera command: \"hiera(\"ceph_rgw_keys\", \u0027\u0027)\".\n\nHere\u0027s an example:\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/manifests/overcloud_controller_pacemaker.pp#L574","accounts_in_message":[],"_revision_number":1},{"id":"d0b48cb9113c2b0702d48787f1e31aa1a2eb9a26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-24 00:11:54.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"609d5d2b7524e8f09664383ca478144afc1c83b5","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2017-02-23 16:57:35.000000000","message":"Abandoned\n\nAbandoning per our policy[0].  If you wish to continue this work, please restore this or let us know in #puppet-openstack and we can restore it.\n\n[0] https://docs.openstack.org/developer/puppet-openstack-guide/reviews.html","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"18271a952ac63e053263fcc25f79c3818bfe319d","revisions":{"18271a952ac63e053263fcc25f79c3818bfe319d":{"kind":"REWORK","_number":1,"created":"2016-03-22 18:28:08.000000000","uploader":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"ref":"refs/changes/89/295989/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-ceph","ref":"refs/changes/89/295989/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-ceph refs/changes/89/295989/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-ceph refs/changes/89/295989/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-ceph refs/changes/89/295989/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-ceph refs/changes/89/295989/1"}}},"commit":{"parents":[{"commit":"50c071263643349570401446ce1aeaea45cdb67b","subject":"Merge \"Fix check for osd prepare\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-ceph/commit/50c071263643349570401446ce1aeaea45cdb67b"}]}],"author":{"name":"Keith Schincke","email":"keith.schincke@gmail.com","date":"2016-03-22 18:25:47.000000000","tz":-240},"committer":{"name":"Keith Schincke","email":"keith.schincke@gmail.com","date":"2016-03-22 18:25:47.000000000","tz":-240},"subject":"Add rgw_key to profile/params.pp","message":"Add rgw_key to profile/params.pp\n\nThis patch add support for the optional parameter rgw_key to the\nprofile/params.pp. This allows the RGW keyring secret to be passed\nin as hiera value\n\nChange-Id: Id52648888f3db1537b95190b7eb41777bac36eed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-ceph/commit/18271a952ac63e053263fcc25f79c3818bfe319d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-ceph/commit/18271a952ac63e053263fcc25f79c3818bfe319d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"50c071263643349570401446ce1aeaea45cdb67b","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}