)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"1c15168ae2dbc8bbf4f6cbe58d7e4a45cd28e7f3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-04-18 13:18:57 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct typo error in ceph::rgw resulting in a hardcoded paramter being"},{"line_number":8,"context_line":"passed to ceph::rgw::civetweb"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"manifests/rgw.pp had \u0027radosgw.gateway\u0027 hardcoded as the name parameter"},{"line_number":11,"context_line":"to ceph::rgw::civetweb. This resulted in a new stanza being created in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_5d850b05","line":8,"updated":"2016-04-19 13:03:33.000000000","message":"too long, make it shorter","commit_id":"9b808e5aa4597fda86d5d24a24a75a55f9669771"}],"manifests/rgw.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b5309cf6ae6889a349527200f44b138df7f0708e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if ($frontend_type \u003d\u003d \u0027civetweb\u0027)"},{"line_number":95,"context_line":"  {"},{"line_number":96,"context_line":"    if( $rgw_frontends \u003d~ /civetweb/ )"},{"line_number":97,"context_line":"    {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba0121b8_bc151be6","line":94,"updated":"2016-03-31 12:52:47.000000000","message":"I don\u0027t understand this logic. Why not use \u003d~ directly here? Why do we need two conditionals?","commit_id":"6d1fef53403a540871cc6762b3360f6f7726015e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"7a6f7fad223a2a84504e694afb4f9047516b6cbe","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if ($frontend_type \u003d\u003d \u0027civetweb\u0027)"},{"line_number":95,"context_line":"  {"},{"line_number":96,"context_line":"    if( $rgw_frontends \u003d~ /civetweb/ )"},{"line_number":97,"context_line":"    {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba0121b8_9372bd0f","line":94,"in_reply_to":"ba0121b8_bc151be6","updated":"2016-03-31 14:54:05.000000000","message":"rgw_fontends is an optional parameter when frontend_type is civetweb. However, the default value for rgw_frontends is \"fastcgi ...\". This check set of checks will allows the admin to configure rgw to use civetweb and use the implicit settings. The only time frontend_type is civetweb and rgw_frontends contains civetweb is when the default port is being changed. \nhttp://docs.ceph.com/docs/master/install/install-ceph-gateway/?highlight\u003dcivetweb#change-the-default-port\n\nI can collapse this check to a compound if statement.","commit_id":"6d1fef53403a540871cc6762b3360f6f7726015e"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"1c15168ae2dbc8bbf4f6cbe58d7e4a45cd28e7f3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if( ($frontend_type \u003d\u003d \u0027civetweb\u0027) \u0026\u0026 ( $rgw_frontends \u003d~ /civetweb/ ) )"},{"line_number":95,"context_line":"  {"},{"line_number":96,"context_line":"    ceph::rgw::civetweb { $name:"},{"line_number":97,"context_line":"      rgw_frontends \u003d\u003e $rgw_frontends,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_3d912f48","line":94,"updated":"2016-04-19 13:03:33.000000000","message":"why for you have added this?","commit_id":"9b808e5aa4597fda86d5d24a24a75a55f9669771"}]}