)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"231ad47557f1f56e335660a369028323ad04adca","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        \u0027global/auth_supported\u0027:        value \u003d\u003e \u0027none\u0027;"},{"line_number":172,"context_line":"      }"},{"line_number":173,"context_line":"    }"},{"line_number":174,"context_line":"    #for RHEL/CentOS7, systemctl needs to reload to pickup the ceph-radosgw init file"},{"line_number":175,"context_line":"    if (($::operatingsystem \u003d\u003d \u0027RedHat\u0027 or $::operatingsystem \u003d\u003d \u0027CentOS\u0027) and (versioncmp($::operatingsystemmajrelease, \u00277\u0027) \u003e\u003d 0))"},{"line_number":176,"context_line":"    {"},{"line_number":177,"context_line":"      exec { \u0027systemctl-daemon-reload-ceph-mon\u0027: #needed for the new init file"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dab17558_b2effae7","line":174,"updated":"2016-05-10 16:10:12.000000000","message":"I\u0027m not sure we actually need that, it should be solved by packaging. And if we need that, we need to make this exec idempotent, triggered by an event (notify) and also move it in rgw manifest, not in init.pp","commit_id":"56562c4d54f2446e08811ceef31ea3721bc24de8"}],"manifests/mon.pp":[{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"47b8281b1e879aa0be0f2ededd8b07dfea38aa37","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      }"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"    # For Ubuntu Xenial system"},{"line_number":93,"context_line":"    elsif $::service_provider \u003d\u003d \u0027systemd\u0027 and $::operatingsystem \u003d\u003d \u0027Ubuntu\u0027 {"},{"line_number":94,"context_line":"      $init \u003d \u0027systemd\u0027"},{"line_number":95,"context_line":"      Service {"},{"line_number":96,"context_line":"        name     \u003d\u003e $mon_service,"}],"source_content_type":"text/x-puppet","patch_set":26,"id":"9abb7d3a_5c160ea8","line":93,"updated":"2016-06-03 02:05:06.000000000","message":"Shouldn\u0027t you also add a operatingsystemmajrelease check? Trusty/Hammer uses upstart,Xenial/Jewel uses systemd, CentOS(6|7)/Hammer uses sysvinit, CentOS7/Jewel uses systemd.","commit_id":"b9eafca0f053ba2ec645c7fb0336c0eb194ad9f5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dcf129dd7ec2f0d128c3aab2d1d88cf5364c17cb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      }"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"    # For Ubuntu Xenial system"},{"line_number":93,"context_line":"    elsif $::service_provider \u003d\u003d \u0027systemd\u0027 and $::operatingsystem \u003d\u003d \u0027Ubuntu\u0027 {"},{"line_number":94,"context_line":"      $init \u003d \u0027systemd\u0027"},{"line_number":95,"context_line":"      Service {"},{"line_number":96,"context_line":"        name     \u003d\u003e $mon_service,"}],"source_content_type":"text/x-puppet","patch_set":26,"id":"9abb7d3a_d937994b","line":93,"in_reply_to":"9abb7d3a_5c160ea8","updated":"2016-06-03 10:55:11.000000000","message":"Agree here with Keith","commit_id":"b9eafca0f053ba2ec645c7fb0336c0eb194ad9f5"}]}