)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"d8f3ea92f534fd65a7eb5be148abb702dd75443f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     cdelatte \u003ccraig.delatte@twcable.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-24 11:52:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adding OSD level params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to address bug 1488126."},{"line_number":10,"context_line":"The osd parameters added will be disabled by default as to not cause duplicate declarations for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_4e1a4f18","line":7,"updated":"2016-06-24 17:17:20.000000000","message":"Capitalization","commit_id":"bf089cd922db18d53244d9e9610519f3bdad1f32"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"d8f3ea92f534fd65a7eb5be148abb702dd75443f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adding OSD level params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to address bug 1488126."},{"line_number":10,"context_line":"The osd parameters added will be disabled by default as to not cause duplicate declarations for"},{"line_number":11,"context_line":"users defining this with in-house puppet modules"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_0e24c75b","line":9,"updated":"2016-06-24 17:17:20.000000000","message":"This should be with the Change-Id as Closes-Bug: or Related-Bug:","commit_id":"bf089cd922db18d53244d9e9610519f3bdad1f32"}],"manifests/init.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d37a9d325878efac6c73516d4fba48fd22c4844f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"#"},{"line_number":121,"context_line":"# [*osd_op_threads*] The number of threads to service Ceph OSD Daemon operations."},{"line_number":122,"context_line":"#   Set to 0 to disable it."},{"line_number":123,"context_line":"#   Optional. Default provided by Ceph"},{"line_number":124,"context_line":"#   Default value 2"},{"line_number":125,"context_line":"#"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class ceph ("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_5bf16ccc","line":124,"range":{"start_line":123,"start_character":14,"end_line":124,"end_character":19},"updated":"2016-06-24 18:03:52.000000000","message":"pick one","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"189ef2638da961dab40865652232d50ebfeb79bc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"#"},{"line_number":121,"context_line":"# [*osd_op_threads*] The number of threads to service Ceph OSD Daemon operations."},{"line_number":122,"context_line":"#   Set to 0 to disable it."},{"line_number":123,"context_line":"#   Optional. Default provided by Ceph"},{"line_number":124,"context_line":"#   Default value 2"},{"line_number":125,"context_line":"#"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class ceph ("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_9b4d949c","line":124,"range":{"start_line":123,"start_character":14,"end_line":124,"end_character":19},"in_reply_to":"3aaa91ec_5bf16ccc","updated":"2016-06-24 18:13:22.000000000","message":"fixed","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d37a9d325878efac6c73516d4fba48fd22c4844f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"      }"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    if $set_osd_params {"},{"line_number":209,"context_line":"      ceph_config {"},{"line_number":210,"context_line":"        \u0027osd/osd_max_backfills\u0027:             value \u003d\u003e $osd_max_backfills;"},{"line_number":211,"context_line":"        \u0027osd/osd_recovery_max_active\u0027:       value \u003d\u003e $osd_recovery_max_active;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_1b2a44db","line":208,"range":{"start_line":208,"start_character":4,"end_line":208,"end_character":24},"updated":"2016-06-24 18:03:52.000000000","message":"we should probably out right deprecate this, its here for backwards compat in this release, and we can drop it in the next release.\n\n\n++ for putting it in the first place","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"189ef2638da961dab40865652232d50ebfeb79bc","unresolved":false,"context_lines":[{"line_number":205,"context_line":"      }"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    if $set_osd_params {"},{"line_number":209,"context_line":"      ceph_config {"},{"line_number":210,"context_line":"        \u0027osd/osd_max_backfills\u0027:             value \u003d\u003e $osd_max_backfills;"},{"line_number":211,"context_line":"        \u0027osd/osd_recovery_max_active\u0027:       value \u003d\u003e $osd_recovery_max_active;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_db3a7ce6","line":208,"range":{"start_line":208,"start_character":4,"end_line":208,"end_character":24},"in_reply_to":"3aaa91ec_1b2a44db","updated":"2016-06-24 18:13:22.000000000","message":"yep, agree it should be deprecated in the next release","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"029affbc08700f388e2d537272da248f674fe1c7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# [*public_addr*] The address of the node (on public network.)"},{"line_number":99,"context_line":"#   Optional. {public-network-ip}"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"# [*set_osd_params*] disables setting osd params using this module by default as people"},{"line_number":102,"context_line":"#   calling ceph_config from in-house modules will get dup-declaration errors."},{"line_number":103,"context_line":"#   Boolean.  Default false."},{"line_number":104,"context_line":"#   THIS OPTION WILL BE DEPRICATED IN NEXT RELEASE"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1aa78d24_10b6013d","line":101,"updated":"2016-07-05 14:38:15.000000000","message":"where is the warning that says it\u0027s deprecated?","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"ff5feb648546958627078ce1d1dd04a7548e6ada","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# [*public_addr*] The address of the node (on public network.)"},{"line_number":99,"context_line":"#   Optional. {public-network-ip}"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"# [*set_osd_params*] disables setting osd params using this module by default as people"},{"line_number":102,"context_line":"#   calling ceph_config from in-house modules will get dup-declaration errors."},{"line_number":103,"context_line":"#   Boolean.  Default false."},{"line_number":104,"context_line":"#   THIS OPTION WILL BE DEPRICATED IN NEXT RELEASE"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1aa78d24_30785d2a","line":101,"in_reply_to":"1aa78d24_10b6013d","updated":"2016-07-05 14:55:37.000000000","message":"line 104.  will add to deprecated section as well","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"029affbc08700f388e2d537272da248f674fe1c7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# [*osd_op_threads*] The number of threads to service Ceph OSD Daemon operations."},{"line_number":123,"context_line":"#   Set to 0 to disable it."},{"line_number":124,"context_line":"#   Optional. Default provided by Ceph"},{"line_number":125,"context_line":"#"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class ceph ("},{"line_number":128,"context_line":"  $fsid,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1aa78d24_709ca5c0","line":125,"updated":"2016-07-05 14:38:15.000000000","message":"please create a # DEPRECATED section here and put set_osd_params here, like we do in other modules.","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"ff5feb648546958627078ce1d1dd04a7548e6ada","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# [*osd_op_threads*] The number of threads to service Ceph OSD Daemon operations."},{"line_number":123,"context_line":"#   Set to 0 to disable it."},{"line_number":124,"context_line":"#   Optional. Default provided by Ceph"},{"line_number":125,"context_line":"#"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class ceph ("},{"line_number":128,"context_line":"  $fsid,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1aa78d24_1090c1eb","line":125,"in_reply_to":"1aa78d24_709ca5c0","updated":"2016-07-05 14:55:37.000000000","message":"Done","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a94c8f7183b7c76230810de04f56860cde472108","unresolved":false,"context_lines":[{"line_number":123,"context_line":"# [*set_osd_params*] disables setting osd params using this module by default as people"},{"line_number":124,"context_line":"#   calling ceph_config from in-house modules will get dup-declaration errors."},{"line_number":125,"context_line":"#   Boolean.  Default false."},{"line_number":126,"context_line":"#   THIS OPTION WILL BE DEPRICATED IN NEXT RELEASE"},{"line_number":127,"context_line":"#"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class ceph ("}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_a5b16449","line":126,"updated":"2016-07-06 17:59:46.000000000","message":"deprecated, not depricated. Also please don\u0027t use uppercase. In fact, drop the line. Not useful.","commit_id":"390e2da25039c82d473453a28156bb023c1b9659"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"02419e2fa1c9b3b0154d2805f49e3d7d1362bbc0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"# [*set_osd_params*] disables setting osd params using this module by default as people"},{"line_number":124,"context_line":"#   calling ceph_config from in-house modules will get dup-declaration errors."},{"line_number":125,"context_line":"#   Boolean.  Default false."},{"line_number":126,"context_line":"#   THIS OPTION WILL BE DEPRICATED IN NEXT RELEASE"},{"line_number":127,"context_line":"#"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class ceph ("}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_40706edc","line":126,"in_reply_to":"1aa78d24_a5b16449","updated":"2016-07-06 18:41:21.000000000","message":"Done","commit_id":"390e2da25039c82d473453a28156bb023c1b9659"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a94c8f7183b7c76230810de04f56860cde472108","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  $cluster_network               \u003d undef,"},{"line_number":150,"context_line":"  $public_network                \u003d undef,"},{"line_number":151,"context_line":"  $public_addr                   \u003d undef,"},{"line_number":152,"context_line":"  $set_osd_params                \u003d false,"},{"line_number":153,"context_line":"  $osd_max_backfills             \u003d undef,"},{"line_number":154,"context_line":"  $osd_recovery_max_active       \u003d undef,"},{"line_number":155,"context_line":"  $osd_recovery_op_priority      \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_c56750b5","line":152,"updated":"2016-07-06 17:59:46.000000000","message":"2 remarks...\n\nPlease look https://github.com/openstack/puppet-nova/blob/master/manifests/api.pp#L244 and do the same here.\n\nAlso, I asked in the previous patchset to send a warning about deprecation.\nSee https://github.com/openstack/puppet-nova/blob/master/manifests/api.pp#L259-L261 for example.","commit_id":"390e2da25039c82d473453a28156bb023c1b9659"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"02419e2fa1c9b3b0154d2805f49e3d7d1362bbc0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  $cluster_network               \u003d undef,"},{"line_number":150,"context_line":"  $public_network                \u003d undef,"},{"line_number":151,"context_line":"  $public_addr                   \u003d undef,"},{"line_number":152,"context_line":"  $set_osd_params                \u003d false,"},{"line_number":153,"context_line":"  $osd_max_backfills             \u003d undef,"},{"line_number":154,"context_line":"  $osd_recovery_max_active       \u003d undef,"},{"line_number":155,"context_line":"  $osd_recovery_op_priority      \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_26ebba14","line":152,"in_reply_to":"1aa78d24_c56750b5","updated":"2016-07-06 18:41:21.000000000","message":"Done\n\nThanks for the references.  Helped a lot.  First time doing the warnings for deprecated variables.","commit_id":"390e2da25039c82d473453a28156bb023c1b9659"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"76c0c24cf9d0121d0b81566cc1a7da5d76001bd0","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  $cluster_network               \u003d undef,"},{"line_number":149,"context_line":"  $public_network                \u003d undef,"},{"line_number":150,"context_line":"  $public_addr                   \u003d undef,"},{"line_number":151,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":152,"context_line":"  $set_osd_params                \u003d false,"},{"line_number":153,"context_line":"  $osd_max_backfills             \u003d undef,"},{"line_number":154,"context_line":"  $osd_recovery_max_active       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1aa78d24_1f06ae51","line":151,"updated":"2016-07-07 03:16:48.000000000","message":"PARAMETER*S*, also please move it to the end of parameters list, like I showed you in puppet-nova...","commit_id":"7fc6bc5b86ca17ec0f7e4be83f71a841c417f4b0"}],"manifests/profile/params.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d37a9d325878efac6c73516d4fba48fd22c4844f","unresolved":false,"context_lines":[{"line_number":133,"context_line":"#"},{"line_number":134,"context_line":"# [*osd_op_threads*] The number of threads to service Ceph OSD Daemon operations."},{"line_number":135,"context_line":"#   Set to 0 to disable it."},{"line_number":136,"context_line":"#   Optional. Default provided by Ceph"},{"line_number":137,"context_line":"#   Default value 2"},{"line_number":138,"context_line":"#"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"class ceph::profile::params ("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_9ba474ba","line":137,"range":{"start_line":136,"start_character":14,"end_line":137,"end_character":19},"updated":"2016-06-24 18:03:52.000000000","message":"pick one","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"189ef2638da961dab40865652232d50ebfeb79bc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"#"},{"line_number":134,"context_line":"# [*osd_op_threads*] The number of threads to service Ceph OSD Daemon operations."},{"line_number":135,"context_line":"#   Set to 0 to disable it."},{"line_number":136,"context_line":"#   Optional. Default provided by Ceph"},{"line_number":137,"context_line":"#   Default value 2"},{"line_number":138,"context_line":"#"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"class ceph::profile::params ("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_de08aa2a","line":137,"range":{"start_line":136,"start_character":14,"end_line":137,"end_character":19},"in_reply_to":"3aaa91ec_9ba474ba","updated":"2016-06-24 18:13:22.000000000","message":"Done","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d37a9d325878efac6c73516d4fba48fd22c4844f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  $osd_recovery_max_single_start \u003d undef,"},{"line_number":169,"context_line":"  $osd_max_scrubs \u003d undef,"},{"line_number":170,"context_line":"  $osd_op_threads \u003d undef,"},{"line_number":171,"context_line":"  $manage_repo \u003d true,"},{"line_number":172,"context_line":") {"},{"line_number":173,"context_line":"  validate_hash($client_keys)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_dbe6fce6","line":171,"range":{"start_line":171,"start_character":2,"end_line":171,"end_character":22},"updated":"2016-06-24 18:03:52.000000000","message":"manage_repo twice?","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"189ef2638da961dab40865652232d50ebfeb79bc","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  $osd_recovery_max_single_start \u003d undef,"},{"line_number":169,"context_line":"  $osd_max_scrubs \u003d undef,"},{"line_number":170,"context_line":"  $osd_op_threads \u003d undef,"},{"line_number":171,"context_line":"  $manage_repo \u003d true,"},{"line_number":172,"context_line":") {"},{"line_number":173,"context_line":"  validate_hash($client_keys)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_be595e37","line":171,"range":{"start_line":171,"start_character":2,"end_line":171,"end_character":22},"in_reply_to":"3aaa91ec_dbe6fce6","updated":"2016-06-24 18:13:22.000000000","message":"doh..  I was looking for that.  I was reading the error as coming from a different module on the tests.  thanks.","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"}],"releasenotes/notes/osd-level-5ebc22c7377e0300.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"029affbc08700f388e2d537272da248f674fe1c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added optiosns to configure some osd parmaters directly"},{"line_number":4,"context_line":"    (instead of generic ceph::conf) this behavior is"},{"line_number":5,"context_line":"    disabled by default. `osd/osd_max_backfills`,"},{"line_number":6,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_50ed2924","line":3,"updated":"2016-07-05 14:38:15.000000000","message":"options","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"ff5feb648546958627078ce1d1dd04a7548e6ada","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added optiosns to configure some osd parmaters directly"},{"line_number":4,"context_line":"    (instead of generic ceph::conf) this behavior is"},{"line_number":5,"context_line":"    disabled by default. `osd/osd_max_backfills`,"},{"line_number":6,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_b3273763","line":3,"in_reply_to":"1aa78d24_50ed2924","updated":"2016-07-05 14:55:37.000000000","message":"Done","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"029affbc08700f388e2d537272da248f674fe1c7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"},{"line_number":8,"context_line":"    `osd/osd_op_threads`"},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - When upgrading move any usage of ceph::conf to ceph::init for the"},{"line_number":11,"context_line":"    following parmaters `osd/osd_max_backfills`,"},{"line_number":12,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"},{"line_number":13,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_10e44139","line":10,"updated":"2016-07-05 14:38:15.000000000","message":"when upgrading, move any usage of...","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"ff5feb648546958627078ce1d1dd04a7548e6ada","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"},{"line_number":8,"context_line":"    `osd/osd_op_threads`"},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - When upgrading move any usage of ceph::conf to ceph::init for the"},{"line_number":11,"context_line":"    following parmaters `osd/osd_max_backfills`,"},{"line_number":12,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"},{"line_number":13,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_d31c8315","line":10,"in_reply_to":"1aa78d24_10e44139","updated":"2016-07-05 14:55:37.000000000","message":"Done","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"029affbc08700f388e2d537272da248f674fe1c7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    `osd/osd_op_threads`"},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - When upgrading move any usage of ceph::conf to ceph::init for the"},{"line_number":11,"context_line":"    following parmaters `osd/osd_max_backfills`,"},{"line_number":12,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"},{"line_number":13,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"},{"line_number":14,"context_line":"    `osd/osd_op_threads`"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_503b699c","line":11,"updated":"2016-07-05 14:38:15.000000000","message":"parameters","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"ff5feb648546958627078ce1d1dd04a7548e6ada","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    `osd/osd_op_threads`"},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - When upgrading move any usage of ceph::conf to ceph::init for the"},{"line_number":11,"context_line":"    following parmaters `osd/osd_max_backfills`,"},{"line_number":12,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"},{"line_number":13,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"},{"line_number":14,"context_line":"    `osd/osd_op_threads`"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_73d4af1f","line":11,"in_reply_to":"1aa78d24_503b699c","updated":"2016-07-05 14:55:37.000000000","message":"Done","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"029affbc08700f388e2d537272da248f674fe1c7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    usage of ceph::conf for `osd/osd_max_backfills`,"},{"line_number":20,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"},{"line_number":21,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"},{"line_number":22,"context_line":"    `osd/osd_op_threads` as these will become activly defined from"},{"line_number":23,"context_line":"    ceph::init"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_d06e3995","line":22,"updated":"2016-07-05 14:38:15.000000000","message":"actively","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"ff5feb648546958627078ce1d1dd04a7548e6ada","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    usage of ceph::conf for `osd/osd_max_backfills`,"},{"line_number":20,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"},{"line_number":21,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"},{"line_number":22,"context_line":"    `osd/osd_op_threads` as these will become activly defined from"},{"line_number":23,"context_line":"    ceph::init"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_53d7f322","line":22,"in_reply_to":"1aa78d24_d06e3995","updated":"2016-07-05 14:55:37.000000000","message":"Done","commit_id":"62eca47be41aa557261ef3aa9581a2e616c1d3bf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1299306a50b9e2169e905baeabd34565802cb2f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added options to configure some osd parmaters directly"},{"line_number":4,"context_line":"    (instead of generic ceph::conf) this behavior is"},{"line_number":5,"context_line":"    disabled by default. `osd/osd_max_backfills`,"},{"line_number":6,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1aa78d24_52a00490","line":3,"updated":"2016-07-13 14:08:21.000000000","message":"parameters","commit_id":"4f6bc81789b8bef07a02554fe0fbe0b7ba4f2f48"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1299306a50b9e2169e905baeabd34565802cb2f5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    `osd_max_scrubs`, `osd/osd_recovery_max_active`,"},{"line_number":21,"context_line":"    `osd_recovery_max_single_start`, `osd/osd_recovery_op_priority`,"},{"line_number":22,"context_line":"    `osd/osd_op_threads` as these will become actively defined from"},{"line_number":23,"context_line":"    ceph::init"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1aa78d24_b2ab2874","line":23,"updated":"2016-07-13 14:08:21.000000000","message":"good release note, very explicit.","commit_id":"4f6bc81789b8bef07a02554fe0fbe0b7ba4f2f48"}],"spec/classes/ceph_init_spec.rb":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d37a9d325878efac6c73516d4fba48fd22c4844f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_service_required\u0027).with_value(\u0027none\u0027) }"},{"line_number":59,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_client_required\u0027).with_value(\u0027none\u0027) }"},{"line_number":60,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_supported\u0027).with_value(\u0027none\u0027) }"},{"line_number":61,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_max_backfills\u0027).with_value(\u00272\u0027) }"},{"line_number":62,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_max_active\u0027).with_value(\u00272\u0027) }"},{"line_number":63,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_op_priority\u0027).with_value(\u00272\u0027) }"},{"line_number":64,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_max_single_start\u0027).with_value(\u00272\u0027) }"},{"line_number":65,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_max_scrubs\u0027).with_value(\u00272\u0027) }"},{"line_number":66,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_op_threads\u0027).with_value(\u00273\u0027) }"},{"line_number":67,"context_line":"    end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    describe \"with custom params and specified fsid\" do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3aaa91ec_5b768c3e","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":89},"updated":"2016-06-24 18:03:52.000000000","message":"aren\u0027t they not supposed to be expected at all?","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"aba693a81ac09d40246af93667baa1146a577fb0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_service_required\u0027).with_value(\u0027none\u0027) }"},{"line_number":59,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_client_required\u0027).with_value(\u0027none\u0027) }"},{"line_number":60,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_supported\u0027).with_value(\u0027none\u0027) }"},{"line_number":61,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_max_backfills\u0027).with_value(\u00272\u0027) }"},{"line_number":62,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_max_active\u0027).with_value(\u00272\u0027) }"},{"line_number":63,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_op_priority\u0027).with_value(\u00272\u0027) }"},{"line_number":64,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_max_single_start\u0027).with_value(\u00272\u0027) }"},{"line_number":65,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_max_scrubs\u0027).with_value(\u00272\u0027) }"},{"line_number":66,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_op_threads\u0027).with_value(\u00273\u0027) }"},{"line_number":67,"context_line":"    end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    describe \"with custom params and specified fsid\" do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3aaa91ec_deaa6a84","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":89},"in_reply_to":"3aaa91ec_3eb44e33","updated":"2016-06-24 18:19:05.000000000","message":"tested and removed","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"189ef2638da961dab40865652232d50ebfeb79bc","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_service_required\u0027).with_value(\u0027none\u0027) }"},{"line_number":59,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_client_required\u0027).with_value(\u0027none\u0027) }"},{"line_number":60,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_supported\u0027).with_value(\u0027none\u0027) }"},{"line_number":61,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_max_backfills\u0027).with_value(\u00272\u0027) }"},{"line_number":62,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_max_active\u0027).with_value(\u00272\u0027) }"},{"line_number":63,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_op_priority\u0027).with_value(\u00272\u0027) }"},{"line_number":64,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_max_single_start\u0027).with_value(\u00272\u0027) }"},{"line_number":65,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_max_scrubs\u0027).with_value(\u00272\u0027) }"},{"line_number":66,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_op_threads\u0027).with_value(\u00273\u0027) }"},{"line_number":67,"context_line":"    end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    describe \"with custom params and specified fsid\" do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3aaa91ec_3eb44e33","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":89},"in_reply_to":"3aaa91ec_5b768c3e","updated":"2016-06-24 18:13:22.000000000","message":"so you want these removed?  I know what you mean, I am just thinking through the tests.","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"905dd041cbcb9b1e4df911885027ff2b4baae786","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_service_required\u0027).with_value(\u0027none\u0027) }"},{"line_number":59,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_client_required\u0027).with_value(\u0027none\u0027) }"},{"line_number":60,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027global/auth_supported\u0027).with_value(\u0027none\u0027) }"},{"line_number":61,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_max_backfills\u0027).with_value(\u00272\u0027) }"},{"line_number":62,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_max_active\u0027).with_value(\u00272\u0027) }"},{"line_number":63,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_op_priority\u0027).with_value(\u00272\u0027) }"},{"line_number":64,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_recovery_max_single_start\u0027).with_value(\u00272\u0027) }"},{"line_number":65,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_max_scrubs\u0027).with_value(\u00272\u0027) }"},{"line_number":66,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027osd/osd_op_threads\u0027).with_value(\u00273\u0027) }"},{"line_number":67,"context_line":"    end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    describe \"with custom params and specified fsid\" do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3aaa91ec_80a7dbbb","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":89},"in_reply_to":"3aaa91ec_deaa6a84","updated":"2016-06-24 20:42:44.000000000","message":"they didn\u0027t need to be removed from the CI, the sense is that they should not be contained with any value since they are undef, so in this case\n\nit { is_expected.to contain_cepf_config(...).with_value(\u0027none\u0027)\n\notherwise we can ignore the sentiment as this should just go away in next version (given we remove the condition)","commit_id":"9ea0bf4a87185896b20ec0d2ffc7d9dca09c3c0d"}]}