)]}'
{"manifests/key.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1366da66f5ffe69cf513512567708a267a6db191","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    exec { \"ceph-injectkey-${name}\":"},{"line_number":143,"context_line":"      command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":144,"context_line":"set -ex"},{"line_number":145,"context_line":"ceph ${cluster_option} ${inject_id_option} ${inject_keyring_option} auth add ${name} --in-file\u003d${keyring_path}\","},{"line_number":146,"context_line":"      unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":147,"context_line":"set -ex"},{"line_number":148,"context_line":"ceph ${cluster_option} ${inject_id_option} ${inject_keyring_option} auth get ${name} | grep ${secret}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_6b1a5d19","line":145,"updated":"2016-07-27 14:16:16.000000000","message":"this will fail if key already exists","commit_id":"2b76d0a1541e06d0b8c7cbaf8fb1dc5df1de755c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b0ce188a102c6203cfd677a7763c666ead307bb8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  exec { \"ceph-key-${name}\":"},{"line_number":117,"context_line":"    command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":118,"context_line":"set -ex"},{"line_number":119,"context_line":"ceph-authtool ${keyring_path} --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}\","},{"line_number":120,"context_line":"    unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":121,"context_line":"set -ex"},{"line_number":122,"context_line":"sed -n \u0027N;\\\\%.*${name}.*\\\\n\\\\s*key \u003d ${secret}%p\u0027 ${keyring_path} | grep ${name}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_8ebebfd2","line":119,"updated":"2016-07-27 14:50:45.000000000","message":"this is safe to re-run so I left it as it was","commit_id":"5297bf34be59a9d9a5fb762ef6a48c6c01360c75"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a0f7cf18186dae5113595328efb3a7b0820a5f02","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":121,"context_line":"set -ex"},{"line_number":122,"context_line":"sed -n \u0027N;\\\\%.*${name}.*\\\\n\\\\s*key \u003d ${secret}%p\u0027 ${keyring_path} | grep ${name}"},{"line_number":123,"context_line":"ceph-authtool ${keyring_path} --name \u0027${name}\u0027 -l | awk -F \u0027\u003d\u0027 \u0027/caps mds/ {print \\$2}\u0027 | grep ${cap_mds}"},{"line_number":124,"context_line":"ceph-authtool ${keyring_path} --name \u0027${name}\u0027 -l | awk -F \u0027\u003d\u0027 \u0027/caps mon/ {print \\$2}\u0027 | grep ${cap_mon}"},{"line_number":125,"context_line":"ceph-authtool ${keyring_path} --name \u0027${name}\u0027 -l | awk -F \u0027\u003d\u0027 \u0027/caps osd/ {print \\$2}\u0027 | grep ${cap_osd}\","},{"line_number":126,"context_line":"    require   \u003d\u003e [ Package[\u0027ceph\u0027], File[$keyring_path], ],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_e80da838","line":123,"updated":"2016-07-27 16:57:16.000000000","message":"not great as it will run add-key if one of the caps was empty (grep will fail)","commit_id":"5297bf34be59a9d9a5fb762ef6a48c6c01360c75"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a0f7cf18186dae5113595328efb3a7b0820a5f02","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    exec { \"ceph-updatecaps-${name}\":"},{"line_number":154,"context_line":"      command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":155,"context_line":"set -ex"},{"line_number":156,"context_line":"ceph ${cluster_option} ${inject_id_option} ${inject_keyring_option} auth caps ${name} mds \u0027${cap_mds}\u0027 mon \u0027${cap_mon}\u0027 osd \u0027${cap_osd}\u0027\","},{"line_number":157,"context_line":"      unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":158,"context_line":"set -ex"},{"line_number":159,"context_line":"ceph ${cluster_option} ${inject_id_option} ${inject_keyring_option} auth get ${name} | awk -F \u0027\u003d\u0027 \u0027/caps mds/ {print \\$2}\u0027 | grep ${cap_mds}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_b2d79d22","line":156,"updated":"2016-07-27 16:57:16.000000000","message":"tests fail as this should not pass stuff like \"mds \u0027\u0027\" when there are no caps for mds","commit_id":"5297bf34be59a9d9a5fb762ef6a48c6c01360c75"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ae499437e498553af5dfb2162979c7cb6593d8e8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"ceph-authtool ${keyring_path} --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}\","},{"line_number":121,"context_line":"    onlyif    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":122,"context_line":"set -ex"},{"line_number":123,"context_line":"NEW_KEYRING\u003d\\$(mktemp)"},{"line_number":124,"context_line":"ceph-authtool \\$NEW_KEYRING --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}"},{"line_number":125,"context_line":"diff -N \\$NEW_KEYRING ${keyring_path} | grep \u0027\u003c\u0027"},{"line_number":126,"context_line":"rm \\$NEW_KEYRING\","}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_ec128eb3","line":123,"updated":"2016-07-28 22:24:37.000000000","message":"I don\u0027t know if I\u0027m just being overly sensitive, but it seems like a bad idea to share the auth secrets into tmp, even if we purge it right when we are done with it.\n\nI\u0027d have to check, but I thought we could get the output into shell instead of file and if so, we could just compare it in the stream","commit_id":"034b059986dfd3e8173a91bc9ede369d0d11554c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e68b668ad0ae6219e3f89127e607ec99cc7ca087","unresolved":false,"context_lines":[{"line_number":120,"context_line":"ceph-authtool ${keyring_path} --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}\","},{"line_number":121,"context_line":"    onlyif    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":122,"context_line":"set -ex"},{"line_number":123,"context_line":"NEW_KEYRING\u003d\\$(mktemp)"},{"line_number":124,"context_line":"ceph-authtool \\$NEW_KEYRING --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}"},{"line_number":125,"context_line":"diff -N \\$NEW_KEYRING ${keyring_path} | grep \u0027\u003c\u0027"},{"line_number":126,"context_line":"rm \\$NEW_KEYRING\","}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_f6cfe97c","line":123,"in_reply_to":"bacf61ea_ec128eb3","updated":"2016-07-29 07:42:06.000000000","message":"yeah agreed, I\u0027ll look for alternatives as well but please comment here if you have more ideas","commit_id":"034b059986dfd3e8173a91bc9ede369d0d11554c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"42894817ab1f64c0b5098cae061ced80e1aff31a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"ceph-authtool ${keyring_path} --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}\","},{"line_number":121,"context_line":"    onlyif    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":122,"context_line":"set -ex"},{"line_number":123,"context_line":"ceph-authtool \u003e(diff -N - ${keyring_path} | grep \u0027\u003c\u0027) --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}\","},{"line_number":124,"context_line":"    require   \u003d\u003e [ Package[\u0027ceph\u0027], File[$keyring_path], ],"},{"line_number":125,"context_line":"    logoutput \u003d\u003e true,"},{"line_number":126,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"bacf61ea_b8843ad4","line":123,"updated":"2016-07-29 10:09:47.000000000","message":"this looked nice initially but we get the wrong exit code\n\noutputting to /dev/stdout could work but doesn\u0027t give any guarantee about the data we\u0027ll be grepping when executed in parallel\n\ngiven mktemp only sets permissions for the user which creates the temporary file, I think it\u0027a viable solution to fix the bug for now","commit_id":"a66afdc0558c829aa646a7a807068e874190ac4e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91df0105d90950c335a0f43d699d3b80cfdc155f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"set -ex"},{"line_number":123,"context_line":"NEW_KEYRING\u003d\\$(mktemp)"},{"line_number":124,"context_line":"ceph-authtool \\$NEW_KEYRING --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}"},{"line_number":125,"context_line":"diff -N \\$NEW_KEYRING ${keyring_path} | grep \u0027\u003c\u0027"},{"line_number":126,"context_line":"rm \\$NEW_KEYRING\","},{"line_number":127,"context_line":"    require   \u003d\u003e [ Package[\u0027ceph\u0027], File[$keyring_path], ],"},{"line_number":128,"context_line":"    logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bacf61ea_aff98482","line":125,"updated":"2016-07-29 14:50:52.000000000","message":"why do you diff here?","commit_id":"d823bf6ac91eb1fd12b0acea5161ba83b819f9f7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4fb7648675d8bf51596c26f4403f55cd2e6cef40","unresolved":false,"context_lines":[{"line_number":122,"context_line":"set -ex"},{"line_number":123,"context_line":"NEW_KEYRING\u003d\\$(mktemp)"},{"line_number":124,"context_line":"ceph-authtool \\$NEW_KEYRING --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}"},{"line_number":125,"context_line":"diff -N \\$NEW_KEYRING ${keyring_path} | grep \u0027\u003c\u0027"},{"line_number":126,"context_line":"rm \\$NEW_KEYRING\","},{"line_number":127,"context_line":"    require   \u003d\u003e [ Package[\u0027ceph\u0027], File[$keyring_path], ],"},{"line_number":128,"context_line":"    logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bacf61ea_208ba269","line":125,"in_reply_to":"bacf61ea_aff98482","updated":"2016-08-01 11:00:35.000000000","message":"we discussed this on IRC but seems like worth posting here: the goal is to catch changes to both the secret key and/or the caps for the keyring, previousy this was only catching secret key diffs","commit_id":"d823bf6ac91eb1fd12b0acea5161ba83b819f9f7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91df0105d90950c335a0f43d699d3b80cfdc155f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"set -ex"},{"line_number":150,"context_line":"OLD_KEYRING\u003d\\$(mktemp)"},{"line_number":151,"context_line":"ceph ${cluster_option} ${inject_id_option} ${inject_keyring_option} auth get ${name} -o \\$OLD_KEYRING || true"},{"line_number":152,"context_line":"diff -N \\$OLD_KEYRING ${keyring_path} | grep \u0027\u003e\u0027"},{"line_number":153,"context_line":"rm \\$OLD_KEYRING\","},{"line_number":154,"context_line":"      require   \u003d\u003e [ Package[\u0027ceph\u0027], Exec[\"ceph-key-${name}\"], ],"},{"line_number":155,"context_line":"      logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bacf61ea_8ff48087","line":152,"updated":"2016-07-29 14:50:52.000000000","message":"why do you diff here?","commit_id":"d823bf6ac91eb1fd12b0acea5161ba83b819f9f7"}]}