)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c981b5c85e429c13dec03ea7a1868ca62d1df9d7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ifb24615372c962b9e264167888d8da939b46341d"},{"line_number":24,"context_line":"Depends-On: Idea369a3f08be2d6c25913152b63cab5eadb8641"},{"line_number":25,"context_line":"Ref: http://docs.ceph.com/docs/master/radosgw/keystone/"},{"line_number":26,"context_line":"Ref: http://docs.ceph.com/docs/master/radosgw/config-ref/#keystone-settings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"fa7ab95a_134bba5a","line":24,"updated":"2016-08-31 16:08:07.000000000","message":"we can\u0027t use depends-on for changes to the same repo, instead you should stack them up using cherry-pick locally","commit_id":"6455d1ca5170193713892a072c59128511dcd584"}],"manifests/profile/params.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ec4f199aa3055b8577b0524bc1198cad73dd9016","unresolved":false,"context_lines":[{"line_number":139,"context_line":"#   Possible values \u0027v2.0\u0027, \u0027v3\u0027"},{"line_number":140,"context_line":"#   Optional. Default is \u0027v2.0\u0027"},{"line_number":141,"context_line":"#"},{"line_number":142,"context_line":"# [*rgw_keystone_admin_domain*] The name of OpenStack domain with admin "},{"line_number":143,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":144,"context_line":"#   Optional. Default is \u0027default\u0027"},{"line_number":145,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_7e17aeed","line":142,"updated":"2016-07-27 17:49:24.000000000","message":"fix whitespaces","commit_id":"ac165aafaa7bba0c98384b4ab4989cc689fdda66"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ec4f199aa3055b8577b0524bc1198cad73dd9016","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  $osd_recovery_max_single_start \u003d undef,"},{"line_number":187,"context_line":"  $osd_max_scrubs \u003d undef,"},{"line_number":188,"context_line":"  $osd_op_threads \u003d undef,"},{"line_number":189,"context_line":"  rgw_keystone_version \u003d \u0027v2.0\u0027,"},{"line_number":190,"context_line":"  $rgw_keystone_admin_domain \u003d \u0027default\u0027,"},{"line_number":191,"context_line":"  $rgw_keystone_admin_project \u003d \u0027openstack\u0027,"},{"line_number":192,"context_line":"  $rgw_keystone_admin_user \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_1eddd242","line":189,"updated":"2016-07-27 17:49:24.000000000","message":"you missed $","commit_id":"ac165aafaa7bba0c98384b4ab4989cc689fdda66"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ed5de70ac0b9df77a5f08c87c2dd4a057e99f5f0","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  $osd_max_scrubs \u003d undef,"},{"line_number":188,"context_line":"  $osd_op_threads \u003d undef,"},{"line_number":189,"context_line":"  $rgw_keystone_version \u003d \u0027v2.0\u0027,"},{"line_number":190,"context_line":"  $rgw_keystone_admin_domain \u003d \u0027default\u0027,"},{"line_number":191,"context_line":"  $rgw_keystone_admin_project \u003d \u0027openstack\u0027,"},{"line_number":192,"context_line":"  $rgw_keystone_admin_user \u003d undef,"},{"line_number":193,"context_line":"  $rgw_keystone_admin_password \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_0c2a822c","line":190,"updated":"2016-07-28 22:16:17.000000000","message":"shouldn\u0027t we use $::os_service_default for these then","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3e00dbaf34da7c3887aec52dfda3087f19b5b5d4","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  $osd_max_scrubs \u003d undef,"},{"line_number":188,"context_line":"  $osd_op_threads \u003d undef,"},{"line_number":189,"context_line":"  $rgw_keystone_version \u003d \u0027v2.0\u0027,"},{"line_number":190,"context_line":"  $rgw_keystone_admin_domain \u003d \u0027default\u0027,"},{"line_number":191,"context_line":"  $rgw_keystone_admin_project \u003d \u0027openstack\u0027,"},{"line_number":192,"context_line":"  $rgw_keystone_admin_user \u003d undef,"},{"line_number":193,"context_line":"  $rgw_keystone_admin_password \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_8c8f92cb","line":190,"in_reply_to":"bacf61ea_0c2a822c","updated":"2016-07-28 23:09:08.000000000","message":"Done","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"308ebc9404b1c039984be4333e4c39d48d80d887","unresolved":false,"context_lines":[{"line_number":139,"context_line":"#   Possible values \u0027v2.0\u0027, \u0027v3\u0027"},{"line_number":140,"context_line":"#   Optional. Default is \u0027v2.0\u0027"},{"line_number":141,"context_line":"#"},{"line_number":142,"context_line":"# [*rgw_keystone_admin_domain*] The name of OpenStack domain with admin "},{"line_number":143,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":144,"context_line":"#   Optional. Default is \u0027default\u0027"},{"line_number":145,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_7b246b5f","line":142,"range":{"start_line":142,"start_character":71,"end_line":142,"end_character":72},"updated":"2016-07-29 19:27:44.000000000","message":"whitespace","commit_id":"19f4662b014e0761c085bcc63f20028a38a640b7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9ececb65e2a21830ddb7074e1a787aafd93fa127","unresolved":false,"context_lines":[{"line_number":143,"context_line":"#   Possible values \u0027v2.0\u0027, \u0027v3\u0027"},{"line_number":144,"context_line":"#   Optional. Default is \u0027v2.0\u0027"},{"line_number":145,"context_line":"#"},{"line_number":146,"context_line":"# [*rgw_keystone_admin_domain*] The name of OpenStack domain with admin"},{"line_number":147,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":148,"context_line":"#   Optional. Default is \u0027default\u0027"},{"line_number":149,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa7ab95a_c75ea244","line":146,"range":{"start_line":146,"start_character":32,"end_line":146,"end_character":60},"updated":"2016-09-01 13:24:24.000000000","message":"If is the name of the Domain it should be Default not default\nhttps://github.com/openstack/keystone/blob/master/doc/source/services.rst#the-default-domain","commit_id":"fa559604ba35bc0dceed35c7091953c2bba4991d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9ececb65e2a21830ddb7074e1a787aafd93fa127","unresolved":false,"context_lines":[{"line_number":147,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":148,"context_line":"#   Optional. Default is \u0027default\u0027"},{"line_number":149,"context_line":"#"},{"line_number":150,"context_line":"# [*rgw_keystone_admin_project*] The name of OpenStack project with admin"},{"line_number":151,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":152,"context_line":"#   Optional. Default is \u0027openstack\u0027"},{"line_number":153,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa7ab95a_2a19d579","line":150,"updated":"2016-09-01 13:24:24.000000000","message":"skip 1 line","commit_id":"fa559604ba35bc0dceed35c7091953c2bba4991d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9ececb65e2a21830ddb7074e1a787aafd93fa127","unresolved":false,"context_lines":[{"line_number":149,"context_line":"#"},{"line_number":150,"context_line":"# [*rgw_keystone_admin_project*] The name of OpenStack project with admin"},{"line_number":151,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":152,"context_line":"#   Optional. Default is \u0027openstack\u0027"},{"line_number":153,"context_line":"#"},{"line_number":154,"context_line":"# [*rgw_keystone_admin_user*] The user name of OpenStack tenant with admin"},{"line_number":155,"context_line":"#   privilege (Service Tenant)"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa7ab95a_0d56ebd1","line":152,"range":{"start_line":152,"start_character":24,"end_line":152,"end_character":36},"updated":"2016-09-01 13:24:24.000000000","message":"It\u0027s a little bit confusing you have Default value and set to undef, maybe let undef? This can lead the user to not set the parameter if they want the default value and the user will get errors.","commit_id":"fa559604ba35bc0dceed35c7091953c2bba4991d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9ececb65e2a21830ddb7074e1a787aafd93fa127","unresolved":false,"context_lines":[{"line_number":151,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":152,"context_line":"#   Optional. Default is \u0027openstack\u0027"},{"line_number":153,"context_line":"#"},{"line_number":154,"context_line":"# [*rgw_keystone_admin_user*] The user name of OpenStack tenant with admin"},{"line_number":155,"context_line":"#   privilege (Service Tenant)"},{"line_number":156,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":157,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa7ab95a_4a2619bb","line":154,"updated":"2016-09-01 13:24:24.000000000","message":"skip 1 line","commit_id":"fa559604ba35bc0dceed35c7091953c2bba4991d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9ececb65e2a21830ddb7074e1a787aafd93fa127","unresolved":false,"context_lines":[{"line_number":155,"context_line":"#   privilege (Service Tenant)"},{"line_number":156,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":157,"context_line":"#"},{"line_number":158,"context_line":"# [*rgw_keystone_admin_password*] The password for OpenStack admin user"},{"line_number":159,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa7ab95a_ea352ddb","line":158,"updated":"2016-09-01 13:24:24.000000000","message":"skip 1 line","commit_id":"fa559604ba35bc0dceed35c7091953c2bba4991d"}],"manifests/rgw/keystone.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ec4f199aa3055b8577b0524bc1198cad73dd9016","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# [*user*] User running the web frontend."},{"line_number":58,"context_line":"#   Optional. Default is \u0027www-data\u0027."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*rgw_keystone_admin_domain*] The name of OpenStack domain with admin "},{"line_number":61,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":62,"context_line":"#   Optional. Default is \u0027default\u0027"},{"line_number":63,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_3ee4160c","line":60,"updated":"2016-07-27 17:49:24.000000000","message":"fix whitespaces","commit_id":"ac165aafaa7bba0c98384b4ab4989cc689fdda66"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ec4f199aa3055b8577b0524bc1198cad73dd9016","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \"client.${name}/rgw_keystone_token_cache_size\": value \u003d\u003e $rgw_keystone_token_cache_size;"},{"line_number":100,"context_line":"    \"client.${name}/rgw_s3_auth_use_keystone\":      value \u003d\u003e $rgw_s3_auth_use_keystone;"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":"#v2.0"},{"line_number":103,"context_line":"  if $rgw_keystone_version \u003d~ \"v2.0\" {"},{"line_number":104,"context_line":"    ceph_config {"},{"line_number":105,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_deb97aee","line":102,"updated":"2016-07-27 17:49:24.000000000","message":"drop this comment","commit_id":"ac165aafaa7bba0c98384b4ab4989cc689fdda66"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ec4f199aa3055b8577b0524bc1198cad73dd9016","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"#v3"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  if $use_pki {"},{"line_number":119,"context_line":"    # fetch the keystone signing cert, add to nss db"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_1eb4b2f0","line":116,"updated":"2016-07-27 17:49:24.000000000","message":"drop this comment","commit_id":"ac165aafaa7bba0c98384b4ab4989cc689fdda66"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ed5de70ac0b9df77a5f08c87c2dd4a057e99f5f0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# [*user*] User running the web frontend."},{"line_number":58,"context_line":"#   Optional. Default is \u0027www-data\u0027."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*rgw_keystone_admin_domain*] The name of OpenStack domain with admin "},{"line_number":61,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":62,"context_line":"#   Optional. Default is \u0027default\u0027"},{"line_number":63,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_4cd91a83","line":60,"range":{"start_line":60,"start_character":71,"end_line":60,"end_character":72},"updated":"2016-07-28 22:16:17.000000000","message":"whitespace","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3e00dbaf34da7c3887aec52dfda3087f19b5b5d4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# [*user*] User running the web frontend."},{"line_number":58,"context_line":"#   Optional. Default is \u0027www-data\u0027."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*rgw_keystone_admin_domain*] The name of OpenStack domain with admin "},{"line_number":61,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":62,"context_line":"#   Optional. Default is \u0027default\u0027"},{"line_number":63,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_423d61ba","line":60,"range":{"start_line":60,"start_character":71,"end_line":60,"end_character":72},"in_reply_to":"bacf61ea_4cd91a83","updated":"2016-07-28 23:09:08.000000000","message":"Done","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ed5de70ac0b9df77a5f08c87c2dd4a057e99f5f0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"#   privilege (Service Tenant)"},{"line_number":70,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*rgw_keystone_admin_password*] The password for OpenStack admin user "},{"line_number":73,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"define ceph::rgw::keystone ("}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_0cf722f6","line":72,"range":{"start_line":72,"start_character":71,"end_line":72,"end_character":72},"updated":"2016-07-28 22:16:17.000000000","message":"whitespace","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3e00dbaf34da7c3887aec52dfda3087f19b5b5d4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"#   privilege (Service Tenant)"},{"line_number":70,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*rgw_keystone_admin_password*] The password for OpenStack admin user "},{"line_number":73,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"define ceph::rgw::keystone ("}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_c277919d","line":72,"range":{"start_line":72,"start_character":71,"end_line":72,"end_character":72},"in_reply_to":"bacf61ea_0cf722f6","updated":"2016-07-28 23:09:08.000000000","message":"Done","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ed5de70ac0b9df77a5f08c87c2dd4a057e99f5f0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"define ceph::rgw::keystone ("},{"line_number":76,"context_line":"  $rgw_keystone_admin_token         \u003d ::os_service_default,"},{"line_number":77,"context_line":"  $rgw_keystone_url                 \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":78,"context_line":"  $rgw_keystone_version             \u003d \u0027v2.0\u0027,"},{"line_number":79,"context_line":"  $rgw_keystone_accepted_roles      \u003d \u0027_member_, Member\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_6c733e81","line":76,"range":{"start_line":76,"start_character":38,"end_line":76,"end_character":58},"updated":"2016-07-28 22:16:17.000000000","message":"don\u0027t we need to add puppet-openstacklib to our deps for this to function?","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3e00dbaf34da7c3887aec52dfda3087f19b5b5d4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"define ceph::rgw::keystone ("},{"line_number":76,"context_line":"  $rgw_keystone_admin_token         \u003d ::os_service_default,"},{"line_number":77,"context_line":"  $rgw_keystone_url                 \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":78,"context_line":"  $rgw_keystone_version             \u003d \u0027v2.0\u0027,"},{"line_number":79,"context_line":"  $rgw_keystone_accepted_roles      \u003d \u0027_member_, Member\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_22582d32","line":76,"range":{"start_line":76,"start_character":38,"end_line":76,"end_character":58},"in_reply_to":"bacf61ea_6c733e81","updated":"2016-07-28 23:09:08.000000000","message":"Done","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ed5de70ac0b9df77a5f08c87c2dd4a057e99f5f0","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $rgw_keystone_version \u003d\u003d \u0027v2.0\u0027 {"},{"line_number":106,"context_line":"    ceph_config {"},{"line_number":107,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"  } elsif $rgw_keystone_version \u003d\u003d \u0027v3\u0027 {"},{"line_number":110,"context_line":"    ceph_config {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_2c7dc66e","line":107,"range":{"start_line":107,"start_character":58,"end_line":107,"end_character":84},"updated":"2016-07-28 22:16:17.000000000","message":"I don\u0027t see any reason to remove this from the above section if we just include it in both cases","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3e00dbaf34da7c3887aec52dfda3087f19b5b5d4","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $rgw_keystone_version \u003d\u003d \u0027v2.0\u0027 {"},{"line_number":106,"context_line":"    ceph_config {"},{"line_number":107,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"  } elsif $rgw_keystone_version \u003d\u003d \u0027v3\u0027 {"},{"line_number":110,"context_line":"    ceph_config {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_ff234ea5","line":107,"range":{"start_line":107,"start_character":58,"end_line":107,"end_character":84},"in_reply_to":"bacf61ea_2c7dc66e","updated":"2016-07-28 23:09:08.000000000","message":"My goal is to set admin_token in version is \u0027v2.0\u0027 and remove it when version is \u0027v3\u0027.","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ed5de70ac0b9df77a5f08c87c2dd4a057e99f5f0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"      \"client.${name}/rgw_keystone_admin_project\":  value \u003d\u003e $rgw_keystone_admin_project;"},{"line_number":115,"context_line":"      \"client.${name}/rgw_keystone_admin_user\":     value \u003d\u003e $rgw_keystone_admin_user;"},{"line_number":116,"context_line":"      \"client.${name}/rgw_keystone_admin_password\": value \u003d\u003e $rgw_keystone_admin_password;"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":"  }"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  if $use_pki {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_8c8cb280","line":117,"range":{"start_line":117,"start_character":4,"end_line":117,"end_character":5},"updated":"2016-07-28 22:16:17.000000000","message":"I guess we should warn/fail if something else is passed","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3e00dbaf34da7c3887aec52dfda3087f19b5b5d4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"      \"client.${name}/rgw_keystone_admin_project\":  value \u003d\u003e $rgw_keystone_admin_project;"},{"line_number":115,"context_line":"      \"client.${name}/rgw_keystone_admin_user\":     value \u003d\u003e $rgw_keystone_admin_user;"},{"line_number":116,"context_line":"      \"client.${name}/rgw_keystone_admin_password\": value \u003d\u003e $rgw_keystone_admin_password;"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":"  }"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  if $use_pki {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_226f8dc6","line":117,"range":{"start_line":117,"start_character":4,"end_line":117,"end_character":5},"in_reply_to":"bacf61ea_8c8cb280","updated":"2016-07-28 23:09:08.000000000","message":"Done","commit_id":"ceef77ca2e3259414bab46d2f279e9982a4d2967"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"04892ae4243065e6692288dc326d616dc2749169","unresolved":false,"context_lines":[{"line_number":107,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"  } elsif $rgw_keystone_version \u003d\u003d \u0027v3\u0027 {"},{"line_number":110,"context_line":"    ceph_config {"},{"line_number":111,"context_line":"      \"client.${name}/rgw_keystone_api_version\":    value \u003d\u003e 3;"},{"line_number":112,"context_line":"      \"client.${name}/rgw_keystone_admin_domain\":   value \u003d\u003e $rgw_keystone_admin_domain;"},{"line_number":113,"context_line":"      \"client.${name}/rgw_keystone_admin_project\":  value \u003d\u003e $rgw_keystone_admin_project;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"bacf61ea_d2e08a2b","line":110,"updated":"2016-08-01 15:29:46.000000000","message":"removed rgw_keystone_admin_token vs the last rev, which means we won\u0027t purge it anymore in v3 mode, thats expected?","commit_id":"8cb91fee105ebc44c8428bcb1bd24680a58c3305"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6be46f16bc48ae6bb68e16ce6d1b596d6e1b6931","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"define ceph::rgw::keystone ("},{"line_number":76,"context_line":"  $rgw_keystone_admin_token         \u003d ::os_service_default,"},{"line_number":77,"context_line":"  $rgw_keystone_url                 \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":78,"context_line":"  $rgw_keystone_version             \u003d \u0027v2.0\u0027,"},{"line_number":79,"context_line":"  $rgw_keystone_accepted_roles      \u003d \u0027_member_, Member\u0027,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9ad45d7e_3daf1e7e","line":76,"updated":"2016-08-11 22:23:51.000000000","message":"::os_service_default is not a thing. I think you mean $::os_service_default","commit_id":"e61509bddfc96f1a7bc08632f600ed064e2e7ded"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3cc2f590da89ca4630b8bace59e656a78d71dc8c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#   Required if is \u0027v3\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"define ceph::rgw::keystone ("},{"line_number":76,"context_line":"  $rgw_keystone_admin_token         \u003d ::os_service_default,"},{"line_number":77,"context_line":"  $rgw_keystone_url                 \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":78,"context_line":"  $rgw_keystone_version             \u003d \u0027v2.0\u0027,"},{"line_number":79,"context_line":"  $rgw_keystone_accepted_roles      \u003d \u0027_member_, Member\u0027,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9ad45d7e_e7332c12","line":76,"in_reply_to":"9ad45d7e_3daf1e7e","updated":"2016-08-12 03:49:04.000000000","message":"Done","commit_id":"e61509bddfc96f1a7bc08632f600ed064e2e7ded"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6be46f16bc48ae6bb68e16ce6d1b596d6e1b6931","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":"  } elsif $rgw_keystone_version \u003d\u003d \u0027v3\u0027 {"},{"line_number":114,"context_line":"    if $rgw_keystone_admin_domain \u003d\u003d $::os_service_default"},{"line_number":115,"context_line":"      or $rgw_keystone_admin_project \u003d\u003d $::os_service_default"},{"line_number":116,"context_line":"      or $rgw_keystone_admin_user \u003d\u003d undef"},{"line_number":117,"context_line":"      or $rgw_keystone_admin_password \u003d\u003d undef"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9ad45d7e_1db21ae5","line":114,"updated":"2016-08-11 22:23:51.000000000","message":"is_service_default($rgw_keystone_admin_domain) or is_service_default($rgw_keystone_admin_project)","commit_id":"e61509bddfc96f1a7bc08632f600ed064e2e7ded"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3cc2f590da89ca4630b8bace59e656a78d71dc8c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":"  } elsif $rgw_keystone_version \u003d\u003d \u0027v3\u0027 {"},{"line_number":114,"context_line":"    if $rgw_keystone_admin_domain \u003d\u003d $::os_service_default"},{"line_number":115,"context_line":"      or $rgw_keystone_admin_project \u003d\u003d $::os_service_default"},{"line_number":116,"context_line":"      or $rgw_keystone_admin_user \u003d\u003d undef"},{"line_number":117,"context_line":"      or $rgw_keystone_admin_password \u003d\u003d undef"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9ad45d7e_273a64e7","line":114,"in_reply_to":"9ad45d7e_1db21ae5","updated":"2016-08-12 03:49:04.000000000","message":"Thanks. I did not know about that function.","commit_id":"e61509bddfc96f1a7bc08632f600ed064e2e7ded"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"27f523ca058375dd22fd97b9c3e8e4880c4d7024","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      fail( \u0027Missing rgw_keystone_admin_token for Keystone V2 integration\u0027)"},{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":"    ceph_config {"},{"line_number":111,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":"  } elsif $rgw_keystone_version \u003d\u003d \u0027v3\u0027 {"},{"line_number":114,"context_line":"    if $rgw_keystone_admin_domain \u003d\u003d undef"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3ac371cc_ca4c6eca","line":111,"updated":"2016-08-17 20:13:11.000000000","message":"what if we disable admin_token middleware which is the case of most production environments?","commit_id":"3fcbc3589faf9ff6e0e5ca009e4064189f6fc4a5"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"cda72856b087225050e512cd6010601b739ae0a4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      fail( \u0027Missing rgw_keystone_admin_token for Keystone V2 integration\u0027)"},{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":"    ceph_config {"},{"line_number":111,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":"  } elsif $rgw_keystone_version \u003d\u003d \u0027v3\u0027 {"},{"line_number":114,"context_line":"    if $rgw_keystone_admin_domain \u003d\u003d undef"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3ac371cc_a180fe8b","line":111,"in_reply_to":"3ac371cc_5b0b2e2a","updated":"2016-08-18 14:56:13.000000000","message":"using keystone v2 api, and releases prior to jewel its required for radosgw to have the admin_token to do validation. Releases starting with jewel can use v3 api and in this case do not require the admin_token","commit_id":"3fcbc3589faf9ff6e0e5ca009e4064189f6fc4a5"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"7a671f0e0bdc9854d025d8473b71c2c7a508616c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      fail( \u0027Missing rgw_keystone_admin_token for Keystone V2 integration\u0027)"},{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":"    ceph_config {"},{"line_number":111,"context_line":"      \"client.${name}/rgw_keystone_admin_token\": value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":"  } elsif $rgw_keystone_version \u003d\u003d \u0027v3\u0027 {"},{"line_number":114,"context_line":"    if $rgw_keystone_admin_domain \u003d\u003d undef"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3ac371cc_5b0b2e2a","line":111,"in_reply_to":"3ac371cc_ca4c6eca","updated":"2016-08-18 02:23:50.000000000","message":"My understanding from (1) is this value is needed for RGW to work with Keystone V2.0.\n1: http://docs.ceph.com/docs/master/radosgw/keystone/","commit_id":"3fcbc3589faf9ff6e0e5ca009e4064189f6fc4a5"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"27f523ca058375dd22fd97b9c3e8e4880c4d7024","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      \"client.${name}/rgw_keystone_admin_user\":     value \u003d\u003e $rgw_keystone_admin_user;"},{"line_number":126,"context_line":"      \"client.${name}/rgw_keystone_admin_password\": value \u003d\u003e $rgw_keystone_admin_password;"},{"line_number":127,"context_line":"    }"},{"line_number":128,"context_line":"    #delete unneeded value"},{"line_number":129,"context_line":"    #this parameter will break Keystone V3 with Ceph Jewel"},{"line_number":130,"context_line":"    ini_setting { \u0027delete admin_token\u0027:"},{"line_number":131,"context_line":"      ensure  \u003d\u003e absent,"},{"line_number":132,"context_line":"      path    \u003d\u003e \u0027/etc/ceph/ceph.conf\u0027,"},{"line_number":133,"context_line":"      section \u003d\u003e \"client.${name}\","},{"line_number":134,"context_line":"      setting \u003d\u003e \u0027rgw_keystone_admin_token\u0027,"},{"line_number":135,"context_line":"    }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3ac371cc_2aeb8279","line":134,"range":{"start_line":128,"start_character":0,"end_line":134,"end_character":44},"updated":"2016-08-17 20:13:11.000000000","message":"This is ugly, we never did that in our modules before. Please find another way. We have a bunch of mechanisms to ensure a param is unset. Please use them.","commit_id":"3fcbc3589faf9ff6e0e5ca009e4064189f6fc4a5"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"7a671f0e0bdc9854d025d8473b71c2c7a508616c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      \"client.${name}/rgw_keystone_admin_user\":     value \u003d\u003e $rgw_keystone_admin_user;"},{"line_number":126,"context_line":"      \"client.${name}/rgw_keystone_admin_password\": value \u003d\u003e $rgw_keystone_admin_password;"},{"line_number":127,"context_line":"    }"},{"line_number":128,"context_line":"    #delete unneeded value"},{"line_number":129,"context_line":"    #this parameter will break Keystone V3 with Ceph Jewel"},{"line_number":130,"context_line":"    ini_setting { \u0027delete admin_token\u0027:"},{"line_number":131,"context_line":"      ensure  \u003d\u003e absent,"},{"line_number":132,"context_line":"      path    \u003d\u003e \u0027/etc/ceph/ceph.conf\u0027,"},{"line_number":133,"context_line":"      section \u003d\u003e \"client.${name}\","},{"line_number":134,"context_line":"      setting \u003d\u003e \u0027rgw_keystone_admin_token\u0027,"},{"line_number":135,"context_line":"    }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3ac371cc_76d39f04","line":134,"range":{"start_line":128,"start_character":0,"end_line":134,"end_character":44},"in_reply_to":"3ac371cc_2aeb8279","updated":"2016-08-18 02:23:50.000000000","message":"I would have used \u0027very ugly\u0027.\nI think my next update is much better. \nI have a new flat spot on my forehead.","commit_id":"3fcbc3589faf9ff6e0e5ca009e4064189f6fc4a5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9ececb65e2a21830ddb7074e1a787aafd93fa127","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# [*user*] User running the web frontend."},{"line_number":58,"context_line":"#   Optional. Default is \u0027www-data\u0027."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*rgw_keystone_admin_domain*] The name of OpenStack domain with admin"},{"line_number":61,"context_line":"#   privilege when using OpenStack Identity API v3"},{"line_number":62,"context_line":"#   Optional. Default is \u0027default\u0027"},{"line_number":63,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa7ab95a_a7eb5e77","line":60,"range":{"start_line":60,"start_character":32,"end_line":60,"end_character":60},"updated":"2016-09-01 13:24:24.000000000","message":"If is the name of the Domain it should be Default not default\nhttps://github.com/openstack/keystone/blob/master/doc/source/services.rst#the-default-domain","commit_id":"fa559604ba35bc0dceed35c7091953c2bba4991d"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8760898892e9ad366d1d72e59e930d2ef0304b96","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"### \u003d\u003d Parameters"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*rgw_keystone_admin_token*] The keystone admin token."},{"line_number":27,"context_line":"#   Mandatory."},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*rgw_keystone_url*] The internal or admin url for keystone."}],"source_content_type":"text/x-puppet","patch_set":34,"id":"9a89bdaa_bf511711","line":26,"updated":"2016-09-02 19:30:44.000000000","message":"Is this still actually technically mandatory? You are defaulting to undef and it doesn\u0027t seem to be used if rgw_keystone_version is not v2.0.","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"026e24abad6e780c7e1058098caa830bda646f08","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"### \u003d\u003d Parameters"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*rgw_keystone_admin_token*] The keystone admin token."},{"line_number":27,"context_line":"#   Mandatory."},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*rgw_keystone_url*] The internal or admin url for keystone."}],"source_content_type":"text/x-puppet","patch_set":34,"id":"9a89bdaa_cebaabc0","line":26,"in_reply_to":"9a89bdaa_bf511711","updated":"2016-09-02 22:52:34.000000000","message":"I\u0027ll update the text to \"Required if rgw_keystone_version is \"v2.0\".","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9a9a0ac8ebb84fd613163a7b65f3f6b3911d5dce","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    exec { \"${name}-nssdb-ca\":"},{"line_number":149,"context_line":"      command \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"},{"line_number":150,"context_line":"set -ex"},{"line_number":151,"context_line":"wget --no-check-certificate ${rgw_keystone_url}/v2.0/certificates/ca -O - |"},{"line_number":152,"context_line":"  openssl x509 -pubkey | certutil -A -d ${nss_db_path} -n ca -t \\\"TCu,Cu,Tuw\\\""},{"line_number":153,"context_line":"\","},{"line_number":154,"context_line":"      unless  \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"fa7ab95a_15d97022","line":151,"range":{"start_line":151,"start_character":48,"end_line":151,"end_character":52},"updated":"2016-09-02 02:38:29.000000000","message":"why hardcode? it can\u0027t be v3?","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"3836110b4eccf35864cc1a001ecd2e55e7f1f6ec","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    exec { \"${name}-nssdb-ca\":"},{"line_number":149,"context_line":"      command \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"},{"line_number":150,"context_line":"set -ex"},{"line_number":151,"context_line":"wget --no-check-certificate ${rgw_keystone_url}/v2.0/certificates/ca -O - |"},{"line_number":152,"context_line":"  openssl x509 -pubkey | certutil -A -d ${nss_db_path} -n ca -t \\\"TCu,Cu,Tuw\\\""},{"line_number":153,"context_line":"\","},{"line_number":154,"context_line":"      unless  \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"fa7ab95a_0ad30a05","line":151,"range":{"start_line":151,"start_character":48,"end_line":151,"end_character":52},"in_reply_to":"fa7ab95a_15d97022","updated":"2016-09-02 04:01:14.000000000","message":"The calls to the URL with \u0027v3\u0027 failed while the calls to \u0027v2.0\u0027 succeeded on the same deployment using UUID/Fernet tokens and \"enable_pki_setup\" true on ::keystone","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9a9a0ac8ebb84fd613163a7b65f3f6b3911d5dce","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    exec { \"${name}-nssdb-signing\":"},{"line_number":162,"context_line":"      command \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"},{"line_number":163,"context_line":"set -ex"},{"line_number":164,"context_line":"wget --no-check-certificate ${rgw_keystone_url}/v2.0/certificates/signing -O - |"},{"line_number":165,"context_line":"  openssl x509 -pubkey | certutil -A -d ${nss_db_path} -n signing_cert -t \\\"P,P,P\\\""},{"line_number":166,"context_line":"\","},{"line_number":167,"context_line":"      unless  \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"fa7ab95a_5505b877","line":164,"updated":"2016-09-02 02:38:29.000000000","message":"same question","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"}],"manifests/rgw/keystone/auth.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"35c40f597f3186b2ff4c7779a01867a80043e7f4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    email    \u003d\u003e $email,"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  # not sure we actually need it"},{"line_number":78,"context_line":"  keystone_user_role { \"${user}@${tenant}\":"},{"line_number":79,"context_line":"    ensure \u003d\u003e present,"},{"line_number":80,"context_line":"    roles  \u003d\u003e $roles,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1ac06dbe_3871cd78","line":77,"updated":"2016-08-24 13:27:51.000000000","message":"it would be great to clarify that thing before merging this patch.","commit_id":"d8d6a33fc0e9fccab59653f1461d0d0f0d661fdb"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"aa5dcd19a58df95e6debb613bacbe6456aff7cef","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    email    \u003d\u003e $email,"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  # not sure we actually need it"},{"line_number":78,"context_line":"  keystone_user_role { \"${user}@${tenant}\":"},{"line_number":79,"context_line":"    ensure \u003d\u003e present,"},{"line_number":80,"context_line":"    roles  \u003d\u003e $roles,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1ac06dbe_409f6f50","line":77,"in_reply_to":"1ac06dbe_3871cd78","updated":"2016-08-24 14:42:10.000000000","message":"I will say \u0027yes\u0027 because glance does it (1) and (2). \nI will update and remove my comment to myself. \n1: https://github.com/openstack/puppet-glance/blob/master/manifests/keystone/auth.pp#L86\n2: https://github.com/openstack/puppet-keystone/blob/master/manifests/resource/service_identity.pp#L172","commit_id":"d8d6a33fc0e9fccab59653f1461d0d0f0d661fdb"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c981b5c85e429c13dec03ea7a1868ca62d1df9d7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $password,"},{"line_number":49,"context_line":"  $user         \u003d \u0027rgwuser\u0027,"},{"line_number":50,"context_line":"  $email        \u003d \u0027rgwuser@localhost\u0027,"},{"line_number":51,"context_line":"  $roles        \u003d [\u0027admin\u0027, \u0027Member\u0027],"},{"line_number":52,"context_line":"  $public_url   \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"},{"line_number":53,"context_line":"  $admin_url    \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"},{"line_number":54,"context_line":"  $internal_url \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"fa7ab95a_db023d6f","line":51,"updated":"2016-08-31 16:08:07.000000000","message":"shouldn\u0027t \"admin\" be enough?","commit_id":"6455d1ca5170193713892a072c59128511dcd584"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d901b975e55e0c6549d3c9ad110dc9385083b995","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $password,"},{"line_number":49,"context_line":"  $user         \u003d \u0027rgwuser\u0027,"},{"line_number":50,"context_line":"  $email        \u003d \u0027rgwuser@localhost\u0027,"},{"line_number":51,"context_line":"  $roles        \u003d [\u0027admin\u0027, \u0027Member\u0027],"},{"line_number":52,"context_line":"  $public_url   \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"},{"line_number":53,"context_line":"  $admin_url    \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"},{"line_number":54,"context_line":"  $internal_url \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"da7fb54a_6a7426cf","line":51,"in_reply_to":"fa7ab95a_13c1e980","updated":"2016-09-02 18:01:41.000000000","message":"AFAIU Member is required for Swift compat","commit_id":"6455d1ca5170193713892a072c59128511dcd584"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"21afe929ce3e401d01de030fb2f51481d1922322","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $password,"},{"line_number":49,"context_line":"  $user         \u003d \u0027rgwuser\u0027,"},{"line_number":50,"context_line":"  $email        \u003d \u0027rgwuser@localhost\u0027,"},{"line_number":51,"context_line":"  $roles        \u003d [\u0027admin\u0027, \u0027Member\u0027],"},{"line_number":52,"context_line":"  $public_url   \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"},{"line_number":53,"context_line":"  $admin_url    \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"},{"line_number":54,"context_line":"  $internal_url \u003d \u0027http://127.0.0.1:8080/swift/v1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"fa7ab95a_13c1e980","line":51,"in_reply_to":"fa7ab95a_db023d6f","updated":"2016-08-31 16:45:03.000000000","message":"I like leaving the second group to show the roles do not need to be only admin.","commit_id":"6455d1ca5170193713892a072c59128511dcd584"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c981b5c85e429c13dec03ea7a1868ca62d1df9d7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027admin_url\u0027    \u003d\u003e $admin_url,"},{"line_number":71,"context_line":"    \u0027internal_url\u0027 \u003d\u003e $internal_url,"},{"line_number":72,"context_line":"  } )"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  keystone_user { $user:"},{"line_number":75,"context_line":"    ensure   \u003d\u003e present,"},{"line_number":76,"context_line":"    password \u003d\u003e $password,"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"fa7ab95a_9b7d15ea","line":73,"updated":"2016-08-31 16:08:07.000000000","message":"I think we\u0027re missing the lines to ensure the roles exist as well:\n\n ensure_resource(\u0027keystone_role\u0027, $roles, {\n  \u0027ensure\u0027 \u003d\u003e \u0027present\u0027\n } )","commit_id":"6455d1ca5170193713892a072c59128511dcd584"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"21afe929ce3e401d01de030fb2f51481d1922322","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027admin_url\u0027    \u003d\u003e $admin_url,"},{"line_number":71,"context_line":"    \u0027internal_url\u0027 \u003d\u003e $internal_url,"},{"line_number":72,"context_line":"  } )"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  keystone_user { $user:"},{"line_number":75,"context_line":"    ensure   \u003d\u003e present,"},{"line_number":76,"context_line":"    password \u003d\u003e $password,"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"fa7ab95a_33beedff","line":73,"in_reply_to":"fa7ab95a_9b7d15ea","updated":"2016-08-31 16:45:03.000000000","message":"Done","commit_id":"6455d1ca5170193713892a072c59128511dcd584"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8760898892e9ad366d1d72e59e930d2ef0304b96","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $rgw_service  \u003d \u0027swift::object-store\u0027,"},{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  include \u0027::openstacklib::openstackclient\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  ensure_resource(\u0027keystone_service\u0027, \u0027swift::object-store\u0027, {"},{"line_number":63,"context_line":"    \u0027ensure\u0027      \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"9a89bdaa_df989b6d","line":60,"updated":"2016-09-02 19:30:44.000000000","message":"don\u0027t believe the single quotes around the include are required","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"026e24abad6e780c7e1058098caa830bda646f08","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $rgw_service  \u003d \u0027swift::object-store\u0027,"},{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  include \u0027::openstacklib::openstackclient\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  ensure_resource(\u0027keystone_service\u0027, \u0027swift::object-store\u0027, {"},{"line_number":63,"context_line":"    \u0027ensure\u0027      \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"9a89bdaa_eee68fe7","line":60,"in_reply_to":"9a89bdaa_df989b6d","updated":"2016-09-02 22:52:34.000000000","message":"Done","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8760898892e9ad366d1d72e59e930d2ef0304b96","unresolved":false,"context_lines":[{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  include \u0027::openstacklib::openstackclient\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  ensure_resource(\u0027keystone_service\u0027, \u0027swift::object-store\u0027, {"},{"line_number":63,"context_line":"    \u0027ensure\u0027      \u003d\u003e \u0027present\u0027,"},{"line_number":64,"context_line":"    \u0027description\u0027 \u003d\u003e \u0027Ceph RGW Service\u0027,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"9a89bdaa_1f8923cb","line":61,"updated":"2016-09-02 19:30:44.000000000","message":"Is it possible to use keystone::resource::service_identity for this?","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"026e24abad6e780c7e1058098caa830bda646f08","unresolved":false,"context_lines":[{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  include \u0027::openstacklib::openstackclient\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  ensure_resource(\u0027keystone_service\u0027, \u0027swift::object-store\u0027, {"},{"line_number":63,"context_line":"    \u0027ensure\u0027      \u003d\u003e \u0027present\u0027,"},{"line_number":64,"context_line":"    \u0027description\u0027 \u003d\u003e \u0027Ceph RGW Service\u0027,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"9a89bdaa_2e02373f","line":61,"in_reply_to":"9a89bdaa_1f8923cb","updated":"2016-09-02 22:52:34.000000000","message":"I saw service_identity late in development. \nI have pending updates for xenial and can change these 5 functions to one. I can work it into the next update of this update.","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"}],"metadata.json":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"60819291ec1b37be4e4ba7c47c58bef4710f0ffd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    { \"name\": \"puppetlabs/concat\", \"version_requirement\": \"\u003e\u003d1.2.1 \u003c3.0.0\" },"},{"line_number":37,"context_line":"    { \"name\": \"puppetlabs/inifile\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":38,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.10.0 \u003c5.0.0\" },"},{"line_number":39,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d9.1.0 \u003c10.0.0 \" }"},{"line_number":40,"context_line":"  ]"},{"line_number":41,"context_line":"}"}],"source_content_type":"application/json","patch_set":19,"id":"3ac371cc_f8f220d1","line":39,"updated":"2016-08-16 21:30:13.000000000","message":"I don\u0027t see $OS_SERVICE_DEFAULT any more do we need openstack lib still?","commit_id":"40de783a3fe05b7313bb97f6562743cc84d482df"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2e7f79205ca0d1ba579be9094b9a87006060ad4f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    { \"name\": \"puppetlabs/apache\", \"version_requirement\": \"\u003e\u003d1.4.1 \u003c2.0.0\" },"},{"line_number":36,"context_line":"    { \"name\": \"puppetlabs/concat\", \"version_requirement\": \"\u003e\u003d1.2.1 \u003c3.0.0\" },"},{"line_number":37,"context_line":"    { \"name\": \"puppetlabs/inifile\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":38,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.10.0 \u003c5.0.0\" },"},{"line_number":39,"context_line":"  ]"},{"line_number":40,"context_line":"}"}],"source_content_type":"application/json","patch_set":20,"id":"3ac371cc_ed4eb96d","line":38,"range":{"start_line":38,"start_character":77,"end_line":38,"end_character":78},"updated":"2016-08-17 14:27:32.000000000","message":"You need to remove this comma as it breaks the json parsing","commit_id":"70f8de03c1f3d0ebc6ec8626ad18778374c96199"}],"releasenotes/notes/radosgw-keystone-v3-93b3895e24b5f913.yaml":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"308ebc9404b1c039984be4333e4c39d48d80d887","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Update Jewel Ceph RGW to support Keystone V3"},{"line_number":20,"context_line":"features:"},{"line_number":21,"context_line":"  - Updates ceph::rgw:keystone to integrate with keystone V3."},{"line_number":22,"context_line":"    Adds new parameters rgw_keystone_admin_domain,"},{"line_number":23,"context_line":"    rgw_keyston_admin_project, rgw_keystone_admin_user"},{"line_number":24,"context_line":"    and rgw_keystone_admin_password. "},{"line_number":25,"context_line":"    Extends rgw_keystone_version to add \u0027v3\u0027 as a valid option"},{"line_number":26,"context_line":"issues:"},{"line_number":27,"context_line":"  - At this time radosgw uses pki to verify Keystone revocation"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bacf61ea_189e0a63","line":24,"range":{"start_line":21,"start_character":4,"end_line":24,"end_character":35},"updated":"2016-07-29 19:27:44.000000000","message":"needs to be quoted or forced into a block so it stops interpreting the colons","commit_id":"19f4662b014e0761c085bcc63f20028a38a640b7"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"308ebc9404b1c039984be4333e4c39d48d80d887","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  - Updates ceph::rgw:keystone to integrate with keystone V3."},{"line_number":22,"context_line":"    Adds new parameters rgw_keystone_admin_domain,"},{"line_number":23,"context_line":"    rgw_keyston_admin_project, rgw_keystone_admin_user"},{"line_number":24,"context_line":"    and rgw_keystone_admin_password. "},{"line_number":25,"context_line":"    Extends rgw_keystone_version to add \u0027v3\u0027 as a valid option"},{"line_number":26,"context_line":"issues:"},{"line_number":27,"context_line":"  - At this time radosgw uses pki to verify Keystone revocation"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bacf61ea_b81ffe06","line":24,"range":{"start_line":24,"start_character":36,"end_line":24,"end_character":37},"updated":"2016-07-29 19:27:44.000000000","message":"whitespace","commit_id":"19f4662b014e0761c085bcc63f20028a38a640b7"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"308ebc9404b1c039984be4333e4c39d48d80d887","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    Extends rgw_keystone_version to add \u0027v3\u0027 as a valid option"},{"line_number":26,"context_line":"issues:"},{"line_number":27,"context_line":"  - At this time radosgw uses pki to verify Keystone revocation"},{"line_number":28,"context_line":"    lists. keystone::enable_pki_setup must be set to true"},{"line_number":29,"context_line":"    to provide the needed keystone support"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bacf61ea_588a421c","line":28,"range":{"start_line":28,"start_character":19,"end_line":28,"end_character":21},"updated":"2016-07-29 19:27:44.000000000","message":"same issue","commit_id":"19f4662b014e0761c085bcc63f20028a38a640b7"}],"spec/defines/ceph_rgw_keystone_spec.rb":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8760898892e9ad366d1d72e59e930d2ef0304b96","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    end"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"  end"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  describe \u0027RedHat Family\u0027 do"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    let :facts do"}],"source_content_type":"text/x-ruby","patch_set":34,"id":"9a89bdaa_1f5e8345","line":183,"updated":"2016-09-02 19:30:44.000000000","message":"Since you \u0027undefaulted\u0027 rgw_keystone_admin_token in the version 2 case you should verify that it fails in some way if v2 and rgw_keystone_admin_token isn\u0027t provided.","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"026e24abad6e780c7e1058098caa830bda646f08","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    end"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"  end"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  describe \u0027RedHat Family\u0027 do"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    let :facts do"}],"source_content_type":"text/x-ruby","patch_set":34,"id":"9a89bdaa_9931cbef","line":183,"in_reply_to":"9a89bdaa_1f5e8345","updated":"2016-09-02 22:52:34.000000000","message":"I have the following code in the puppet module checking for \"v2.0\" and no auth token given. \n\nhttps://review.openstack.org/gitweb?p\u003dopenstack/puppet-ceph.git;a\u003dblob;f\u003dmanifests/rgw/keystone.pp;h\u003d3b5fe8bcc5277baee68ec2aea91c8ea47dfd80cd;hb\u003d206243b1c32a2c954e98d4e2ba2dd0c2a97b245b#l104","commit_id":"206243b1c32a2c954e98d4e2ba2dd0c2a97b245b"}]}