)]}'
{"manifests/rgw/keystone.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"90d6a92b353cc12d08db59d25cd4c7548086d06f","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if is_array($rgw_keystone_accepted_roles)"},{"line_number":77,"context_line":"  {"},{"line_number":78,"context_line":"    $rgw_keystone_accepted_roles_pass \u003d join($rgw_keystone_accepted_roles, \u0027,\u0027)"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":"  else"},{"line_number":81,"context_line":"  {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_5d3db229","line":78,"updated":"2016-08-11 22:26:05.000000000","message":"does $rgw_keystone_accepted_roles_pass get used anywhere?","commit_id":"0220778744794cd0f114ccee220c12aa8d771313"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a6d9c0c9af0497c4e476604d9c2bfb17fea8c4b0","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if is_array($rgw_keystone_accepted_roles)"},{"line_number":77,"context_line":"  {"},{"line_number":78,"context_line":"    $rgw_keystone_accepted_roles_pass \u003d join($rgw_keystone_accepted_roles, \u0027,\u0027)"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":"  else"},{"line_number":81,"context_line":"  {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_825cde19","line":78,"in_reply_to":"9ad45d7e_5d3db229","updated":"2016-08-12 04:01:38.000000000","message":"I should not write code with people talking to me.","commit_id":"0220778744794cd0f114ccee220c12aa8d771313"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"90d6a92b353cc12d08db59d25cd4c7548086d06f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  ceph_config {"},{"line_number":86,"context_line":"    \"client.${name}/rgw_keystone_admin_token\":         value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":87,"context_line":"    \"client.${name}/rgw_keystone_url\":                 value \u003d\u003e $rgw_keystone_url;"},{"line_number":88,"context_line":"    \"client.${name}/rgw_keystone_accepted_roles\":      value \u003d\u003e $rgw_keystone_accepted_roles;"},{"line_number":89,"context_line":"    \"client.${name}/rgw_keystone_token_cache_size\":    value \u003d\u003e $rgw_keystone_token_cache_size;"},{"line_number":90,"context_line":"    \"client.${name}/rgw_s3_auth_use_keystone\":         value \u003d\u003e $rgw_s3_auth_use_keystone;"},{"line_number":91,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_bd482ecd","line":88,"updated":"2016-08-11 22:26:05.000000000","message":"could just update this with join(any2array($rgw_keystone_accepted_roles), \u0027,\u0027) rather than the if clause up there","commit_id":"0220778744794cd0f114ccee220c12aa8d771313"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a6d9c0c9af0497c4e476604d9c2bfb17fea8c4b0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  ceph_config {"},{"line_number":86,"context_line":"    \"client.${name}/rgw_keystone_admin_token\":         value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":87,"context_line":"    \"client.${name}/rgw_keystone_url\":                 value \u003d\u003e $rgw_keystone_url;"},{"line_number":88,"context_line":"    \"client.${name}/rgw_keystone_accepted_roles\":      value \u003d\u003e $rgw_keystone_accepted_roles;"},{"line_number":89,"context_line":"    \"client.${name}/rgw_keystone_token_cache_size\":    value \u003d\u003e $rgw_keystone_token_cache_size;"},{"line_number":90,"context_line":"    \"client.${name}/rgw_s3_auth_use_keystone\":         value \u003d\u003e $rgw_s3_auth_use_keystone;"},{"line_number":91,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_c26376af","line":88,"in_reply_to":"9ad45d7e_bd482ecd","updated":"2016-08-12 04:01:38.000000000","message":"Much better solution. I guess I cannot fix everything with a hammer.","commit_id":"0220778744794cd0f114ccee220c12aa8d771313"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9311512f4f764ec4d04f398a4bf348d757091c89","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  ceph_config {"},{"line_number":77,"context_line":"    \"client.${name}/rgw_keystone_admin_token\":         value \u003d\u003e $rgw_keystone_admin_token;"},{"line_number":78,"context_line":"    \"client.${name}/rgw_keystone_url\":                 value \u003d\u003e $rgw_keystone_url;"},{"line_number":79,"context_line":"    \"client.${name}/rgw_keystone_accepted_roles\":      value \u003d\u003e join(any2array($rgw_keystone_accepted_roles), \u0027,\u0027);"},{"line_number":80,"context_line":"    \"client.${name}/rgw_keystone_token_cache_size\":    value \u003d\u003e $rgw_keystone_token_cache_size;"},{"line_number":81,"context_line":"    \"client.${name}/rgw_s3_auth_use_keystone\":         value \u003d\u003e $rgw_s3_auth_use_keystone;"},{"line_number":82,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_02356df6","line":79,"updated":"2016-08-12 15:17:06.000000000","message":"shouldn\u0027t it be join(any2array($rgw_keystone_accepted_roles), \u0027,\u0027);\n?","commit_id":"76b48dc84566c0621485f3d28ae2dde9d35f0c46"}]}