)]}'
{"manifests/osd.pp":[{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"d7cf528c012342d363c2cc4edb0e0658e4cadd5d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      Exec[$ceph_prepare] -\u003e Exec[$ceph_activate]"},{"line_number":125,"context_line":"      exec { $ceph_activate:"},{"line_number":126,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_c70103b1","line":123,"updated":"2016-08-11 08:51:05.000000000","message":"can we use some selinux module here?","commit_id":"24da82b48f30f25c19df66dc0cb1a8692e321dcc"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"0ecd5f604ed6bc35a37d04813432e76fcfe24caa","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      Exec[$ceph_prepare] -\u003e Exec[$ceph_activate]"},{"line_number":125,"context_line":"      exec { $ceph_activate:"},{"line_number":126,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_427a2178","line":123,"in_reply_to":"9ad45d7e_027669a3","updated":"2016-08-11 09:03:57.000000000","message":"I meant use something like https://forge.puppet.com/thias/selinux","commit_id":"24da82b48f30f25c19df66dc0cb1a8692e321dcc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ec8c3131d4f10c3a8e9e0c0006180719611ef02c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      Exec[$ceph_prepare] -\u003e Exec[$ceph_activate]"},{"line_number":125,"context_line":"      exec { $ceph_activate:"},{"line_number":126,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_985006d6","line":123,"in_reply_to":"9ad45d7e_38c8faa7","updated":"2016-08-11 09:40:08.000000000","message":"ok I see it now, thanks :)","commit_id":"24da82b48f30f25c19df66dc0cb1a8692e321dcc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a3089d32a8b34bdd7e09752d890c23620819337b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      Exec[$ceph_prepare] -\u003e Exec[$ceph_activate]"},{"line_number":125,"context_line":"      exec { $ceph_activate:"},{"line_number":126,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_b8606ad0","line":123,"in_reply_to":"9ad45d7e_427a2178","updated":"2016-08-11 09:36:28.000000000","message":"so to not add any selinux logic in puppet-ceph itself ?","commit_id":"24da82b48f30f25c19df66dc0cb1a8692e321dcc"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"b969eeb7e85f6c3b65387b05ac6a22e1f0f8c7fe","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      Exec[$ceph_prepare] -\u003e Exec[$ceph_activate]"},{"line_number":125,"context_line":"      exec { $ceph_activate:"},{"line_number":126,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_38c8faa7","line":123,"in_reply_to":"9ad45d7e_b8606ad0","updated":"2016-08-11 09:38:55.000000000","message":"No-no-no, add that module to metadata.json and use\n\nselinux::filecontext {}","commit_id":"24da82b48f30f25c19df66dc0cb1a8692e321dcc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eb02b4de87837cd13f062f39592f53ec04cfae33","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      Exec[$ceph_prepare] -\u003e Exec[$ceph_activate]"},{"line_number":125,"context_line":"      exec { $ceph_activate:"},{"line_number":126,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_7356155d","line":123,"in_reply_to":"9ad45d7e_b8606ad0","updated":"2016-08-11 10:02:00.000000000","message":"it\u0027s a bit unfortunate though that we\u0027ll need to figure how to discern when $data is a directory from when it isn\u0027t in puppet-ceph anyway","commit_id":"24da82b48f30f25c19df66dc0cb1a8692e321dcc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a9c92f5c899ddc0e90f21087210ad6ff18df2476","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      Exec[$ceph_prepare] -\u003e Exec[$ceph_activate]"},{"line_number":125,"context_line":"      exec { $ceph_activate:"},{"line_number":126,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_027669a3","line":123,"in_reply_to":"9ad45d7e_c70103b1","updated":"2016-08-11 09:02:46.000000000","message":"hi, not sure if you meant to manage this from a different module entirely, to depend on some selinux module or?","commit_id":"24da82b48f30f25c19df66dc0cb1a8692e321dcc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cbd67b3f491b6cf1001e62cae4e7d21fcabbdd23","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      if (str2bool($::selinux) \u003d\u003d true) {"},{"line_number":115,"context_line":"        package { \u0027policycoreutils-python\u0027:"},{"line_number":116,"context_line":"          ensure \u003d\u003e installed,"},{"line_number":117,"context_line":"        } -\u003e"},{"line_number":118,"context_line":"        exec { \"fcontext_${name}\":"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_ffd588e4","line":115,"updated":"2016-08-11 18:14:13.000000000","message":"use ensure_packages to avoid collision.","commit_id":"ef219b392eaf9835fb222a8245384bf729233880"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cbd67b3f491b6cf1001e62cae4e7d21fcabbdd23","unresolved":false,"context_lines":[{"line_number":114,"context_line":"      if (str2bool($::selinux) \u003d\u003d true) {"},{"line_number":115,"context_line":"        package { \u0027policycoreutils-python\u0027:"},{"line_number":116,"context_line":"          ensure \u003d\u003e installed,"},{"line_number":117,"context_line":"        } -\u003e"},{"line_number":118,"context_line":"        exec { \"fcontext_${name}\":"},{"line_number":119,"context_line":"          command \u003d\u003e \"semanage fcontext -a -t ${selinux_file_context} \u0027${data}(/.*)?\u0027 \u0026\u0026 restorecon -R ${data}\","},{"line_number":120,"context_line":"          path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/bin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_9ffd6c70","line":117,"updated":"2016-08-11 18:14:13.000000000","message":"don\u0027t use -\u003e but add the package in require of the exec.","commit_id":"ef219b392eaf9835fb222a8245384bf729233880"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3409d3e6ceb3a828bc07f31052ff43251e87f155","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/bin\u0027],"},{"line_number":121,"context_line":"          require \u003d\u003e Exec[$ceph_prepare],"},{"line_number":122,"context_line":"          before  \u003d\u003e Exec[$ceph_activate],"},{"line_number":123,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":"      }"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_dd937459","line":123,"updated":"2016-08-11 16:31:14.000000000","message":"the exec though allows us to test if $data is a directory, if it doesn\u0027t we don\u0027t need to run semanage .. using selinux::dircontext we can\u0027t make this condition unless we add it here anyway","commit_id":"ef219b392eaf9835fb222a8245384bf729233880"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cbd67b3f491b6cf1001e62cae4e7d21fcabbdd23","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/bin\u0027],"},{"line_number":121,"context_line":"          require \u003d\u003e Exec[$ceph_prepare],"},{"line_number":122,"context_line":"          before  \u003d\u003e Exec[$ceph_activate],"},{"line_number":123,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":"      }"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_9f0bac7c","line":123,"in_reply_to":"9ad45d7e_dd937459","updated":"2016-08-11 18:14:13.000000000","message":"can\u0027t we do it in packaging side? do we really need this exec?","commit_id":"ef219b392eaf9835fb222a8245384bf729233880"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b70673ffd36547576e47b73525e6f9576024d51b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      if (str2bool($::selinux) \u003d\u003d true) {"},{"line_number":115,"context_line":"        ensure_packages([\u0027policycoreutils-python\u0027], {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})"},{"line_number":116,"context_line":"        exec { \"fcontext_${name}\":"},{"line_number":117,"context_line":"          command \u003d\u003e \"semanage fcontext -a -t ${selinux_file_context} \u0027${data}(/.*)?\u0027 \u0026\u0026 restorecon -R ${data}\","},{"line_number":118,"context_line":"          path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/bin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9ad45d7e_bd1f8eb5","line":115,"updated":"2016-08-11 22:27:45.000000000","message":"is this package named the same on redhat/ubuntu?","commit_id":"0c4a4a182becc53cc8f6aa2fdaaf0dda80223e56"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1623fc10148676f2bf259b629b8a102ca611f4ea","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      if (str2bool($::selinux) \u003d\u003d true) {"},{"line_number":115,"context_line":"        ensure_packages([\u0027policycoreutils-python\u0027], {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})"},{"line_number":116,"context_line":"        exec { \"fcontext_${name}\":"},{"line_number":117,"context_line":"          command \u003d\u003e \"semanage fcontext -a -t ${selinux_file_context} \u0027${data}(/.*)?\u0027 \u0026\u0026 restorecon -R ${data}\","},{"line_number":118,"context_line":"          path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/bin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9ad45d7e_b8eb1cdb","line":115,"in_reply_to":"9ad45d7e_bd1f8eb5","updated":"2016-08-11 22:45:31.000000000","message":"right, totally not \u0027policycoreutils\u0027","commit_id":"0c4a4a182becc53cc8f6aa2fdaaf0dda80223e56"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b70673ffd36547576e47b73525e6f9576024d51b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        exec { \"fcontext_${name}\":"},{"line_number":117,"context_line":"          command \u003d\u003e \"semanage fcontext -a -t ${selinux_file_context} \u0027${data}(/.*)?\u0027 \u0026\u0026 restorecon -R ${data}\","},{"line_number":118,"context_line":"          path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/bin\u0027],"},{"line_number":119,"context_line":"          require \u003d\u003e [Package[\u0027policycoreutils-python\u0027],Exec[$ceph_prepare]]"},{"line_number":120,"context_line":"          before  \u003d\u003e Exec[$ceph_activate],"},{"line_number":121,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":122,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9ad45d7e_9d1a8ac4","line":119,"updated":"2016-08-11 22:27:45.000000000","message":"missing comma at the end","commit_id":"0c4a4a182becc53cc8f6aa2fdaaf0dda80223e56"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1623fc10148676f2bf259b629b8a102ca611f4ea","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        exec { \"fcontext_${name}\":"},{"line_number":117,"context_line":"          command \u003d\u003e \"semanage fcontext -a -t ${selinux_file_context} \u0027${data}(/.*)?\u0027 \u0026\u0026 restorecon -R ${data}\","},{"line_number":118,"context_line":"          path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/bin\u0027],"},{"line_number":119,"context_line":"          require \u003d\u003e [Package[\u0027policycoreutils-python\u0027],Exec[$ceph_prepare]]"},{"line_number":120,"context_line":"          before  \u003d\u003e Exec[$ceph_activate],"},{"line_number":121,"context_line":"          unless  \u003d\u003e \"test ! -b ${data} \u0026\u0026 (semanage fcontext -l | grep ${data})\","},{"line_number":122,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9ad45d7e_f8bf54cd","line":119,"in_reply_to":"9ad45d7e_9d1a8ac4","updated":"2016-08-11 22:45:31.000000000","message":"thanks","commit_id":"0c4a4a182becc53cc8f6aa2fdaaf0dda80223e56"}]}