)]}'
{"manifests/mon.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8a68891622ba35571ad7ed273ca396b8facb2158","unresolved":false,"context_lines":[{"line_number":76,"context_line":"      $cluster_name \u003d \u0027ceph\u0027"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    $mon_service \u003d \"ceph-mon-${id}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # For Ubuntu Trusty system"},{"line_number":82,"context_line":"    if $::service_provider \u003d\u003d \u0027upstart\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_1375d7c9","side":"PARENT","line":79,"updated":"2016-09-13 15:33:46.000000000","message":"You still need this variable because it\u0027s used later in this file.","commit_id":"26333fd8735a7402d89367099a2a1d9fc1b0cdd8"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"a5c86051fbd182bea5c8d40b9f29cceb025fbe33","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    # NOTE(aschultz): this is the service title for the mon service. It may be"},{"line_number":84,"context_line":"    # different than the actual service name."},{"line_number":85,"context_line":"    $mon_service \u003d \"ceph-mon-${id}\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # For Ubuntu Trusty system"},{"line_number":88,"context_line":"    if $::service_provider \u003d\u003d \u0027upstart\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a8ec9b2_bbbbe074","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":35},"updated":"2016-09-13 21:07:35.000000000","message":"you set this, but I don\u0027t see it used","commit_id":"9f3a31fa22551bd922fc22b0900c120b109ae224"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ddfbf2fda7fc27ba43677d26f52b65bf14b1c887","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    # NOTE(aschultz): this is the service title for the mon service. It may be"},{"line_number":84,"context_line":"    # different than the actual service name."},{"line_number":85,"context_line":"    $mon_service \u003d \"ceph-mon-${id}\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # For Ubuntu Trusty system"},{"line_number":88,"context_line":"    if $::service_provider \u003d\u003d \u0027upstart\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a8ec9b2_3e3a5ece","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":35},"in_reply_to":"7a8ec9b2_bbbbe074","updated":"2016-09-13 21:15:16.000000000","message":"it\u0027s used further down this file. As an example see L203, L210 and L227. Trying to minimize the actual change. The issue is really service title vs name under systemd","commit_id":"9f3a31fa22551bd922fc22b0900c120b109ae224"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"907c6cd103cf2ec1ac14a7079313fed9d4f59ea4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      $init \u003d \u0027upstart\u0027"},{"line_number":90,"context_line":"      Service {"},{"line_number":91,"context_line":"        name     \u003d\u003e \"ceph-mon-${id}\","},{"line_number":92,"context_line":"        provider \u003d\u003e $::ceph::params::service_provider,"},{"line_number":93,"context_line":"        start    \u003d\u003e \"start ceph-mon id\u003d${id}\","},{"line_number":94,"context_line":"        stop     \u003d\u003e \"stop ceph-mon id\u003d${id}\","},{"line_number":95,"context_line":"        status   \u003d\u003e \"status ceph-mon id\u003d${id}\","}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a8ec9b2_5bf57c81","line":92,"updated":"2016-09-13 21:04:08.000000000","message":"shouldn\u0027t we enable \u003d\u003e $mon_enable here too?","commit_id":"9f3a31fa22551bd922fc22b0900c120b109ae224"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ddfbf2fda7fc27ba43677d26f52b65bf14b1c887","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      $init \u003d \u0027upstart\u0027"},{"line_number":90,"context_line":"      Service {"},{"line_number":91,"context_line":"        name     \u003d\u003e \"ceph-mon-${id}\","},{"line_number":92,"context_line":"        provider \u003d\u003e $::ceph::params::service_provider,"},{"line_number":93,"context_line":"        start    \u003d\u003e \"start ceph-mon id\u003d${id}\","},{"line_number":94,"context_line":"        stop     \u003d\u003e \"stop ceph-mon id\u003d${id}\","},{"line_number":95,"context_line":"        status   \u003d\u003e \"status ceph-mon id\u003d${id}\","}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a8ec9b2_7e4b065a","line":92,"in_reply_to":"7a8ec9b2_5bf57c81","updated":"2016-09-13 21:15:16.000000000","message":"I think this is a long standing issue with the upstart implementation where there is no actual ceph-mon-# service.  I thought under upstart something else started up the ceph-mon services.","commit_id":"9f3a31fa22551bd922fc22b0900c120b109ae224"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9c7e37738cfbd479beedf2765b589af48f2b496c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"      }"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    } elsif $ensure \u003d\u003d absent {"},{"line_number":228,"context_line":"      service { $mon_service:"},{"line_number":229,"context_line":"        ensure \u003d\u003e stopped"},{"line_number":230,"context_line":"      }"},{"line_number":231,"context_line":"      -\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_94e511aa","line":228,"updated":"2016-09-13 22:43:50.000000000","message":"isn\u0027t the service resource named after the Service \u0027name\u0027 parameter?","commit_id":"65f9d0ac49925e5f212824580150f998c70a1fbf"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7cc878bb14505431fb603bde357d7612d6554f86","unresolved":false,"context_lines":[{"line_number":225,"context_line":"      }"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    } elsif $ensure \u003d\u003d absent {"},{"line_number":228,"context_line":"      service { $mon_service:"},{"line_number":229,"context_line":"        ensure \u003d\u003e stopped"},{"line_number":230,"context_line":"      }"},{"line_number":231,"context_line":"      -\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_c202663e","line":228,"in_reply_to":"7a8ec9b2_8f1dfa68","updated":"2016-09-14 08:54:18.000000000","message":"right but my understanding is that this will only stop a service named \u0027ceph-mon-${id}\u0027, is it wrong?","commit_id":"65f9d0ac49925e5f212824580150f998c70a1fbf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6a88a20db1df5e19669cf2a13eadb9caf3cb18bd","unresolved":false,"context_lines":[{"line_number":225,"context_line":"      }"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    } elsif $ensure \u003d\u003d absent {"},{"line_number":228,"context_line":"      service { $mon_service:"},{"line_number":229,"context_line":"        ensure \u003d\u003e stopped"},{"line_number":230,"context_line":"      }"},{"line_number":231,"context_line":"      -\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_8f1dfa68","line":228,"in_reply_to":"7a8ec9b2_94e511aa","updated":"2016-09-13 22:49:39.000000000","message":"By default title \u003d\u003d name. It doesn\u0027t have to.  So in this case, we want the name to be different than the title due to the upstart/systemd name differences.  Name is generally what gets used when interacting with the underlying service providers and the title is what is used by puppet for relationships, etc. This could be service { \u0027foo\u0027: name \u003d\u003e \u0027ceph-mon@1\u0027 } and that is valid.","commit_id":"65f9d0ac49925e5f212824580150f998c70a1fbf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"94f3c5d245fb1a149d8301103f2462ad2d6231b6","unresolved":false,"context_lines":[{"line_number":225,"context_line":"      }"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    } elsif $ensure \u003d\u003d absent {"},{"line_number":228,"context_line":"      service { $mon_service:"},{"line_number":229,"context_line":"        ensure \u003d\u003e stopped"},{"line_number":230,"context_line":"      }"},{"line_number":231,"context_line":"      -\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_dc7c0923","line":228,"in_reply_to":"7a8ec9b2_c202663e","updated":"2016-09-14 10:18:51.000000000","message":"No for systemd it\u0027ll manage the service named ceph-mon@${id}.  The puppet title does not affect what the actual service is managed if name is specified.  This is where the title/name thing comes in. \n\nhttps://docs.puppet.com/puppet/latest/reference/types/service.html#service-attribute-name","commit_id":"65f9d0ac49925e5f212824580150f998c70a1fbf"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6098a89d879776914617bf3b92953f3bf245dcd4","unresolved":false,"context_lines":[{"line_number":225,"context_line":"      }"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    } elsif $ensure \u003d\u003d absent {"},{"line_number":228,"context_line":"      service { $mon_service:"},{"line_number":229,"context_line":"        ensure \u003d\u003e stopped"},{"line_number":230,"context_line":"      }"},{"line_number":231,"context_line":"      -\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_77522e15","line":228,"in_reply_to":"7a8ec9b2_dc7c0923","updated":"2016-09-14 10:24:11.000000000","message":"right, I did not know that l102 is not defining the resource but only the defaults for the resource :)\n\nthanks!","commit_id":"65f9d0ac49925e5f212824580150f998c70a1fbf"}],"manifests/rgw.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"907c6cd103cf2ec1ac14a7079313fed9d4f59ea4","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    Service {"},{"line_number":173,"context_line":"      name     \u003d\u003e \"radosgw-${name}\","},{"line_number":174,"context_line":"      start    \u003d\u003e \"start radosgw id\u003d${name}\","},{"line_number":175,"context_line":"      stop     \u003d\u003e \"stop radosgw id\u003d${name}\","},{"line_number":176,"context_line":"      status   \u003d\u003e \"status radosgw id\u003d${name}\","},{"line_number":177,"context_line":"      provider \u003d\u003e $::ceph::params::service_provider,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a8ec9b2_db16eca6","line":174,"updated":"2016-09-13 21:04:08.000000000","message":"shouldn\u0027t we enable \u003d\u003e $rgw_enable here too?","commit_id":"9f3a31fa22551bd922fc22b0900c120b109ae224"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ddfbf2fda7fc27ba43677d26f52b65bf14b1c887","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    Service {"},{"line_number":173,"context_line":"      name     \u003d\u003e \"radosgw-${name}\","},{"line_number":174,"context_line":"      start    \u003d\u003e \"start radosgw id\u003d${name}\","},{"line_number":175,"context_line":"      stop     \u003d\u003e \"stop radosgw id\u003d${name}\","},{"line_number":176,"context_line":"      status   \u003d\u003e \"status radosgw id\u003d${name}\","},{"line_number":177,"context_line":"      provider \u003d\u003e $::ceph::params::service_provider,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a8ec9b2_7eb9462e","line":174,"in_reply_to":"7a8ec9b2_db16eca6","updated":"2016-09-13 21:15:16.000000000","message":"same sort of deal as the mons, i think radosgw doesn\u0027t work the same under upstart.","commit_id":"9f3a31fa22551bd922fc22b0900c120b109ae224"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"ea54ce9954a9f8379854e6338e753bfb19c0105e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  # Everything else that is supported by puppet-ceph should run systemd."},{"line_number":181,"context_line":"  } else {"},{"line_number":182,"context_line":"    Service {"},{"line_number":183,"context_line":"      name   \u003d\u003e \"ceph-radowsgw@${name}\","},{"line_number":184,"context_line":"      enable \u003d\u003e $rgw_enable,"},{"line_number":185,"context_line":"      ensure \u003d\u003e $rgw_ensure,"},{"line_number":186,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_e20045ad","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":40},"updated":"2016-09-14 08:01:49.000000000","message":"there is a typo, should be ceph-radosgw, it broke fuel ci, i wonder why other tests passed","commit_id":"65f9d0ac49925e5f212824580150f998c70a1fbf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"94f3c5d245fb1a149d8301103f2462ad2d6231b6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  # Everything else that is supported by puppet-ceph should run systemd."},{"line_number":181,"context_line":"  } else {"},{"line_number":182,"context_line":"    Service {"},{"line_number":183,"context_line":"      name   \u003d\u003e \"ceph-radowsgw@${name}\","},{"line_number":184,"context_line":"      enable \u003d\u003e $rgw_enable,"},{"line_number":185,"context_line":"      ensure \u003d\u003e $rgw_ensure,"},{"line_number":186,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_3cc24d34","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":40},"in_reply_to":"7a8ec9b2_e20045ad","updated":"2016-09-14 10:18:51.000000000","message":"oops. I have always struggled with radosgw and usually typo this with radowsgw. Thanks. I\u0027ll fix.","commit_id":"65f9d0ac49925e5f212824580150f998c70a1fbf"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7cc878bb14505431fb603bde357d7612d6554f86","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  # Everything else that is supported by puppet-ceph should run systemd."},{"line_number":181,"context_line":"  } else {"},{"line_number":182,"context_line":"    Service {"},{"line_number":183,"context_line":"      name   \u003d\u003e \"ceph-radowsgw@${name}\","},{"line_number":184,"context_line":"      enable \u003d\u003e $rgw_enable,"},{"line_number":185,"context_line":"      ensure \u003d\u003e $rgw_ensure,"},{"line_number":186,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_dd1a4e6e","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":40},"in_reply_to":"7a8ec9b2_e20045ad","updated":"2016-09-14 08:54:18.000000000","message":"the tripleo job is not using radosgw","commit_id":"65f9d0ac49925e5f212824580150f998c70a1fbf"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"dd89fff0ce77de7f73f342e655d6ecea2dc98682","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    Service {"},{"line_number":183,"context_line":"      name   \u003d\u003e \"ceph-radosgw@${name}\","},{"line_number":184,"context_line":"      enable \u003d\u003e $rgw_enable,"},{"line_number":185,"context_line":"      ensure \u003d\u003e $rgw_ensure,"},{"line_number":186,"context_line":"    }"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_79800e47","line":185,"updated":"2016-09-15 15:39:06.000000000","message":"Should we set this here when we are setting it again on line 190?","commit_id":"06fdab88c9bad08e49d8cadb7f2a1a581ac899d3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a58409490161805e3c623993d08f17a04596538f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    Service {"},{"line_number":183,"context_line":"      name   \u003d\u003e \"ceph-radosgw@${name}\","},{"line_number":184,"context_line":"      enable \u003d\u003e $rgw_enable,"},{"line_number":185,"context_line":"      ensure \u003d\u003e $rgw_ensure,"},{"line_number":186,"context_line":"    }"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_d94f62bb","line":185,"in_reply_to":"7a8ec9b2_79800e47","updated":"2016-09-15 15:44:15.000000000","message":"Good catch, yea not really necessary here as the line 190 will override this.","commit_id":"06fdab88c9bad08e49d8cadb7f2a1a581ac899d3"}],"releasenotes/notes/service-management-9483b9cfc067c736.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"72697b5a9ccb149a4d3b7d4cd5a5e735a1ecafd5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"  - removal of support for sysv service management for"},{"line_number":7,"context_line":"    ceph-mon and ceph-radosgw as the current recommended"},{"line_number":8,"context_line":"    platforms are either systemd or upstart based."},{"line_number":9,"context_line":"    http://docs.ceph.com/docs/jewel/start/os-recommendations/#platforms"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a8ec9b2_49c116e4","line":8,"updated":"2016-09-14 10:52:18.000000000","message":"more than because of the platforms, this is because current version of the module does not support ceph/hammer anymore, the jewel version comes with systemd units not sysv inits","commit_id":"06fdab88c9bad08e49d8cadb7f2a1a581ac899d3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0762a78ce62a1d34d10b866ae8ecabf77e3da950","unresolved":false,"context_lines":[{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"  - removal of support for sysv service management for"},{"line_number":7,"context_line":"    ceph-mon and ceph-radosgw as the current recommended"},{"line_number":8,"context_line":"    platforms are either systemd or upstart based."},{"line_number":9,"context_line":"    http://docs.ceph.com/docs/jewel/start/os-recommendations/#platforms"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a8ec9b2_0c6abc80","line":8,"in_reply_to":"7a8ec9b2_49c116e4","updated":"2016-09-14 10:59:01.000000000","message":"It\u0027s kinda both. The main point is to say no more sysv but we still support upstart :)","commit_id":"06fdab88c9bad08e49d8cadb7f2a1a581ac899d3"}]}