)]}'
{"manifests/init.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"3b11a13f475150255a0afb6ed8a13493a1592295","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"  if $set_osd_params {"},{"line_number":176,"context_line":"    warning(\u0027set_osd_params is deprecated.  It is here to allow a transition to using \\"},{"line_number":177,"context_line":"              this module to assign values and will be removed in a future release.\u0027)"},{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  package { $::ceph::params::packages :"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_0830ef00","line":177,"updated":"2016-09-14 09:27:33.000000000","message":"nit: remove extra whitespace before \"this ...\"","commit_id":"acc8eb715df6998286f86e9d01659718bb26bd47"}],"manifests/repo.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"3b11a13f475150255a0afb6ed8a13493a1592295","unresolved":false,"context_lines":[{"line_number":123,"context_line":"      if $enable_sig {"},{"line_number":124,"context_line":"        if $::operatingsystem !\u003d \u0027CentOS\u0027 {"},{"line_number":125,"context_line":"          warning(\"CentOS SIG repository is only supported on CentOS operating system, \\"},{"line_number":126,"context_line":"                    not on ${::operatingsystem}, which can lead to packaging issues.\")"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        yumrepo { \u0027ceph-jewel-sig\u0027:"},{"line_number":129,"context_line":"          enabled    \u003d\u003e \u00271\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_28a84b1f","line":126,"updated":"2016-09-14 09:27:33.000000000","message":"nit: remove extra whitespace before \"not ...\"","commit_id":"acc8eb715df6998286f86e9d01659718bb26bd47"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"67c4af332adc3886989e91e00d63613d0fdc488d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"      if $enable_sig {"},{"line_number":124,"context_line":"        if $::operatingsystem !\u003d \u0027CentOS\u0027 {"},{"line_number":125,"context_line":"          warning(\"CentOS SIG repository is only supported on CentOS operating system, \\"},{"line_number":126,"context_line":"                    not on ${::operatingsystem}, which can lead to packaging issues.\")"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        yumrepo { \u0027ceph-jewel-sig\u0027:"},{"line_number":129,"context_line":"          enabled    \u003d\u003e \u00271\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_d6e78810","line":126,"in_reply_to":"7a8ec9b2_28a84b1f","updated":"2016-09-14 09:49:31.000000000","message":"Hey Ivan, thanks for the feedback.\nThe spaces need to be multiples of 2\nI\u0027ll double check it but I think will break lint.","commit_id":"acc8eb715df6998286f86e9d01659718bb26bd47"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3a9d7a7e1ff969a5300144e4d49b978dba01463c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      # https://wiki.centos.org/SpecialInterestGroup/Storage/"},{"line_number":123,"context_line":"      if $enable_sig {"},{"line_number":124,"context_line":"        if $::operatingsystem !\u003d \u0027CentOS\u0027 {"},{"line_number":125,"context_line":"          warning(\"CentOS SIG repository is only supported on CentOS operating system, \\"},{"line_number":126,"context_line":"                   not on ${::operatingsystem}, which can lead to packaging issues.\")"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        yumrepo { \u0027ceph-jewel-sig\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_62027571","line":125,"updated":"2016-09-19 20:22:06.000000000","message":"Oh now you bring this up. So I think we have to do something similar to HEREDOC where we don\u0027t pad the subseqent lines. This would have the added advantage of allowing for more works on the next lines.\n\n       warning(\"blahblah \\\ncontinued on next line \\\nend\")\n\nLooks like we need to go back and fix all the warnings.","commit_id":"666185809644d4f77f52121ba55178f3f8c02977"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"7f2561f92f80ec08262a157dd4c9afff41441638","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      # https://wiki.centos.org/SpecialInterestGroup/Storage/"},{"line_number":123,"context_line":"      if $enable_sig {"},{"line_number":124,"context_line":"        if $::operatingsystem !\u003d \u0027CentOS\u0027 {"},{"line_number":125,"context_line":"          warning(\"CentOS SIG repository is only supported on CentOS operating system, \\"},{"line_number":126,"context_line":"                   not on ${::operatingsystem}, which can lead to packaging issues.\")"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        yumrepo { \u0027ceph-jewel-sig\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_c5e3f703","line":125,"updated":"2016-09-15 14:41:37.000000000","message":"Won\u0027t these types of breaks introduce long hunks of space in the log output? e.g.\nCentOS SIG repository is only supported on CentOS operating system,             not  on\n\nIs there a better way to do it or are we stuck with a choice between big gaps in output or line continuations with no ident?","commit_id":"666185809644d4f77f52121ba55178f3f8c02977"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"3f69dbe69379b95586cda787d74252a1a652b308","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      # https://wiki.centos.org/SpecialInterestGroup/Storage/"},{"line_number":123,"context_line":"      if $enable_sig {"},{"line_number":124,"context_line":"        if $::operatingsystem !\u003d \u0027CentOS\u0027 {"},{"line_number":125,"context_line":"          warning(\"CentOS SIG repository is only supported on CentOS operating system, \\"},{"line_number":126,"context_line":"                   not on ${::operatingsystem}, which can lead to packaging issues.\")"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        yumrepo { \u0027ceph-jewel-sig\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_7913ae0d","line":125,"in_reply_to":"7a8ec9b2_5e425811","updated":"2016-09-15 15:37:56.000000000","message":"i.e.\n\nOption 1\n\n  Warning: Scope(Class[main]): asdfasdf but blah blah         new line blah\n\nOption 2\n\n  Warning: Scope(Class[main]): asdfasdf but blah blah \n\n             new line blah\n\nOption 3\n\n  Warning: Scope(Class[main]): asdfasdf but blah blah\n  Warning: Scope(Class[main]): new line blah","commit_id":"666185809644d4f77f52121ba55178f3f8c02977"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"089faa70c78c453e043863de1dd33f2974ad7cf3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      # https://wiki.centos.org/SpecialInterestGroup/Storage/"},{"line_number":123,"context_line":"      if $enable_sig {"},{"line_number":124,"context_line":"        if $::operatingsystem !\u003d \u0027CentOS\u0027 {"},{"line_number":125,"context_line":"          warning(\"CentOS SIG repository is only supported on CentOS operating system, \\"},{"line_number":126,"context_line":"                   not on ${::operatingsystem}, which can lead to packaging issues.\")"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        yumrepo { \u0027ceph-jewel-sig\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_795e4e77","line":125,"in_reply_to":"7a8ec9b2_7913ae0d","updated":"2016-09-15 15:44:23.000000000","message":"sorry,\n\nOption 2\n  Warning: Scope(Class[main]): asdfasdf but blah blah \n             \u003cempty line here\u003e\n             new line blah","commit_id":"666185809644d4f77f52121ba55178f3f8c02977"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"e2f019251fcc31f6778826d1df4cb4e7e6885491","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      # https://wiki.centos.org/SpecialInterestGroup/Storage/"},{"line_number":123,"context_line":"      if $enable_sig {"},{"line_number":124,"context_line":"        if $::operatingsystem !\u003d \u0027CentOS\u0027 {"},{"line_number":125,"context_line":"          warning(\"CentOS SIG repository is only supported on CentOS operating system, \\"},{"line_number":126,"context_line":"                   not on ${::operatingsystem}, which can lead to packaging issues.\")"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        yumrepo { \u0027ceph-jewel-sig\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_5e425811","line":125,"in_reply_to":"7a8ec9b2_c5e3f703","updated":"2016-09-15 15:31:49.000000000","message":"Yeahp, that will introduce a \"     \" in the message, we can add a \\n but that will introduce an empty space between the lines or duplicate the call to the warning function, which will create 2 log entries.. \n\nThe best option IMO should re-write the messages for not having more than 140 chars.","commit_id":"666185809644d4f77f52121ba55178f3f8c02977"}]}