)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b97eccf71e885c6348650b4ec9169ae45b797d81","unresolved":false,"context_lines":[{"line_number":27,"context_line":"if the FSID is defined. Else, leaves the $cluster_option variable as"},{"line_number":28,"context_line":"is."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I61d18400754842860372c4cc5f3b80d104d59706"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_bfa03ef5","line":30,"updated":"2016-09-19 10:21:34.000000000","message":"You might want to add a line:\n\nCloses-Bug: 1604728\n\nbefore Change-Id as well and set branch topic to:\n\nbug/1604728","commit_id":"006e3bb2d376ce31d99ba6883765e49a18ce749a"}],"manifests/osd.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8c04053f1460b66377db33f54c799a90ee03acdc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   on the directory backing the OSD service."},{"line_number":46,"context_line":"#   Optional. Defaults to \u0027ceph_var_lib_t\u0027"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*fsid*] The ceph cluster FSID"},{"line_number":49,"context_line":"#   Optional. Defaults to $::ceph::profile::params::fsid"},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"define ceph::osd ("}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_dade2ddc","line":48,"updated":"2016-09-16 18:34:16.000000000","message":"this new option will probably require a unit test and a release note.","commit_id":"006e3bb2d376ce31d99ba6883765e49a18ce749a"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"043d97ffadcce39e239850dc44f7a16c6f12808c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $cluster \u003d undef,"},{"line_number":55,"context_line":"  $exec_timeout \u003d $::ceph::params::exec_timeout,"},{"line_number":56,"context_line":"  $selinux_file_context \u003d \u0027ceph_var_lib_t\u0027,"},{"line_number":57,"context_line":"  $fsid \u003d $::ceph::profile::params::fsid,  "},{"line_number":58,"context_line":"  ) {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    $data \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_1a77b502","line":57,"updated":"2016-09-16 18:37:14.000000000","message":"White space at EOL.","commit_id":"006e3bb2d376ce31d99ba6883765e49a18ce749a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8c04053f1460b66377db33f54c799a90ee03acdc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $cluster \u003d undef,"},{"line_number":55,"context_line":"  $exec_timeout \u003d $::ceph::params::exec_timeout,"},{"line_number":56,"context_line":"  $selinux_file_context \u003d \u0027ceph_var_lib_t\u0027,"},{"line_number":57,"context_line":"  $fsid \u003d $::ceph::profile::params::fsid,  "},{"line_number":58,"context_line":"  ) {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    $data \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_5aca1d1c","line":57,"updated":"2016-09-16 18:34:16.000000000","message":"please remove trailing space","commit_id":"006e3bb2d376ce31d99ba6883765e49a18ce749a"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"043d97ffadcce39e239850dc44f7a16c6f12808c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    if $cluster {"},{"line_number":63,"context_line":"      $cluster_option \u003d \"--cluster ${cluster}\""},{"line_number":64,"context_line":"      if $fsid {"},{"line_number":65,"context_line":"        $cluster_option \u003d \"--cluster ${cluster} --fsid ${fsid}\""},{"line_number":66,"context_line":"      }      "},{"line_number":67,"context_line":"      $cluster_name \u003d $cluster"},{"line_number":68,"context_line":"    } else {"},{"line_number":69,"context_line":"      $cluster_name \u003d \u0027ceph\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_dab38d96","line":66,"range":{"start_line":64,"start_character":6,"end_line":66,"end_character":7},"updated":"2016-09-16 18:37:14.000000000","message":"Can this be moved to line 71 and change the assignment to:\n$cluster_option \u003d \"${cluster_option} --fsid ${fsid}\"","commit_id":"006e3bb2d376ce31d99ba6883765e49a18ce749a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8c04053f1460b66377db33f54c799a90ee03acdc","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      $cluster_option \u003d \"--cluster ${cluster}\""},{"line_number":64,"context_line":"      if $fsid {"},{"line_number":65,"context_line":"        $cluster_option \u003d \"--cluster ${cluster} --fsid ${fsid}\""},{"line_number":66,"context_line":"      }      "},{"line_number":67,"context_line":"      $cluster_name \u003d $cluster"},{"line_number":68,"context_line":"    } else {"},{"line_number":69,"context_line":"      $cluster_name \u003d \u0027ceph\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_7acd1930","line":66,"updated":"2016-09-16 18:34:16.000000000","message":"please remove trailing space","commit_id":"006e3bb2d376ce31d99ba6883765e49a18ce749a"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"043d97ffadcce39e239850dc44f7a16c6f12808c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      $cluster_option \u003d \"--cluster ${cluster}\""},{"line_number":64,"context_line":"      if $fsid {"},{"line_number":65,"context_line":"        $cluster_option \u003d \"--cluster ${cluster} --fsid ${fsid}\""},{"line_number":66,"context_line":"      }      "},{"line_number":67,"context_line":"      $cluster_name \u003d $cluster"},{"line_number":68,"context_line":"    } else {"},{"line_number":69,"context_line":"      $cluster_name \u003d \u0027ceph\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_ba5c017e","line":66,"updated":"2016-09-16 18:37:14.000000000","message":"white space at EOL.","commit_id":"006e3bb2d376ce31d99ba6883765e49a18ce749a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d015206e665162f66d6e54935f4aaeae5776133d","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    if $cluster {"},{"line_number":63,"context_line":"      $cluster_option \u003d \"--cluster ${cluster}\""},{"line_number":64,"context_line":"      if $fsid {"},{"line_number":65,"context_line":"        $cluster_option \u003d \"--cluster ${cluster} --fsid ${fsid}\""},{"line_number":66,"context_line":"      }      "},{"line_number":67,"context_line":"      $cluster_name \u003d $cluster"},{"line_number":68,"context_line":"    } else {"},{"line_number":69,"context_line":"      $cluster_name \u003d \u0027ceph\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_ff0ac61e","line":66,"range":{"start_line":64,"start_character":6,"end_line":66,"end_character":7},"in_reply_to":"7a8ec9b2_dab38d96","updated":"2016-09-19 10:20:08.000000000","message":"+1 , I think the ultimate goal is to pass --fsid always","commit_id":"006e3bb2d376ce31d99ba6883765e49a18ce749a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d7ef9f0c935f14e7c18d2b23a686194b37d1462c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"\","},{"line_number":96,"context_line":"        logoutput \u003d\u003e true,"},{"line_number":97,"context_line":"      }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"      # return error if ${data} has fsid differing from ${fsid}, unless there is no fsid"},{"line_number":100,"context_line":"      exec { $ceph_check_fsid_mismatch:"},{"line_number":101,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_7ce2f902","line":98,"updated":"2016-09-20 12:02:06.000000000","message":"Here we might want:\n\nExec[$ceph_check_udev] -\u003e Exec[$ceph_check_fsid_mismatch]","commit_id":"c97736b67f1d9063202ed89b136ee65cb0a2f8ff"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9dedf87d19c8e335b77e74dea4b12f774c888b0e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"\","},{"line_number":96,"context_line":"        logoutput \u003d\u003e true,"},{"line_number":97,"context_line":"      }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"      # return error if ${data} has fsid differing from ${fsid}, unless there is no fsid"},{"line_number":100,"context_line":"      exec { $ceph_check_fsid_mismatch:"},{"line_number":101,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_aad26132","line":98,"in_reply_to":"7a8ec9b2_7ce2f902","updated":"2016-09-20 16:32:22.000000000","message":"Done","commit_id":"c97736b67f1d9063202ed89b136ee65cb0a2f8ff"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d7ef9f0c935f14e7c18d2b23a686194b37d1462c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"set -ex"},{"line_number":103,"context_line":"test ${fsid} \u003d \\$(ceph-disk list ${data} | egrep -o \u0027[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}\u0027)"},{"line_number":104,"context_line":"\","},{"line_number":105,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":106,"context_line":"set -ex"},{"line_number":107,"context_line":"test -z \\$(ceph-disk list ${data} | egrep -o \u0027[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}\u0027)"},{"line_number":108,"context_line":"\","}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_3c9cf15c","line":105,"updated":"2016-09-20 12:02:06.000000000","message":"if we don\u0027t need the unless clause, I think we can remove it entirely","commit_id":"c97736b67f1d9063202ed89b136ee65cb0a2f8ff"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9dedf87d19c8e335b77e74dea4b12f774c888b0e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"set -ex"},{"line_number":103,"context_line":"test ${fsid} \u003d \\$(ceph-disk list ${data} | egrep -o \u0027[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}\u0027)"},{"line_number":104,"context_line":"\","},{"line_number":105,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":106,"context_line":"set -ex"},{"line_number":107,"context_line":"test -z \\$(ceph-disk list ${data} | egrep -o \u0027[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}\u0027)"},{"line_number":108,"context_line":"\","}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_4ac9dd78","line":105,"in_reply_to":"7a8ec9b2_3c9cf15c","updated":"2016-09-20 16:32:22.000000000","message":"I think we need it because a new disk will have no FSID and we don\u0027t want to fail for that reason.","commit_id":"c97736b67f1d9063202ed89b136ee65cb0a2f8ff"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d7ef9f0c935f14e7c18d2b23a686194b37d1462c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        logoutput \u003d\u003e true,"},{"line_number":110,"context_line":"        timeout   \u003d\u003e $exec_timeout,"},{"line_number":111,"context_line":"      }"},{"line_number":112,"context_line":"      Exec[$ceph_check_udev] -\u003e Exec[$ceph_prepare]"},{"line_number":113,"context_line":"      # ceph-disk: prepare should be idempotent http://tracker.ceph.com/issues/7475"},{"line_number":114,"context_line":"      exec { $ceph_prepare:"},{"line_number":115,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_7c1bd91c","line":112,"updated":"2016-09-20 12:02:06.000000000","message":"I think this should become:\n\nExec[$ceph_check_fsid_mismatch] -\u003e Exec[$ceph_prepare]","commit_id":"c97736b67f1d9063202ed89b136ee65cb0a2f8ff"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9dedf87d19c8e335b77e74dea4b12f774c888b0e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        logoutput \u003d\u003e true,"},{"line_number":110,"context_line":"        timeout   \u003d\u003e $exec_timeout,"},{"line_number":111,"context_line":"      }"},{"line_number":112,"context_line":"      Exec[$ceph_check_udev] -\u003e Exec[$ceph_prepare]"},{"line_number":113,"context_line":"      # ceph-disk: prepare should be idempotent http://tracker.ceph.com/issues/7475"},{"line_number":114,"context_line":"      exec { $ceph_prepare:"},{"line_number":115,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_4a1b9d1c","line":112,"in_reply_to":"7a8ec9b2_7c1bd91c","updated":"2016-09-20 16:32:22.000000000","message":"Done","commit_id":"c97736b67f1d9063202ed89b136ee65cb0a2f8ff"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ff33b7c3ce084af4d61492ffaf159242e1f5a247","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      $cluster_name \u003d \u0027ceph\u0027"},{"line_number":67,"context_line":"    }"},{"line_number":68,"context_line":"    if $fsid {"},{"line_number":69,"context_line":"      $cluster_option \u003d \"${cluster_option} --cluster-uuid ${fsid}\""},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"    "},{"line_number":72,"context_line":"    if $ensure \u003d\u003d present {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a8ec9b2_fd542755","line":69,"updated":"2016-09-20 21:02:22.000000000","message":"we can\u0027t reassign vars in puppet though, you probably want to rename L63 (this is causing one of the unit tests to fail)","commit_id":"b75a00d61bebfa43748c3ff7021d5de25388f14a"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8ef6cd9846aa36112e0e4910b724a898e4b4056c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        logoutput \u003d\u003e true,"},{"line_number":97,"context_line":"      }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"      Exec[$ceph_check_udev] -\u003e Exec[$ceph_check_fsid_mismatch]"},{"line_number":100,"context_line":"      # return error if ${data} has fsid differing from ${fsid}, unless there is no fsid"},{"line_number":101,"context_line":"      exec { $ceph_check_fsid_mismatch:"},{"line_number":102,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":103,"context_line":"set -ex"},{"line_number":104,"context_line":"test ${fsid} \u003d \\$(ceph-disk list ${data} | egrep -o \u0027[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}\u0027)"},{"line_number":105,"context_line":"\","},{"line_number":106,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":107,"context_line":"set -ex"},{"line_number":108,"context_line":"test -z \\$(ceph-disk list ${data} | egrep -o \u0027[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}\u0027)"},{"line_number":109,"context_line":"\","},{"line_number":110,"context_line":"        logoutput \u003d\u003e true,"},{"line_number":111,"context_line":"        timeout   \u003d\u003e $exec_timeout,"},{"line_number":112,"context_line":"      }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      Exec[$ceph_check_fsid_mismatch] -\u003e Exec[$ceph_prepare]"},{"line_number":115,"context_line":"      # ceph-disk: prepare should be idempotent http://tracker.ceph.com/issues/7475"},{"line_number":116,"context_line":"      exec { $ceph_prepare:"},{"line_number":117,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7a8ec9b2_dcd3b4d3","line":114,"range":{"start_line":99,"start_character":6,"end_line":114,"end_character":60},"updated":"2016-09-21 15:51:09.000000000","message":"$::ceph::profile::params::fsid can be undef, so this test will fail, please move into a conditional and add tests for both cases","commit_id":"acaa8b69783a817d8a8240e2a4331b9b8c0de28c"}],"releasenotes/notes/osd-check-fsid-mismatch-a5cb615be1b4e40f.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d7ef9f0c935f14e7c18d2b23a686194b37d1462c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The ceph cluster FSID is explictly added as a cluster option"},{"line_number":4,"context_line":"  - An additional check is done prior to preparing an OSD to verify the OSD is not already prepared with a different FSID, which is a symptom of trying to add an OSD from a different ceph cluster"},{"line_number":5,"context_line":"  - The deployment will fail if an the OSD fails to activate when trying to deploy on top of an existing failed deploy"},{"line_number":6,"context_line":"  - Prior to this change, a deploy might report it is successful even if all of the OSDs fail to activate"},{"line_number":7,"context_line":"  - The logs will indicate that the OSD activation failed because a different FSID was found so that the user may then choose zap away the old deploy"},{"line_number":8,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a8ec9b2_3cb791f6","line":5,"updated":"2016-09-20 12:02:06.000000000","message":"this looks like continuation of the previous line","commit_id":"c97736b67f1d9063202ed89b136ee65cb0a2f8ff"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8ef6cd9846aa36112e0e4910b724a898e4b4056c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The ceph cluster FSID is explictly added as a cluster option (--cluster-uuid) per OSD  "},{"line_number":4,"context_line":"  - An additional check is done prior to preparing an OSD to verify the OSD is not already prepared with a different FSID, which is a symptom of trying to add an OSD from a different ceph cluster"},{"line_number":5,"context_line":"  - Prior to this change, a deploy might report it is successful even if all of the OSDs fail to activate"},{"line_number":6,"context_line":"  - The logs will now indicate that the OSD activation failed because a different FSID was found so that the user may then choose zap away the old deploy"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a8ec9b2_dcead473","line":3,"range":{"start_line":3,"start_character":89,"end_line":3,"end_character":91},"updated":"2016-09-21 15:51:09.000000000","message":"nit:whitespace","commit_id":"acaa8b69783a817d8a8240e2a4331b9b8c0de28c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6bd463d262e6fddce1c9a82700c4247967715519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The ceph cluster FSID is explictly added as a cluster option (--cluster-uuid) per OSD  "},{"line_number":4,"context_line":"  - An additional check is done prior to preparing an OSD to verify the OSD is not already prepared with a different FSID, which is a symptom of trying to add an OSD from a different ceph cluster"},{"line_number":5,"context_line":"  - Prior to this change, a deploy might report it is successful even if all of the OSDs fail to activate"},{"line_number":6,"context_line":"  - The logs will now indicate that the OSD activation failed because a different FSID was found so that the user may then choose zap away the old deploy"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a8ec9b2_3c6743b8","line":3,"updated":"2016-09-21 13:39:39.000000000","message":"to ceph-disk prepare","commit_id":"acaa8b69783a817d8a8240e2a4331b9b8c0de28c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6bd463d262e6fddce1c9a82700c4247967715519","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The ceph cluster FSID is explictly added as a cluster option (--cluster-uuid) per OSD  "},{"line_number":4,"context_line":"  - An additional check is done prior to preparing an OSD to verify the OSD is not already prepared with a different FSID, which is a symptom of trying to add an OSD from a different ceph cluster"},{"line_number":5,"context_line":"  - Prior to this change, a deploy might report it is successful even if all of the OSDs fail to activate"},{"line_number":6,"context_line":"  - The logs will now indicate that the OSD activation failed because a different FSID was found so that the user may then choose zap away the old deploy"},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - Bug 1604728 Puppet should exit with error if disk activate fails"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a8ec9b2_5cd40f1f","line":6,"updated":"2016-09-21 13:39:39.000000000","message":"looks like this is continuation of previous line?","commit_id":"acaa8b69783a817d8a8240e2a4331b9b8c0de28c"}],"spec/defines/ceph_osd_spec.rb":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ff33b7c3ce084af4d61492ffaf159242e1f5a247","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        {"},{"line_number":108,"context_line":"          :cluster \u003d\u003e \u0027testcluster\u0027,"},{"line_number":109,"context_line":"          :journal \u003d\u003e \u0027/srv/journal\u0027,"},{"line_number":110,"context_line":"          :fsid    \u003d\u003e \u0027f39ace04-f967-4c3d-9fd2-32af2d2d2cd5\u0027,"},{"line_number":111,"context_line":"        }"},{"line_number":112,"context_line":"      end"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7a8ec9b2_7dbc976c","line":110,"updated":"2016-09-20 21:02:22.000000000","message":"I think you need to set the fsid as a default param as we can\u0027t guess the fsid from the other tests exec output","commit_id":"b75a00d61bebfa43748c3ff7021d5de25388f14a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3d9d2dd79c75a8ba75fd78548112db1e34bad985","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        {"},{"line_number":108,"context_line":"          :cluster \u003d\u003e \u0027testcluster\u0027,"},{"line_number":109,"context_line":"          :journal \u003d\u003e \u0027/srv/journal\u0027,"},{"line_number":110,"context_line":"          :fsid    \u003d\u003e \u0027f39ace04-f967-4c3d-9fd2-32af2d2d2cd5\u0027,"},{"line_number":111,"context_line":"        }"},{"line_number":112,"context_line":"      end"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7a8ec9b2_bd445f74","line":110,"in_reply_to":"7a8ec9b2_7dbc976c","updated":"2016-09-20 21:03:51.000000000","message":"or you can duplicate this on l31","commit_id":"b75a00d61bebfa43748c3ff7021d5de25388f14a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6bd463d262e6fddce1c9a82700c4247967715519","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      let :title do"},{"line_number":29,"context_line":"        \u0027/srv\u0027"},{"line_number":30,"context_line":"      end"},{"line_number":31,"context_line":"      "},{"line_number":32,"context_line":"      let :params do"},{"line_number":33,"context_line":"        {"},{"line_number":34,"context_line":"          :fsid    \u003d\u003e \u0027f39ace04-f967-4c3d-9fd2-32af2d2d2cd5\u0027,"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"7a8ec9b2_fce5db08","line":31,"updated":"2016-09-21 13:39:39.000000000","message":"would be good to remove the spaces here","commit_id":"acaa8b69783a817d8a8240e2a4331b9b8c0de28c"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8ef6cd9846aa36112e0e4910b724a898e4b4056c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        chown -h ceph:ceph /srv"},{"line_number":69,"context_line":"    fi"},{"line_number":70,"context_line":"fi"},{"line_number":71,"context_line":"ceph-disk prepare  --cluster-uuid f39ace04-f967-4c3d-9fd2-32af2d2d2cd5 /srv "},{"line_number":72,"context_line":"udevadm settle"},{"line_number":73,"context_line":"\","},{"line_number":74,"context_line":"        \u0027unless\u0027    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"7a8ec9b2_7c9620f1","line":71,"range":{"start_line":71,"start_character":75,"end_line":71,"end_character":76},"updated":"2016-09-21 15:51:09.000000000","message":"nit: whitespace","commit_id":"acaa8b69783a817d8a8240e2a4331b9b8c0de28c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1e885f8322c8cad86a3b60aa1c332b716f5aad86","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        chown -h ceph:ceph /srv"},{"line_number":52,"context_line":"    fi"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":"ceph-disk prepare  /srv "},{"line_number":55,"context_line":"udevadm settle"},{"line_number":56,"context_line":"\","},{"line_number":57,"context_line":"        \u0027unless\u0027    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"5a8bc5a2_6eeec48c","line":54,"updated":"2016-09-22 23:19:08.000000000","message":"you need to add an extra blank space here before /srv","commit_id":"32bb94da1b86594e1c0a81c33224cc15f3ab1b52"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a2740809cfc56496889efe77245ee4f893dd27ad","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        chown -h ceph:ceph /srv"},{"line_number":52,"context_line":"    fi"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":"ceph-disk prepare  /srv "},{"line_number":55,"context_line":"udevadm settle"},{"line_number":56,"context_line":"\","},{"line_number":57,"context_line":"        \u0027unless\u0027    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"5a8bc5a2_8c0a38d1","line":54,"in_reply_to":"5a8bc5a2_6eeec48c","updated":"2016-09-23 00:24:26.000000000","message":"Done","commit_id":"32bb94da1b86594e1c0a81c33224cc15f3ab1b52"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1e885f8322c8cad86a3b60aa1c332b716f5aad86","unresolved":false,"context_lines":[{"line_number":115,"context_line":"      ) }"},{"line_number":116,"context_line":"      it { is_expected.to contain_exec(\u0027ceph-osd-check-fsid-mismatch-/srv/data\u0027).with("},{"line_number":117,"context_line":"        \u0027command\u0027   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":118,"context_line":"set -ex"},{"line_number":119,"context_line":"test f39ace04-f967-4c3d-9fd2-32af2d2d2cd5 \u003d \\$(ceph-disk list /srv/data | egrep -o \u0027[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}\u0027)"},{"line_number":120,"context_line":"\","},{"line_number":121,"context_line":"        \u0027unless\u0027    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"5a8bc5a2_8e6870f7","line":118,"updated":"2016-09-22 23:19:08.000000000","message":"lines 118, 119, 122, 123 go indented with 10 spaces","commit_id":"32bb94da1b86594e1c0a81c33224cc15f3ab1b52"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a2740809cfc56496889efe77245ee4f893dd27ad","unresolved":false,"context_lines":[{"line_number":115,"context_line":"      ) }"},{"line_number":116,"context_line":"      it { is_expected.to contain_exec(\u0027ceph-osd-check-fsid-mismatch-/srv/data\u0027).with("},{"line_number":117,"context_line":"        \u0027command\u0027   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":118,"context_line":"set -ex"},{"line_number":119,"context_line":"test f39ace04-f967-4c3d-9fd2-32af2d2d2cd5 \u003d \\$(ceph-disk list /srv/data | egrep -o \u0027[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}\u0027)"},{"line_number":120,"context_line":"\","},{"line_number":121,"context_line":"        \u0027unless\u0027    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"5a8bc5a2_ac0ff4df","line":118,"in_reply_to":"5a8bc5a2_8e6870f7","updated":"2016-09-23 00:24:26.000000000","message":"Done","commit_id":"32bb94da1b86594e1c0a81c33224cc15f3ab1b52"}]}