)]}'
{"manifests/rgw.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b9c58d4fb265ffa1005ee36dbb2ac648cc7732c2","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    mode                    \u003d\u003e \u00270640\u0027,"},{"line_number":155,"context_line":"    selinux_ignore_defaults \u003d\u003e true,"},{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  # service definition"},{"line_number":159,"context_line":"  # if Ubuntu does not use systemd"},{"line_number":160,"context_line":"  if $::service_provider \u003d\u003d \u0027upstart\u0027 {"},{"line_number":161,"context_line":"    if $rgw_enable {"},{"line_number":162,"context_line":"      file { \"${rgw_data}/done\":"},{"line_number":163,"context_line":"        ensure \u003d\u003e present,"},{"line_number":164,"context_line":"        before \u003d\u003e Service[$rgw_service],"},{"line_number":165,"context_line":"      }"},{"line_number":166,"context_line":"    }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    $rgw_service \u003d \"radosgw-${name}\""},{"line_number":169,"context_line":"    Service {"},{"line_number":170,"context_line":"      name     \u003d\u003e $rgw_service,"},{"line_number":171,"context_line":"      start    \u003d\u003e \"start radosgw id\u003d${name}\","},{"line_number":172,"context_line":"      stop     \u003d\u003e \"stop radosgw id\u003d${name}\","},{"line_number":173,"context_line":"      status   \u003d\u003e \"status radosgw id\u003d${name}\","},{"line_number":174,"context_line":"      provider \u003d\u003e $::ceph::params::service_provider,"},{"line_number":175,"context_line":"    }"},{"line_number":176,"context_line":"  # Everything else that is supported by puppet-ceph should run systemd."},{"line_number":177,"context_line":"  } else {"},{"line_number":178,"context_line":"    $rgw_service \u003d \"ceph-radosgw@${name}\""},{"line_number":179,"context_line":"    Service {"},{"line_number":180,"context_line":"      name   \u003d\u003e $rgw_service,"},{"line_number":181,"context_line":"      enable \u003d\u003e $rgw_enable,"},{"line_number":182,"context_line":"    }"},{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  service { $rgw_service:"},{"line_number":186,"context_line":"    ensure \u003d\u003e $rgw_ensure,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_be8aa318","line":183,"range":{"start_line":157,"start_character":0,"end_line":183,"end_character":3},"updated":"2016-09-20 16:35:55.000000000","message":"Leave this alone.","commit_id":"5fee04fba5e4069036b0b1318caadcec33e081e0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"eece21c697bf5b8d1d68865c7112bbd34c5db31e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    mode                    \u003d\u003e \u00270640\u0027,"},{"line_number":155,"context_line":"    selinux_ignore_defaults \u003d\u003e true,"},{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  # service definition"},{"line_number":159,"context_line":"  # if Ubuntu does not use systemd"},{"line_number":160,"context_line":"  if $::service_provider \u003d\u003d \u0027upstart\u0027 {"},{"line_number":161,"context_line":"    if $rgw_enable {"},{"line_number":162,"context_line":"      file { \"${rgw_data}/done\":"},{"line_number":163,"context_line":"        ensure \u003d\u003e present,"},{"line_number":164,"context_line":"        before \u003d\u003e Service[$rgw_service],"},{"line_number":165,"context_line":"      }"},{"line_number":166,"context_line":"    }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    $rgw_service \u003d \"radosgw-${name}\""},{"line_number":169,"context_line":"    Service {"},{"line_number":170,"context_line":"      name     \u003d\u003e $rgw_service,"},{"line_number":171,"context_line":"      start    \u003d\u003e \"start radosgw id\u003d${name}\","},{"line_number":172,"context_line":"      stop     \u003d\u003e \"stop radosgw id\u003d${name}\","},{"line_number":173,"context_line":"      status   \u003d\u003e \"status radosgw id\u003d${name}\","},{"line_number":174,"context_line":"      provider \u003d\u003e $::ceph::params::service_provider,"},{"line_number":175,"context_line":"    }"},{"line_number":176,"context_line":"  # Everything else that is supported by puppet-ceph should run systemd."},{"line_number":177,"context_line":"  } else {"},{"line_number":178,"context_line":"    $rgw_service \u003d \"ceph-radosgw@${name}\""},{"line_number":179,"context_line":"    Service {"},{"line_number":180,"context_line":"      name   \u003d\u003e $rgw_service,"},{"line_number":181,"context_line":"      enable \u003d\u003e $rgw_enable,"},{"line_number":182,"context_line":"    }"},{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  service { $rgw_service:"},{"line_number":186,"context_line":"    ensure \u003d\u003e $rgw_ensure,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_de984f6d","line":183,"range":{"start_line":157,"start_character":0,"end_line":183,"end_character":3},"in_reply_to":"7a8ec9b2_be8aa318","updated":"2016-09-20 16:38:15.000000000","message":"Sorry my previous comment wasn\u0027t clear. revert this back to it\u0027s current implementation as $rgw_service is for the puppet title. The service names used are correct as currently implemented.","commit_id":"5fee04fba5e4069036b0b1318caadcec33e081e0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b9c58d4fb265ffa1005ee36dbb2ac648cc7732c2","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  service { $rgw_service:"},{"line_number":186,"context_line":"    ensure \u003d\u003e $rgw_ensure,"},{"line_number":187,"context_line":"    tag    \u003d\u003e [\u0027ceph-radosgw\u0027]"},{"line_number":188,"context_line":"  }"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  Ceph_config\u003c||\u003e -\u003e Service\u003c| tag \u003d\u003d \u0027ceph-radosgw\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_3e77733c","line":187,"range":{"start_line":187,"start_character":21,"end_line":187,"end_character":28},"updated":"2016-09-20 16:35:55.000000000","message":"this is truly the only thing that needs to be fixed.","commit_id":"5fee04fba5e4069036b0b1318caadcec33e081e0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"eece21c697bf5b8d1d68865c7112bbd34c5db31e","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  service { $rgw_service:"},{"line_number":186,"context_line":"    ensure \u003d\u003e $rgw_ensure,"},{"line_number":187,"context_line":"    tag    \u003d\u003e [\u0027ceph-radosgw\u0027]"},{"line_number":188,"context_line":"  }"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  Ceph_config\u003c||\u003e -\u003e Service\u003c| tag \u003d\u003d \u0027ceph-radosgw\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_5edb5f1b","line":187,"range":{"start_line":187,"start_character":21,"end_line":187,"end_character":28},"in_reply_to":"7a8ec9b2_3e77733c","updated":"2016-09-20 16:38:15.000000000","message":"(this is the problem so this is the correct change)","commit_id":"5fee04fba5e4069036b0b1318caadcec33e081e0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f0ce9e167b3da8f3ee947424e00c1446a2891c3f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    selinux_ignore_defaults \u003d\u003e true,"},{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  # NOTE(aschultz): this is the radowsgw service title, it may be different"},{"line_number":159,"context_line":"  # than the actual service name"},{"line_number":160,"context_line":"  $rgw_service \u003d \"radosgw-${name}\""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  # service definition"},{"line_number":163,"context_line":"  # if Ubuntu does not use systemd"},{"line_number":164,"context_line":"  if $::service_provider \u003d\u003d \u0027upstart\u0027 {"},{"line_number":165,"context_line":"    if $rgw_enable {"},{"line_number":166,"context_line":"      file { \"${rgw_data}/done\":"},{"line_number":167,"context_line":"        ensure \u003d\u003e present,"},{"line_number":168,"context_line":"        before \u003d\u003e Service[$rgw_service],"},{"line_number":169,"context_line":"      }"},{"line_number":170,"context_line":"    }"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    Service {"},{"line_number":173,"context_line":"      name     \u003d\u003e \"radosgw-${name}\","},{"line_number":174,"context_line":"      start    \u003d\u003e \"start radosgw id\u003d${name}\","},{"line_number":175,"context_line":"      stop     \u003d\u003e \"stop radosgw id\u003d${name}\","},{"line_number":176,"context_line":"      status   \u003d\u003e \"status radosgw id\u003d${name}\","},{"line_number":177,"context_line":"      provider \u003d\u003e $::ceph::params::service_provider,"},{"line_number":178,"context_line":"    }"},{"line_number":179,"context_line":"  # Everything else that is supported by puppet-ceph should run systemd."},{"line_number":180,"context_line":"  } else {"},{"line_number":181,"context_line":"    Service {"},{"line_number":182,"context_line":"      name   \u003d\u003e \"ceph-radosgw@${name}\","},{"line_number":183,"context_line":"      enable \u003d\u003e $rgw_enable,"},{"line_number":184,"context_line":"    }"},{"line_number":185,"context_line":"  }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  service { $rgw_service:"},{"line_number":188,"context_line":"    ensure \u003d\u003e $rgw_ensure,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a8ec9b2_c1814b4f","side":"PARENT","line":185,"range":{"start_line":158,"start_character":0,"end_line":185,"end_character":3},"updated":"2016-09-20 17:46:24.000000000","message":"Do not change this as this also breaks backwards compatibility.","commit_id":"e6d1026ee1b2c5456a598de97dbcd1a6cdce36bd"}]}
